7fcf792825f6be76ec2f32c0e00c588dcb6b648c
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 8
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private cacheFileContent(intId int, startPageIndex long, pageCount int, addNewPages boolean, cacheHit OModifiableBoolean) : OCachePointer[] renamed to private loadFileContent(intId int, startPageIndex long, pageCount int) : OCachePointer[] in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache | From | To | |
| Inline Method | 4 | ||
| Inline Method private flushRing(writePagesToFlush int, flushedPages int, forceFlush boolean, iterateByWritePagesFirst boolean) : int inlined to public run() : void in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache.PeriodicFlushTask | From | To | |
| Inline Method private flushRing(subMap NavigableMap<PageKey,PageGroup>) : void inlined to public call() : Void in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache.FileFlushTask | From | To | |
| Inline Method private removeFromRing(subMap NavigableMap<PageKey,PageGroup>) : void inlined to public call() : Void in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache.RemoveFilePagesTask | From | To | |
| Rename Variable | 6 | ||
| Rename Variable writeNormalizedSize : int to exclusiveWriteNormalizedSize : int in method public OWOWCache(pageSize int, bufferPool OByteBufferPool, writeAheadLog OWriteAheadLog, pageFlushInterval long, exclusiveWriteCacheMaxSize long, storageLocal OLocalPaginatedStorage, checkMinSize boolean, files OClosableLinkedContainer<Long,OFileClassic>, id int) in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache | From | To | |
| Rename Variable e : Throwable to t : Throwable in method public run() : void in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache.PeriodicFlushTask | From | To | |
| Rename Variable pageGroup : PageGroup to pagePointer : OCachePointer in method public store(fileId long, pageIndex long, dataPointer OCachePointer) : CountDownLatch in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache | From | To | |
| Rename Variable pageLocks : Lock[] to locks : Lock[] in method public load(fileId long, startPageIndex long, pageCount int, addNewPages boolean, cacheHit OModifiableBoolean) : OCachePointer[] in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache | From | To | |
| Rename Variable cacheThreshold : double to exclusiveWriteCacheThreshold : double in method private flushExclusivePagesIfNeeded(flushedPages int) : int in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache.PeriodicFlushTask | From | To | |
| Rename Variable externalId : long to finalId : long in method public call() : Void in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache.FileFlushTask | From | To | |
| Change Return Type | 2 | ||
| Change Return Type Future to CountDownLatch in method public store(fileId long, pageIndex long, dataPointer OCachePointer) : CountDownLatch in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache | From | To | |
| Change Return Type Future to CountDownLatch in method public store(fileId long, pageIndex long, dataPointer OCachePointer) : CountDownLatch in class com.orientechnologies.orient.core.storage.cache.OWriteCache | From | To | |
| Rename Attribute | 4 | ||
| Rename Attribute listeners : List<WeakReference<OLowDiskSpaceListener>> to lowDiskSpaceListeners : List<WeakReference<OLowDiskSpaceListener>> in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache | From | To | |
| Rename Attribute cacheMaxSize : int to exclusiveWriteCacheMaxSize : int in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache | From | To | |
| Rename Attribute fileCounter : int to nextInternalId : int in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache | From | To | |
| Rename Attribute writeCacheMaxSize : int to exclusiveWriteCacheMaxSize : int in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache | From | To | |
| Change Variable Type | 5 | ||
| Change Variable Type entryIterator : Iterator<Map.Entry<PageKey,PageGroup>> to entryIterator : Iterator<Map.Entry<PageKey,OCachePointer>> in method public call() : Void in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache.FileFlushTask | From | To | |
| Change Variable Type entry : Map.Entry<PageKey,PageGroup> to entry : Map.Entry<PageKey,OCachePointer> in method public call() : Void in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache.RemoveFilePagesTask | From | To | |
| Change Variable Type pageGroup : PageGroup to pagePointer : OCachePointer in method public store(fileId long, pageIndex long, dataPointer OCachePointer) : CountDownLatch in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache | From | To | |
| Change Variable Type entry : Map.Entry<PageKey,PageGroup> to entry : Map.Entry<PageKey,OCachePointer> in method public call() : Void in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache.FileFlushTask | From | To | |
| Change Variable Type entryIterator : Iterator<Map.Entry<PageKey,PageGroup>> to entryIterator : Iterator<Map.Entry<PageKey,OCachePointer>> in method public call() : Void in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache.RemoveFilePagesTask | From | To | |
| Extract Method | 2 | ||
| Extract Method private flushExclusivePagesIfNeeded(flushedPages int) : int extracted from public run() : void in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache.PeriodicFlushTask | From | To | |
| Extract Method private doPutInCache(dataPointer OCachePointer, pageKey PageKey) : void extracted from public store(fileId long, pageIndex long, dataPointer OCachePointer) : Future in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type exclusiveWriteCacheSize : LongAdder to exclusiveWriteCacheSize : AtomicLong in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache | From | To | |
| Change Attribute Type writeCachePages : ConcurrentSkipListMap<PageKey,PageGroup> to writeCachePages : ConcurrentSkipListMap<PageKey,OCachePointer> in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public setNotFlushed(notFlushed boolean) : void extracted from public load(fileId long, startPageIndex long, pageCount int, addNewPages boolean, cacheHit OModifiableBoolean) : OCachePointer[] in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache & moved to class com.orientechnologies.orient.core.storage.cache.OCachePointer | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter groupTTL : long to exclusiveWriteCacheMaxSize : long in method public OWOWCache(pageSize int, bufferPool OByteBufferPool, writeAheadLog OWriteAheadLog, pageFlushInterval long, exclusiveWriteCacheMaxSize long, storageLocal OLocalPaginatedStorage, checkMinSize boolean, files OClosableLinkedContainer<Long,OFileClassic>, id int) in class com.orientechnologies.orient.core.storage.cache.local.OWOWCache | From | To |