20b298f9a1d4cf2f0b37080f06f15cd029e76fae
Files Diff
- Added: 8
- Removed: 2
- Renamed: 0
- Modified: 15
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public printMetadata() : String renamed to public getMetadata() : String in class org.pac4j.saml.metadata.SAML2MetadataGenerator | From | To | |
| Rename Method public buildDecrypter() : Decrypter renamed to public build() : Decrypter in class org.pac4j.saml.crypto.KeyStoreDecryptionProvider | From | To | |
| Rename Method public buildSpContext(webContext WebContext) : ExtendedSAMLMessageContext renamed to public buildServiceProviderContext(webContext WebContext) : ExtendedSAMLMessageContext in class org.pac4j.saml.context.SAML2ContextProvider | From | To | |
| Push Down Method | 9 | ||
| Push Down Method public getKeyInfo() : KeyInfo from class org.pac4j.saml.crypto.CredentialProvider to public getKeyInfo() : KeyInfo from class org.pac4j.saml.crypto.KeyStoreCredentialProvider | From | To | |
| Push Down Method public getCredential() : Credential from class org.pac4j.saml.crypto.CredentialProvider to public getCredential() : Credential from class org.pac4j.saml.crypto.KeyStoreCredentialProvider | From | To | |
| Push Down Method private loadKeyStore(inputStream InputStream, storePasswd String) : KeyStore from class org.pac4j.saml.crypto.CredentialProvider to private loadKeyStore(inputStream InputStream, storePasswd String) : KeyStore from class org.pac4j.saml.crypto.KeyStoreCredentialProvider | From | To | |
| Push Down Method public getKeyInfoGenerator() : KeyInfoGenerator from class org.pac4j.saml.crypto.CredentialProvider to public getKeyInfoGenerator() : KeyInfoGenerator from class org.pac4j.saml.crypto.KeyStoreCredentialProvider | From | To | |
| Push Down Method protected generateKeyInfoForCredential(credential Credential) : KeyInfo from class org.pac4j.saml.crypto.CredentialProvider to protected generateKeyInfoForCredential(credential Credential) : KeyInfo from class org.pac4j.saml.crypto.KeyStoreCredentialProvider | From | To | |
| Push Down Method public getCredentialResolver() : CredentialResolver from class org.pac4j.saml.crypto.CredentialProvider to public getCredentialResolver() : CredentialResolver from class org.pac4j.saml.crypto.KeyStoreCredentialProvider | From | To | |
| Push Down Method private getPrivateKeyAlias(keyStore KeyStore) : String from class org.pac4j.saml.crypto.CredentialProvider to private getPrivateKeyAlias(keyStore KeyStore) : String from class org.pac4j.saml.crypto.KeyStoreCredentialProvider | From | To | |
| Push Down Method public CredentialProvider(name String, storePasswd String, privateKeyPasswd String) from class org.pac4j.saml.crypto.CredentialProvider to public KeyStoreCredentialProvider(name String, storePasswd String, privateKeyPasswd String) from class org.pac4j.saml.crypto.KeyStoreCredentialProvider | From | To | |
| Push Down Method public getKeyInfoCredentialResolver() : KeyInfoCredentialResolver from class org.pac4j.saml.crypto.CredentialProvider to public getKeyInfoCredentialResolver() : KeyInfoCredentialResolver from class org.pac4j.saml.crypto.KeyStoreCredentialProvider | From | To | |
| Extract Subclass | 1 | ||
| Extract Subclass org.pac4j.saml.crypto.KeyStoreCredentialProvider from class org.pac4j.saml.crypto.CredentialProvider | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type trustEngineProvider : SignatureTrustEngineProvider to trustEngineProvider : SAMLSignatureTrustEngineProvider in method public Saml2WebSSOProfileHandler(credentialProvider CredentialProvider, decoder MessageDecoder, parserPool ParserPool, destinationBindingType String, trustEngineProvider SAMLSignatureTrustEngineProvider) in class org.pac4j.saml.sso.Saml2WebSSOProfileHandler | From | To | |
| Change Return Type | 1 | ||
| Change Return Type EntityDescriptor to MetadataResolver in method public buildMetadataResolver() : MetadataResolver in class org.pac4j.saml.metadata.SAML2MetadataGenerator | From | To | |
| Push Down Attribute | 3 | ||
| Push Down Attribute private privateKey : String from class org.pac4j.saml.crypto.CredentialProvider to private privateKey : String from class org.pac4j.saml.crypto.KeyStoreCredentialProvider | From | To | |
| Push Down Attribute private credentialResolver : CredentialResolver from class org.pac4j.saml.crypto.CredentialProvider to private credentialResolver : CredentialResolver from class org.pac4j.saml.crypto.KeyStoreCredentialProvider | From | To | |
| Push Down Attribute private logger : Logger from class org.pac4j.saml.crypto.CredentialProvider to private logger : Logger from class org.pac4j.saml.crypto.KeyStoreCredentialProvider | From | To | |
| Rename Class | 7 | ||
| Rename Class org.pac4j.saml.crypto.EncryptionProvider renamed to org.pac4j.saml.crypto.KeyStoreDecryptionProvider | From | To | |
| Rename Class org.pac4j.saml.sso.Saml2AuthnRequestBuilder renamed to org.pac4j.saml.sso.SAML2AuthnRequestBuilder | From | To | |
| Rename Class org.pac4j.saml.exceptions.SamlException renamed to org.pac4j.saml.exceptions.SAMLException | From | To | |
| Rename Class org.pac4j.saml.sso.Saml2ResponseValidator renamed to org.pac4j.saml.sso.SAML2ResponseValidator | From | To | |
| Rename Class org.pac4j.saml.metadata.Saml2MetadataGenerator renamed to org.pac4j.saml.metadata.SAML2MetadataGenerator | From | To | |
| Rename Class org.pac4j.saml.context.Saml2ContextProvider renamed to org.pac4j.saml.context.SAML2ContextProvider | From | To | |
| Rename Class org.pac4j.saml.crypto.SignatureTrustEngineProvider renamed to org.pac4j.saml.crypto.ExplicitSignatureTrustEngineProvider | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type metadataGenerator : Saml2MetadataGenerator to metadataGenerator : SAML2MetadataGenerator in method private generateServiceProviderMetadata() : MetadataResolver in class org.pac4j.saml.client.Saml2Client | From | To | |
| Extract Interface | 2 | ||
| Extract Interface org.pac4j.saml.crypto.SAMLSignatureTrustEngineProvider from classes [org.pac4j.saml.crypto.ExplicitSignatureTrustEngineProvider] | From | To | |
| Extract Interface org.pac4j.saml.sso.AuthnRequestBuilder from classes [org.pac4j.saml.sso.SAML2AuthnRequestBuilder] | From | To | |
| Extract Method | 1 | ||
| Extract Method public buildEntityDescriptor() : EntityDescriptor extracted from public buildMetadata() : EntityDescriptor in class org.pac4j.saml.metadata.SAML2MetadataGenerator | From | To | |
| Change Attribute Type | 5 | ||
| Change Attribute Type contextProvider : Saml2ContextProvider to contextProvider : SAMLContextProvider in class org.pac4j.saml.client.Saml2Client | From | To | |
| Change Attribute Type signatureTrustEngineProvider : SignatureTrustEngineProvider to signatureTrustEngineProvider : SAMLSignatureTrustEngineProvider in class org.pac4j.saml.sso.Saml2WebSSOProfileHandler | From | To | |
| Change Attribute Type authnRequestBuilder : Saml2AuthnRequestBuilder to authnRequestBuilder : AuthnRequestBuilder in class org.pac4j.saml.client.Saml2Client | From | To | |
| Change Attribute Type signatureTrustEngineProvider : SignatureTrustEngineProvider to signatureTrustEngineProvider : SAMLSignatureTrustEngineProvider in class org.pac4j.saml.client.Saml2Client | From | To | |
| Change Attribute Type responseValidator : Saml2ResponseValidator to responseValidator : SAML2ResponseValidator in class org.pac4j.saml.client.Saml2Client | From | To |