308f0ead45da867bd8f76f83710dd693536782ed
Files Diff
- Added: 11
- Removed: 4
- Renamed: 0
- Modified: 50
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public logoutRedirect(context WebContext) : HttpAction renamed to public getLogoutAction(context WebContext, currentProfile U, targetUrl String) : RedirectAction in class org.pac4j.core.client.DirectClient | From | To | |
| Rename Method public logoutRedirect(context WebContext) : HttpAction renamed to public getLogoutAction(context WebContext, currentProfile U, targetUrl String) : RedirectAction in class org.pac4j.core.client.Client | From | To | |
| Pull Up Method | 9 | ||
| Pull Up Method public getProfileManagerFactory() : Function<C,ProfileManager> from class org.pac4j.core.engine.DefaultCallbackLogic to public getProfileManagerFactory() : Function<C,ProfileManager> from class org.pac4j.core.profile.ProfileManagerFactoryAware | From | To | |
| Pull Up Method public setProfileManagerFactory(factory Function<C,ProfileManager>) : void from class org.pac4j.core.engine.DefaultApplicationLogoutLogic to public setProfileManagerFactory(factory Function<C,ProfileManager>) : void from class org.pac4j.core.profile.ProfileManagerFactoryAware | From | To | |
| Pull Up Method protected getProfileManager(context C) : ProfileManager from class org.pac4j.core.engine.DefaultCallbackLogic to protected getProfileManager(context C) : ProfileManager from class org.pac4j.core.profile.ProfileManagerFactoryAware | From | To | |
| Pull Up Method protected getProfileManager(context C) : ProfileManager from class org.pac4j.core.engine.DefaultApplicationLogoutLogic to protected getProfileManager(context C) : ProfileManager from class org.pac4j.core.profile.ProfileManagerFactoryAware | From | To | |
| Pull Up Method public setProfileManagerFactory(factory Function<C,ProfileManager>) : void from class org.pac4j.core.engine.DefaultSecurityLogic to public setProfileManagerFactory(factory Function<C,ProfileManager>) : void from class org.pac4j.core.profile.ProfileManagerFactoryAware | From | To | |
| Pull Up Method protected getProfileManager(context C) : ProfileManager from class org.pac4j.core.engine.DefaultSecurityLogic to protected getProfileManager(context C) : ProfileManager from class org.pac4j.core.profile.ProfileManagerFactoryAware | From | To | |
| Pull Up Method public getProfileManagerFactory() : Function<C,ProfileManager> from class org.pac4j.core.engine.DefaultSecurityLogic to public getProfileManagerFactory() : Function<C,ProfileManager> from class org.pac4j.core.profile.ProfileManagerFactoryAware | From | To | |
| Pull Up Method public setProfileManagerFactory(factory Function<C,ProfileManager>) : void from class org.pac4j.core.engine.DefaultCallbackLogic to public setProfileManagerFactory(factory Function<C,ProfileManager>) : void from class org.pac4j.core.profile.ProfileManagerFactoryAware | From | To | |
| Pull Up Method public getProfileManagerFactory() : Function<C,ProfileManager> from class org.pac4j.core.engine.DefaultApplicationLogoutLogic to public getProfileManagerFactory() : Function<C,ProfileManager> from class org.pac4j.core.profile.ProfileManagerFactoryAware | From | To | |
| Rename Variable | 1 | ||
| Rename Variable clients : Clients to configClients : Clients in method public perform(context C, config Config, httpActionAdapter HttpActionAdapter<R,C>, defaultUrl String, inputLogoutUrlPattern String, inputLocalLogout Boolean, inputCentralLogout Boolean) : R in class org.pac4j.core.engine.DefaultLogoutLogic | From | To | |
| Pull Up Attribute | 3 | ||
| Pull Up Attribute private profileManagerFactory : Function<C,ProfileManager> from class org.pac4j.core.engine.DefaultSecurityLogic to private profileManagerFactory : Function<C,ProfileManager> from class org.pac4j.core.profile.ProfileManagerFactoryAware | From | To | |
| Pull Up Attribute private profileManagerFactory : Function<C,ProfileManager> from class org.pac4j.core.engine.DefaultApplicationLogoutLogic to private profileManagerFactory : Function<C,ProfileManager> from class org.pac4j.core.profile.ProfileManagerFactoryAware | From | To | |
| Pull Up Attribute private profileManagerFactory : Function<C,ProfileManager> from class org.pac4j.core.engine.DefaultCallbackLogic to private profileManagerFactory : Function<C,ProfileManager> from class org.pac4j.core.profile.ProfileManagerFactoryAware | From | To | |
| Change Return Type | 2 | ||
| Change Return Type HttpAction to RedirectAction in method public getLogoutAction(context WebContext, currentProfile U, targetUrl String) : RedirectAction in class org.pac4j.core.client.Client | From | To | |
| Change Return Type HttpAction to RedirectAction in method public getLogoutAction(context WebContext, currentProfile U, targetUrl String) : RedirectAction in class org.pac4j.core.client.DirectClient | From | To | |
| Rename Class | 2 | ||
| Rename Class org.pac4j.core.engine.DefaultApplicationLogoutLogicTests renamed to org.pac4j.core.engine.DefaultLogoutLogicTests | From | To | |
| Rename Class org.pac4j.core.engine.DefaultApplicationLogoutLogic renamed to org.pac4j.core.engine.DefaultLogoutLogic | From | To | |
| Move Class | 1 | ||
| Move Class org.pac4j.core.client.RedirectAction moved to org.pac4j.core.redirect.RedirectAction | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.pac4j.core.profile.ProfileManagerFactoryAware from classes [org.pac4j.core.engine.DefaultCallbackLogic, org.pac4j.core.engine.DefaultLogoutLogic, org.pac4j.core.engine.DefaultSecurityLogic] | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type client : Client<Credentials,CommonProfile> to client : Client in method public perform(context C, config Config, httpActionAdapter HttpActionAdapter<R,C>, defaultUrl String, inputLogoutUrlPattern String, inputLocalLogout Boolean, inputCentralLogout Boolean) : R in class org.pac4j.core.engine.DefaultLogoutLogic | From | To | |
| Extract Method | 4 | ||
| Extract Method private expectedNProfiles(n int) : void extracted from public testLogout() : void in class org.pac4j.core.engine.DefaultLogoutLogicTests | From | To | |
| Extract Method private getProfilesFromSession() : LinkedHashMap<String,CommonProfile> extracted from public testLogout() : void in class org.pac4j.core.engine.DefaultLogoutLogicTests | From | To | |
| Extract Method private getProfilesFromRequest() : LinkedHashMap<String,CommonProfile> extracted from public testLogout() : void in class org.pac4j.core.engine.DefaultLogoutLogicTests | From | To | |
| Extract Method private addProfilesToContext() : void extracted from public testLogout() : void in class org.pac4j.core.engine.DefaultLogoutLogicTests | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type logic : ApplicationLogoutLogic<Object,WebContext> to logic : LogoutLogic<Object,WebContext> in class org.pac4j.core.engine.DefaultLogoutLogicTests | From | To |