67f9cc7d1ee54b9d525e9e270f7e9771bb4e54bb
Files Diff
- Added: 20
- Removed: 11
- Renamed: 0
- Modified: 72
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method public computeFinalUrl(url String, context WebContext) : String from class org.pac4j.cas.config.CasConfiguration to public compute(url String, clientName String, context WebContext) : String from class org.pac4j.core.http.callback.NoParameterCallbackUrlResolver | From | To | |
| Change Parameter Type | 5 | ||
| Change Parameter Type clientName : String to client : OidcClient in method public OidcExtractor(configuration OidcConfiguration, client OidcClient) in class org.pac4j.oidc.credentials.extractor.OidcExtractor | From | To | |
| Change Parameter Type urlResolver : UrlResolver to callbackUrlResolver : CallbackUrlResolver in method public setCallbackUrlResolver(callbackUrlResolver CallbackUrlResolver) : void in class org.pac4j.core.client.Clients | From | To | |
| Change Parameter Type callbackUrl : String to client : CasClient in method public CasRedirectActionBuilder(configuration CasConfiguration, client CasClient) in class org.pac4j.cas.redirect.CasRedirectActionBuilder | From | To | |
| Change Parameter Type urlResolver : UrlResolver to callbackUrlResolver : CallbackUrlResolver in method public setCallbackUrlResolver(callbackUrlResolver CallbackUrlResolver) : void in class org.pac4j.core.client.IndirectClient | From | To | |
| Change Parameter Type callbackUrlResolver : UrlResolver to callbackUrlResolver : CallbackUrlResolver in method public setCallbackUrlResolver(callbackUrlResolver CallbackUrlResolver) : void in class org.pac4j.cas.client.direct.DirectCasClient | From | To | |
| Move Method | 14 | ||
| Move Method public toString() : String from class org.pac4j.oidc.credentials.authenticator.OidcAuthenticator to public toString() : String from class org.pac4j.core.client.finder.DefaultCallbackClientFinder | From | To | |
| Move Method public setUrlResolver(urlResolver UrlResolver) : void from class org.pac4j.oauth.config.OAuthConfiguration to public setUrlResolver(urlResolver UrlResolver) : void from class org.pac4j.core.http.callback.AbstractCallbackUrlResolver | From | To | |
| Move Method public getUrlResolver() : UrlResolver from class org.pac4j.oauth.config.OAuthConfiguration to public getUrlResolver() : UrlResolver from class org.pac4j.core.http.callback.AbstractCallbackUrlResolver | From | To | |
| Move Method public toString() : String from class org.pac4j.oidc.credentials.extractor.OidcExtractor to public toString() : String from class org.pac4j.core.client.finder.DefaultCallbackClientFinder | From | To | |
| Move Method public setCallbackUrlResolver(callbackUrlResolver UrlResolver) : void from class org.pac4j.oidc.config.OidcConfiguration to public setCallbackUrlResolver(callbackUrlResolver CallbackUrlResolver) : void from class org.pac4j.cas.client.direct.DirectCasClient | From | To | |
| Move Method public toString() : String from class org.pac4j.oauth.credentials.authenticator.OAuthAuthenticator to public toString() : String from class org.pac4j.core.client.finder.DefaultCallbackClientFinder | From | To | |
| Move Method public toString() : String from class org.pac4j.oauth.profile.creator.OAuthProfileCreator to public toString() : String from class org.pac4j.core.client.finder.DefaultCallbackClientFinder | From | To | |
| Move Method public toString() : String from class org.pac4j.oidc.redirect.OidcRedirectActionBuilder to public toString() : String from class org.pac4j.core.client.finder.DefaultCallbackClientFinder | From | To | |
| Move Method public toString() : String from class org.pac4j.oauth.redirect.OAuth10RedirectActionBuilder to public toString() : String from class org.pac4j.core.client.finder.DefaultCallbackClientFinder | From | To | |
| Move Method public toString() : String from class org.pac4j.oauth.redirect.OAuth20RedirectActionBuilder to public toString() : String from class org.pac4j.core.client.finder.DefaultCallbackClientFinder | From | To | |
| Move Method public toString() : String from class org.pac4j.oidc.profile.creator.OidcProfileCreator to public toString() : String from class org.pac4j.core.client.finder.DefaultCallbackClientFinder | From | To | |
| Move Method public getClientNameParameter() : String from class org.pac4j.core.client.Clients to public getClientNameParameter() : String from class org.pac4j.core.client.finder.DefaultSecurityClientFinder | From | To | |
| Move Method public toString() : String from class org.pac4j.oauth.credentials.extractor.OAuthCredentialsExtractor to public toString() : String from class org.pac4j.core.client.finder.DefaultCallbackClientFinder | From | To | |
| Move Method public setClientNameParameter(clientNameParameter String) : void from class org.pac4j.core.client.Clients to public setClientNameParameter(clientNameParameter String) : void from class org.pac4j.core.client.finder.DefaultSecurityClientFinder | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private clientNameParameter : String from class org.pac4j.core.client.Clients to private clientNameParameter : String from class org.pac4j.core.client.finder.DefaultSecurityClientFinder | From | To | |
| Move Attribute private urlResolver : UrlResolver from class org.pac4j.oauth.config.OAuthConfiguration to private urlResolver : UrlResolver from class org.pac4j.core.http.callback.AbstractCallbackUrlResolver | From | To | |
| Extract Class | 8 | ||
| Extract Class org.pac4j.core.http.callback.QueryParameterCallbackUrlResolver from class org.pac4j.cas.credentials.extractor.TicketAndLogoutRequestExtractor | From | To | |
| Extract Class org.pac4j.core.http.callback.AbstractCallbackUrlResolver from class org.pac4j.oauth.config.OAuthConfiguration | From | To | |
| Extract Class org.pac4j.core.client.finder.DefaultSecurityClientFinder from class org.pac4j.cas.credentials.extractor.TicketAndLogoutRequestExtractor | From | To | |
| Extract Class org.pac4j.core.http.callback.QueryParameterCallbackUrlResolver from class org.pac4j.oauth.config.OAuthConfiguration | From | To | |
| Extract Class org.pac4j.core.client.finder.DefaultCallbackClientFinder from class org.pac4j.core.client.Clients | From | To | |
| Extract Class org.pac4j.core.client.finder.DefaultCallbackClientFinderTests from class org.pac4j.core.client.ClientsTests | From | To | |
| Extract Class org.pac4j.core.client.finder.DefaultSecurityClientFinder from class org.pac4j.core.client.Clients | From | To | |
| Extract Class org.pac4j.core.client.finder.DefaultSecurityClientFinder from class org.pac4j.oauth.config.OAuthConfiguration | From | To | |
| Rename Class | 1 | ||
| Rename Class org.pac4j.core.client.finder.DefaultClientFinderTests renamed to org.pac4j.core.client.finder.DefaultSecurityClientFinderTests | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.pac4j.core.http.RelativeUrlResolverTests moved and renamed to org.pac4j.core.http.url.DefaultUrlResolverTests | From | To | |
| Move Class | 6 | ||
| Move Class org.pac4j.core.http.DefaultAjaxRequestResolver moved to org.pac4j.core.http.ajax.DefaultAjaxRequestResolver | From | To | |
| Move Class org.pac4j.core.http.UrlResolver moved to org.pac4j.core.http.url.UrlResolver | From | To | |
| Move Class org.pac4j.core.http.J2ENopHttpActionAdapter moved to org.pac4j.core.http.adapter.J2ENopHttpActionAdapter | From | To | |
| Move Class org.pac4j.core.http.HttpActionAdapter moved to org.pac4j.core.http.adapter.HttpActionAdapter | From | To | |
| Move Class org.pac4j.core.http.AjaxRequestResolver moved to org.pac4j.core.http.ajax.AjaxRequestResolver | From | To | |
| Move Class org.pac4j.core.http.DefaultAjaxRequestResolverTests moved to org.pac4j.core.http.ajax.DefaultAjaxRequestResolverTests | From | To | |
| Rename Method | 5 | ||
| Rename Method public setUrlResolver(urlResolver UrlResolver) : void renamed to public setCallbackUrlResolver(callbackUrlResolver CallbackUrlResolver) : void in class org.pac4j.core.client.IndirectClient | From | To | |
| Rename Method public setUrlResolver(urlResolver UrlResolver) : void renamed to public setCallbackUrlResolver(callbackUrlResolver CallbackUrlResolver) : void in class org.pac4j.core.client.Clients | From | To | |
| Rename Method public getUrlResolver() : UrlResolver renamed to public getCallbackUrlResolver() : CallbackUrlResolver in class org.pac4j.core.client.Clients | From | To | |
| Rename Method public getUrlResolver() : UrlResolver renamed to public getCallbackUrlResolver() : CallbackUrlResolver in class org.pac4j.core.client.IndirectClient | From | To | |
| Rename Method public testNoCallbackUrl() : void renamed to public testNoValuesSet() : void in class org.pac4j.core.client.ClientsTests | From | To | |
| Rename Variable | 4 | ||
| Rename Variable clientsGroup : Clients to clients : Clients in method public testMissingClient() : void in class org.pac4j.core.client.ClientsTests | From | To | |
| Rename Variable lowerName : String to lowerTrimmedName : String in method protected internalInit() : void in class org.pac4j.core.client.Clients | From | To | |
| Rename Variable clientsGroup : Clients to clients : Clients in method public testNoValuesSet() : void in class org.pac4j.core.client.ClientsTests | From | To | |
| Rename Variable currentUrl : String to callbackUrl : String in method protected retrieveCredentials(context WebContext) : TokenCredentials in class org.pac4j.cas.client.direct.DirectCasClient | From | To | |
| Change Return Type | 2 | ||
| Change Return Type UrlResolver to CallbackUrlResolver in method public getCallbackUrlResolver() : CallbackUrlResolver in class org.pac4j.core.client.Clients | From | To | |
| Change Return Type UrlResolver to CallbackUrlResolver in method public getCallbackUrlResolver() : CallbackUrlResolver in class org.pac4j.core.client.IndirectClient | From | To | |
| Rename Attribute | 4 | ||
| Rename Attribute clientName : String to client : OidcClient in class org.pac4j.oidc.credentials.extractor.OidcExtractor | From | To | |
| Rename Attribute callbackUrl : String to client : CasClient in class org.pac4j.cas.redirect.CasRedirectActionBuilder | From | To | |
| Rename Attribute urlResolver : UrlResolver to callbackUrlResolver : CallbackUrlResolver in class org.pac4j.core.client.IndirectClient | From | To | |
| Rename Attribute urlResolver : UrlResolver to callbackUrlResolver : CallbackUrlResolver in class org.pac4j.core.client.Clients | From | To | |
| Change Attribute Type | 6 | ||
| Change Attribute Type urlResolver : UrlResolver to callbackUrlResolver : CallbackUrlResolver in class org.pac4j.core.client.IndirectClient | From | To | |
| Change Attribute Type logic : CallbackLogic<Object,J2EContext> to logic : DefaultCallbackLogic<Object,J2EContext> in class org.pac4j.core.engine.DefaultCallbackLogicTests | From | To | |
| Change Attribute Type urlResolver : UrlResolver to callbackUrlResolver : CallbackUrlResolver in class org.pac4j.core.client.Clients | From | To | |
| Change Attribute Type finder : DefaultClientFinder to finder : DefaultSecurityClientFinder in class org.pac4j.core.client.finder.DefaultSecurityClientFinderTests | From | To | |
| Change Attribute Type clientName : String to client : OidcClient in class org.pac4j.oidc.credentials.extractor.OidcExtractor | From | To | |
| Change Attribute Type callbackUrl : String to client : CasClient in class org.pac4j.cas.redirect.CasRedirectActionBuilder | From | To | |
| Extract And Move Method | 3 | ||
| Extract And Move Method public findLogoutHandler() : CasLogoutHandler extracted from public extract(context WebContext) : TokenCredentials in class org.pac4j.cas.credentials.extractor.TicketAndLogoutRequestExtractor & moved to class org.pac4j.cas.config.CasConfiguration | From | To | |
| Extract And Move Method public findProviderMetadata() : OIDCProviderMetadata extracted from protected internalInit() : void in class org.pac4j.oidc.profile.creator.OidcProfileCreator & moved to class org.pac4j.oidc.config.OidcConfiguration | From | To | |
| Extract And Move Method public findProviderMetadata() : OIDCProviderMetadata extracted from public validate(credentials OidcCredentials, context WebContext) : void in class org.pac4j.oidc.credentials.authenticator.OidcAuthenticator & moved to class org.pac4j.oidc.config.OidcConfiguration | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter clientName : String to client : OidcClient in method public OidcExtractor(configuration OidcConfiguration, client OidcClient) in class org.pac4j.oidc.credentials.extractor.OidcExtractor | From | To | |
| Rename Parameter urlResolver : UrlResolver to callbackUrlResolver : CallbackUrlResolver in method public setCallbackUrlResolver(callbackUrlResolver CallbackUrlResolver) : void in class org.pac4j.core.client.Clients | From | To | |
| Rename Parameter callbackUrl : String to client : CasClient in method public CasRedirectActionBuilder(configuration CasConfiguration, client CasClient) in class org.pac4j.cas.redirect.CasRedirectActionBuilder | From | To | |
| Rename Parameter urlResolver : UrlResolver to callbackUrlResolver : CallbackUrlResolver in method public setCallbackUrlResolver(callbackUrlResolver CallbackUrlResolver) : void in class org.pac4j.core.client.IndirectClient | From | To |