pac4j a21cda70872740dcfbdf414a239514fefd41a4f2

a21cda70872740dcfbdf414a239514fefd41a4f2

Files Diff

Added: 6
Removed: 0
Renamed: 0
Modified: 11

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	3
Move And Rename Method protected retrieveUserProfile(credentials OidcCredentials, context WebContext) : U from class org.pac4j.oidc.client.OidcClient to public create(credentials OidcCredentials, context WebContext) : U from class org.pac4j.oidc.profile.creator.OidcProfileCreator	From	To
Move And Rename Method protected retrieveCredentials(context WebContext) : OidcCredentials from class org.pac4j.oidc.client.OidcClient to public extract(context WebContext) : OidcCredentials from class org.pac4j.oidc.credentials.extractor.OidcExtractor	From	To
Move And Rename Method protected retrieveRedirectAction(context WebContext) : RedirectAction from class org.pac4j.oidc.client.OidcClient to public redirect(context WebContext) : RedirectAction from class org.pac4j.oidc.redirect.OidcRedirectActionBuilder	From	To
Move Method	20
Move Method public getCustomParams() : Map<String,String> from class org.pac4j.oidc.client.OidcClient to public getCustomParams() : Map<String,String> from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Method public getSecret() : String from class org.pac4j.oidc.client.OidcClient to public getSecret() : String from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Method public setMaxClockSkew(maxClockSkew int) : void from class org.pac4j.oidc.client.OidcClient to public setMaxClockSkew(maxClockSkew int) : void from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Method public getClientAuthentication() : ClientAuthentication from class org.pac4j.oidc.client.OidcClient to public getClientAuthentication() : ClientAuthentication from class org.pac4j.oidc.credentials.authenticator.OidcAuthenticator	From	To
Move Method private toSingleParameter(requestParameters Map<String,String[]>) : Map<String,String> from class org.pac4j.oidc.client.OidcClient to protected toSingleParameter(requestParameters Map<String,String[]>) : Map<String,String> from class org.pac4j.oidc.credentials.extractor.OidcExtractor	From	To
Move Method public isUseNonce() : boolean from class org.pac4j.oidc.client.OidcClient to public isUseNonce() : boolean from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Method protected createRSATokenValidator(jwsAlgorithm JWSAlgorithm, clientID ClientID) : IDTokenValidator from class org.pac4j.oidc.client.OidcClient to protected createRSATokenValidator(jwsAlgorithm JWSAlgorithm, clientID ClientID) : IDTokenValidator from class org.pac4j.oidc.profile.creator.OidcProfileCreator	From	To
Move Method public getConnectTimeout() : int from class org.pac4j.oidc.client.OidcClient to public getConnectTimeout() : int from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Method public getPreferredJwsAlgorithm() : JWSAlgorithm from class org.pac4j.oidc.client.OidcClient to public getPreferredJwsAlgorithm() : JWSAlgorithm from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Method public getScope() : String from class org.pac4j.oidc.client.OidcClient to public getScope() : String from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Method public getClientAuthenticationMethod() : ClientAuthenticationMethod from class org.pac4j.oidc.client.OidcClient to public getClientAuthenticationMethod() : ClientAuthenticationMethod from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Method protected createRSATokenValidator(jwsAlgorithm JWSAlgorithm, clientID ClientID) : IDTokenValidator from class org.pac4j.oidc.client.AzureAdClient to protected createRSATokenValidator(jwsAlgorithm JWSAlgorithm, clientID ClientID) : IDTokenValidator from class org.pac4j.oidc.profile.azuread.AzureAdProfileCreator	From	To
Move Method public setReadTimeout(readTimeout int) : void from class org.pac4j.oidc.client.OidcClient to public setReadTimeout(readTimeout int) : void from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Method public getProviderMetadata() : OIDCProviderMetadata from class org.pac4j.oidc.client.OidcClient to public getProviderMetadata() : OIDCProviderMetadata from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Method public getDiscoveryURI() : String from class org.pac4j.oidc.client.OidcClient to public getDiscoveryURI() : String from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Method public getMaxClockSkew() : int from class org.pac4j.oidc.client.OidcClient to public getMaxClockSkew() : int from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Method public setConnectTimeout(connectTimeout int) : void from class org.pac4j.oidc.client.OidcClient to public setConnectTimeout(connectTimeout int) : void from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Method public getReadTimeout() : int from class org.pac4j.oidc.client.OidcClient to public getReadTimeout() : int from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Method protected createHMACTokenValidator(jwsAlgorithm JWSAlgorithm, clientID ClientID, secret Secret) : IDTokenValidator from class org.pac4j.oidc.client.OidcClient to protected createHMACTokenValidator(jwsAlgorithm JWSAlgorithm, clientID ClientID, secret Secret) : IDTokenValidator from class org.pac4j.oidc.profile.creator.OidcProfileCreator	From	To
Move Method public getIdTokenValidator() : IDTokenValidator from class org.pac4j.oidc.client.OidcClient to public getIdTokenValidator() : IDTokenValidator from class org.pac4j.oidc.profile.creator.OidcProfileCreator	From	To
Rename Variable	1
Rename Variable userProfile : CommonProfile to profile : CommonProfile in method public buildProfile(typedId String, attributes Map<String,Object>) : CommonProfile in class org.pac4j.core.profile.ProfileHelper	From	To
Inline Method	3
Inline Method protected createResourceRetriever() : ResourceRetriever inlined to protected internalInit(context WebContext) : void in class org.pac4j.oidc.client.OidcClient	From	To
Inline Method public buildUserProfileByClassCompleteName(typedId String, attributes Map<String,Object>, completeName String) : CommonProfile inlined to public buildProfile(typedId String, attributes Map<String,Object>) : CommonProfile in class org.pac4j.core.profile.ProfileHelper	From	To
Move Attribute	17
Move Attribute private discoveryURI : String from class org.pac4j.oidc.client.OidcClient to private discoveryURI : String from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Attribute private idTokenValidator : IDTokenValidator from class org.pac4j.oidc.client.OidcClient to protected idTokenValidator : IDTokenValidator from class org.pac4j.oidc.profile.creator.OidcProfileCreator	From	To
Move Attribute private secret : String from class org.pac4j.oidc.client.OidcClient to private secret : String from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Attribute private clientAuthenticationMethod : ClientAuthenticationMethod from class org.pac4j.oidc.client.OidcClient to private clientAuthenticationMethod : ClientAuthenticationMethod from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Attribute private STATE_ATTRIBUTE : String from class org.pac4j.oidc.client.OidcClient to public STATE_ATTRIBUTE : String from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Attribute private preferredJwsAlgorithm : JWSAlgorithm from class org.pac4j.oidc.client.OidcClient to private preferredJwsAlgorithm : JWSAlgorithm from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Attribute private customParams : Map<String,String> from class org.pac4j.oidc.client.OidcClient to private customParams : Map<String,String> from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Attribute private connectTimeout : int from class org.pac4j.oidc.client.OidcClient to private connectTimeout : int from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Attribute private useNonce : boolean from class org.pac4j.oidc.client.OidcClient to private useNonce : boolean from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Attribute private clientId : String from class org.pac4j.oidc.client.OidcClient to private clientId : String from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Attribute private scope : String from class org.pac4j.oidc.client.OidcClient to private scope : String from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Attribute private DEFAULT_MAX_CLOCK_SKEW : int from class org.pac4j.oidc.client.OidcClient to public DEFAULT_MAX_CLOCK_SKEW : int from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Attribute private NONCE_ATTRIBUTE : String from class org.pac4j.oidc.client.OidcClient to public NONCE_ATTRIBUTE : String from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Attribute private readTimeout : int from class org.pac4j.oidc.client.OidcClient to private readTimeout : int from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Attribute private maxClockSkew : int from class org.pac4j.oidc.client.OidcClient to private maxClockSkew : int from class org.pac4j.oidc.config.OidcConfiguration	From	To
Move Attribute private clientAuthentication : ClientAuthentication from class org.pac4j.oidc.client.OidcClient to protected clientAuthentication : ClientAuthentication from class org.pac4j.oidc.credentials.authenticator.OidcAuthenticator	From	To
Move Attribute private authParams : Map<String,String> from class org.pac4j.oidc.client.OidcClient to private authParams : Map<String,String> from class org.pac4j.oidc.redirect.OidcRedirectActionBuilder	From	To
Extract Class	2
Extract Class org.pac4j.oidc.profile.creator.OidcProfileCreator from class org.pac4j.oidc.client.OidcClient	From	To
Extract Class org.pac4j.oidc.config.OidcConfiguration from class org.pac4j.oidc.client.OidcClient	From	To

a21cda70872740dcfbdf414a239514fefd41a4f2

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: