bdca45867868ca844ae9d8737e733d052ae6c25b
Files Diff
- Added: 12
- Removed: 14
- Renamed: 0
- Modified: 39
Link to commit
Third party dependencies:
| Dependency Action | |
|---|---|
| Added | |
| com.fasterxml.jackson.dataformat:jackson-dataformat-xml:2.7.0 | |
| Updated | |
| From com.fasterxml.jackson.core:jackson-databind 2.5.1 To 2.7.0 |
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 3 | ||
| Move And Rename Method public testMissingScope() : void from class org.pac4j.oauth.client.LinkedIn2ClientIT to public testMissingSecret() : void from class org.pac4j.oauth.client.BaseOAuthClientTests | From | To | |
| Move And Rename Method public testMissingFields() : void from class org.pac4j.oauth.client.LinkedIn2ClientIT to public testMissingKey() : void from class org.pac4j.oauth.client.BaseOAuthClientTests | From | To | |
| Move And Rename Method public testMissingSecret() : void from class org.pac4j.oauth.client.OAuthClientIT to public testMissingKey() : void from class org.pac4j.oauth.client.BaseOAuthClientTests | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type clazz : Class<? extends XmlObject> to clazz : Class<? extends OldXmlObject> in method public XmlObjectConverter(clazz Class<? extends OldXmlObject>) in class org.pac4j.oauth.profile.converter.XmlObjectConverter | From | To | |
| Move Method | 3 | ||
| Move Method public testMissingKey() : void from class org.pac4j.oauth.client.OAuthClientIT to public testMissingKey() : void from class org.pac4j.oauth.client.BaseOAuthClientTests | From | To | |
| Move Method protected abstract buildFromXml(xml String) : void from class org.pac4j.oauth.profile.XmlObject to protected abstract buildFromXml(xml String) : void from class org.pac4j.oauth.profile.OldXmlObject | From | To | |
| Move Method public buildFrom(xml String) : void from class org.pac4j.oauth.profile.XmlObject to public buildFrom(xml String) : void from class org.pac4j.oauth.profile.OldXmlObject | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private serialVersionUID : long from class org.pac4j.oauth.profile.XmlObject to private serialVersionUID : long from class org.pac4j.oauth.profile.OldXmlObject | From | To | |
| Move Attribute private clazz : Class<? extends Object> from class org.pac4j.oauth.profile.converter.XmlListConverter to private clazz : Class<? extends Object> from class org.pac4j.oauth.profile.converter.OldXmlListConverter | From | To | |
| Extract Class | 1 | ||
| Extract Class org.pac4j.oauth.profile.OldXmlObject from class org.pac4j.oauth.profile.XmlObject | From | To | |
| Rename Class | 8 | ||
| Rename Class org.pac4j.oauth.client.RunFoursquare renamed to org.pac4j.oauth.client.RunFoursquareClient | From | To | |
| Rename Class org.pac4j.oauth.client.RunGoogle renamed to org.pac4j.oauth.client.RunGoogle2Client | From | To | |
| Rename Class org.pac4j.oauth.client.RunFacebook renamed to org.pac4j.oauth.client.RunFacebookClient | From | To | |
| Rename Class org.pac4j.oauth.client.RunDropbox renamed to org.pac4j.oauth.client.RunDropboxClient | From | To | |
| Rename Class org.pac4j.oauth.client.RunGithub renamed to org.pac4j.oauth.client.RunGithubClient | From | To | |
| Rename Class org.pac4j.oauth.client.RunBitbucket renamed to org.pac4j.oauth.client.RunBitbucketClient | From | To | |
| Rename Class org.pac4j.oauth.client.OkClientIT renamed to org.pac4j.oauth.client.RunOkClient | From | To | |
| Rename Class org.pac4j.oauth.client.FacebookClientTests renamed to org.pac4j.oauth.client.OAuthClientsTests | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type constructor : Constructor<? extends XmlObject> to constructor : Constructor<? extends OldXmlObject> in method public convert(attribute Object) : OldXmlObject in class org.pac4j.oauth.profile.converter.XmlObjectConverter | From | To | |
| Change Variable Type xmlObject : XmlObject to xmlObject : OldXmlObject in method public convert(attribute Object) : OldXmlObject in class org.pac4j.oauth.profile.converter.XmlObjectConverter | From | To | |
| Extract Method | 1 | ||
| Extract Method private addUrl(profile LinkedIn2Profile, json JsonNode, name String) : void extracted from protected extractUserProfile(body String) : LinkedIn2Profile in class org.pac4j.oauth.client.LinkedIn2Client | From | To | |
| Rename Method | 2 | ||
| Rename Method public getIsCurrent() : Boolean renamed to public getCurrent() : Boolean in class org.pac4j.oauth.profile.linkedin2.LinkedIn2Position | From | To | |
| Rename Method public stringify(obj Object) : String renamed to public toJSONString(obj Object) : String in class org.pac4j.oauth.profile.JsonHelper | From | To | |
| Change Return Type | 3 | ||
| Change Return Type XmlList to Object in method public convert(attribute Object) : Object in class org.pac4j.oauth.profile.converter.XmlListConverter | From | To | |
| Change Return Type Client to IndirectClient in method protected getClient() : IndirectClient in class org.pac4j.oauth.client.RunOkClient | From | To | |
| Change Return Type XmlObject to OldXmlObject in method public convert(attribute Object) : OldXmlObject in class org.pac4j.oauth.profile.converter.XmlObjectConverter | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.pac4j.oauth.profile.OldXmlObject from classes [org.pac4j.oauth.profile.XmlList, org.pac4j.oauth.profile.converter.MockXmlObject] | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute clazz : Class<? extends Object> to arrayClazz : Class in class org.pac4j.oauth.profile.converter.XmlListConverter | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type converterForString : XmlListConverter to converterForString : OldXmlListConverter in class org.pac4j.oauth.profile.converter.TestXmlListConverter | From | To | |
| Change Attribute Type clazz : Class<? extends XmlObject> to clazz : Class<? extends OldXmlObject> in class org.pac4j.oauth.profile.converter.XmlObjectConverter | From | To | |
| Change Attribute Type clazz : Class<? extends Object> to arrayClazz : Class in class org.pac4j.oauth.profile.converter.XmlListConverter | From | To | |
| Change Attribute Type converterForMockXmlObject : XmlListConverter to converterForMockXmlObject : OldXmlListConverter in class org.pac4j.oauth.profile.converter.TestXmlListConverter | From | To |