e8f09ae02c48eccd33bf07452fe9a803aea2fbd4
Files Diff
- Added: 2
- Removed: 5
- Renamed: 0
- Modified: 13
Link to commit
Third party dependencies:
| Dependency Action | |
|---|---|
| Added | |
| com.github.scribejava:scribejava-apis:2.2.0 | |
| Removed | |
| org.scribe:scribe:1.3.6 |
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Merge Attribute | 1 | ||
| Merge Attribute [connectTimeout : int, readTimeout : int, proxyHost : String, proxyPort : int] to service : OAuthService in class org.pac4j.oauth.client.BaseOAuthClient | From | To | |
| Rename Method | 1 | ||
| Rename Method protected createProxyRequest(url String) : ProxyOAuthRequest renamed to protected createOAuthRequest(url String) : OAuthRequest in class org.pac4j.oauth.client.BaseOAuthClient | From | To | |
| Push Down Method | 2 | ||
| Push Down Method public getProxyHost() : String from class org.pac4j.oauth.client.BaseOAuthClient to public getStateData() : String from class org.pac4j.oauth.client.BaseOAuth20StateClient | From | To | |
| Push Down Method public setProxyHost(proxyHost String) : void from class org.pac4j.oauth.client.BaseOAuthClient to public setStateData(stateData String) : void from class org.pac4j.oauth.client.BaseOAuth20StateClient | From | To | |
| Move And Inline Method | 1 | ||
| Move And Inline Method protected getAuthorizationUrl(state String) : String moved from class org.pac4j.oauth.client.BaseOAuth20StateClient to class org.pac4j.oauth.client.BaseOAuth20Client & inlined to protected retrieveAuthorizationUrl(context WebContext) : String | From | To | |
| Inline Method | 1 | ||
| Inline Method protected getAuthorizationUrl(state String) : String inlined to protected retrieveAuthorizationUrl(context WebContext) : String in class org.pac4j.oauth.client.BaseOAuth20StateClient | From | To | |
| Change Return Type | 1 | ||
| Change Return Type ProxyOAuthRequest to OAuthRequest in method protected createOAuthRequest(url String) : OAuthRequest in class org.pac4j.oauth.client.BaseOAuthClient | From | To | |
| Move Class | 2 | ||
| Move Class org.scribe.builder.api.CasOAuthWrapperApi20 moved to org.pac4j.scribe.builder.api.CasOAuthWrapperApi20 | From | To | |
| Move Class org.scribe.builder.api.BitBucketApi moved to org.pac4j.scribe.builder.api.BitBucketApi | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type request : ProxyOAuthRequest to request : OAuthRequest in method protected sendRequestForData(accessToken Token, dataUrl String) : String in class org.pac4j.oauth.client.BaseOAuthClient | From | To | |
| Change Variable Type request : ProxyOAuthRequest to request : OAuthRequest in method protected retrieveUserProfileFromToken(accessToken Token) : FacebookProfile in class org.pac4j.oauth.client.FacebookClient | From | To | |
| Extract And Move Method | 5 | ||
| Extract And Move Method protected buildOAuthConfig(context WebContext, type SignatureType, scope String) : OAuthConfig extracted from protected internalInit(context WebContext) : void in class org.pac4j.oauth.client.BitbucketClient & moved to class org.pac4j.oauth.client.BaseOAuthClient | From | To | |
| Extract And Move Method protected buildOAuthConfig(context WebContext, type SignatureType, scope String) : OAuthConfig extracted from protected internalInit(context WebContext) : void in class org.pac4j.oauth.client.CasOAuthWrapperClient & moved to class org.pac4j.oauth.client.BaseOAuthClient | From | To | |
| Extract And Move Method protected buildOAuthConfig(context WebContext, type SignatureType, scope String) : OAuthConfig extracted from protected internalInit(context WebContext) : void in class org.pac4j.oauth.client.FoursquareClient & moved to class org.pac4j.oauth.client.BaseOAuthClient | From | To | |
| Extract And Move Method protected buildOAuthConfig(context WebContext, type SignatureType, scope String) : OAuthConfig extracted from protected internalInit(context WebContext) : void in class org.pac4j.oauth.client.DropBoxClient & moved to class org.pac4j.oauth.client.BaseOAuthClient | From | To | |
| Extract And Move Method protected buildOAuthConfig(context WebContext, type SignatureType, scope String) : OAuthConfig extracted from protected internalInit(context WebContext) : void in class org.pac4j.oauth.client.GitHubClient & moved to class org.pac4j.oauth.client.BaseOAuthClient | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter proxyHost : String to stateData : String in method public setStateData(stateData String) : void in class org.pac4j.oauth.client.BaseOAuth20StateClient | From | To |