1e09385e22b6075ba21e101f358573d6e11076b1
Files Diff
- Added: 3
- Removed: 1
- Renamed: 0
- Modified: 25
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private createRepositoryDirectory(repositoryDirectoryInterface RepositoryDirectoryInterface, repositoryDirectories List<RepositoryDirectory>, depth int, parent RepositoryDirectory, filter String) : void renamed to public loadFilesAndFolders(path String) : RepositoryDirectory in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Rename Variable | 3 | ||
| Rename Variable repositoryObject : RepositoryObjectInterface to child : RepositoryDirectoryInterface in method private populateFolders(repositoryDirectory RepositoryDirectory, repositoryDirectoryInterface RepositoryDirectoryInterface) : void in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Rename Variable jsonValue : String to jsonString : String in method public getRecentSearches() : JSONArray in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Rename Variable repositoryDirectories : List<RepositoryDirectory> to repositoryTree : RepositoryTree in method public loadDirectoryTree(filter String) : Response in class org.pentaho.repo.endpoint.RepositoryBrowserEndpoint | From | To | |
| Change Return Type | 6 | ||
| Change Return Type List<RepositoryFile> to RepositoryDirectory in method public loadFiles(path String) : RepositoryDirectory in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Change Return Type List<RepositoryDirectory> to RepositoryTree in method public loadDirectoryTree(filter String) : RepositoryTree in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Change Return Type List<RepositoryDirectory> to RepositoryTree in method public loadDirectoryTree() : RepositoryTree in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Change Return Type LinkedList<String> to JSONArray in method public storeRecentSearch(recentSearch String) : JSONArray in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Change Return Type void to RepositoryDirectory in method public loadFilesAndFolders(path String) : RepositoryDirectory in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Change Return Type LinkedList<String> to JSONArray in method public getRecentSearches() : JSONArray in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Extract Attribute | 4 | ||
| Extract Attribute public FILTER : String in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Extract Attribute public PENTAHO_ENTERPRISE_REPOSITORY : String in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Extract Attribute public JOB : String in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Extract Attribute public FOLDER : String in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute repositoryDirectoryInterface : RepositoryDirectoryInterface to rootDirectory : RepositoryDirectoryInterface in method public loadDirectoryTree(filter String) : RepositoryTree in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable repositoryFile : RepositoryFile to repositoryDirectory : RepositoryDirectory in method private populateFiles(repositoryDirectory RepositoryDirectory, repositoryDirectoryInterface RepositoryDirectoryInterface, filter String) : void in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type repositoryDirectories : List<RepositoryDirectory> to repositoryTree : RepositoryTree in method public loadDirectoryTree(filter String) : Response in class org.pentaho.repo.endpoint.RepositoryBrowserEndpoint | From | To | |
| Change Variable Type repositoryFile : RepositoryFile to repositoryDirectory : RepositoryDirectory in method private populateFiles(repositoryDirectory RepositoryDirectory, repositoryDirectoryInterface RepositoryDirectoryInterface, filter String) : void in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Change Variable Type recentSearches : LinkedList<String> to recentSearches : JSONArray in method public storeRecentSearch(recentSearch String) : JSONArray in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Change Variable Type repositoryObject : RepositoryObjectInterface to child : RepositoryDirectoryInterface in method private populateFolders(repositoryDirectory RepositoryDirectory, repositoryDirectoryInterface RepositoryDirectoryInterface) : void in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Extract Variable | 2 | ||
| Extract Variable children : List<RepositoryDirectoryInterface> in method private populateFolders(repositoryDirectory RepositoryDirectory, repositoryDirectoryInterface RepositoryDirectoryInterface) : void from class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Extract Variable latestDate : Date in method private populateFiles(repositoryDirectory RepositoryDirectory, repositoryDirectoryInterface RepositoryDirectoryInterface, filter String) : void from class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Extract Method | 6 | ||
| Extract Method private populateFiles(repositoryDirectory RepositoryDirectory, repositoryDirectoryInterface RepositoryDirectoryInterface, filter String) : void extracted from private createRepositoryDirectory(repositoryDirectoryInterface RepositoryDirectoryInterface, repositoryDirectories List<RepositoryDirectory>, depth int, parent RepositoryDirectory, filter String) : void in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Extract Method private getLogin() : String extracted from public getRecentSearches() : LinkedList<String> in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Extract Method private populateFolders(repositoryDirectory RepositoryDirectory, repositoryDirectoryInterface RepositoryDirectoryInterface) : void extracted from private createRepositoryDirectory(repositoryDirectoryInterface RepositoryDirectoryInterface, repositoryDirectories List<RepositoryDirectory>, depth int, parent RepositoryDirectory, filter String) : void in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Extract Method private getRepositoryElements(repositoryDirectoryInterface RepositoryDirectoryInterface) : List<RepositoryElementMetaInterface> extracted from public loadFiles(id String) : List<RepositoryFile> in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Extract Method private populateFiles(repositoryDirectory RepositoryDirectory, repositoryDirectoryInterface RepositoryDirectoryInterface, filter String) : void extracted from public loadFiles(id String) : List<RepositoryFile> in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Extract Method private getLogin() : String extracted from public storeRecentSearch(recentSearch String) : LinkedList<String> in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method public build(parentPath String, repositoryDirectoryInterface RepositoryDirectoryInterface) : RepositoryDirectory extracted from private createRepositoryDirectory(repositoryDirectoryInterface RepositoryDirectoryInterface, repositoryDirectories List<RepositoryDirectory>, depth int, parent RepositoryDirectory, filter String) : void in class org.pentaho.repo.controller.RepositoryBrowserController & moved to class org.pentaho.repo.model.RepositoryDirectory | From | To | |
| Extract And Move Method public build(parentPath String, repositoryDirectoryInterface RepositoryDirectoryInterface) : RepositoryDirectory extracted from public loadFiles(id String) : List<RepositoryFile> in class org.pentaho.repo.controller.RepositoryBrowserController & moved to class org.pentaho.repo.model.RepositoryDirectory | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter filter : String to path : String in method public loadFilesAndFolders(path String) : RepositoryDirectory in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Rename Parameter id : String to path : String in method public loadFiles(path String) : RepositoryDirectory in class org.pentaho.repo.controller.RepositoryBrowserController | From | To | |
| Rename Parameter id : String to path : String in method public loadFile(path String) : Response in class org.pentaho.repo.endpoint.RepositoryBrowserEndpoint | From | To |