4f13e7602787315d5613c413ff0b0b3775177e97
Files Diff
- Added: 3
- Removed: 0
- Renamed: 0
- Modified: 16
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Variable | 3 | ||
| Rename Variable status : String to logId : String in method public doGet(request HttpServletRequest, response HttpServletResponse) : void in class org.pentaho.di.www.GetJobStatusServlet | From | To | |
| Rename Variable stringBuffer : StringBuffer to eventBuffer : StringBuilder in method public getBuffer(parentLogChannelId String, includeGeneral boolean, startLineNr int, endLineNr int) : StringBuffer in class org.pentaho.di.core.logging.LoggingBuffer | From | To | |
| Rename Variable status : String to logId : String in method public doGet(request HttpServletRequest, response HttpServletResponse) : void in class org.pentaho.di.www.GetTransStatusServlet | From | To | |
| Extract Attribute | 1 | ||
| Extract Attribute private loggingRegistry : LoggingRegistry in class org.pentaho.di.core.logging.LoggingBuffer | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute logging : String to currentLogText : String in method public showLog() : void in class org.pentaho.di.ui.spoon.SpoonSlave | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable line : BufferLine to bufferLine : BufferLine in method private getLogChId(bufferLine BufferLine) : String in class org.pentaho.di.core.logging.LoggingBuffer | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute cache : XMLHandlerCache to instance : XMLHandlerCache in class org.pentaho.di.core.xml.XMLHandlerCache | From | To | |
| Rename Attribute hashtable : Hashtable<XMLHandlerCacheEntry,Integer> to cache : Map<XMLHandlerCacheEntry,Integer> in class org.pentaho.di.core.xml.XMLHandlerCache | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type stringBuffer : StringBuffer to eventBuffer : StringBuilder in method public getBuffer(parentLogChannelId String, includeGeneral boolean, startLineNr int, endLineNr int) : StringBuffer in class org.pentaho.di.core.logging.LoggingBuffer | From | To | |
| Extract Method | 4 | ||
| Extract Method private getLogChId(bufferLine BufferLine) : String extracted from public getLogBufferFromTo(channelId List<String>, includeGeneral boolean, from int, to int) : List<KettleLoggingEvent> in class org.pentaho.di.core.logging.LoggingBuffer | From | To | |
| Extract Method private isGeneral(logChannelId String) : boolean extracted from public getLogBufferFromTo(channelId List<String>, includeGeneral boolean, from int, to int) : List<KettleLoggingEvent> in class org.pentaho.di.core.logging.LoggingBuffer | From | To | |
| Extract Method private getLogText(trans Trans, startLineNr int, lastLineNr int) : String extracted from public doGet(request HttpServletRequest, response HttpServletResponse) : void in class org.pentaho.di.www.GetTransStatusServlet | From | To | |
| Extract Method private getLogText(job Job, startLineNr int, lastLineNr int) : String extracted from public doGet(request HttpServletRequest, response HttpServletResponse) : void in class org.pentaho.di.www.GetJobStatusServlet | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type buffer : List<BufferLine> to buffer : LinkedBlockingDeque<BufferLine> in class org.pentaho.di.core.logging.LoggingBuffer | From | To | |
| Change Attribute Type hashtable : Hashtable<XMLHandlerCacheEntry,Integer> to cache : Map<XMLHandlerCacheEntry,Integer> in class org.pentaho.di.core.xml.XMLHandlerCache | From | To | |
| Change Attribute Type cache : XMLHandlerCache to cache : Map<XMLHandlerCacheEntry,Integer> in class org.pentaho.di.core.xml.XMLHandlerCache | From | To |