5d5c4b3ab6feffb7043f201f5f2da4cfe3453953
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 8
Link to commit
Third party dependencies:
| Dependency Action | |
|---|---|
| Added | |
| joda-time:joda-time:2.9.9 | |
| Removed | |
| net.java.dev.jets3t:jets3t:0.9.4 | |
| Updated | |
| From junit:junit 4.11 To 4.7 | |
| From com.amazonaws:aws-java-sdk-s3 1.11.516 To 1.11.275 | |
| From org.apache.commons:commons-compress 1.18 To 1.4.1 | |
| From com.fasterxml.jackson.core:jackson-annotations 2.9.8 To 2.9.2 | |
| From commons-logging:commons-logging 1.2 To 1.1.3 | |
| From com.fasterxml.jackson.core:jackson-core 2.9.2 To 2.9.8 | |
| From junit:junit junit.version To 4.7 | |
| From commons-logging:commons-logging 1.1.3 To 1.2 | |
| From com.google.guava:guava 17.0 To 19.0 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-base 2.5.4 To 2.9.8 | |
| From org.postgresql:postgresql 42.1.1 To 42.2.5 | |
| From com.fasterxml.jackson.core:jackson-annotations 2.9.2 To 2.9.8 | |
| From org.eclipse:jface 3.3.0-I20070606-0010 To jface.version | |
| From org.postgresql:postgresql 42.2.5 To 42.1.1 | |
| From javax.servlet:javax.servlet-api 4.0.0-b07 To 3.0.1 | |
| From commons-codec:commons-codec 1.10 To 1.9 | |
| From com.fasterxml.jackson.core:jackson-databind 2.9.8 To 2.9.2 | |
| From org.dom4j:dom4j 2.1.1 To 1.6.1 | |
| From javax.servlet:javax.servlet-api 3.0.1 To 4.0.0-b07 | |
| From org.eclipse:jface jface.version To 3.3.0-I20070606-0010 | |
| From org.apache.commons:commons-compress 1.4.1 To 1.18 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-base 2.9.8 To 2.5.4 | |
| From junit:junit 4.7 To 4.11 | |
| From junit:junit 4.4 To 4.7 | |
| From commons-codec:commons-codec 1.9 To 1.10 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider 2.9.8 To 2.5.4 | |
| From org.mockito:mockito-all 1.10.19 To 1.9.5 | |
| From com.fasterxml.jackson.core:jackson-core 2.9.8 To 2.9.2 | |
| From org.dom4j:dom4j 1.6.1 To 2.1.1 | |
| From com.fasterxml.jackson.core:jackson-databind 2.9.2 To 2.9.8 | |
| From org.mockito:mockito-all 1.9.5 To 1.10.19 | |
| From com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider 2.5.4 To 2.9.8 | |
| From com.google.guava:guava 19.0 To 17.0 |
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private getS3ServiceMock(credentials AWSCredentials) : S3Service renamed to private getS3ClientMock(credentials AWSCredentials) : AmazonS3 in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProviderTest | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type bucket : S3Bucket to bucket : Bucket in method public getS3Object(bucket Bucket, objectKey String) : S3Object in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProvider | From | To | |
| Change Parameter Type bucket : S3Bucket to bucket : Bucket in method private getS3Objects(bucket Bucket) : ObjectListing in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProvider | From | To | |
| Change Parameter Type service : S3Service to s3Client : AmazonS3 in method public S3ObjectsProvider(s3Client AmazonS3) in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProvider | From | To | |
| Change Parameter Type bucket : S3Bucket to bucket : Bucket in method public getS3ObjectContentLenght(bucket Bucket, objectKey String) : long in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProvider | From | To | |
| Rename Variable | 1 | ||
| Rename Variable service : S3Service to s3Client : AmazonS3 in method private getS3ClientMock(credentials AWSCredentials) : AmazonS3 in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProviderTest | From | To | |
| Change Return Type | 5 | ||
| Change Return Type S3Bucket to Bucket in method public getBucket(bucketName String) : Bucket in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProvider | From | To | |
| Change Return Type S3Service to AmazonS3 in method private getS3ClientMock(credentials AWSCredentials) : AmazonS3 in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProviderTest | From | To | |
| Change Return Type S3Bucket[] to List<Bucket> in method private getBuckets() : List<Bucket> in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProvider | From | To | |
| Change Return Type S3Object[] to ObjectListing in method private getS3Objects(bucket Bucket) : ObjectListing in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProvider | From | To | |
| Change Return Type S3Bucket[] to List<Bucket> in method private generateTestBuckets(TEST_USER_BUCKETS_NAMES String[]) : List<Bucket> in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProviderTest | From | To | |
| Rename Attribute | 5 | ||
| Rename Attribute service : S3Service to s3Client : AmazonS3 in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProvider | From | To | |
| Rename Attribute s3Object : S3Object to s3ObjectInputStream : S3ObjectInputStream in class org.pentaho.di.trans.steps.s3csvinput.S3CsvInputData | From | To | |
| Rename Attribute fis : InputStream to s3ObjectInputStream : S3ObjectInputStream in class org.pentaho.di.trans.steps.s3csvinput.S3CsvInputData | From | To | |
| Rename Attribute s3serviceMock : S3Service to s3ClientMock : AmazonS3 in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProviderTest | From | To | |
| Rename Attribute s3Service : S3Service to s3Client : AmazonS3 in class org.pentaho.di.trans.steps.s3csvinput.S3CsvInputData | From | To | |
| Extract Variable | 1 | ||
| Extract Variable mockMetaData : ObjectMetadata in method private getS3ClientMock(credentials AWSCredentials) : AmazonS3 from class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProviderTest | From | To | |
| Change Variable Type | 6 | ||
| Change Variable Type s3bucket : S3Bucket to s3bucket : Bucket in method private getCSV() : void in class org.pentaho.di.trans.steps.s3csvinput.S3CsvInputDialog | From | To | |
| Change Variable Type bucket : S3Bucket to bucket : Bucket in method public getS3ObjectsNames(bucketName String) : String[] in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProvider | From | To | |
| Change Variable Type actual : S3Bucket to actual : Bucket in method public testGetBucketFound() : void in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProviderTest | From | To | |
| Change Variable Type service : S3Service to s3Client : AmazonS3 in method private getS3ClientMock(credentials AWSCredentials) : AmazonS3 in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProviderTest | From | To | |
| Change Variable Type actual : String[] to actual : List<String> in method public testGetObjectsNamesInBucketWithObjects() : void in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProviderTest | From | To | |
| Change Variable Type actual : S3Bucket to actual : Bucket in method public testGetBucketNotFound_ReturnsNull() : void in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProviderTest | From | To | |
| Change Attribute Type | 11 | ||
| Change Attribute Type service : S3Service to s3Client : AmazonS3 in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProvider | From | To | |
| Change Attribute Type BUCKET1 : S3Bucket to BUCKET1 : Bucket in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProviderTest | From | To | |
| Change Attribute Type bucket3Objects : S3Object[] to bucket3Objects : ObjectListing in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProviderTest | From | To | |
| Change Attribute Type bucket2Objects : S3Object[] to bucket2Objects : ObjectListing in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProviderTest | From | To | |
| Change Attribute Type s3bucket : S3Bucket to s3bucket : Bucket in class org.pentaho.di.trans.steps.s3csvinput.S3CsvInputData | From | To | |
| Change Attribute Type s3Service : S3Service to s3Client : AmazonS3 in class org.pentaho.di.trans.steps.s3csvinput.S3CsvInputData | From | To | |
| Change Attribute Type BUCKET3 : S3Bucket to BUCKET3 : Bucket in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProviderTest | From | To | |
| Change Attribute Type s3Object : S3Object to s3ObjectInputStream : S3ObjectInputStream in class org.pentaho.di.trans.steps.s3csvinput.S3CsvInputData | From | To | |
| Change Attribute Type fis : InputStream to s3ObjectInputStream : S3ObjectInputStream in class org.pentaho.di.trans.steps.s3csvinput.S3CsvInputData | From | To | |
| Change Attribute Type s3serviceMock : S3Service to s3ClientMock : AmazonS3 in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProviderTest | From | To | |
| Change Attribute Type BUCKET2 : S3Bucket to BUCKET2 : Bucket in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProviderTest | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter service : S3Service to s3Client : AmazonS3 in method public S3ObjectsProvider(s3Client AmazonS3) in class org.pentaho.di.trans.steps.s3csvinput.S3ObjectsProvider | From | To |