73da1e28a3d912753f6bbf317aa97b5e1af9e06b
Files Diff
- Added: 7
- Removed: 1
- Renamed: 0
- Modified: 33
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 2 | ||
| Move And Rename Method private showDynamic() : void from class org.pentaho.di.engine.ui.RunConfigurationDialog to public attach(runConfigurationDialog RunConfigurationDialog) : void from class org.pentaho.di.engine.configuration.impl.spark.SparkRunConfigurationUI | From | To | |
| Move And Rename Method private showDefault() : void from class org.pentaho.di.engine.ui.RunConfigurationDialog to public attach(runConfigurationDialog RunConfigurationDialog) : void from class org.pentaho.di.engine.configuration.impl.pentaho.DefaultRunConfigurationUI | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type configuration : TransExecutionConfiguration to configuration : ExecutionConfiguration in method public execute(runConfiguration RunConfiguration, configuration ExecutionConfiguration, meta AbstractMeta, variableSpace VariableSpace) : void in class org.pentaho.di.engine.configuration.api.RunConfigurationExecutor | From | To | |
| Change Parameter Type configuration : TransExecutionConfiguration to executionConfiguration : ExecutionConfiguration in method public execute(runConfiguration RunConfiguration, executionConfiguration ExecutionConfiguration, meta AbstractMeta, variableSpace VariableSpace) : void in class org.pentaho.di.engine.configuration.impl.pentaho.DefaultRunConfigurationExecutor | From | To | |
| Change Parameter Type configuration : TransExecutionConfiguration to configuration : ExecutionConfiguration in method public execute(runConfiguration RunConfiguration, configuration ExecutionConfiguration, meta AbstractMeta, variableSpace VariableSpace) : void in class org.pentaho.di.engine.configuration.impl.spark.SparkRunConfigurationExecutor | From | To | |
| Move Method | 1 | ||
| Move Method private checkOKEnabled(defaultRunConfiguration DefaultRunConfiguration, wcSlaveServer CCombo) : void from class org.pentaho.di.engine.ui.RunConfigurationDialog to public checkOKEnabled() : void from class org.pentaho.di.engine.configuration.impl.pentaho.DefaultRunConfigurationUI | From | To | |
| Pull Up Attribute | 2 | ||
| Pull Up Attribute protected wRunConfiguration : ComboVar from class org.pentaho.di.ui.job.entries.trans.JobEntryTransDialog to protected wRunConfiguration : ComboVar from class org.pentaho.di.ui.job.entries.trans.JobEntryBaseDialog | From | To | |
| Pull Up Attribute private wRunConfiguration : CCombo from class org.pentaho.di.ui.trans.dialog.TransExecutionConfigurationDialog to protected wRunConfiguration : CCombo from class org.pentaho.di.ui.core.dialog.ConfigurationDialog | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private spoonSupplier : Supplier<Spoon> from class org.pentaho.di.engine.ui.RunConfigurationDialog to private spoonSupplier : Supplier<Spoon> from class org.pentaho.di.engine.configuration.impl.pentaho.DefaultRunConfigurationUI | From | To | |
| Move Attribute public CLUSTERED : String from class org.pentaho.di.engine.ui.RunConfigurationDialog to private CLUSTERED : String from class org.pentaho.di.engine.configuration.impl.pentaho.DefaultRunConfigurationUI | From | To | |
| Extract Class | 1 | ||
| Extract Class org.pentaho.di.engine.configuration.impl.pentaho.DefaultRunConfigurationUI from class org.pentaho.di.engine.ui.RunConfigurationDialog | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type transExecutionConfiguration : TransExecutionConfiguration to executionConfiguration : ExecutionConfiguration in method public callExtensionPoint(logChannelInterface LogChannelInterface, o Object) : void in class org.pentaho.di.engine.configuration.impl.extension.RunConfigurationRunExtensionPoint | From | To | |
| Extract Method | 2 | ||
| Extract Method private setSlaveServer(executionConfiguration ExecutionConfiguration, meta AbstractMeta, defaultRunConfiguration DefaultRunConfiguration, variableSpace VariableSpace) : void extracted from public execute(runConfiguration RunConfiguration, configuration TransExecutionConfiguration, meta AbstractMeta, variableSpace VariableSpace) : void in class org.pentaho.di.engine.configuration.impl.pentaho.DefaultRunConfigurationExecutor | From | To | |
| Extract Method private configureTransExecution(transExecutionConfiguration TransExecutionConfiguration, defaultRunConfiguration DefaultRunConfiguration, variableSpace VariableSpace, meta AbstractMeta) : void extracted from public execute(runConfiguration RunConfiguration, configuration TransExecutionConfiguration, meta AbstractMeta, variableSpace VariableSpace) : void in class org.pentaho.di.engine.configuration.impl.pentaho.DefaultRunConfigurationExecutor | From | To | |
| Rename Method | 4 | ||
| Rename Method public testExecuteRemoteNotFound() : void renamed to public testExecuteRemoteNotFoundTrans() : void in class org.pentaho.di.engine.configuration.impl.pentaho.DefaultRunConfigurationExecutorTest | From | To | |
| Rename Method public testExecuteLocal() : void renamed to public testExecuteLocalTrans() : void in class org.pentaho.di.engine.configuration.impl.pentaho.DefaultRunConfigurationExecutorTest | From | To | |
| Rename Method public testExecuteClustered() : void renamed to public testExecuteClusteredTrans() : void in class org.pentaho.di.engine.configuration.impl.pentaho.DefaultRunConfigurationExecutorTest | From | To | |
| Rename Method public testExecuteRemote() : void renamed to public testExecuteRemoteTrans() : void in class org.pentaho.di.engine.configuration.impl.pentaho.DefaultRunConfigurationExecutorTest | From | To | |
| Rename Variable | 1 | ||
| Rename Variable transExecutionConfiguration : TransExecutionConfiguration to executionConfiguration : ExecutionConfiguration in method public callExtensionPoint(logChannelInterface LogChannelInterface, o Object) : void in class org.pentaho.di.engine.configuration.impl.extension.RunConfigurationRunExtensionPoint | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type variableSpace : VariableSpace to variableSpace : AbstractMeta in class org.pentaho.di.engine.configuration.impl.pentaho.DefaultRunConfigurationExecutorTest | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method protected runConfigurationSectionLayout(PKG Class<?>, prefix String) : void extracted from public open() : boolean in class org.pentaho.di.ui.trans.dialog.TransExecutionConfigurationDialog & moved to class org.pentaho.di.ui.core.dialog.ConfigurationDialog | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter configuration : TransExecutionConfiguration to executionConfiguration : ExecutionConfiguration in method public execute(runConfiguration RunConfiguration, executionConfiguration ExecutionConfiguration, meta AbstractMeta, variableSpace VariableSpace) : void in class org.pentaho.di.engine.configuration.impl.pentaho.DefaultRunConfigurationExecutor | From | To |