80a3a8ad220495ec8ac89d112ea355ec5904ce88
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 4
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Extract Variable | 2 | ||
| Extract Variable login : String in method public UserRoleDelegate(rsm IRoleSupportSecurityManager, repositoryMeta PurRepositoryMeta, userInfo IUser, logger Log, serviceManager ServiceManager) from class org.pentaho.di.repository.pur.UserRoleDelegate | From | To | |
| Extract Variable password : String in method public UserRoleDelegate(rsm IRoleSupportSecurityManager, repositoryMeta PurRepositoryMeta, userInfo IUser, logger Log, serviceManager ServiceManager) from class org.pentaho.di.repository.pur.UserRoleDelegate | From | To | |
| Inline Variable | 1 | ||
| Inline Variable info : UserInfo in method public saveUserInfo_NormalizesInfo_PassesIfNoViolations() : void from class org.pentaho.di.repository.kdr.KettleDatabaseRepositorySecurityProviderTest | From | To | |
| Extract Method | 17 | ||
| Extract Method private cannotCreateUserException(user IUser, e Exception) : KettleException extracted from public createUser(newUser IUser) : void in class org.pentaho.di.repository.pur.UserRoleDelegate | From | To | |
| Extract Method private ensureHasPermissions() : void extracted from public deleteRoles(roles List<IRole>) : void in class org.pentaho.di.repository.pur.UserRoleDelegate | From | To | |
| Extract Method private ensureHasPermissions() : void extracted from public deleteUser(name String) : void in class org.pentaho.di.repository.pur.UserRoleDelegate | From | To | |
| Extract Method private testSaveUserInfo_Passes(login String, expectedLogin String) : void extracted from public saveUserInfo_NormalizesInfo_PassesIfNoViolations() : void in class org.pentaho.di.repository.kdr.KettleDatabaseRepositorySecurityProviderTest | From | To | |
| Extract Method private cannotCreateRoleException(role IRole, e Exception) : KettleException extracted from public createRole(newRole IRole) : void in class org.pentaho.di.repository.pur.UserRoleDelegate | From | To | |
| Extract Method private ensureHasPermissions() : void extracted from public createUser(newUser IUser) : void in class org.pentaho.di.repository.pur.UserRoleDelegate | From | To | |
| Extract Method private ensureHasPermissions() : void extracted from public createRole(newRole IRole) : void in class org.pentaho.di.repository.pur.UserRoleDelegate | From | To | |
| Extract Method private userExistsException() : KettleException extracted from public createUser(newUser IUser) : void in class org.pentaho.di.repository.pur.UserRoleDelegate | From | To | |
| Extract Method private userExistsException() : KettleException extracted from public createRole(newRole IRole) : void in class org.pentaho.di.repository.pur.UserRoleDelegate | From | To | |
| Extract Method private ensureHasPermissions() : void extracted from public getRole(name String) : IRole in class org.pentaho.di.repository.pur.UserRoleDelegate | From | To | |
| Extract Method private ensureHasPermissions() : void extracted from public deleteRole(name String) : void in class org.pentaho.di.repository.pur.UserRoleDelegate | From | To | |
| Extract Method private ensureHasPermissions() : void extracted from public deleteUsers(users List<IUser>) : void in class org.pentaho.di.repository.pur.UserRoleDelegate | From | To | |
| Extract Method private ensureHasPermissions() : void extracted from public getUser(name String) : IUser in class org.pentaho.di.repository.pur.UserRoleDelegate | From | To | |
| Extract Method private ensureHasPermissions() : void extracted from public getDefaultRoles() : List<IRole> in class org.pentaho.di.repository.pur.UserRoleDelegate | From | To | |
| Extract Method private ensureHasPermissions() : void extracted from public updateRole(role IRole) : void in class org.pentaho.di.repository.pur.UserRoleDelegate | From | To | |
| Extract Method private ensureHasPermissions() : void extracted from public getUser(name String, password String) : IUser in class org.pentaho.di.repository.pur.UserRoleDelegate | From | To | |
| Extract Method private ensureHasPermissions() : void extracted from public updateUser(user IUser) : void in class org.pentaho.di.repository.pur.UserRoleDelegate | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter newRole : IRole to role : IRole in method private cannotCreateRoleException(role IRole, e Exception) : KettleException in class org.pentaho.di.repository.pur.UserRoleDelegate | From | To | |
| Rename Parameter newUser : IUser to user : IUser in method private cannotCreateUserException(user IUser, e Exception) : KettleException in class org.pentaho.di.repository.pur.UserRoleDelegate | From | To |