ae1d789fa3aa9ccc1c9fff50c89d9331dfa7b9a7
Files Diff
- Added: 5
- Removed: 0
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private getCSV() : void renamed to public getFieldNames(meta CsvInputMeta) : String[] in class org.pentaho.di.ui.trans.steps.csvinput.CsvInputDialog | From | To | |
| Change Return Type | 1 | ||
| Change Return Type void to String[] in method public getFieldNames(meta CsvInputMeta) : String[] in class org.pentaho.di.ui.trans.steps.csvinput.CsvInputDialog | From | To | |
| Move Attribute | 9 | ||
| Move Attribute protected LABEL_SPACING : int from class org.pentaho.di.ui.trans.step.common.CommonStepDialog to public LABEL_SPACING : int from class org.pentaho.di.ui.core.dialog.BaseDialog | From | To | |
| Move Attribute protected SMALL_FIELD : int from class org.pentaho.di.ui.trans.step.common.CommonStepDialog to public SMALL_FIELD : int from class org.pentaho.di.ui.core.dialog.BaseDialog | From | To | |
| Move Attribute protected SHELL_WIDTH_OFFSET : int from class org.pentaho.di.ui.trans.step.common.CommonStepDialog to public SHELL_WIDTH_OFFSET : int from class org.pentaho.di.ui.core.dialog.BaseDialog | From | To | |
| Move Attribute protected VAR_ICON_HEIGHT : int from class org.pentaho.di.ui.trans.step.common.CommonStepDialog to public VAR_ICON_HEIGHT : int from class org.pentaho.di.ui.core.dialog.BaseDialog | From | To | |
| Move Attribute protected MEDIUM_FIELD : int from class org.pentaho.di.ui.trans.step.common.CommonStepDialog to public MEDIUM_FIELD : int from class org.pentaho.di.ui.core.dialog.BaseDialog | From | To | |
| Move Attribute protected VAR_ICON_WIDTH : int from class org.pentaho.di.ui.trans.step.common.CommonStepDialog to public VAR_ICON_WIDTH : int from class org.pentaho.di.ui.core.dialog.BaseDialog | From | To | |
| Move Attribute protected ELEMENT_SPACING : int from class org.pentaho.di.ui.trans.step.common.CommonStepDialog to public ELEMENT_SPACING : int from class org.pentaho.di.ui.core.dialog.BaseDialog | From | To | |
| Move Attribute protected MARGIN_SIZE : int from class org.pentaho.di.ui.trans.step.common.CommonStepDialog to public MARGIN_SIZE : int from class org.pentaho.di.ui.core.dialog.BaseDialog | From | To | |
| Move Attribute protected MEDIUM_SMALL_FIELD : int from class org.pentaho.di.ui.trans.step.common.CommonStepDialog to public MEDIUM_SMALL_FIELD : int from class org.pentaho.di.ui.core.dialog.BaseDialog | From | To | |
| Extract Class | 1 | ||
| Extract Class org.pentaho.di.ui.core.dialog.BaseDialog from class org.pentaho.di.ui.trans.step.common.CommonStepDialog | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute meta : CsvInputMeta to inputMeta : CsvInputMeta in method private getReader(inputStream InputStream) : InputStreamReader in class org.pentaho.di.ui.trans.steps.csvinput.CsvInputDialog | From | To | |
| Inline Variable | 1 | ||
| Inline Variable margin : int in method public open() : int from class org.pentaho.di.ui.core.dialog.EnterNumberDialog | From | To | |
| Extract Method | 7 | ||
| Extract Method private getInputStream(meta CsvInputMeta) : InputStream extracted from private getCSV() : void in class org.pentaho.di.ui.trans.steps.csvinput.CsvInputDialog | From | To | |
| Extract Method public open(failOnParseError boolean) : String extracted from public open() : String in class org.pentaho.di.ui.trans.steps.textfileinput.TextFileCSVImportProgressDialog | From | To | |
| Extract Method public convertLineToRow(log LogChannelInterface, textFileLine TextFileLine, info InputFileMetaInterface, passThruFields Object[], nrPassThruFields int, outputRowMeta RowMetaInterface, convertRowMeta RowMetaInterface, fname String, rowNr long, delimiter String, enclosure String, escapeCharacter String, errorHandler FileErrorHandler, addShortFilename boolean, addExtension boolean, addPath boolean, addSize boolean, addIsHidden boolean, addLastModificationDate boolean, addUri boolean, addRootUri boolean, shortFilename String, path String, hidden boolean, modificationDateTime Date, uri String, rooturi String, extension String, size long, failOnParseError boolean) : Object[] extracted from public convertLineToRow(log LogChannelInterface, textFileLine TextFileLine, info InputFileMetaInterface, passThruFields Object[], nrPassThruFields int, outputRowMeta RowMetaInterface, convertRowMeta RowMetaInterface, fname String, rowNr long, delimiter String, enclosure String, escapeCharacter String, errorHandler FileErrorHandler, addShortFilename boolean, addExtension boolean, addPath boolean, addSize boolean, addIsHidden boolean, addLastModificationDate boolean, addUri boolean, addRootUri boolean, shortFilename String, path String, hidden boolean, modificationDateTime Date, uri String, rooturi String, extension String, size long) : Object[] in class org.pentaho.di.trans.steps.textfileinput.TextFileInput | From | To | |
| Extract Method private getFieldNamesImpl(reader InputStreamReader, meta CsvInputMeta) : String[] extracted from private getCSV() : void in class org.pentaho.di.ui.trans.steps.csvinput.CsvInputDialog | From | To | |
| Extract Method private doScan(monitor IProgressMonitor, failOnParseError boolean) : String extracted from private doScan(monitor IProgressMonitor) : String in class org.pentaho.di.ui.trans.steps.textfileinput.TextFileCSVImportProgressDialog | From | To | |
| Extract Method public getData(inputMeta CsvInputMeta, copyStepname boolean, reloadAllFields boolean, newFieldNames List<String>) : void extracted from public getData(inputMeta CsvInputMeta, copyStepname boolean) : void in class org.pentaho.di.ui.trans.steps.csvinput.CsvInputDialog | From | To | |
| Extract Method private getReader(inputStream InputStream) : InputStreamReader extracted from private getCSV() : void in class org.pentaho.di.ui.trans.steps.csvinput.CsvInputDialog | From | To |