ecdeba2261a574b0198c875bd5c2c58febb46e36
Files Diff
- Added: 3
- Removed: 0
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 2 | ||
| Pull Up Method private getFieldNamesImpl(reader InputStreamReader, meta CsvInputMeta) : String[] from class org.pentaho.di.ui.trans.steps.csvinput.CsvInputDialog to public getFieldNamesImpl(reader InputStreamReader, meta CsvInputAwareMeta) : String[] from class org.pentaho.di.ui.trans.step.common.CsvInputAwareStepDialog | From | To | |
| Pull Up Method public loadFieldsImpl(meta CsvInputMeta, samples int, reloadAllFields boolean) : String from class org.pentaho.di.ui.trans.steps.csvinput.CsvInputDialog to public loadFieldsImpl(meta CsvInputAwareMeta, samples int) : String from class org.pentaho.di.ui.trans.step.common.CsvInputAwareStepDialog | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type newFieldNames : List<String> to newFieldNames : Set<String> in method public getData(inputMeta CsvInputMeta, copyStepname boolean, reloadAllFields boolean, newFieldNames Set<String>) : void in class org.pentaho.di.ui.trans.steps.csvinput.CsvInputDialog | From | To | |
| Change Parameter Type meta : CsvInputMeta to meta : CsvInputAwareMeta in method public getFieldNamesImpl(reader InputStreamReader, meta CsvInputAwareMeta) : String[] in class org.pentaho.di.ui.trans.step.common.CsvInputAwareStepDialog | From | To | |
| Change Parameter Type meta : CsvInputMeta to meta : CsvInputAwareMeta in method public loadFieldsImpl(meta CsvInputAwareMeta, samples int) : String in class org.pentaho.di.ui.trans.step.common.CsvInputAwareStepDialog | From | To | |
| Rename Variable | 4 | ||
| Rename Variable fieldNames : String[] to incomingFieldNames : String[] in method public repopulateFields(meta StepMetaType, previousFieldValues Map<String,List<String>>, reloadAllFields boolean) : Set<String> in class org.pentaho.di.ui.trans.step.common.GetFieldsCapableStepDialog | From | To | |
| Rename Variable fieldName : String to incomingFieldName : String in method public repopulateFields(meta StepMetaType, previousFieldValues Map<String,List<String>>, reloadAllFields boolean) : Set<String> in class org.pentaho.di.ui.trans.step.common.GetFieldsCapableStepDialog | From | To | |
| Rename Variable userDefinedFields : List<String> to newFieldNames : Set<String> in method public loadFields(meta StepMetaType, samples int, reloadAllFields boolean) : String in class org.pentaho.di.ui.trans.step.common.GetFieldsCapableStepDialog | From | To | |
| Rename Variable userDefinedFields : List<String> to newFieldNames : Set<String> in method public repopulateFields(meta StepMetaType, previousFieldValues Map<String,List<String>>, reloadAllFields boolean) : Set<String> in class org.pentaho.di.ui.trans.step.common.GetFieldsCapableStepDialog | From | To | |
| Change Return Type | 1 | ||
| Change Return Type List<String> to Set<String> in method public repopulateFields(meta StepMetaType, previousFieldValues Map<String,List<String>>, reloadAllFields boolean) : Set<String> in class org.pentaho.di.ui.trans.step.common.GetFieldsCapableStepDialog | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type userDefinedFields : List<String> to newFieldNames : Set<String> in method public repopulateFields(meta StepMetaType, previousFieldValues Map<String,List<String>>, reloadAllFields boolean) : Set<String> in class org.pentaho.di.ui.trans.step.common.GetFieldsCapableStepDialog | From | To | |
| Change Variable Type userDefinedFields : List<String> to newFieldNames : Set<String> in method public loadFields(meta StepMetaType, samples int, reloadAllFields boolean) : String in class org.pentaho.di.ui.trans.step.common.GetFieldsCapableStepDialog | From | To | |
| Extract Interface | 2 | ||
| Extract Interface org.pentaho.di.ui.trans.step.common.CsvInputAwareImportProgressDialog from classes [org.pentaho.di.ui.trans.steps.textfileinput.TextFileCSVImportProgressDialog] | From | To | |
| Extract Interface org.pentaho.di.trans.steps.common.CsvInputAwareMeta from classes [org.pentaho.di.trans.steps.csvinput.CsvInputMeta, org.pentaho.di.trans.steps.fileinput.text.TextFileInputMeta] | From | To | |
| Extract Method | 4 | ||
| Extract Method public convertLineToRow(log LogChannelInterface, textFileLine TextFileLine, info TextFileInputMeta, passThruFields Object[], nrPassThruFields int, outputRowMeta RowMetaInterface, convertRowMeta RowMetaInterface, fname String, rowNr long, delimiter String, enclosure String, escapeCharacter String, errorHandler FileErrorHandler, additionalOutputFields BaseFileInputAdditionalField, shortFilename String, path String, hidden boolean, modificationDateTime Date, uri String, rooturi String, extension String, size Long, failOnParseError boolean) : Object[] extracted from public convertLineToRow(log LogChannelInterface, textFileLine TextFileLine, info TextFileInputMeta, passThruFields Object[], nrPassThruFields int, outputRowMeta RowMetaInterface, convertRowMeta RowMetaInterface, fname String, rowNr long, delimiter String, enclosure String, escapeCharacter String, errorHandler FileErrorHandler, additionalOutputFields BaseFileInputAdditionalField, shortFilename String, path String, hidden boolean, modificationDateTime Date, uri String, rooturi String, extension String, size Long) : Object[] in class org.pentaho.di.trans.steps.fileinput.text.TextFileInputUtils | From | To | |
| Extract Method private doScan(monitor IProgressMonitor, failOnParseError boolean) : String extracted from private doScan(monitor IProgressMonitor) : String in class org.pentaho.di.ui.trans.steps.fileinput.text.TextFileCSVImportProgressDialog | From | To | |
| Extract Method public open(failOnParseError boolean) : String extracted from public open() : String in class org.pentaho.di.ui.trans.steps.fileinput.text.TextFileCSVImportProgressDialog | From | To | |
| Extract Method public getData(meta TextFileInputMeta, copyStepname boolean, reloadAllFields boolean, newFieldNames Set<String>) : void extracted from public getData(meta TextFileInputMeta) : void in class org.pentaho.di.ui.trans.steps.fileinput.text.TextFileInputDialog | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public getFields() : void extracted from public open() : String in class org.pentaho.di.ui.trans.steps.csvinput.CsvInputDialog & moved to class org.pentaho.di.ui.trans.step.common.GetFieldsCapableStepDialog | From | To |