fafca6e9811aa694d7bf71406d8bbfa8f6fdb319
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 26
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 2 | ||
| Pull Up Method public saveSharedObjects() : void from class org.pentaho.di.job.JobMeta to public saveSharedObjects() : void from class org.pentaho.di.base.AbstractMeta | From | To | |
| Pull Up Method public saveSharedObjects() : void from class org.pentaho.di.trans.TransMeta to public saveSharedObjects() : void from class org.pentaho.di.base.AbstractMeta | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type sourceObject : SharedObjectInterface to sourceObject : T in method private synchronizeJobs(sourceObject T, handler SynchronizationHandler<T>, originalName String) : void in class org.pentaho.di.ui.spoon.SharedObjectSyncUtil | From | To | |
| Change Parameter Type object : SharedObjectInterface to object : T in method private synchronizeTransformations(object T, handler SynchronizationHandler<T>, originalName String) : void in class org.pentaho.di.ui.spoon.SharedObjectSyncUtil | From | To | |
| Change Parameter Type handler : SynchronizationHandler to handler : SynchronizationHandler<T> in method private synchronizeTransformations(object T, handler SynchronizationHandler<T>, originalName String) : void in class org.pentaho.di.ui.spoon.SharedObjectSyncUtil | From | To | |
| Change Parameter Type handler : SynchronizationHandler to handler : SynchronizationHandler<T> in method private synchronizeJobs(sourceObject T, handler SynchronizationHandler<T>, originalName String) : void in class org.pentaho.di.ui.spoon.SharedObjectSyncUtil | From | To | |
| Move Method | 1 | ||
| Move Method private delClusterSchema(transMeta TransMeta, clusterSchema ClusterSchema) : void from class org.pentaho.di.ui.spoon.Spoon to public delClusterSchema(transMeta TransMeta, clusterSchema ClusterSchema) : void from class org.pentaho.di.ui.spoon.delegates.SpoonClustersDelegate | From | To | |
| Rename Variable | 2 | ||
| Rename Variable slaveNames : String[] to servers : List<SlaveServer> in method package refreshSlavesSubtree(tiRootName TreeItem, meta AbstractMeta, guiResource GUIResource) : void in class org.pentaho.di.ui.spoon.Spoon | From | To | |
| Rename Variable cluster : SharedObjectInterface to soi : SharedObjectInterface in method protected isDuplicate(objects List<? extends SharedObjectInterface>, object SharedObjectInterface) : boolean in class org.pentaho.di.ui.spoon.delegates.SpoonSharedObjectDelegate | From | To | |
| Inline Method | 1 | ||
| Inline Method private pickupClusterSchemas(transMeta TransMeta) : String[] inlined to public editClustering(transMeta TransMeta, stepMetas List<StepMeta>) : void in class org.pentaho.di.ui.spoon.Spoon | From | To | |
| Change Return Type | 2 | ||
| Change Return Type List<? extends SharedObjectInterface> to List<T> in method public getObjectsForSyncFromTransformation(transformation TransMeta) : List<T> in class org.pentaho.di.ui.spoon.SharedObjectSyncUtil.SynchronizationHandler | From | To | |
| Change Return Type List<? extends SharedObjectInterface> to List<T> in method public getObjectsForSyncFromJob(job JobMeta) : List<T> in class org.pentaho.di.ui.spoon.SharedObjectSyncUtil.SynchronizationHandler | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type objectsForSync : List<? extends SharedObjectInterface> to objectsForSync : List<T> in method private synchronizeTransformations(object T, handler SynchronizationHandler<T>, originalName String) : void in class org.pentaho.di.ui.spoon.SharedObjectSyncUtil | From | To | |
| Change Variable Type slaveNames : String[] to servers : List<SlaveServer> in method package refreshSlavesSubtree(tiRootName TreeItem, meta AbstractMeta, guiResource GUIResource) : void in class org.pentaho.di.ui.spoon.Spoon | From | To | |
| Change Variable Type objectsForSync : List<? extends SharedObjectInterface> to objectsForSync : List<T> in method private synchronizeJobs(sourceObject T, handler SynchronizationHandler<T>, originalName String) : void in class org.pentaho.di.ui.spoon.SharedObjectSyncUtil | From | To | |
| Extract Method | 10 | ||
| Extract Method private showSaveErrorDialog(partitionSchema PartitionSchema, e KettleException) : void extracted from public newPartitioningSchema(transMeta TransMeta) : void in class org.pentaho.di.ui.spoon.delegates.SpoonPartitionsDelegate | From | To | |
| Extract Method public synchronizeClusterSchemas(clusterSchema ClusterSchema, originalName String) : void extracted from public synchronizeClusterSchemas(clusterSchema ClusterSchema) : void in class org.pentaho.di.ui.spoon.SharedObjectSyncUtil | From | To | |
| Extract Method private synchronizeShared(object T, name String, objectsForSync List<T>, handler SynchronizationHandler<T>) : void extracted from private synchronizeTransformations(object SharedObjectInterface, handler SynchronizationHandler) : void in class org.pentaho.di.ui.spoon.SharedObjectSyncUtil | From | To | |
| Extract Method private synchronizeShared(object T, name String, objectsForSync List<T>, handler SynchronizationHandler<T>) : void extracted from private synchronizeJobs(sourceObject SharedObjectInterface, handler SynchronizationHandler) : void in class org.pentaho.di.ui.spoon.SharedObjectSyncUtil | From | To | |
| Extract Method public synchronizeSlaveServers(slaveServer SlaveServer, originalName String) : void extracted from public synchronizeSlaveServers(slaveServer SlaveServer) : void in class org.pentaho.di.ui.spoon.SharedObjectSyncUtil | From | To | |
| Extract Method private showSaveError(clusterSchema ClusterSchema, e KettleException) : void extracted from public newClusteringSchema(transMeta TransMeta) : void in class org.pentaho.di.ui.spoon.delegates.SpoonClustersDelegate | From | To | |
| Extract Method public synchronizeSteps(step StepMeta, originalName String) : void extracted from public synchronizeSteps(step StepMeta) : void in class org.pentaho.di.ui.spoon.SharedObjectSyncUtil | From | To | |
| Extract Method public synchronizePartitionSchemas(partitionSchema PartitionSchema, originalName String) : void extracted from public synchronizePartitionSchemas(partitionSchema PartitionSchema) : void in class org.pentaho.di.ui.spoon.SharedObjectSyncUtil | From | To | |
| Extract Method public synchronizeConnections(database DatabaseMeta, originalName String) : void extracted from public synchronizeConnections(database DatabaseMeta) : void in class org.pentaho.di.ui.spoon.SharedObjectSyncUtil | From | To | |
| Extract Method private showSaveErrorDialog(slaveServer SlaveServer, e KettleException) : void extracted from public newSlaveServer(hasSlaveServersInterface HasSlaveServersInterface) : void in class org.pentaho.di.ui.spoon.delegates.SpoonSlaveDelegate | From | To | |
| Extract And Move Method | 3 | ||
| Extract And Move Method public editPartitionSchema(transMeta TransMeta, partitionSchema PartitionSchema) : void extracted from private editPartitionSchema(transMeta TransMeta, partitionSchema PartitionSchema) : void in class org.pentaho.di.ui.spoon.Spoon & moved to class org.pentaho.di.ui.spoon.delegates.SpoonPartitionsDelegate | From | To | |
| Extract And Move Method public edit(slaveServer SlaveServer, existingServers List<SlaveServer>) : boolean extracted from protected editSlaveServer(slaveServer SlaveServer) : void in class org.pentaho.di.ui.spoon.Spoon & moved to class org.pentaho.di.ui.spoon.delegates.SpoonSlaveDelegate | From | To | |
| Extract And Move Method public delPartitionSchema(transMeta TransMeta, partitionSchema PartitionSchema) : void extracted from private delPartitionSchema(transMeta TransMeta, partitionSchema PartitionSchema) : void in class org.pentaho.di.ui.spoon.Spoon & moved to class org.pentaho.di.ui.spoon.delegates.SpoonPartitionsDelegate | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter dist : String to dest : String in method private copyFile(src String, dest String) : boolean in class org.pentaho.di.shared.SharedObjects | From | To |