0f6595c0c511a3f07c51cf92d1ced665556b7d4c
Files Diff
- Added: 16
- Removed: 4
- Renamed: 0
- Modified: 36
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method public isMetricsEnabled() : boolean renamed to public isGlobalMetricsEnabled() : boolean in class org.apache.phoenix.query.QueryServicesOptions | From | To | |
| Rename Method private logMutationSize(htable HTableInterface, mutations List<Mutation>, connection PhoenixConnection) : void renamed to private calculateMutationSize(mutations List<Mutation>) : long in class org.apache.phoenix.execute.MutationState | From | To | |
| Rename Method private getUncommittedSattementIndexes() : int[] renamed to private getUncommittedStatementIndexes() : int[] in class org.apache.phoenix.execute.MutationState | From | To | |
| Rename Method public getInternalPhoenixMetrics() : Collection<Metric> renamed to public getGlobalPhoenixClientMetrics() : Collection<GlobalMetric> in class org.apache.phoenix.util.PhoenixRuntime | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type statement : PhoenixStatement to childContext : StatementContext in method private deleteRows(childContext StatementContext, targetTableRef TableRef, indexTableRef TableRef, iterator ResultIterator, projector RowProjector, sourceTableRef TableRef) : MutationState in class org.apache.phoenix.compile.DeleteCompiler | From | To | |
| Change Parameter Type statement : PhoenixStatement to childContext : StatementContext in method private upsertSelect(childContext StatementContext, tableRef TableRef, projector RowProjector, iterator ResultIterator, columnIndexes int[], pkSlotIndexes int[]) : MutationState in class org.apache.phoenix.compile.UpsertCompiler | From | To | |
| Change Parameter Type statement : PhoenixStatement to ctx : StatementContext in method public PhoenixResultSet(resultIterator ResultIterator, rowProjector RowProjector, ctx StatementContext) in class org.apache.phoenix.jdbc.PhoenixResultSet | From | To | |
| Rename Variable | 2 | ||
| Rename Variable connection : PhoenixConnection to clonedConnection : PhoenixConnection in method public newIterator(parentContext StatementContext, iterator ResultIterator, scan Scan, tableName String) : PeekingResultIterator in class org.apache.phoenix.compile.MutatingParallelIteratorFactory | From | To | |
| Rename Variable duration : long to mutationCommitTime : long in method public commit() : void in class org.apache.phoenix.execute.MutationState | From | To | |
| Change Return Type | 2 | ||
| Change Return Type Collection<Metric> to Collection<GlobalMetric> in method public getGlobalPhoenixClientMetrics() : Collection<GlobalMetric> in class org.apache.phoenix.util.PhoenixRuntime | From | To | |
| Change Return Type void to long in method private calculateMutationSize(mutations List<Mutation>) : long in class org.apache.phoenix.execute.MutationState | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute context : StatementContext to parentContext : StatementContext in class org.apache.phoenix.execute.UnionPlan | From | To | |
| Rename Attribute METRICS_ENABLED : String to GLOBAL_METRICS_ENABLED : String in class org.apache.phoenix.query.QueryServices | From | To | |
| Extract Variable | 6 | ||
| Extract Variable endToEndTaskTime : long in method protected afterExecute(task Runnable, t Throwable) : void from class org.apache.phoenix.job.JobManager.InstrumentedThreadPoolExecutor | From | To | |
| Extract Variable taskExecutionTime : long in method protected afterExecute(task Runnable, t Throwable) : void from class org.apache.phoenix.job.JobManager.InstrumentedThreadPoolExecutor | From | To | |
| Extract Variable sizeOfSpoolFile : long in method package SpoolingResultIterator(sMetrics SpoolingMetricsHolder, mMetrics MemoryMetricsHolder, scanner ResultIterator, mm MemoryManager, thresholdBytes int, maxSpoolToDisk long, spoolDirectory String) from class org.apache.phoenix.iterate.SpoolingResultIterator | From | To | |
| Extract Variable numMutations : long in method public commit() : void from class org.apache.phoenix.execute.MutationState | From | To | |
| Extract Variable queueWaitTime : long in method protected beforeExecute(worker Thread, task Runnable) : void from class org.apache.phoenix.job.JobManager.InstrumentedThreadPoolExecutor | From | To | |
| Extract Variable numScans : int in method protected submitWork(nestedScans List<List<Scan>>, nestedFutures List<List<Pair<Scan,Future<PeekingResultIterator>>>>, allIterators Queue<PeekingResultIterator>, estFlattenedSize int) : void from class org.apache.phoenix.iterate.ParallelIterators | From | To | |
| Rename Parameter | 8 | ||
| Rename Parameter statement : PhoenixStatement to childContext : StatementContext in method private deleteRows(childContext StatementContext, targetTableRef TableRef, indexTableRef TableRef, iterator ResultIterator, projector RowProjector, sourceTableRef TableRef) : MutationState in class org.apache.phoenix.compile.DeleteCompiler | From | To | |
| Rename Parameter newMutation : MutationState to newMutationState : MutationState in method public join(newMutationState MutationState) : void in class org.apache.phoenix.execute.MutationState | From | To | |
| Rename Parameter context : StatementContext to parentContext : StatementContext in method protected abstract mutate(parentContext StatementContext, iterator ResultIterator, connection PhoenixConnection) : MutationState in class org.apache.phoenix.compile.MutatingParallelIteratorFactory | From | To | |
| Rename Parameter context : StatementContext to parentContext : StatementContext in method public newIterator(parentContext StatementContext, iterator ResultIterator, scan Scan, tableName String) : PeekingResultIterator in class org.apache.phoenix.compile.MutatingParallelIteratorFactory | From | To | |
| Rename Parameter context : StatementContext to parentContext : StatementContext in method protected mutate(parentContext StatementContext, iterator ResultIterator, connection PhoenixConnection) : MutationState in class org.apache.phoenix.compile.UpsertCompiler.UpsertingParallelIteratorFactory | From | To | |
| Rename Parameter statement : PhoenixStatement to childContext : StatementContext in method private upsertSelect(childContext StatementContext, tableRef TableRef, projector RowProjector, iterator ResultIterator, columnIndexes int[], pkSlotIndexes int[]) : MutationState in class org.apache.phoenix.compile.UpsertCompiler | From | To | |
| Rename Parameter statement : PhoenixStatement to ctx : StatementContext in method public PhoenixResultSet(resultIterator ResultIterator, rowProjector RowProjector, ctx StatementContext) in class org.apache.phoenix.jdbc.PhoenixResultSet | From | To | |
| Rename Parameter context : StatementContext to parentContext : StatementContext in method protected mutate(parentContext StatementContext, iterator ResultIterator, connection PhoenixConnection) : MutationState in class org.apache.phoenix.compile.DeleteCompiler.DeletingParallelIteratorFactory | From | To |