1f1ecc97bab1b081a2b18e78ad141385c837ecd3
Files Diff
- Added: 1
- Removed: 2
- Renamed: 0
- Modified: 25
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method private waitForIndexToBeActive(conn Connection, index String) : void renamed to private waitForIndexToBeRebuilt(conn Connection, index String) : void in class org.apache.phoenix.end2end.index.MutableIndexFailureIT | From | To | |
| Rename Method public disableIndexWithTimestamp(indexTableName String, minTimeStamp long, metaTable HTableInterface, blockWriteRebuildIndex boolean) : MetaDataMutationResult renamed to public setIndexDisableTimeStamp(indexTableName String, minTimeStamp long, metaTable HTableInterface, newState PIndexState) : MetaDataMutationResult in class org.apache.phoenix.util.IndexUtil | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type tableName : String to commitShouldFail : boolean in method private updateTable(conn Connection, commitShouldFail boolean) : void in class org.apache.phoenix.end2end.index.MutableIndexFailureIT | From | To | |
| Change Return Type | 2 | ||
| Change Return Type void to long in method private handleFailureWithExceptions(attempted Multimap<HTableInterfaceReference,Mutation>, cause Exception) : long in class org.apache.phoenix.index.PhoenixIndexFailurePolicy | From | To | |
| Change Return Type Collection<Boolean[]> to List<Object[]> in method public data() : List<Object[]> in class org.apache.phoenix.end2end.index.MutableIndexFailureIT | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute tableName : String to fullTableName : String in method private updateTable(conn Connection, commitShouldFail boolean) : void in class org.apache.phoenix.end2end.index.MutableIndexFailureIT | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type statements : List<SQLCloseable> to statements : List<? extends PhoenixStatement> in method private closeStatements() : void in class org.apache.phoenix.jdbc.PhoenixConnection | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type statements : List<SQLCloseable> to statements : List<PhoenixStatement> in class org.apache.phoenix.jdbc.PhoenixConnection | From | To | |
| Extract Method | 2 | ||
| Extract Method private updateTableAgain(conn Connection, commitShouldFail boolean) : void extracted from public helpTestWriteFailureDisablesIndex() : void in class org.apache.phoenix.end2end.index.MutableIndexFailureIT | From | To | |
| Extract Method public getServerProperties() : Map<String,String> extracted from public doSetup() : void in class org.apache.phoenix.end2end.IndexToolForPartialBuildIT | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public getServerProperties() : Map<String,String> extracted from public doSetup() : void in class org.apache.phoenix.end2end.IndexToolForPartialBuildWithNamespaceEnabledIT & moved to class org.apache.phoenix.end2end.IndexToolForPartialBuildIT | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter tableName : String to commitShouldFail : boolean in method private updateTable(conn Connection, commitShouldFail boolean) : void in class org.apache.phoenix.end2end.index.MutableIndexFailureIT | From | To | |
| Rename Parameter tableName : String to fullTableName : String in method private validateDataWithIndex(conn Connection, fullTableName String, fullIndexName String, localIndex boolean) : void in class org.apache.phoenix.end2end.index.MutableIndexFailureIT | From | To | |
| Rename Parameter indexName : String to fullIndexName : String in method private validateDataWithIndex(conn Connection, fullTableName String, fullIndexName String, localIndex boolean) : void in class org.apache.phoenix.end2end.index.MutableIndexFailureIT | From | To |