3f6b25947d07ea0d7756556dd80e951f12ceda69
Files Diff
- Added: 22
- Removed: 0
- Renamed: 0
- Modified: 21
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Push Down Method | 2 | ||
| Push Down Method public create(children List<Expression>, likeType LikeType) : LikeExpression from class org.apache.phoenix.expression.LikeExpression to public create(children List<Expression>, likeType LikeType) : LikeExpression from class org.apache.phoenix.expression.ByteBasedLikeExpression | From | To | |
| Push Down Method public create(children List<Expression>, likeType LikeType) : LikeExpression from class org.apache.phoenix.expression.LikeExpression to public create(children List<Expression>, likeType LikeType) : LikeExpression from class org.apache.phoenix.expression.StringBasedLikeExpression | From | To | |
| Rename Variable | 7 | ||
| Rename Variable result : Boolean to result1 : Boolean in method private testExpression(value String, expression String, sortorder SortOrder) : boolean in class org.apache.phoenix.expression.ILikeExpressionTest | From | To | |
| Rename Variable ptr : ImmutableBytesWritable to tmpPtr : ImmutableBytesWritable in method public evaluate(tuple Tuple, ptr ImmutableBytesWritable) : boolean in class org.apache.phoenix.expression.function.RegexpSplitFunction | From | To | |
| Rename Variable e : LikeExpression to e1 : LikeExpression in method private testExpression(value String, expression String, sortorder SortOrder) : boolean in class org.apache.phoenix.expression.ILikeExpressionTest | From | To | |
| Rename Variable evaluated : boolean to evaluated1 : boolean in method private testExpression(value String, expression String, sortorder SortOrder) : boolean in class org.apache.phoenix.expression.LikeExpressionTest | From | To | |
| Rename Variable evaluated : boolean to evaluated1 : boolean in method private testExpression(value String, expression String, sortorder SortOrder) : boolean in class org.apache.phoenix.expression.ILikeExpressionTest | From | To | |
| Rename Variable e : LikeExpression to e1 : LikeExpression in method private testExpression(value String, expression String, sortorder SortOrder) : boolean in class org.apache.phoenix.expression.LikeExpressionTest | From | To | |
| Rename Variable result : Boolean to result1 : Boolean in method private testExpression(value String, expression String, sortorder SortOrder) : boolean in class org.apache.phoenix.expression.LikeExpressionTest | From | To | |
| Inline Method | 2 | ||
| Inline Method private split(tuple Tuple, ptr ImmutableBytesWritable, sourceStr String) : boolean inlined to public evaluate(tuple Tuple, ptr ImmutableBytesWritable) : boolean in class org.apache.phoenix.expression.function.RegexpSplitFunction | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Pattern to AbstractBasePattern in method protected compilePattern(value String) : AbstractBasePattern in class org.apache.phoenix.expression.LikeExpression | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type splitter : Splitter to splitter : AbstractBaseSplitter in method public evaluate(tuple Tuple, ptr ImmutableBytesWritable) : boolean in class org.apache.phoenix.expression.function.RegexpSplitFunction | From | To | |
| Change Variable Type pattern : Pattern to pattern : AbstractBasePattern in method public evaluate(tuple Tuple, ptr ImmutableBytesWritable) : boolean in class org.apache.phoenix.expression.LikeExpression | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type pattern : Pattern to pattern : AbstractBasePattern in class org.apache.phoenix.expression.function.RegexpSubstrFunction | From | To | |
| Change Attribute Type initializedSplitter : Splitter to initializedSplitter : AbstractBaseSplitter in class org.apache.phoenix.expression.function.RegexpSplitFunction | From | To | |
| Change Attribute Type pattern : Pattern to pattern : AbstractBasePattern in class org.apache.phoenix.expression.LikeExpression | From | To | |
| Change Attribute Type pattern : Pattern to pattern : AbstractBasePattern in class org.apache.phoenix.expression.function.RegexpReplaceFunction | From | To | |
| Extract Method | 5 | ||
| Extract Method private getBytesInCharNoException(b byte, sortOrder SortOrder) : int extracted from public getBytesInChar(b byte, sortOrder SortOrder) : int in class org.apache.phoenix.util.StringUtil | From | To | |
| Extract Method private testExpression(value String, expression String, sortorder SortOrder) : boolean extracted from public testExpression(value String, expression String) : boolean in class org.apache.phoenix.expression.LikeExpressionTest | From | To | |
| Extract Method private testFilterWithRegexSubstr(conn Connection, offset Integer, exceptedSubstr String) : void extracted from public testFilterWithRegexSubstr() : void in class org.apache.phoenix.end2end.RegexpSubstrFunctionIT | From | To | |
| Extract Method private testGroupByScanWithRegexpSubstr(conn Connection, offset Integer, exceptedSubstr String) : void extracted from public testGroupByScanWithRegexpSubstr() : void in class org.apache.phoenix.end2end.RegexpSubstrFunctionIT | From | To | |
| Extract Method private testExpression(value String, expression String, sortorder SortOrder) : boolean extracted from public testExpression(value String, expression String) : boolean in class org.apache.phoenix.expression.ILikeExpressionTest | From | To |