pheonix 59c5932ea1b0cad03f75d64c004f67c7f9b1b235

59c5932ea1b0cad03f75d64c004f67c7f9b1b235

Files Diff

Added: 5
Removed: 3
Renamed: 0
Modified: 30

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	2
Rename Method private getPhysicalTableRowForView(tableMetadata List<Mutation>, parentTenantSchemaTableNames byte[][], physicalSchemaTableNames byte[][]) : Mutation renamed to private getParentAndPhysicalNames(tableMetadata List<Mutation>, parentTenantSchemaTableNames byte[][], physicalSchemaTableNames byte[][]) : void in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Rename Method private clearParentTableFromCache(clientTimeStamp long, schemaName byte[], tableName byte[]) : void renamed to private clearRemoteTableFromCache(clientTimeStamp long, schemaName byte[], tableName byte[]) : void in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Move And Rename Method	17
Move And Rename Method public setLockedAncestorTable(builderForValue PTableProtos.PTable.Builder) : Builder from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.GetTableRequest.Builder to public setParentTable(builderForValue PTableProtos.PTable.Builder) : Builder from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.CreateTableRequest.Builder	From	To
Move And Rename Method public setSkipAddingIndexes(value boolean) : Builder from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.GetTableRequest.Builder to public setParentTable(value PTableProtos.PTable) : Builder from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.CreateTableRequest.Builder	From	To
Move And Rename Method private getLockedAncestorTableFieldBuilder() : SingleFieldBuilder<org.apache.phoenix.coprocessor.generated.PTableProtos.PTable,org.apache.phoenix.coprocessor.generated.PTableProtos.PTable.Builder,org.apache.phoenix.coprocessor.generated.PTableProtos.PTableOrBuilder> from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.GetTableRequest.Builder to private getParentTableFieldBuilder() : SingleFieldBuilder<org.apache.phoenix.coprocessor.generated.PTableProtos.PTable,org.apache.phoenix.coprocessor.generated.PTableProtos.PTable.Builder,org.apache.phoenix.coprocessor.generated.PTableProtos.PTableOrBuilder> from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.CreateTableRequest.Builder	From	To
Move And Rename Method public clearLockedAncestorTable() : Builder from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.GetTableRequest.Builder to public clearParentTable() : Builder from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.CreateTableRequest.Builder	From	To
Move And Rename Method private addIndexesFromParentTable(result MetaDataMutationResult, resolvedTimestamp Long, alwaysAddIndexes boolean) : boolean from class org.apache.phoenix.schema.MetaDataClient to public addIndexesFromParent(connection PhoenixConnection, view PTable, parentTable PTable, inheritedIndexes List<PTable>) : void from class org.apache.phoenix.util.ViewUtil	From	To
Move And Rename Method public clearSkipAddingParentColumns() : Builder from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.GetTableRequest.Builder to public clearViewModifiedUpdateCacheFrequency() : Builder from class org.apache.phoenix.coprocessor.generated.PTableProtos.PTable.Builder	From	To
Move And Rename Method public setLockedAncestorTable(value PTableProtos.PTable) : Builder from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.GetTableRequest.Builder to public setParentTable(value PTableProtos.PTable) : Builder from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.CreateTableRequest.Builder	From	To
Move And Rename Method private addDerivedColumnsFromAncestors(table PTable, timestamp long, clientVersion int, lockedAncestorTable PTable) : PTable from class org.apache.phoenix.coprocessor.MetaDataEndpointImpl to public addDerivedColumnsAndIndexesFromParent(connection PhoenixConnection, table PTable, parentTable PTable) : PTable from class org.apache.phoenix.util.ViewUtil	From	To
Move And Rename Method public clearSkipAddingParentColumns() : Builder from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.DropTableRequest.Builder to public clearViewModifiedUseStatsForParallelization() : Builder from class org.apache.phoenix.coprocessor.generated.PTableProtos.PTable.Builder	From	To
Move And Rename Method public hasSkipAddingParentColumns() : boolean from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.DropTableRequest to public hasParentTable() : boolean from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.CreateTableRequest.Builder	From	To
Move And Rename Method private validateColumnForAddToBaseTable(basePhysicalTable PTable, tableMetadata List<Mutation>, rowKeyMetaData byte[][], childViewsResult TableViewFinderResult, clientTimeStamp long, clientVersion int) : MetaDataMutationResult from class org.apache.phoenix.coprocessor.MetaDataEndpointImpl to public validateWithChildViews(table PTable, childViews List<PTable>, tableMetadata List<Mutation>, schemaName byte[], tableName byte[]) : MetaDataMutationResult from class org.apache.phoenix.coprocessor.AddColumnMutator	From	To
Move And Rename Method public getLockedAncestorTableBuilder() : PTableProtos.PTable.Builder from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.GetTableRequest.Builder to public getParentTableBuilder() : PTableProtos.PTable.Builder from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.CreateTableRequest.Builder	From	To
Move And Rename Method public mergeLockedAncestorTable(value PTableProtos.PTable) : Builder from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.GetTableRequest.Builder to public mergeParentTable(value PTableProtos.PTable) : Builder from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.CreateTableRequest.Builder	From	To
Move And Rename Method private dropViewIndexes(region Region, basePhysicalTable PTable, locks List<RowLock>, tableMetadata List<Mutation>, mutationsForAddingColumnsToViews List<Mutation>, schemaName byte[], tableName byte[], invalidateList List<ImmutableBytesPtr>, clientTimeStamp long, childViewsResult TableViewFinderResult, tableNamesToDelete List<byte[]>, sharedTablesToDelete List<SharedTableState>, clientVersion int) : MetaDataMutationResult from class org.apache.phoenix.coprocessor.MetaDataEndpointImpl to public validateWithChildViews(table PTable, childViews List<PTable>, tableMetadata List<Mutation>, schemaName byte[], tableName byte[]) : MetaDataMutationResult from class org.apache.phoenix.coprocessor.DropColumnMutator	From	To
Move And Rename Method public setSkipAddingParentColumns(value boolean) : Builder from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.GetTableRequest.Builder to public setParentTable(value PTableProtos.PTable) : Builder from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.CreateTableRequest.Builder	From	To
Move And Rename Method public setSkipAddingParentColumns(value boolean) : Builder from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.DropTableRequest.Builder to public setParentTable(value PTableProtos.PTable) : Builder from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.CreateTableRequest.Builder	From	To
Move And Rename Method public clearSkipAddingIndexes() : Builder from class org.apache.phoenix.coprocessor.generated.MetaDataProtos.GetTableRequest.Builder to public clearViewModifiedUseStatsForParallelization() : Builder from class org.apache.phoenix.coprocessor.generated.PTableProtos.PTable.Builder	From	To
Change Parameter Type	3
Change Parameter Type value : boolean to value : PTableProtos.PTable in method public setParentTable(value PTableProtos.PTable) : Builder in class org.apache.phoenix.coprocessor.generated.MetaDataProtos.CreateTableRequest.Builder	From	To
Move Method	6
Move Method private getInteger(p Put, family byte[], qualifier byte[]) : int from class org.apache.phoenix.coprocessor.MetaDataEndpointImpl to private getInteger(p Put, family byte[], qualifier byte[]) : int from class org.apache.phoenix.coprocessor.AddColumnMutator	From	To
Move Method private switchAttribute(table PTable, currAttribute boolean, tableMetaData List<Mutation>, attrQualifier byte[]) : boolean from class org.apache.phoenix.coprocessor.MetaDataEndpointImpl to private switchAttribute(currAttribute boolean, tableMetaData List<Mutation>, attrQualifier byte[]) : boolean from class org.apache.phoenix.coprocessor.AddColumnMutator	From	To
Move Method private getColumn(pkCount int, rowKeyMetaData byte[][], table PTable) : PColumn from class org.apache.phoenix.coprocessor.MetaDataEndpointImpl to public getColumn(pkCount int, rowKeyMetaData byte[][], table PTable) : PColumn from class org.apache.phoenix.util.MetaDataUtil	From	To
Move Method private addTagsToPutsForViewAlteredProperties(tableMetaData List<Mutation>, parent PTable) : void from class org.apache.phoenix.coprocessor.MetaDataEndpointImpl to public addTagsToPutsForViewAlteredProperties(tableMetaData List<Mutation>, parent PTable, extendedCellBuilder ExtendedCellBuilder) : void from class org.apache.phoenix.util.ViewUtil	From	To
Move Method public dropChildViews(env RegionCoprocessorEnvironment, tenantIdBytes byte[], schemaName byte[], tableName byte[]) : void from class org.apache.phoenix.coprocessor.MetaDataEndpointImpl to public dropChildViews(env RegionCoprocessorEnvironment, tenantIdBytes byte[], schemaName byte[], tableName byte[]) : void from class org.apache.phoenix.util.ViewUtil	From	To
Move Method private isDivergedView(view PTable) : boolean from class org.apache.phoenix.coprocessor.MetaDataEndpointImpl to public isDivergedView(view PTable) : boolean from class org.apache.phoenix.util.ViewUtil	From	To
Change Return Type	2
Change Return Type boolean to void in method public addIndexesFromParent(connection PhoenixConnection, view PTable, parentTable PTable, inheritedIndexes List<PTable>) : void in class org.apache.phoenix.util.ViewUtil	From	To
Change Return Type Mutation to void in method private getParentAndPhysicalNames(tableMetadata List<Mutation>, parentTenantSchemaTableNames byte[][], physicalSchemaTableNames byte[][]) : void in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Extract Class	1
Extract Class org.apache.phoenix.util.ViewUtil from class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Move And Rename Class	1
Move And Rename Class org.apache.phoenix.coprocessor.MetaDataEndpointImpl.MutatateColumnType moved and renamed to org.apache.phoenix.coprocessor.ColumnMutator.MutateColumnType	From	To
Move Class	1
Move Class org.apache.phoenix.coprocessor.TableViewFinderResult moved to org.apache.phoenix.util.TableViewFinderResult	From	To
Rename Attribute	1
Rename Attribute allowSystemCatalogRollback : boolean to allowSplittableSystemCatalogRollback : boolean in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Extract Method	2
Extract Method private addTableToCache(result MetaDataMutationResult, timestamp long) : PTable extracted from private addTableToCache(result MetaDataMutationResult) : PTable in class org.apache.phoenix.schema.MetaDataClient	From	To
Extract Method private deleteMutexCells(physicalSchemaName String, physicalTableName String, acquiredColumnMutexSet Set<String>) : void extracted from public addColumn(table PTable, origColumnDefs List<ColumnDef>, stmtProperties ListMultimap<String,Pair<String,Object>>, ifNotExists boolean, removeTableProps boolean, namedTableNode NamedTableNode, tableType PTableType) : MutationState in class org.apache.phoenix.schema.MetaDataClient	From	To
Rename Parameter	3
Rename Parameter basePhysicalTable : PTable to table : PTable in method public validateWithChildViews(table PTable, childViews List<PTable>, tableMetadata List<Mutation>, schemaName byte[], tableName byte[]) : MetaDataMutationResult in class org.apache.phoenix.coprocessor.DropColumnMutator	From	To
Rename Parameter basePhysicalTable : PTable to table : PTable in method public validateWithChildViews(table PTable, childViews List<PTable>, tableMetadata List<Mutation>, schemaName byte[], tableName byte[]) : MetaDataMutationResult in class org.apache.phoenix.coprocessor.AddColumnMutator	From	To
Rename Parameter additionalTableMetaData : List<Mutation> to tableMetaData : List<Mutation> in method private dropIndexes(env RegionCoprocessorEnvironment, table PTable, invalidateList List<ImmutableBytesPtr>, locks List<RowLock>, clientTimeStamp long, tableMetaData List<Mutation>, columnToDelete PColumn, tableNamesToDelete List<byte[]>, sharedTablesToDelete List<SharedTableState>, clientVersion int) : MetaDataMutationResult in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To

59c5932ea1b0cad03f75d64c004f67c7f9b1b235

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: