pheonix 5b46793b6951cf1ca04850a5ad771f2cd9f5802a

5b46793b6951cf1ca04850a5ad771f2cd9f5802a

Files Diff

Added: 1
Removed: 0
Renamed: 0
Modified: 2

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move Method	20
Move Method public testAlteringViewThatHasChildViews() : void from class org.apache.phoenix.end2end.AlterTableIT to public testAlteringViewThatHasChildViews() : void from class org.apache.phoenix.end2end.AlterTableWithViewsIT	From	To
Move Method public testAddExistingViewPkColumnToBaseTableWithMultipleViews() : void from class org.apache.phoenix.end2end.AlterTableIT to public testAddExistingViewPkColumnToBaseTableWithMultipleViews() : void from class org.apache.phoenix.end2end.AlterTableWithViewsIT	From	To
Move Method public testAddExistingViewColumnToBaseTableWithViews() : void from class org.apache.phoenix.end2end.AlterTableIT to public testAddExistingViewColumnToBaseTableWithViews() : void from class org.apache.phoenix.end2end.AlterTableWithViewsIT	From	To
Move Method public testAddExistingViewPkColumnToBaseTableWithMultipleViewsHavingSamePks() : void from class org.apache.phoenix.end2end.AlterTableIT to public testAddExistingViewPkColumnToBaseTableWithMultipleViewsHavingSamePks() : void from class org.apache.phoenix.end2end.AlterTableWithViewsIT	From	To
Move Method private verifyNewColumns(rs ResultSet, values String...) : void from class org.apache.phoenix.end2end.AlterTableIT to private verifyNewColumns(rs ResultSet, values String...) : void from class org.apache.phoenix.end2end.AlterTableWithViewsIT	From	To
Move Method private getTenantConnection(tenantId String) : Connection from class org.apache.phoenix.end2end.AlterTableIT to private getTenantConnection(tenantId String) : Connection from class org.apache.phoenix.end2end.AlterTableWithViewsIT	From	To
Move Method private assertTableDefinition(conn Connection, tableName String, tableType PTableType, parentTableName String, sequenceNumber int, columnCount int, baseColumnCount int, columnName String...) : void from class org.apache.phoenix.end2end.AlterTableIT to private assertTableDefinition(conn Connection, tableName String, tableType PTableType, parentTableName String, sequenceNumber int, columnCount int, baseColumnCount int, columnName String...) : void from class org.apache.phoenix.end2end.AlterTableWithViewsIT	From	To
Move Method public testDropColumnOnTableWithViewsNotAllowed() : void from class org.apache.phoenix.end2end.AlterTableIT to public testDropColumnOnTableWithViewsNotAllowed() : void from class org.apache.phoenix.end2end.AlterTableWithViewsIT	From	To
Move Method public testAddExistingViewPkColumnToBaseTableWithViews() : void from class org.apache.phoenix.end2end.AlterTableIT to public testAddExistingViewPkColumnToBaseTableWithViews() : void from class org.apache.phoenix.end2end.AlterTableWithViewsIT	From	To
Move Method public testAddingColumnToBaseTablePropagatesToEntireViewHierarchy() : void from class org.apache.phoenix.end2end.AlterTableIT to public testAddingColumnToBaseTablePropagatesToEntireViewHierarchy() : void from class org.apache.phoenix.end2end.AlterTableWithViewsIT	From	To
Move Method private getIndexOfPkColumn(conn PhoenixConnection, columnName String, tableName String) : int from class org.apache.phoenix.end2end.AlterTableIT to private getIndexOfPkColumn(conn PhoenixConnection, columnName String, tableName String) : int from class org.apache.phoenix.end2end.AlterTableWithViewsIT	From	To
Move Method public testAddPKColumnToBaseTableWhoseViewsHaveIndices() : void from class org.apache.phoenix.end2end.AlterTableIT to public testAddPKColumnToBaseTableWhoseViewsHaveIndices() : void from class org.apache.phoenix.end2end.AlterTableWithViewsIT	From	To
Move Method public testDivergedViewsStayDiverged() : void from class org.apache.phoenix.end2end.AlterTableIT to public testDivergedViewsStayDiverged() : void from class org.apache.phoenix.end2end.AlterTableWithViewsIT	From	To
Move Method private getSystemCatalogEntriesForTable(conn Connection, tableName String, message String) : String from class org.apache.phoenix.end2end.AlterTableIT to private getSystemCatalogEntriesForTable(conn Connection, tableName String, message String) : String from class org.apache.phoenix.end2end.AlterTableWithViewsIT	From	To
Move Method public testChangingPKOfBaseTableChangesPKForAllViews() : void from class org.apache.phoenix.end2end.AlterTableIT to public testChangingPKOfBaseTableChangesPKForAllViews() : void from class org.apache.phoenix.end2end.AlterTableWithViewsIT	From	To
Move Method private getTableSequenceNumber(conn PhoenixConnection, tableName String) : long from class org.apache.phoenix.end2end.AlterTableIT to private getTableSequenceNumber(conn PhoenixConnection, tableName String) : long from class org.apache.phoenix.end2end.AlterTableWithViewsIT	From	To
Move Method private getMaxKeySequenceNumber(conn PhoenixConnection, tableName String) : short from class org.apache.phoenix.end2end.AlterTableIT to private getMaxKeySequenceNumber(conn PhoenixConnection, tableName String) : short from class org.apache.phoenix.end2end.AlterTableWithViewsIT	From	To
Move Method public testCacheInvalidatedAfterAddingColumnToBaseTableWithViews() : void from class org.apache.phoenix.end2end.AlterTableIT to public testCacheInvalidatedAfterAddingColumnToBaseTableWithViews() : void from class org.apache.phoenix.end2end.AlterTableWithViewsIT	From	To
Move Method public testAddNewColumnsToBaseTableWithViews() : void from class org.apache.phoenix.end2end.AlterTableIT to public testAddNewColumnsToBaseTableWithViews() : void from class org.apache.phoenix.end2end.AlterTableWithViewsIT	From	To
Move Method private checkColumnPartOfPk(conn PhoenixConnection, columnName String, tableName String) : boolean from class org.apache.phoenix.end2end.AlterTableIT to private checkColumnPartOfPk(conn PhoenixConnection, columnName String, tableName String) : boolean from class org.apache.phoenix.end2end.AlterTableWithViewsIT	From	To
Rename Variable	8
Rename Variable column : PColumn to col : PColumn in method package addRowsToChildViews(basePhysicalTable PTable, tableMetadata List<Mutation>, mutationsForAddingColumnsToViews List<Mutation>, schemaName byte[], tableName byte[], invalidateList List<ImmutableBytesPtr>, clientTimeStamp long, childViewsResult TableViewFinderResult, region Region, locks List<RowLock>) : MetaDataMutationResult in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Rename Variable dataColumnDataType : int to viewPkColumnDataType : int in method private addMutationsForAddingPkColsToViewIndexes(mutationsForAddingColumnsToViews List<Mutation>, clientTimeStamp long, view PTable, deltaNumPkColsSoFar short, viewPkColumnName String, viewColumnDefinitionPut Put) : void in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Rename Variable viewName : byte[] to newOrdinalPosition : int in method package addRowsToChildViews(basePhysicalTable PTable, tableMetadata List<Mutation>, mutationsForAddingColumnsToViews List<Mutation>, schemaName byte[], tableName byte[], invalidateList List<ImmutableBytesPtr>, clientTimeStamp long, childViewsResult TableViewFinderResult, region Region, locks List<RowLock>) : MetaDataMutationResult in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Rename Variable numColsAddedToBaseTable : int to columnsAddedToBaseTable : short in method package addRowsToChildViews(basePhysicalTable PTable, tableMetadata List<Mutation>, mutationsForAddingColumnsToViews List<Mutation>, schemaName byte[], tableName byte[], invalidateList List<ImmutableBytesPtr>, clientTimeStamp long, childViewsResult TableViewFinderResult, region Region, locks List<RowLock>) : MetaDataMutationResult in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Rename Variable addingPKColumn : boolean to addingExistingPkCol : boolean in method package addRowsToChildViews(basePhysicalTable PTable, tableMetadata List<Mutation>, mutationsForAddingColumnsToViews List<Mutation>, schemaName byte[], tableName byte[], invalidateList List<ImmutableBytesPtr>, clientTimeStamp long, childViewsResult TableViewFinderResult, region Region, locks List<RowLock>) : MetaDataMutationResult in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Rename Variable viewTenantId : byte[] to newOrdinalPosition : int in method package addRowsToChildViews(basePhysicalTable PTable, tableMetadata List<Mutation>, mutationsForAddingColumnsToViews List<Mutation>, schemaName byte[], tableName byte[], invalidateList List<ImmutableBytesPtr>, clientTimeStamp long, childViewsResult TableViewFinderResult, region Region, locks List<RowLock>) : MetaDataMutationResult in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Rename Variable viewPkColumns : List<PColumn> to viewPkCols : List<PColumn> in method package addRowsToChildViews(basePhysicalTable PTable, tableMetadata List<Mutation>, mutationsForAddingColumnsToViews List<Mutation>, schemaName byte[], tableName byte[], invalidateList List<ImmutableBytesPtr>, clientTimeStamp long, childViewsResult TableViewFinderResult, region Region, locks List<RowLock>) : MetaDataMutationResult in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Rename Variable columnSizes : List<Cell> to cells : List<Cell> in method private getInteger(p Put, family byte[], qualifier byte[]) : int in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Extract Class	1
Extract Class org.apache.phoenix.end2end.AlterTableWithViewsIT from class org.apache.phoenix.end2end.AlterTableIT	From	To
Change Variable Type	3
Change Variable Type numColsAddedToBaseTable : int to columnsAddedToBaseTable : short in method package addRowsToChildViews(basePhysicalTable PTable, tableMetadata List<Mutation>, mutationsForAddingColumnsToViews List<Mutation>, schemaName byte[], tableName byte[], invalidateList List<ImmutableBytesPtr>, clientTimeStamp long, childViewsResult TableViewFinderResult, region Region, locks List<RowLock>) : MetaDataMutationResult in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Change Variable Type viewTenantId : byte[] to newOrdinalPosition : int in method package addRowsToChildViews(basePhysicalTable PTable, tableMetadata List<Mutation>, mutationsForAddingColumnsToViews List<Mutation>, schemaName byte[], tableName byte[], invalidateList List<ImmutableBytesPtr>, clientTimeStamp long, childViewsResult TableViewFinderResult, region Region, locks List<RowLock>) : MetaDataMutationResult in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Change Variable Type viewName : byte[] to newOrdinalPosition : int in method package addRowsToChildViews(basePhysicalTable PTable, tableMetadata List<Mutation>, mutationsForAddingColumnsToViews List<Mutation>, schemaName byte[], tableName byte[], invalidateList List<ImmutableBytesPtr>, clientTimeStamp long, childViewsResult TableViewFinderResult, region Region, locks List<RowLock>) : MetaDataMutationResult in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Extract Variable	1
Extract Variable existingMaxLength : int in method private validateColumnForAddToBaseTable(existingViewColumn PColumn, columnToBeAdded Put, basePhysicalTable PTable, isColumnToBeAddPkCol boolean, view PTable) : MetaDataMutationResult from class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Inline Variable	3
Inline Variable viewSchemaName : byte[] in method private addRowsToChildViews(table PTable, tableMetadata List<Mutation>, mutationsForAddingColumnsToViews List<Mutation>, schemaName byte[], tableName byte[], invalidateList List<ImmutableBytesPtr>, clientTimeStamp long, childViewsResult TableViewFinderResult, region Region, locks List<RowLock>) : MetaDataMutationResult from class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Inline Variable viewTenantId : byte[] in method private addRowsToChildViews(table PTable, tableMetadata List<Mutation>, mutationsForAddingColumnsToViews List<Mutation>, schemaName byte[], tableName byte[], invalidateList List<ImmutableBytesPtr>, clientTimeStamp long, childViewsResult TableViewFinderResult, region Region, locks List<RowLock>) : MetaDataMutationResult from class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Inline Variable viewName : byte[] in method private addRowsToChildViews(table PTable, tableMetadata List<Mutation>, mutationsForAddingColumnsToViews List<Mutation>, schemaName byte[], tableName byte[], invalidateList List<ImmutableBytesPtr>, clientTimeStamp long, childViewsResult TableViewFinderResult, region Region, locks List<RowLock>) : MetaDataMutationResult from class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Extract Method	6
Extract Method private isDivergedView(view PTable) : boolean extracted from private addRowsToChildViews(table PTable, tableMetadata List<Mutation>, mutationsForAddingColumnsToViews List<Mutation>, schemaName byte[], tableName byte[], invalidateList List<ImmutableBytesPtr>, clientTimeStamp long, childViewsResult TableViewFinderResult, region Region, locks List<RowLock>) : MetaDataMutationResult in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Extract Method private getInteger(p Put, family byte[], qualifier byte[]) : int extracted from private addRowsToChildViews(table PTable, tableMetadata List<Mutation>, mutationsForAddingColumnsToViews List<Mutation>, schemaName byte[], tableName byte[], invalidateList List<ImmutableBytesPtr>, clientTimeStamp long, childViewsResult TableViewFinderResult, region Region, locks List<RowLock>) : MetaDataMutationResult in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Extract Method private addMutationsForAddingPkColsToViewIndexes(mutationsForAddingColumnsToViews List<Mutation>, clientTimeStamp long, view PTable, deltaNumPkColsSoFar short, viewPkColumnName String, viewColumnDefinitionPut Put) : void extracted from private addRowsToChildViews(table PTable, tableMetadata List<Mutation>, mutationsForAddingColumnsToViews List<Mutation>, schemaName byte[], tableName byte[], invalidateList List<ImmutableBytesPtr>, clientTimeStamp long, childViewsResult TableViewFinderResult, region Region, locks List<RowLock>) : MetaDataMutationResult in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Extract Method private getColumnKey(viewKey byte[], columnName String, columnFamily String) : byte[] extracted from private addRowsToChildViews(table PTable, tableMetadata List<Mutation>, mutationsForAddingColumnsToViews List<Mutation>, schemaName byte[], tableName byte[], invalidateList List<ImmutableBytesPtr>, clientTimeStamp long, childViewsResult TableViewFinderResult, region Region, locks List<RowLock>) : MetaDataMutationResult in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Extract Method private addViewIndexesHeaderRowMutations(mutationsForAddingColumnsToViews List<Mutation>, invalidateList List<ImmutableBytesPtr>, clientTimeStamp long, view PTable, deltaNumPkColsSoFar short) : void extracted from private addRowsToChildViews(table PTable, tableMetadata List<Mutation>, mutationsForAddingColumnsToViews List<Mutation>, schemaName byte[], tableName byte[], invalidateList List<ImmutableBytesPtr>, clientTimeStamp long, childViewsResult TableViewFinderResult, region Region, locks List<RowLock>) : MetaDataMutationResult in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Extract Method private validateColumnForAddToBaseTable(existingViewColumn PColumn, columnToBeAdded Put, basePhysicalTable PTable, isColumnToBeAddPkCol boolean, view PTable) : MetaDataMutationResult extracted from private addRowsToChildViews(table PTable, tableMetadata List<Mutation>, mutationsForAddingColumnsToViews List<Mutation>, schemaName byte[], tableName byte[], invalidateList List<ImmutableBytesPtr>, clientTimeStamp long, childViewsResult TableViewFinderResult, region Region, locks List<RowLock>) : MetaDataMutationResult in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To
Rename Parameter	1
Rename Parameter table : PTable to basePhysicalTable : PTable in method package addRowsToChildViews(basePhysicalTable PTable, tableMetadata List<Mutation>, mutationsForAddingColumnsToViews List<Mutation>, schemaName byte[], tableName byte[], invalidateList List<ImmutableBytesPtr>, clientTimeStamp long, childViewsResult TableViewFinderResult, region Region, locks List<RowLock>) : MetaDataMutationResult in class org.apache.phoenix.coprocessor.MetaDataEndpointImpl	From	To

5b46793b6951cf1ca04850a5ad771f2cd9f5802a

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: