6a27cecce312002f9b7f76ffdcafcb694f5e3ea8
Files Diff
- Added: 5
- Removed: 1
- Renamed: 0
- Modified: 15
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 8 | ||
| Move And Rename Method public setStopRow(value ByteString) : Builder from class org.apache.phoenix.coprocessor.generated.StatCollectorProtos.StatCollectRequest.Builder to public setMaxLength(value int) : Builder from class org.apache.phoenix.coprocessor.generated.PGuidePostsProtos.PGuidePosts.Builder | From | To | |
| Move And Rename Method public setStartRow(value ByteString) : Builder from class org.apache.phoenix.coprocessor.generated.StatCollectorProtos.StatCollectRequest.Builder to public setMaxLength(value int) : Builder from class org.apache.phoenix.coprocessor.generated.PGuidePostsProtos.PGuidePosts.Builder | From | To | |
| Move And Rename Method public addGuidePost(row byte[]) : boolean from class org.apache.phoenix.schema.stats.GuidePostsInfo to public addGuidePosts(row byte[]) : boolean from class org.apache.phoenix.schema.stats.GuidePostsInfoBuilder | From | To | |
| Move And Rename Method public setRowsScanned(value long) : Builder from class org.apache.phoenix.coprocessor.generated.StatCollectorProtos.StatCollectResponse.Builder to public setMaxLength(value int) : Builder from class org.apache.phoenix.coprocessor.generated.PGuidePostsProtos.PGuidePosts.Builder | From | To | |
| Move And Rename Method public addGuidePost(row byte[], byteCount long) : boolean from class org.apache.phoenix.schema.stats.GuidePostsInfo to public addGuidePosts(row byte[], byteCount long) : boolean from class org.apache.phoenix.schema.stats.GuidePostsInfoBuilder | From | To | |
| Move And Rename Method public clearRowsScanned() : Builder from class org.apache.phoenix.coprocessor.generated.StatCollectorProtos.StatCollectResponse.Builder to public clearMaxLength() : Builder from class org.apache.phoenix.coprocessor.generated.PGuidePostsProtos.PGuidePosts.Builder | From | To | |
| Move And Rename Method public clearStartRow() : Builder from class org.apache.phoenix.coprocessor.generated.StatCollectorProtos.StatCollectRequest.Builder to public clearMaxLength() : Builder from class org.apache.phoenix.coprocessor.generated.PGuidePostsProtos.PGuidePosts.Builder | From | To | |
| Move And Rename Method public clearStopRow() : Builder from class org.apache.phoenix.coprocessor.generated.StatCollectorProtos.StatCollectRequest.Builder to public clearMaxLength() : Builder from class org.apache.phoenix.coprocessor.generated.PGuidePostsProtos.PGuidePosts.Builder | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type value : ByteString to value : int in method public setMaxLength(value int) : Builder in class org.apache.phoenix.coprocessor.generated.PGuidePostsProtos.PGuidePosts.Builder | From | To | |
| Change Parameter Type guidePosts : List<byte[]> to guidePosts : ImmutableBytesWritable in method public GuidePostsInfo(byteCount long, guidePosts ImmutableBytesWritable, rowCount long, maxLength int, guidePostsCount int) in class org.apache.phoenix.schema.stats.GuidePostsInfo | From | To | |
| Change Parameter Type value : long to value : int in method public setMaxLength(value int) : Builder in class org.apache.phoenix.coprocessor.generated.PGuidePostsProtos.PGuidePosts.Builder | From | To | |
| Move Method | 2 | ||
| Move Method private getJdbcUrl() : String from class org.apache.phoenix.coprocessor.MetaDataRegionObserver.BuildIndexScheduleTask to private getJdbcUrl(env RegionCoprocessorEnvironment) : String from class org.apache.phoenix.coprocessor.MetaDataRegionObserver | From | To | |
| Move Method public incrementRowCount() : void from class org.apache.phoenix.schema.stats.GuidePostsInfo to public incrementRowCount() : void from class org.apache.phoenix.schema.stats.GuidePostsInfoBuilder | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.phoenix.schema.stats.GuidePostsInfoBuilder from class org.apache.phoenix.schema.stats.GuidePostsInfo | From | To | |
| Split Variable | 1 | ||
| Split Variable guidePosts : GuidePostsInfo to [guidePostsInfoWriter : GuidePostsInfoBuilder, s : Scan] in method public readStatistics(statsHTable HTableInterface, tableNameBytes byte[], clientTimeStamp long) : PTableStats in class org.apache.phoenix.schema.stats.StatisticsUtil | From | To | |
| Change Variable Type | 8 | ||
| Change Variable Type pair : Pair<Long,GuidePostsInfo> to pair : Pair<Long,GuidePostsInfoBuilder> in method public getGuidePosts(fam ImmutableBytesPtr) : GuidePostsInfo in class org.apache.phoenix.schema.stats.StatisticsCollector | From | To | |
| Change Variable Type value : List<byte[]> to guidePostsCount : int in method public createFromProto(table PTableProtos.PTable) : PTable in class org.apache.phoenix.schema.PTableImpl | From | To | |
| Change Variable Type gps : List<byte[]> to gps : GuidePostsInfo in method private getParallelScans(startKey byte[], stopKey byte[]) : List<List<Scan>> in class org.apache.phoenix.iterate.BaseResultIterators | From | To | |
| Change Variable Type rowTracker : List<GuidePostsInfo> to rowTracker : List<GuidePostsInfoBuilder> in method public collectStatistics(results List<Cell>) : void in class org.apache.phoenix.schema.stats.StatisticsCollector | From | To | |
| Change Variable Type gps : Pair<Long,GuidePostsInfo> to gps : Pair<Long,GuidePostsInfoBuilder> in method public collectStatistics(results List<Cell>) : void in class org.apache.phoenix.schema.stats.StatisticsCollector | From | To | |
| Change Variable Type s : GuidePostsInfo to s : GuidePostsInfoBuilder in method public collectStatistics(results List<Cell>) : void in class org.apache.phoenix.schema.stats.StatisticsCollector | From | To | |
| Change Variable Type keys : List<byte[]> to keys : ImmutableBytesWritable in method public toString() : String in class org.apache.phoenix.schema.stats.PTableStatsImpl | From | To | |
| Change Variable Type gps : List<byte[]> to gps : GuidePostsInfo in method private getGuidePosts(whereConditions Set<byte[]>) : GuidePostsInfo in class org.apache.phoenix.iterate.BaseResultIterators | From | To | |
| Extract Method | 2 | ||
| Extract Method private getGuidePostsPerCf(guidePostsWriterPerCf TreeMap<byte[],GuidePostsInfoBuilder>) : SortedMap<byte[],GuidePostsInfo> extracted from public readStatistics(statsHTable HTableInterface, tableNameBytes byte[], clientTimeStamp long) : PTableStats in class org.apache.phoenix.schema.stats.StatisticsUtil | From | To | |
| Extract Method public getRowKey(table byte[], fam ImmutableBytesPtr, guidePostStartKey ImmutableBytesWritable) : byte[] extracted from public getRowKey(table byte[], fam ImmutableBytesPtr, guidePostStartKey byte[]) : byte[] in class org.apache.phoenix.schema.stats.StatisticsUtil | From | To | |
| Inline Variable | 1 | ||
| Inline Variable currentKey : byte[] in method private getParallelScans(startKey byte[], stopKey byte[]) : List<List<Scan>> from class org.apache.phoenix.iterate.BaseResultIterators | From | To | |
| Rename Variable | 2 | ||
| Rename Variable value : List<byte[]> to guidePostsCount : int in method public createFromProto(table PTableProtos.PTable) : PTable in class org.apache.phoenix.schema.PTableImpl | From | To | |
| Rename Variable currentGuidePost : byte[] to currentGuidePostBytes : byte[] in method private getParallelScans(startKey byte[], stopKey byte[]) : List<List<Scan>> in class org.apache.phoenix.iterate.BaseResultIterators | From | To | |
| Change Return Type | 3 | ||
| Change Return Type List<byte[]> to GuidePostsInfo in method private getDefaultFamilyGuidePosts(guidePostMap Map<byte[],GuidePostsInfo>, defaultCF byte[]) : GuidePostsInfo in class org.apache.phoenix.iterate.BaseResultIterators | From | To | |
| Change Return Type List<byte[]> to GuidePostsInfo in method private getGuidePosts(whereConditions Set<byte[]>) : GuidePostsInfo in class org.apache.phoenix.iterate.BaseResultIterators | From | To | |
| Change Return Type List<byte[]> to ImmutableBytesWritable in method public getGuidePosts() : ImmutableBytesWritable in class org.apache.phoenix.schema.stats.GuidePostsInfo | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable size : int to guidePostsCount : int in method public GuidePostsInfo(byteCount long, guidePosts ImmutableBytesWritable, rowCount long, maxLength int, guidePostsCount int) in class org.apache.phoenix.schema.stats.GuidePostsInfo | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute keyByteSize : long to guidePostsCount : int in class org.apache.phoenix.schema.stats.GuidePostsInfo | From | To | |
| Rename Attribute guidePostsMap : Map<ImmutableBytesPtr,Pair<Long,GuidePostsInfo>> to guidePostsInfoWriterMap : Map<ImmutableBytesPtr,Pair<Long,GuidePostsInfoBuilder>> in class org.apache.phoenix.schema.stats.StatisticsCollector | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type guidePostsMap : Map<ImmutableBytesPtr,Pair<Long,GuidePostsInfo>> to guidePostsInfoWriterMap : Map<ImmutableBytesPtr,Pair<Long,GuidePostsInfoBuilder>> in class org.apache.phoenix.schema.stats.StatisticsCollector | From | To | |
| Change Attribute Type cachedGps : Pair<Long,GuidePostsInfo> to cachedGps : Pair<Long,GuidePostsInfoBuilder> in class org.apache.phoenix.schema.stats.StatisticsCollector | From | To | |
| Change Attribute Type guidePosts : List<byte[]> to guidePosts : ImmutableBytesWritable in class org.apache.phoenix.schema.stats.GuidePostsInfo | From | To | |
| Change Attribute Type keyByteSize : long to guidePostsCount : int in class org.apache.phoenix.schema.stats.GuidePostsInfo | From | To |