71537ed63d1bffbbc60c43e7c6592c9bce279786
Files Diff
- Added: 4
- Removed: 0
- Renamed: 0
- Modified: 22
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Variable | 3 | ||
| Rename Variable byteCount : Long to bytes : double in method public getCost() : Cost in class org.apache.phoenix.execute.HashJoinPlan | From | To | |
| Rename Variable byteCount : Long to outputBytes : Double in method public getCost() : Cost in class org.apache.phoenix.execute.ClientScanPlan | From | To | |
| Rename Variable selectivity : double to rhsByteSum : double in method public getCost() : Cost in class org.apache.phoenix.execute.HashJoinPlan | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private useSortMergeJoin : boolean from class org.apache.phoenix.compile.QueryCompiler to private useSortMergeJoin : boolean from class org.apache.phoenix.compile.JoinCompiler | From | To | |
| Parameterize Variable | 3 | ||
| Parameterize Variable hintedQuery : String to query : String in method private verifyQueryPlan(query String, expected String) : void in class org.apache.phoenix.end2end.CostBasedDecisionIT | From | To | |
| Parameterize Variable dataPlan : String to expected : String in method private verifyQueryPlan(query String, expected String) : void in class org.apache.phoenix.end2end.CostBasedDecisionIT | From | To | |
| Parameterize Variable indexPlan : String to expected : String in method private verifyQueryPlan(query String, expected String) : void in class org.apache.phoenix.end2end.CostBasedDecisionIT | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute useSortMergeJoin : boolean to costBased : boolean in class org.apache.phoenix.compile.QueryCompiler | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type byteCount : Long to outputBytes : Double in method public getCost() : Cost in class org.apache.phoenix.execute.ClientScanPlan | From | To | |
| Change Variable Type byteCount : Long to bytes : double in method public getCost() : Cost in class org.apache.phoenix.execute.HashJoinPlan | From | To | |
| Extract Variable | 2 | ||
| Extract Variable services : QueryServices in method private HashJoinPlan(statement SelectStatement, plan QueryPlan, joinInfo HashJoinInfo, subPlans SubPlan[], recompileWhereClause boolean, dependencies Map<ImmutableBytesPtr,ServerCache>) from class org.apache.phoenix.execute.HashJoinPlan | From | To | |
| Extract Variable services : ConnectionQueryServices in method public QueryCompiler(statement PhoenixStatement, select SelectStatement, resolver ColumnResolver, targetColumns List<? extends PDatum>, parallelIteratorFactory ParallelIteratorFactory, sequenceManager SequenceManager, projectTuples boolean, dataPlan QueryPlan) from class org.apache.phoenix.compile.QueryCompiler | From | To | |
| Extract Method | 12 | ||
| Extract Method private verifyQueryPlan(query String, expected String) : void extracted from public testCostOverridesStaticPlanOrdering1() : void in class org.apache.phoenix.end2end.CostBasedDecisionIT | From | To | |
| Extract Method protected compileJoinQuery(strategy JoinCompiler.Strategy, context StatementContext, binds List<Object>, joinTable JoinTable, asSubquery boolean, projectPKColumns boolean, orderBy List<OrderByNode>) : QueryPlan extracted from protected compileJoinQuery(context StatementContext, binds List<Object>, joinTable JoinTable, asSubquery boolean, projectPKColumns boolean, orderBy List<OrderByNode>) : QueryPlan in class org.apache.phoenix.compile.QueryCompiler | From | To | |
| Extract Method private verifyQueryPlan(query String, expected String) : void extracted from public testHintOverridesCost() : void in class org.apache.phoenix.end2end.CostBasedDecisionIT | From | To | |
| Extract Method private verifyQueryPlan(query String, expected String) : void extracted from public testCostOverridesStaticPlanOrderingInDeleteQuery() : void in class org.apache.phoenix.end2end.CostBasedDecisionIT | From | To | |
| Extract Method private verifyQueryPlan(query String, expected String) : void extracted from public testCostOverridesStaticPlanOrderingInUpsertQuery() : void in class org.apache.phoenix.end2end.CostBasedDecisionIT | From | To | |
| Extract Method private verifyQueryPlan(query String, expected String) : void extracted from public testCostOverridesStaticPlanOrderingInJoinQuery() : void in class org.apache.phoenix.end2end.CostBasedDecisionIT | From | To | |
| Extract Method private verifyQueryPlan(query String, expected String) : void extracted from public testCostOverridesStaticPlanOrdering2() : void in class org.apache.phoenix.end2end.CostBasedDecisionIT | From | To | |
| Extract Method private verifyQueryPlan(query String, expected String) : void extracted from public testCostOverridesStaticPlanOrdering3() : void in class org.apache.phoenix.end2end.CostBasedDecisionIT | From | To | |
| Extract Method private verifyQueryPlan(query String, expected String) : void extracted from public testCostOverridesStaticPlanOrderingInUnionQuery() : void in class org.apache.phoenix.end2end.CostBasedDecisionIT | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public hasKeyRangeExpression() : boolean extracted from public getCost() : Cost in class org.apache.phoenix.execute.HashJoinPlan & moved to class org.apache.phoenix.execute.HashJoinPlan.HashSubPlan | From | To |