7175dcbc011dff48f6d041697ec84da98f80f729
Files Diff
- Added: 5
- Removed: 2
- Renamed: 0
- Modified: 40
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Inline Method | 1 | ||
| Move And Inline Method public executeMultithreadedQueryExecutor(queryHint String, export boolean, runMode RunMode) : void moved from class org.apache.phoenix.pherf.workload.WorkloadExecutor to class org.apache.phoenix.pherf.Pherf & inlined to public run() : void | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type rowsUpserted : int to rowsUpserted : long in method public WriteThreadTime(tableName String, threadName String, rowsUpserted long, timeInMsPerMillionRows long) in class org.apache.phoenix.pherf.result.WriteThreadTime | From | To | |
| Change Parameter Type rowsUpserted : int to rowsUpserted : long in method public add(tableName String, threadName String, rowsUpserted long, timeInMsPerMillionRows long) : void in class org.apache.phoenix.pherf.result.DataLoadThreadTime | From | To | |
| Move Method | 1 | ||
| Move Method protected executeQuerySetDdls(querySet QuerySet) : void from class org.apache.phoenix.pherf.workload.QueryExecutor to public executeQuerySetDdls(querySet QuerySet) : void from class org.apache.phoenix.pherf.util.PhoenixUtil | From | To | |
| Pull Up Attribute | 3 | ||
| Pull Up Attribute package matcherScenario : String from class org.apache.phoenix.pherf.DataIngestIT to protected matcherScenario : String from class org.apache.phoenix.pherf.ResultBaseTestIT | From | To | |
| Pull Up Attribute protected util : PhoenixUtil from class org.apache.phoenix.pherf.DataIngestIT to protected util : PhoenixUtil from class org.apache.phoenix.pherf.ResultBaseTestIT | From | To | |
| Pull Up Attribute package matcherSchema : String from class org.apache.phoenix.pherf.DataIngestIT to protected matcherSchema : String from class org.apache.phoenix.pherf.ResultBaseTestIT | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private parser : XMLConfigParser from class org.apache.phoenix.pherf.workload.WorkloadExecutor to private parser : XMLConfigParser from class org.apache.phoenix.pherf.workload.QueryExecutor | From | To | |
| Move Attribute protected util : PhoenixUtil from class org.apache.phoenix.pherf.DataIngestIT to private util : PhoenixUtil from class org.apache.phoenix.pherf.workload.QueryExecutor | From | To | |
| Move Attribute private parser : XMLConfigParser from class org.apache.phoenix.pherf.workload.WorkloadExecutor to protected parser : XMLConfigParser from class org.apache.phoenix.pherf.ResultBaseTestIT | From | To | |
| Rename Class | 1 | ||
| Rename Class org.apache.phoenix.pherf.workload.MultithreadedRunner renamed to org.apache.phoenix.pherf.workload.MultiThreadedRunner | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.apache.phoenix.pherf.loaddata.DataLoader moved and renamed to org.apache.phoenix.pherf.workload.WriteWorkload | From | To | |
| Change Variable Type | 12 | ||
| Change Variable Type thread : Thread to thread : Runnable in method protected executeQuerySetSerial(dataModelResult DataModelResult, querySet QuerySet, querySetResult QuerySetResult) : void in class org.apache.phoenix.pherf.workload.QueryExecutor | From | To | |
| Change Variable Type thread : Thread to thread : Future in method protected executeQuerySetParallel(dataModelResult DataModelResult, querySet QuerySet, querySetResult QuerySetResult) : void in class org.apache.phoenix.pherf.workload.QueryExecutor | From | To | |
| Change Variable Type threads : List<Thread> to threads : List<Future> in method protected executeQuerySetParallel(dataModelResult DataModelResult, querySet QuerySet, querySetResult QuerySetResult) : void in class org.apache.phoenix.pherf.workload.QueryExecutor | From | To | |
| Change Variable Type loader : DataLoader to loader : WriteWorkload in method public testNullChance() : void in class org.apache.phoenix.pherf.RuleGeneratorTest | From | To | |
| Change Variable Type threads : List<Thread> to threads : List<Future> in method protected executeQuerySetSerial(dataModelResult DataModelResult, querySet QuerySet, querySetResult QuerySetResult) : void in class org.apache.phoenix.pherf.workload.QueryExecutor | From | To | |
| Change Variable Type thread : Thread to thread : Runnable in method protected executeQuerySetParallel(dataModelResult DataModelResult, querySet QuerySet, querySetResult QuerySetResult) : void in class org.apache.phoenix.pherf.workload.QueryExecutor | From | To | |
| Change Variable Type loader : DataLoader to loader : WriteWorkload in method public testValueListRule() : void in class org.apache.phoenix.pherf.RuleGeneratorTest | From | To | |
| Change Variable Type loader : DataLoader to loader : WriteWorkload in method public testSequentialDataSequence() : void in class org.apache.phoenix.pherf.RuleGeneratorTest | From | To | |
| Change Variable Type loader : DataLoader to loader : WriteWorkload in method public testDateGenerator() : void in class org.apache.phoenix.pherf.RuleGeneratorTest | From | To | |
| Change Variable Type thread : Thread to thread : Future in method protected executeQuerySetSerial(dataModelResult DataModelResult, querySet QuerySet, querySetResult QuerySetResult) : void in class org.apache.phoenix.pherf.workload.QueryExecutor | From | To | |
| Change Variable Type thread : Thread to thread : Runnable in method protected executeRunner(name String, dataModelResult DataModelResult, queryResult QueryResult, querySet QuerySet) : Runnable in class org.apache.phoenix.pherf.workload.QueryExecutor | From | To | |
| Change Variable Type info : Info to maxDuration : long in method public call() : Info in class org.apache.phoenix.pherf.workload.WriteWorkload.upsertData.future.submit | From | To | |
| Extract Method | 3 | ||
| Extract Method private getResourceUrl() : URL extracted from public testConfigReader() : void in class org.apache.phoenix.pherf.ConfigurationParserTest | From | To | |
| Extract Method private getScenarios() : List<Scenario> extracted from public testConfigReader() : void in class org.apache.phoenix.pherf.ConfigurationParserTest | From | To | |
| Extract Method private getDataModel() : DataModel extracted from public testConfigReader() : void in class org.apache.phoenix.pherf.ConfigurationParserTest | From | To | |
| Rename Method | 3 | ||
| Rename Method public generateData() : void renamed to public testColumnRulesApplied() : void in class org.apache.phoenix.pherf.DataIngestIT | From | To | |
| Rename Method protected execcuteQuerySetSerial(dataModelResult DataModelResult, querySet QuerySet, querySetResult QuerySetResult, scenario Scenario) : void renamed to protected executeQuerySetSerial(dataModelResult DataModelResult, querySet QuerySet, querySetResult QuerySetResult) : void in class org.apache.phoenix.pherf.workload.QueryExecutor | From | To | |
| Rename Method protected execcuteQuerySetParallel(dataModelResult DataModelResult, querySet QuerySet, querySetResult QuerySetResult, scenario Scenario) : void renamed to protected executeQuerySetParallel(dataModelResult DataModelResult, querySet QuerySet, querySetResult QuerySetResult) : void in class org.apache.phoenix.pherf.workload.QueryExecutor | From | To | |
| Rename Variable | 2 | ||
| Rename Variable info : Info to maxDuration : long in method public call() : Info in class org.apache.phoenix.pherf.workload.WriteWorkload.upsertData.future.submit | From | To | |
| Rename Variable workloadExec : WorkloadExecutor to workloadExecutor : WorkloadExecutor in method public run() : void in class org.apache.phoenix.pherf.Pherf | From | To | |
| Change Return Type | 5 | ||
| Change Return Type Thread to Runnable in method protected executeRunner(name String, dataModelResult DataModelResult, queryResult QueryResult, querySet QuerySet) : Runnable in class org.apache.phoenix.pherf.workload.QueryExecutor | From | To | |
| Change Return Type int to long in method public getRowsUpserted() : long in class org.apache.phoenix.pherf.result.WriteThreadTime | From | To | |
| Change Return Type void to Runnable in method protected exportAllScenarios(dataModel DataModel) : Runnable in class org.apache.phoenix.pherf.workload.QueryExecutor | From | To | |
| Change Return Type void to Runnable in method public execute() : Runnable in class org.apache.phoenix.pherf.workload.WriteWorkload | From | To | |
| Change Return Type void to Runnable in method protected executeAllScenarios(dataModel DataModel) : Runnable in class org.apache.phoenix.pherf.workload.QueryExecutor | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute loadData : boolean to preLoadData : boolean in class org.apache.phoenix.pherf.Pherf | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type monitorFrequency : long to monitorFrequency : AtomicLong in class org.apache.phoenix.pherf.jmx.MonitorManager | From | To | |
| Change Attribute Type shouldStop : boolean to shouldStop : AtomicBoolean in class org.apache.phoenix.pherf.jmx.MonitorManager | From | To | |
| Change Attribute Type isRunning : boolean to isRunning : AtomicBoolean in class org.apache.phoenix.pherf.jmx.MonitorManager | From | To | |
| Change Attribute Type rowsUpserted : int to rowsUpserted : long in class org.apache.phoenix.pherf.result.WriteThreadTime | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter phoenixUtil : PhoenixUtil to util : PhoenixUtil in method public WriteWorkload(util PhoenixUtil, parser XMLConfigParser) in class org.apache.phoenix.pherf.workload.WriteWorkload | From | To |