pheonix 7865a59b0bbc4ea5e8ab775b920f5f608115707b

7865a59b0bbc4ea5e8ab775b920f5f608115707b

Files Diff

Added: 2
Removed: 0
Renamed: 0
Modified: 26

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	1
Move And Rename Method private addWriteFailingCoprocessor(conn Connection, tableName String) : void from class org.apache.phoenix.end2end.index.PartialIndexRebuilderIT to public addCoprocessor(conn Connection, tableName String, coprocessorClass Class) : void from class org.apache.phoenix.util.TestUtil	From	To
Change Parameter Type	3
Change Parameter Type dependencies : List<SQLCloseable> to dependencies : Map<ImmutableBytesPtr,ServerCache> in method private HashJoinPlan(statement SelectStatement, plan QueryPlan, joinInfo HashJoinInfo, subPlans SubPlan[], recompileWhereClause boolean, dependencies Map<ImmutableBytesPtr,ServerCache>) in class org.apache.phoenix.execute.HashJoinPlan	From	To
Change Parameter Type dependencies : List<? extends SQLCloseable> to caches : Map<ImmutableBytesPtr,ServerCache> in method public iterator(caches Map<ImmutableBytesPtr,ServerCache>, scanGrouper ParallelScanGrouper, scan Scan) : ResultIterator in class org.apache.phoenix.execute.BaseQueryPlan	From	To
Change Parameter Type dependencies : List<? extends SQLCloseable> to dependencies : Map<ImmutableBytesPtr,ServerCache> in method private getWrappedIterator(dependencies Map<ImmutableBytesPtr,ServerCache>, iterator ResultIterator) : ResultIterator in class org.apache.phoenix.execute.BaseQueryPlan	From	To
Change Attribute Type	2
Change Attribute Type dependencies : List<SQLCloseable> to dependencies : Map<ImmutableBytesPtr,ServerCache> in class org.apache.phoenix.execute.HashJoinPlan	From	To
Change Attribute Type servers : ImmutableSet<HRegionLocation> to servers : Set<HRegionLocation> in class org.apache.phoenix.cache.ServerCacheClient.ServerCache	From	To
Extract Method	1
Extract Method public addServerCache(keyRanges ScanRanges, cachePtr ImmutableBytesWritable, txState byte[], cacheFactory ServerCacheFactory, cacheUsingTableRef TableRef, storeCacheOnClient boolean) : ServerCache extracted from public addServerCache(keyRanges ScanRanges, cachePtr ImmutableBytesWritable, txState byte[], cacheFactory ServerCacheFactory, cacheUsingTableRef TableRef) : ServerCache in class org.apache.phoenix.cache.ServerCacheClient	From	To
Extract And Move Method	32
Extract And Move Method protected getConnection() : Connection extracted from public testJoinWithSubquery() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testJoinWithDifferentNumericJoinKeyTypes() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testLeftJoin() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testUpsertWithJoin() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testJoinWithPostFilters() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testJoinWithDifferentDateJoinKeyTypes() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testInnerJoin() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testRightJoin() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testJoinPlanWithIndex() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testJoinMultiJoinKeys() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testJoinWithSubqueryAndAggregation() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testLeftJoinWithPreFilters() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testMultiRightJoin() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testJoinWithWildcard() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testJoinWithTableWildcard() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testSelfJoin() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testSubJoin() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testInnerJoinWithPreFilters() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testLeftJoinWithAggregation() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testNonEquiJoin() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testJoinWithLimit() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testLeftRightJoin() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testJoinWithSkipMergeOptimization() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testMultiLeftJoin() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testStarJoin() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testJoinWithOffset() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testJoinWithSetMaxRows() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testDefaultJoin() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testJoinWithSubqueryPostFilters() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testJoinWithIncomparableJoinKeyTypes() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testRightJoinWithAggregation() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Extract And Move Method protected getConnection() : Connection extracted from public testNestedSubqueries() : void in class org.apache.phoenix.end2end.HashJoinIT & moved to class org.apache.phoenix.end2end.BaseJoinIT	From	To
Rename Parameter	2
Rename Parameter servers : Set<HRegionLocation> to remainingOnServers : Set<HRegionLocation> in method private removeServerCache(cache ServerCache, remainingOnServers Set<HRegionLocation>) : void in class org.apache.phoenix.cache.ServerCacheClient	From	To
Rename Parameter dependencies : List<? extends SQLCloseable> to caches : Map<ImmutableBytesPtr,ServerCache> in method public iterator(caches Map<ImmutableBytesPtr,ServerCache>, scanGrouper ParallelScanGrouper, scan Scan) : ResultIterator in class org.apache.phoenix.execute.BaseQueryPlan	From	To

7865a59b0bbc4ea5e8ab775b920f5f608115707b

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: