pheonix 78f35a65d0cc55014c51da70c847969a2ea3c5a6

78f35a65d0cc55014c51da70c847969a2ea3c5a6

Files Diff

Added: 1
Removed: 0
Renamed: 0
Modified: 19

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method public setIndexDisableTimeStamp(indexTableName String, minTimeStamp long, metaTable HTableInterface, newState PIndexState) : MetaDataMutationResult renamed to public updateIndexState(indexTableName String, minTimeStamp long, metaTable HTableInterface, newState PIndexState) : MetaDataMutationResult in class org.apache.phoenix.util.IndexUtil	From	To
Change Parameter Type	2
Change Parameter Type scanner : Scanner to scanner : CoveredDeleteScanner in method public createGetterFromScanner(scanner CoveredDeleteScanner, currentRow byte[]) : ValueGetter in class org.apache.phoenix.hbase.index.util.IndexManagementUtil	From	To
Change Parameter Type scan : Scanner to scan : CoveredDeleteScanner in method public LazyValueGetter(scan CoveredDeleteScanner, currentRow byte[]) in class org.apache.phoenix.hbase.index.covered.data.LazyValueGetter	From	To
Move Method	1
Move Method private updateIndexState(conn PhoenixConnection, indexTableName String, env RegionCoprocessorEnvironment, oldState PIndexState, newState PIndexState, indexDisableTimestamp Long) : void from class org.apache.phoenix.coprocessor.MetaDataRegionObserver to public updateIndexState(conn PhoenixConnection, indexTableName String, newState PIndexState, indexDisableTimestamp Long) : void from class org.apache.phoenix.util.IndexUtil	From	To
Change Return Type	3
Change Return Type Scanner to CoveredDeleteScanner in method private getFilteredScanner(filters Filter, returnNullIfRowNotFound boolean, deleteTracker DeleteTracker) : CoveredDeleteScanner in class org.apache.phoenix.hbase.index.scanner.ScannerBuilder	From	To
Change Return Type Scanner to CoveredDeleteScanner in method public buildIndexedColumnScanner(indexedColumns Collection<? extends ColumnReference>, tracker ColumnTracker, ts long, returnNullIfRowNotFound boolean) : CoveredDeleteScanner in class org.apache.phoenix.hbase.index.scanner.ScannerBuilder	From	To
Change Return Type Pair<Scanner,IndexUpdate> to Pair<CoveredDeleteScanner,IndexUpdate> in method public getIndexedColumnsTableState(indexedColumns Collection<? extends ColumnReference>, ignoreNewerMutations boolean, returnNullScannerIfRowNotFound boolean, indexMetaData IndexMetaData) : Pair<CoveredDeleteScanner,IndexUpdate> in class org.apache.phoenix.hbase.index.covered.LocalTableState	From	To
Extract Variable	1
Extract Variable deleteFilter : ApplyAndFilterDeletesFilter in method public buildIndexedColumnScanner(indexedColumns Collection<? extends ColumnReference>, tracker ColumnTracker, ts long, returnNullIfRowNotFound boolean) : CoveredDeleteScanner from class org.apache.phoenix.hbase.index.scanner.ScannerBuilder	From	To
Change Variable Type	8
Change Variable Type p : Pair<Scanner,IndexUpdate> to p : Pair<CoveredDeleteScanner,IndexUpdate> in method public testCorrectOrderingWithLazyLoadingColumns() : void in class org.apache.phoenix.hbase.index.covered.TestLocalTableState	From	To
Change Variable Type stateInfo : Pair<Scanner,IndexUpdate> to stateInfo : Pair<CoveredDeleteScanner,IndexUpdate> in method private getIndexUpdateForGroup(group ColumnGroup, state TableState, indexMetaData IndexMetaData) : IndexUpdate in class org.apache.phoenix.hbase.index.covered.example.CoveredColumnIndexCodec	From	To
Change Variable Type pair : Pair<Scanner,IndexUpdate> to pair : Pair<CoveredDeleteScanner,IndexUpdate> in method public getIndexUpdateState(indexedColumns Collection<? extends ColumnReference>, ignoreNewerMutations boolean, returnNullScannerIfRowNotFound boolean, indexMetaData IndexMetaData) : Pair<ValueGetter,IndexUpdate> in class org.apache.phoenix.hbase.index.covered.LocalTableState	From	To
Change Variable Type kvs : Pair<Scanner,IndexUpdate> to kvs : Pair<CoveredDeleteScanner,IndexUpdate> in method private getDeleteForGroup(group ColumnGroup, state TableState, indexMetaData IndexMetaData) : IndexUpdate in class org.apache.phoenix.hbase.index.covered.example.CoveredColumnIndexCodec	From	To
Change Variable Type scanner : Scanner to scanner : CoveredDeleteScanner in method public getIndexedColumnsTableState(indexedColumns Collection<? extends ColumnReference>, ignoreNewerMutations boolean, returnNullScannerIfRowNotFound boolean, indexMetaData IndexMetaData) : Pair<CoveredDeleteScanner,IndexUpdate> in class org.apache.phoenix.hbase.index.covered.LocalTableState	From	To
Change Variable Type p : Pair<Scanner,IndexUpdate> to p : Pair<CoveredDeleteScanner,IndexUpdate> in method public testCorrectRollback() : void in class org.apache.phoenix.hbase.index.covered.TestLocalTableState	From	To
Change Variable Type p : Pair<Scanner,IndexUpdate> to p : Pair<CoveredDeleteScanner,IndexUpdate> in method public testOnlyLoadsRequestedColumns() : void in class org.apache.phoenix.hbase.index.covered.TestLocalTableState	From	To
Change Variable Type p : Pair<Scanner,IndexUpdate> to p : Pair<CoveredDeleteScanner,IndexUpdate> in method public testNoScannerForImmutableRows() : void in class org.apache.phoenix.hbase.index.covered.TestLocalTableState	From	To
Change Attribute Type	1
Change Attribute Type scan : Scanner to scan : CoveredDeleteScanner in class org.apache.phoenix.hbase.index.covered.data.LazyValueGetter	From	To
Extract And Move Method	1
Extract And Move Method public waitForIndexRebuild(conn Connection, fullIndexName String, expectedIndexState PIndexState) : void extracted from private waitForIndexRebuild(conn Connection, index String, expectedIndexState PIndexState) : void in class org.apache.phoenix.end2end.index.MutableIndexFailureIT & moved to class org.apache.phoenix.util.TestUtil	From	To

78f35a65d0cc55014c51da70c847969a2ea3c5a6

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: