7a2944a0d2fa56431c06e63461afa6f1f63e65d0
Files Diff
- Added: 6
- Removed: 2
- Renamed: 0
- Modified: 57
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Change Parameter Type | 5 | ||
Change Parameter Type node : Expression to modulusExpression : ModulusExpression in method public visitEnter(modulusExpression ModulusExpression) : Iterator<Expression> in class org.apache.phoenix.expression.visitor.ExpressionVisitor | From | To | |
Change Parameter Type node : Expression to modulusExpression : ModulusExpression in method public visitEnter(modulusExpression ModulusExpression) : Iterator<Expression> in class org.apache.phoenix.expression.visitor.BaseExpressionVisitor | From | To | |
Change Parameter Type funcClass : Class<? extends FunctionExpression> to funcClass : Class<? extends ScalarFunction> in method private getBuiltInFunctionInfo(funcClass Class<? extends ScalarFunction>) : BuiltInFunctionInfo in class org.apache.phoenix.parse.BuiltInFunctionInfoTest | From | To | |
Change Parameter Type node : Expression to arrayAnyComparisonExpression : ArrayAnyComparisonExpression in method public visitEnter(arrayAnyComparisonExpression ArrayAnyComparisonExpression) : Iterator<Expression> in class org.apache.phoenix.expression.visitor.ExpressionVisitor | From | To | |
Change Parameter Type node : Expression to arrayAnyComparisonExpression : ArrayAnyComparisonExpression in method public visitEnter(arrayAnyComparisonExpression ArrayAnyComparisonExpression) : Iterator<Expression> in class org.apache.phoenix.expression.visitor.BaseExpressionVisitor | From | To | |
Move Method | 22 | ||
Move Method public visitLeave(node ComparisonExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visitLeave(node ComparisonExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Move Method public visitLeave(node AddExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visitLeave(node AddExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Move Method public visitLeave(node LikeExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visitLeave(node LikeExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Move Method public visit(node LiteralExpression) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visit(node LiteralExpression) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Move Method public visitLeave(node IsNullExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visitLeave(node IsNullExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Move Method public visitLeave(node InListExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visitLeave(node InListExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Move Method public visit(node KeyValueColumnExpression) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visit(node KeyValueColumnExpression) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Move Method public visitLeave(node SubtractExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visitLeave(node SubtractExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Move Method public visit(node ProjectedColumnExpression) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visit(node ProjectedColumnExpression) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Move Method public visitLeave(node NotExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visitLeave(node NotExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Move Method public visitLeave(node OrExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visitLeave(node OrExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Move Method public visitLeave(node AndExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visitLeave(node AndExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Move Method public visitLeave(node RowValueConstructorExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visitLeave(node RowValueConstructorExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Move Method public visitLeave(node ScalarFunction, l List<E>) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visitLeave(node ScalarFunction, l List<E>) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Move Method public visitLeave(node CaseExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visitLeave(node CaseExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Move Method public visit(node RowKeyColumnExpression) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visit(node RowKeyColumnExpression) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Move Method public visitLeave(node StringConcatExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visitLeave(node StringConcatExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Move Method public visitLeave(node SingleAggregateFunction, l List<E>) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visitLeave(node SingleAggregateFunction, l List<E>) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Move Method public visitLeave(node MultiplyExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visitLeave(node MultiplyExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Move Method public visitLeave(node DivideExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visitLeave(node DivideExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Move Method public visitLeave(node ArrayConstructorExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visitLeave(node ArrayConstructorExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Move Method public visitLeave(node CoerceExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor to public visitLeave(node CoerceExpression, l List<E>) : E from class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor | From | To | |
Extract Class | 2 | ||
Extract Class org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor | From | To | |
Extract Class org.apache.phoenix.expression.visitor.CloneExpressionVisitor from class org.apache.phoenix.expression.visitor.BaseExpressionVisitor | From | To | |
Rename Class | 1 | ||
Rename Class org.apache.phoenix.expression.function.InlineArrayElemRefExpression renamed to org.apache.phoenix.expression.function.ArrayElemRefExpression | From | To | |
Move Class | 2 | ||
Move Class org.apache.phoenix.arithmetic.ArithmeticOperationTest moved to org.apache.phoenix.expression.ArithmeticOperationTest | From | To | |
Move Class org.apache.phoenix.compile.SequenceManager.SequenceValueExpression moved to org.apache.phoenix.compile.SequenceValueExpression | From | To | |
Change Variable Type | 5 | ||
Change Variable Type e : DecimalMultiplyExpression to clone : Expression in method private assertEqualValue(e Expression, type PDataType, value Object) : void in class org.apache.phoenix.expression.ArithmeticOperationTest | From | To | |
Change Variable Type e : DecimalSubtractExpression to clone : Expression in method private assertEqualValue(e Expression, type PDataType, value Object) : void in class org.apache.phoenix.expression.ArithmeticOperationTest | From | To | |
Change Variable Type e : DecimalDivideExpression to clone : Expression in method private assertEqualValue(e Expression, type PDataType, value Object) : void in class org.apache.phoenix.expression.ArithmeticOperationTest | From | To | |
Change Variable Type e : DecimalAddExpression to clone : Expression in method private assertEqualValue(e Expression, type PDataType, value Object) : void in class org.apache.phoenix.expression.ArithmeticOperationTest | From | To | |
Extract Method | 7 | ||
Extract Method private assertEqualValue(e Expression, type PDataType, value Object) : void extracted from public testDecimalAddition() : void in class org.apache.phoenix.expression.ArithmeticOperationTest | From | To | |
Extract Method private assertEqualValue(e Expression, type PDataType, value Object) : void extracted from public testDecimalDivision() : void in class org.apache.phoenix.expression.ArithmeticOperationTest | From | To | |
Extract Method private assertEqualValue(e Expression, type PDataType, value Object) : void extracted from public testDecimalMultiplication() : void in class org.apache.phoenix.expression.ArithmeticOperationTest | From | To | |
Extract Method private assertEqualValue(e Expression, type PDataType, value Object) : void extracted from public testDecimalSubtraction() : void in class org.apache.phoenix.expression.ArithmeticOperationTest | From | To | |
Extract Method private assertEqualValue(e Expression, type PDataType, value Object) : void extracted from public testIntPlusDecimal() : void in class org.apache.phoenix.expression.ArithmeticOperationTest | From | To | |
Rename Method | 4 | ||
Rename Method public visitLeave(node Expression, l List<E>) : E renamed to public visitEnter(arrayElemRefExpression ArrayElemRefExpression) : Iterator<Expression> in class org.apache.phoenix.expression.visitor.ExpressionVisitor | From | To | |
Rename Method public visit(node Expression) : E renamed to public visitEnter(arrayAnyComparisonExpression ArrayAnyComparisonExpression) : Iterator<Expression> in class org.apache.phoenix.expression.visitor.ExpressionVisitor | From | To | |
Rename Method public visitLeave(node Expression, l List<E>) : E renamed to public visitEnter(arrayElemRefExpression ArrayElemRefExpression) : Iterator<Expression> in class org.apache.phoenix.expression.visitor.BaseExpressionVisitor | From | To | |
Rename Method public visit(node Expression) : E renamed to public visitEnter(arrayAnyComparisonExpression ArrayAnyComparisonExpression) : Iterator<Expression> in class org.apache.phoenix.expression.visitor.BaseExpressionVisitor | From | To | |
Push Down Method | 6 | ||
Push Down Method public accept(visitor ExpressionVisitor<T>) : T from class org.apache.phoenix.expression.BaseCompoundExpression to public accept(visitor ExpressionVisitor<T>) : T from class org.apache.phoenix.expression.ArrayConstructorExpression | From | To | |
Push Down Method public accept(visitor ExpressionVisitor<T>) : T from class org.apache.phoenix.expression.BaseTerminalExpression to public accept(visitor ExpressionVisitor<T>) : T from class org.apache.phoenix.expression.RowKeyExpression | From | To | |
Push Down Method public accept(visitor ExpressionVisitor<T>) : T from class org.apache.phoenix.expression.BaseTerminalExpression to public accept(visitor ExpressionVisitor<T>) : T from class org.apache.phoenix.compile.ProjectionCompiler.ArrayIndexExpression | From | To | |
Push Down Method public accept(visitor ExpressionVisitor<T>) : T from class org.apache.phoenix.expression.BaseCompoundExpression to public accept(visitor ExpressionVisitor<T>) : T from class org.apache.phoenix.expression.function.ArrayAnyComparisonExpression | From | To | |
Push Down Method public accept(visitor ExpressionVisitor<T>) : T from class org.apache.phoenix.expression.BaseTerminalExpression to public accept(visitor ExpressionVisitor<T>) : T from class org.apache.phoenix.expression.aggregator.BaseAggregator | From | To | |
Push Down Method public accept(visitor ExpressionVisitor<T>) : T from class org.apache.phoenix.expression.BaseCompoundExpression to public accept(visitor ExpressionVisitor<T>) : T from class org.apache.phoenix.expression.ModulusExpression | From | To | |
Rename Variable | 5 | ||
Rename Variable e : DecimalMultiplyExpression to clone : Expression in method private assertEqualValue(e Expression, type PDataType, value Object) : void in class org.apache.phoenix.expression.ArithmeticOperationTest | From | To | |
Rename Variable e : DecimalSubtractExpression to clone : Expression in method private assertEqualValue(e Expression, type PDataType, value Object) : void in class org.apache.phoenix.expression.ArithmeticOperationTest | From | To | |
Rename Variable e : DecimalAddExpression to clone : Expression in method private assertEqualValue(e Expression, type PDataType, value Object) : void in class org.apache.phoenix.expression.ArithmeticOperationTest | From | To | |
Rename Variable e : DecimalDivideExpression to clone : Expression in method private assertEqualValue(e Expression, type PDataType, value Object) : void in class org.apache.phoenix.expression.ArithmeticOperationTest | From | To | |
Change Return Type | 4 | ||
Change Return Type E to Iterator<Expression> in method public visitEnter(arrayElemRefExpression ArrayElemRefExpression) : Iterator<Expression> in class org.apache.phoenix.expression.visitor.ExpressionVisitor | From | To | |
Change Return Type E to Iterator<Expression> in method public visitEnter(arrayAnyComparisonExpression ArrayAnyComparisonExpression) : Iterator<Expression> in class org.apache.phoenix.expression.visitor.ExpressionVisitor | From | To | |
Change Return Type E to Iterator<Expression> in method public visitEnter(arrayElemRefExpression ArrayElemRefExpression) : Iterator<Expression> in class org.apache.phoenix.expression.visitor.BaseExpressionVisitor | From | To | |
Change Return Type E to Iterator<Expression> in method public visitEnter(arrayAnyComparisonExpression ArrayAnyComparisonExpression) : Iterator<Expression> in class org.apache.phoenix.expression.visitor.BaseExpressionVisitor | From | To | |
Extract Superclass | 2 | ||
Extract Superclass org.apache.phoenix.expression.visitor.StatelessTraverseNoExpressionVisitor from classes [org.apache.phoenix.compile.CreateTableCompiler.ViewWhereExpressionVisitor, org.apache.phoenix.compile.WhereOptimizer.RemoveExtractedNodesVisitor, org.apache.phoenix.compile.WhereOptimizer.KeyExpressionVisitor] | From | To | |
Extract Superclass org.apache.phoenix.expression.visitor.StatelessTraverseAllExpressionVisitor from classes [org.apache.phoenix.expression.visitor.KeyValueExpressionVisitor, org.apache.phoenix.expression.visitor.RowKeyExpressionVisitor, org.apache.phoenix.expression.visitor.SingleAggregateFunctionVisitor] | From | To | |
Extract And Move Method | 1 | ||
Extract And Move Method public create(children List<Expression>) : Expression extracted from public visitLeave(node CaseParseNode, l List<Expression>) : Expression in class org.apache.phoenix.compile.ExpressionCompiler & moved to class org.apache.phoenix.expression.CaseExpression | From | To | |
Rename Parameter | 5 | ||
Rename Parameter node : Expression to arrayAnyComparisonExpression : ArrayAnyComparisonExpression in method public visitEnter(arrayAnyComparisonExpression ArrayAnyComparisonExpression) : Iterator<Expression> in class org.apache.phoenix.expression.visitor.BaseExpressionVisitor | From | To | |
Rename Parameter expressions : List<Expression> to children : List<Expression> in method public CaseExpression(children List<Expression>) in class org.apache.phoenix.expression.CaseExpression | From | To | |
Rename Parameter node : Expression to modulusExpression : ModulusExpression in method public visitEnter(modulusExpression ModulusExpression) : Iterator<Expression> in class org.apache.phoenix.expression.visitor.ExpressionVisitor | From | To | |
Rename Parameter node : Expression to modulusExpression : ModulusExpression in method public visitEnter(modulusExpression ModulusExpression) : Iterator<Expression> in class org.apache.phoenix.expression.visitor.BaseExpressionVisitor | From | To | |
Rename Parameter node : Expression to arrayAnyComparisonExpression : ArrayAnyComparisonExpression in method public visitEnter(arrayAnyComparisonExpression ArrayAnyComparisonExpression) : Iterator<Expression> in class org.apache.phoenix.expression.visitor.ExpressionVisitor | From | To |