pheonix 86fe2fc5dfbebcf339aec42cce38b7a11e95186f

86fe2fc5dfbebcf339aec42cce38b7a11e95186f

Files Diff

Added: 1
Removed: 0
Renamed: 0
Modified: 12

Link to commit

Dependency Action

Refactorings reported:

	Refactoring Name	Occurences
	Rename Variable	4
	Rename Variable defaultFamilyByes : byte[] to defaultFamilyBytes : byte[] in method private generateTableDescriptor(physicalTableName byte[], existingDesc TableDescriptor, tableType PTableType, tableProps Map<String,Object>, families List<Pair<byte[],Map<String,Object>>>, splits byte[][], isNamespaceMapped boolean) : TableDescriptorBuilder in class org.apache.phoenix.query.ConnectionQueryServicesImpl	From	To
	Rename Variable props : Collection<Pair<String,Object>> to propsForCF : Collection<Pair<String,Object>> in method private populateFamilyPropsList(familyNames Map<String,PName>, commonFamilyProps Map<String,Object>, statement CreateTableStatement, defaultFamilyName String, isLocalIndex boolean, familyPropList List<Pair<byte[],Map<String,Object>>>) : void in class org.apache.phoenix.schema.MetaDataClient	From	To
	Rename Variable family : PColumnFamily to entry : Map.Entry<String,Map<String,Object>> in method private setSyncedPropsForNewColumnFamilies(allFamiliesProps Map<String,Map<String,Object>>, table PTable, tableDescBuilder TableDescriptorBuilder, newTTL Integer, newKeepDeletedCells KeepDeletedCells, newReplicationScope Integer) : void in class org.apache.phoenix.query.ConnectionQueryServicesImpl	From	To
	Rename Variable tableDescriptorPair : Pair<TableDescriptor,TableDescriptor> to oldToNewTableDescriptors : Map<TableDescriptor,TableDescriptor> in method public addColumn(tableMetaData List<Mutation>, table PTable, stmtProperties Map<String,List<Pair<String,Object>>>, colFamiliesForPColumnsToBeAdded Set<String>, columns List<PColumn>) : MetaDataMutationResult in class org.apache.phoenix.query.ConnectionQueryServicesImpl	From	To
	Change Return Type	1
	Change Return Type Pair<TableDescriptor,TableDescriptor> to Map<TableDescriptor,TableDescriptor> in method private separateAndValidateProperties(table PTable, properties Map<String,List<Pair<String,Object>>>, colFamiliesForPColumnsToBeAdded Set<String>, tableProps Map<String,Object>) : Map<TableDescriptor,TableDescriptor> in class org.apache.phoenix.query.ConnectionQueryServicesImpl	From	To
	Parameterize Variable	1
	Parameterize Variable newTableDescriptorBuilder : TableDescriptorBuilder to tableDescBuilder : TableDescriptorBuilder in method private setSyncedPropsForNewColumnFamilies(allFamiliesProps Map<String,Map<String,Object>>, table PTable, tableDescBuilder TableDescriptorBuilder, newTTL Integer, newKeepDeletedCells KeepDeletedCells, newReplicationScope Integer) : void in class org.apache.phoenix.query.ConnectionQueryServicesImpl	From	To
	Change Variable Type	2
	Change Variable Type family : PColumnFamily to entry : Map.Entry<String,Map<String,Object>> in method private setSyncedPropsForNewColumnFamilies(allFamiliesProps Map<String,Map<String,Object>>, table PTable, tableDescBuilder TableDescriptorBuilder, newTTL Integer, newKeepDeletedCells KeepDeletedCells, newReplicationScope Integer) : void in class org.apache.phoenix.query.ConnectionQueryServicesImpl	From	To
	Change Variable Type tableDescriptorPair : Pair<TableDescriptor,TableDescriptor> to oldToNewTableDescriptors : Map<TableDescriptor,TableDescriptor> in method public addColumn(tableMetaData List<Mutation>, table PTable, stmtProperties Map<String,List<Pair<String,Object>>>, colFamiliesForPColumnsToBeAdded Set<String>, columns List<PColumn>) : MetaDataMutationResult in class org.apache.phoenix.query.ConnectionQueryServicesImpl	From	To
	Extract Method	3
	Extract Method private setSyncedPropsForNewColumnFamilies(allFamiliesProps Map<String,Map<String,Object>>, table PTable, tableDescBuilder TableDescriptorBuilder, newTTL Integer, newKeepDeletedCells KeepDeletedCells, newReplicationScope Integer) : void extracted from private separateAndValidateProperties(table PTable, properties Map<String,List<Pair<String,Object>>>, colFamiliesForPColumnsToBeAdded Set<String>, tableProps Map<String,Object>) : Pair<TableDescriptor,TableDescriptor> in class org.apache.phoenix.query.ConnectionQueryServicesImpl	From	To
	Extract Method private populateFamilyPropsList(familyNames Map<String,PName>, commonFamilyProps Map<String,Object>, statement CreateTableStatement, defaultFamilyName String, isLocalIndex boolean, familyPropList List<Pair<byte[],Map<String,Object>>>) : void extracted from private createTableInternal(statement CreateTableStatement, splits byte[][], parent PTable, viewStatement String, viewType ViewType, viewIndexType PDataType, viewColumnConstants byte[][], isViewColumnReferenced BitSet, allocateIndexId boolean, indexType IndexType, asyncCreatedDate Date, tableProps Map<String,Object>, commonFamilyProps Map<String,Object>) : PTable in class org.apache.phoenix.schema.MetaDataClient	From	To
	Extract Method private setSyncedPropsForUnreferencedColumnFamilies(tableDesc TableDescriptor, allFamiliesProps Map<String,Map<String,Object>>, newTTL Integer, newKeepDeletedCells KeepDeletedCells, newReplicationScope Integer) : void extracted from private separateAndValidateProperties(table PTable, properties Map<String,List<Pair<String,Object>>>, colFamiliesForPColumnsToBeAdded Set<String>, tableProps Map<String,Object>) : Pair<TableDescriptor,TableDescriptor> in class org.apache.phoenix.query.ConnectionQueryServicesImpl	From	To
	Rename Parameter	1
	Rename Parameter props : ListMultimap<String,Pair<String,Object>> to statementProps : ListMultimap<String,Pair<String,Object>> in method private populatePropertyMaps(statementProps ListMultimap<String,Pair<String,Object>>, tableProps Map<String,Object>, commonFamilyProps Map<String,Object>, tableType PTableType) : void in class org.apache.phoenix.schema.MetaDataClient	From	To