abeaa74ad35e145fcae40f239437e1b5964bcd72
Files Diff
- Added: 2
- Removed: 1
- Renamed: 0
- Modified: 68
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method private escapePattern(pattern String) : String from class org.apache.phoenix.jdbc.PhoenixDatabaseMetaData to public escapeStringConstant(pattern String) : String from class org.apache.phoenix.util.StringUtil | From | To | |
| Move Method | 1 | ||
| Move Method public convertToRoundExpressionIfNeeded(fromDataType PDataType, targetDataType PDataType, expressions List<Expression>) : Expression from class org.apache.phoenix.parse.CastParseNode to private convertToRoundExpressionIfNeeded(fromDataType PDataType, targetDataType PDataType, expressions List<Expression>) : Expression from class org.apache.phoenix.compile.ExpressionCompiler | From | To | |
| Rename Variable | 2 | ||
| Rename Variable parser : SQLParser to sql : String in method public testParseJoin2() : void in class org.apache.phoenix.parse.QueryParserTest | From | To | |
| Rename Variable children : List<ParseNode> to args : List<ParseNode> in method public function(name String, valueNodes List<ParseNode>, columnNodes List<ParseNode>, isAscending boolean) : FunctionParseNode in class org.apache.phoenix.parse.ParseNodeFactory | From | To | |
| Change Return Type | 1 | ||
| Change Return Type MultiplyParseNode to ParseNode in method public negate(child ParseNode) : ParseNode in class org.apache.phoenix.parse.ParseNodeFactory | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private CompareOpString : String[] from class org.apache.phoenix.expression.ComparisonExpression to private CompareOpString : String[] from class org.apache.phoenix.util.QueryUtil | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.phoenix.parse.ArrayAllAnyComparisonNode from classes [org.apache.phoenix.parse.ArrayAllComparisonNode, org.apache.phoenix.parse.ArrayAnyComparisonNode] | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type parser : SQLParser to sql : String in method public testParseJoin2() : void in class org.apache.phoenix.parse.QueryParserTest | From | To | |
| Extract Variable | 1 | ||
| Extract Variable expressionStr : String in method public createIndex(statement CreateIndexStatement, splits byte[][]) : MutationState from class org.apache.phoenix.schema.MetaDataClient | From | To | |
| Extract Method | 39 | ||
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from private helpTestToNumberFilter(toNumberClause String, expectedDecimal BigDecimal) : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testCollapseFunctionToNull() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testSingleEqualFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testScanCaching_CustomFetchSizeOnStatement() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testInListWithAnd1GTEFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testAndTrueFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testFalseFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testSecondPkColInListFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testDegenerateRowKeyFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testToDateFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testTypeMismatch() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testAndFalseFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testPaddedRowKeyFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testDegenerateBiggerThanMaxLengthVarchar() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testInListWithAnd2Filter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testInListWithAnd2FilterScanKey() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testSingleFixedFullPkSalted() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testTenantConstraintsAddedToScan() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testSingleVariableFullPkSalted() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testInListWithAnd1Filter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testPaddedStartStopKey() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testAndFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testNotBetweenFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testScanCaching_Default() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testInListWithAnd1FilterScankey() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testPartialRangeFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testInFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testTenantConstraintsAddedToScanWithNullTenantTypeId() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testTrueFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testMultiFixedFullPkSalted() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testRowKeyFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testRHSLiteral() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testOrFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testMultiColumnEqualFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testOrTrueFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testInListFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testOrFalseFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testOr2InFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To | |
| Extract Method private newPreparedStatement(pconn PhoenixConnection, query String) : PhoenixPreparedStatement extracted from public testBetweenFilter() : void in class org.apache.phoenix.compile.WhereCompilerTest | From | To |