d3aba78a57167fbad24ee15a8f00d44a11e1021a
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 8
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Move Method | 4 | ||
Move Method private getTTLForEmptyCf(emptyCf byte[], tableNameBytes byte[], tableDescriptor HTableDescriptor) : int from class org.apache.phoenix.schema.MetaDataClient to private getTTLForEmptyCf(emptyCf byte[], tableNameBytes byte[], tableDescriptor HTableDescriptor) : int from class org.apache.phoenix.query.ConnectionQueryServicesImpl | From | To | |
Move Method private setTTLToEmptyCFTTL(familyProps Map<String,Map<String,Object>>, table PTable, newTableDesc HTableDescriptor) : void from class org.apache.phoenix.schema.MetaDataClient to private setTTLToEmptyCFTTL(familyProps Map<String,Map<String,Object>>, table PTable, tableDesc HTableDescriptor) : void from class org.apache.phoenix.query.ConnectionQueryServicesImpl | From | To | |
Move Method private isHTableProperty(propName String) : boolean from class org.apache.phoenix.schema.MetaDataClient to private isHTableProperty(propName String) : boolean from class org.apache.phoenix.query.ConnectionQueryServicesImpl | From | To | |
Move Method private isHColumnProperty(propName String) : boolean from class org.apache.phoenix.schema.MetaDataClient to private isHColumnProperty(propName String) : boolean from class org.apache.phoenix.query.ConnectionQueryServicesImpl | From | To | |
Rename Variable | 2 | ||
Rename Variable key : String to propName : String in method private modifyColumnFamilyDescriptor(hcd HColumnDescriptor, props Map<String,Object>) : void in class org.apache.phoenix.query.ConnectionQueryServicesImpl | From | To | |
Rename Variable stmtPropsMap : ListMultimap<String,Pair<String,Object>> to stmtProperties : ListMultimap<String,Pair<String,Object>> in method public addColumn(statement AddColumnStatement) : MutationState in class org.apache.phoenix.schema.MetaDataClient | From | To | |
Inline Method | 2 | ||
Inline Method private ensureFamilyCreated(tableName byte[], tableType PTableType, family Pair<byte[],Map<String,Object>>) : void inlined to public addColumn(tableMetaData List<Mutation>, table PTable, stmtProperties Map<String,List<Pair<String,Object>>>, colFamiliesForPColumnsToBeAdded Set<String>) : MetaDataMutationResult in class org.apache.phoenix.query.ConnectionQueryServicesImpl | From | To | |
Inline Method private existingColumnFamilies(table PTable) : HashSet<String> inlined to public addColumn(statement AddColumnStatement) : MutationState in class org.apache.phoenix.schema.MetaDataClient | From | To | |
Extract Method | 1 | ||
Extract Method private modifyColumnFamilyDescriptor(hcd HColumnDescriptor, props Map<String,Object>) : void extracted from private modifyColumnFamilyDescriptor(hcd HColumnDescriptor, family Pair<byte[],Map<String,Object>>) : void in class org.apache.phoenix.query.ConnectionQueryServicesImpl | From | To | |
Rename Parameter | 2 | ||
Rename Parameter newTableDesc : HTableDescriptor to tableDesc : HTableDescriptor in method private setTTLToEmptyCFTTL(familyProps Map<String,Map<String,Object>>, table PTable, tableDesc HTableDescriptor) : void in class org.apache.phoenix.query.ConnectionQueryServicesImpl | From | To | |
Rename Parameter tabeMetaData : List<Mutation> to tableMetaData : List<Mutation> in method public addColumn(tableMetaData List<Mutation>, table PTable, properties Map<String,List<Pair<String,Object>>>, colFamiliesForPColumnsToBeAdded Set<String>) : MetaDataMutationResult in class org.apache.phoenix.query.DelegateConnectionQueryServices | From | To |