dd8789b473fd8f0c35b0d5014f5c793fffa255e3
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 32
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 2 | ||
| Move And Rename Method public getExpressionsFromOrderPreservingTrackInfos() : List<Expression> from class org.apache.phoenix.compile.OrderPreservingTracker to public extractExpressions(orderPreservingTrackInfos List<Info>) : List<Expression> from class org.apache.phoenix.compile.OrderPreservingTracker.Info | From | To | |
| Move And Rename Method public track(node Expression, sortOrder SortOrder, isNullsLast Boolean) : void from class org.apache.phoenix.compile.OrderPreservingTracker to private doTrack(expression Expression, isAscending Boolean, isNullsLast Boolean) : void from class org.apache.phoenix.compile.OrderPreservingTracker.TrackOrderByContext | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type tupleProjector : TupleProjector to innerQueryPlan : QueryPlan in method public compile(context StatementContext, innerQueryPlan QueryPlan, whereExpression Expression) : GroupBy in class org.apache.phoenix.compile.GroupByCompiler.GroupBy | From | To | |
| Move Method | 1 | ||
| Move Method private hasEqualityConstraints(startPos int, endPos int) : boolean from class org.apache.phoenix.compile.OrderPreservingTracker to private hasEqualityConstraints(startPos int, endPos int) : boolean from class org.apache.phoenix.compile.OrderPreservingTracker.TrackOrderByContext | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private isOrderPreserving : boolean from class org.apache.phoenix.compile.OrderPreservingTracker to private isOrderPreserving : boolean from class org.apache.phoenix.compile.OrderPreservingTracker.TrackOrderByContext | From | To | |
| Move Attribute private orderPreservingColumnCount : int from class org.apache.phoenix.compile.OrderPreservingTracker to private orderPreservingColumnCount : int from class org.apache.phoenix.compile.OrderPreservingTracker.TrackOrderByContext | From | To | |
| Move Attribute private isReverse : Boolean from class org.apache.phoenix.compile.OrderPreservingTracker to private isReverse : Boolean from class org.apache.phoenix.compile.OrderPreservingTracker.TrackOrderByContext | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.phoenix.compile.OrderPreservingTracker.TrackOrderByContext from class org.apache.phoenix.compile.OrderPreservingTracker | From | To | |
| Merge Parameter | 2 | ||
| Merge Parameter [innerPlanTupleProjector : TupleProjector, isInRowKeyOrder : boolean] to innerPlan : QueryPlan in method protected compileSingleFlatQuery(context StatementContext, select SelectStatement, binds List<Object>, asSubquery boolean, allowPageFilter boolean, innerPlan QueryPlan) : QueryPlan in class org.apache.phoenix.compile.QueryCompiler | From | To | |
| Merge Parameter [lhsKeyExpressions : List<Expression>, rhsKeyExpressions : List<Expression>] to lhsAndRhsKeyExpressions : Pair<List<Expression>,List<Expression>> in method public SortMergeJoinPlan(context StatementContext, statement FilterableStatement, table TableRef, type JoinType, lhsPlan QueryPlan, rhsPlan QueryPlan, lhsAndRhsKeyExpressions Pair<List<Expression>,List<Expression>>, rhsKeyExpressions List<Expression>, joinedTable PTable, lhsTable PTable, rhsTable PTable, rhsFieldPosition int, isSingleValueOnly boolean, lhsAndRhsOrderByNodes Pair<List<OrderByNode>,List<OrderByNode>>) in class org.apache.phoenix.execute.SortMergeJoinPlan | From | To | |
| Extract Variable | 1 | ||
| Extract Variable innerQueryPlanRowProjector : RowProjector in method protected compileSingleQuery(context StatementContext, select SelectStatement, binds List<Object>, asSubquery boolean, allowPageFilter boolean) : QueryPlan from class org.apache.phoenix.compile.QueryCompiler | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type prevPos : int to selectedTrackOrderByContext : TrackOrderByContext in method public isOrderPreserving() : boolean in class org.apache.phoenix.compile.OrderPreservingTracker | From | To | |
| Extract Method | 2 | ||
| Extract Method private getExpressionToCheckConstant(columnIndex int) : Expression extracted from private hasEqualityConstraints(startPos int, endPos int) : boolean in class org.apache.phoenix.compile.OrderPreservingTracker.TrackOrderByContext | From | To | |
| Extract Method public isTrackOrderByPreserving(selectStatement SelectStatement) : boolean extracted from public compile(context StatementContext, statement SelectStatement, groupBy GroupBy, limit Integer, offset Integer, rowProjector RowProjector, tupleProjector TupleProjector, isInRowKeyOrder boolean, whereExpression Expression) : OrderBy in class org.apache.phoenix.compile.OrderByCompiler | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute prevPos : int to selectedTrackOrderByContext : TrackOrderByContext in method public isOrderPreserving() : boolean in class org.apache.phoenix.compile.OrderPreservingTracker | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute orderPreservingInfos : List<Info> to inputOrderBys : List<OrderBy> in class org.apache.phoenix.compile.OrderPreservingTracker | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type orderPreservingInfos : List<Info> to inputOrderBys : List<OrderBy> in class org.apache.phoenix.compile.OrderPreservingTracker | From | To | |
| Extract And Move Method | 4 | ||
| Extract And Move Method public convertGroupByExpressionToRowKeyColumnExpression(groupBy GroupBy, originalExpression Expression, groupByColumnIndex int) : RowKeyColumnExpression extracted from private wrapGroupByExpression(expression Expression) : Expression in class org.apache.phoenix.compile.ExpressionCompiler & moved to class org.apache.phoenix.util.ExpressionUtil | From | To | |
| Extract And Move Method public createByCheckIfOrderByReverse(expression Expression, isNullsLast boolean, isAscending boolean, orderByReverse boolean) : OrderByExpression extracted from public newIterator(context StatementContext, scanner ResultIterator, scan Scan, tableName String, plan QueryPlan) : PeekingResultIterator in class org.apache.phoenix.execute.AggregatePlan.OrderingResultIteratorFactory & moved to class org.apache.phoenix.expression.OrderByExpression | From | To | |
| Extract And Move Method public createByCheckIfExpressionSortOrderDesc(expression Expression, isNullsLast boolean, isAscending boolean) : OrderByExpression extracted from public compile(context StatementContext, statement SelectStatement, groupBy GroupBy, limit Integer, offset Integer, rowProjector RowProjector, tupleProjector TupleProjector, isInRowKeyOrder boolean, whereExpression Expression) : OrderBy in class org.apache.phoenix.compile.OrderByCompiler & moved to class org.apache.phoenix.expression.OrderByExpression | From | To | |
| Extract And Move Method public getExpression() : Expression extracted from public compile(context StatementContext, statement SelectStatement, groupBy GroupBy, limit Integer, offset Integer, rowProjector RowProjector, tupleProjector TupleProjector, isInRowKeyOrder boolean, whereExpression Expression) : OrderBy in class org.apache.phoenix.compile.OrderByCompiler & moved to class org.apache.phoenix.compile.OrderPreservingTracker.Info | From | To | |
| Rename Parameter | 5 | ||
| Rename Parameter node : ProjectedColumnExpression to projectedColumnExpression : ProjectedColumnExpression in method public visit(projectedColumnExpression ProjectedColumnExpression) : Info in class org.apache.phoenix.compile.OrderPreservingTracker.TrackOrderPreservingExpressionVisitor | From | To | |
| Rename Parameter node : RowKeyColumnExpression to rowKeyColumnExpression : RowKeyColumnExpression in method public visit(rowKeyColumnExpression RowKeyColumnExpression) : Info in class org.apache.phoenix.compile.OrderPreservingTracker.TrackOrderPreservingExpressionVisitor | From | To | |
| Rename Parameter node : Expression to expression : Expression in method private doTrack(expression Expression, isAscending Boolean, isNullsLast Boolean) : void in class org.apache.phoenix.compile.OrderPreservingTracker.TrackOrderByContext | From | To | |
| Rename Parameter tupleProjector : TupleProjector to innerQueryPlan : QueryPlan in method public compile(context StatementContext, innerQueryPlan QueryPlan, whereExpression Expression) : GroupBy in class org.apache.phoenix.compile.GroupByCompiler.GroupBy | From | To | |
| Rename Parameter node : Expression to expression : Expression in method public track(expression Expression) : void in class org.apache.phoenix.compile.OrderPreservingTracker | From | To |