pheonix ebebf58910ba03aaab9e515ddb0cd36ea469515d

ebebf58910ba03aaab9e515ddb0cd36ea469515d

Files Diff

Added: 2
Removed: 0
Renamed: 0
Modified: 23

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method public getProperties(fileName String) : Properties renamed to private loadProperties(fileName String) : Properties in class org.apache.phoenix.pherf.PherfConstants	From	To
Push Down Method	1
Push Down Method public read() : List<Result> from class org.apache.phoenix.pherf.result.impl.CSVResultHandler to public read() : List<Result> from class org.apache.phoenix.pherf.result.impl.CSVFileResultHandler	From	To
Pull Up Method	6
Pull Up Method public getResultFileDetails() : ResultFileDetails from class org.apache.phoenix.pherf.result.impl.ImageResultHandler to public getResultFileDetails() : ResultFileDetails from class org.apache.phoenix.pherf.result.impl.DefaultResultHandler	From	To
Pull Up Method public getResultFileDetails() : ResultFileDetails from class org.apache.phoenix.pherf.result.impl.CSVResultHandler to public getResultFileDetails() : ResultFileDetails from class org.apache.phoenix.pherf.result.impl.DefaultResultHandler	From	To
Pull Up Method public getResultFileDetails() : ResultFileDetails from class org.apache.phoenix.pherf.result.impl.XMLResultHandler to public getResultFileDetails() : ResultFileDetails from class org.apache.phoenix.pherf.result.impl.DefaultResultHandler	From	To
Pull Up Method public XMLResultHandler(resultFileName String, resultFileDetails ResultFileDetails, generateFullFileName boolean) from class org.apache.phoenix.pherf.result.impl.XMLResultHandler to public DefaultResultHandler() from class org.apache.phoenix.pherf.result.impl.DefaultResultHandler	From	To
Pull Up Method public CSVResultHandler(resultFileName String, resultFileDetails ResultFileDetails, generateFullFileName boolean) from class org.apache.phoenix.pherf.result.impl.CSVResultHandler to public DefaultResultHandler() from class org.apache.phoenix.pherf.result.impl.DefaultResultHandler	From	To
Pull Up Method public ImageResultHandler(resultFileName String, resultFileDetails ResultFileDetails, generateFullFileName boolean) from class org.apache.phoenix.pherf.result.impl.ImageResultHandler to public DefaultResultHandler() from class org.apache.phoenix.pherf.result.impl.DefaultResultHandler	From	To
Change Parameter Type	2
Change Parameter Type runMode : RunMode to details : ResultFileDetails in method public getCsvDetailedRepresentation(util ResultUtil, details ResultFileDetails) : List<List<ResultValue>> in class org.apache.phoenix.pherf.result.QueryResult	From	To
Change Parameter Type pool : ExecutorService to workloadExecutor : WorkloadExecutor in method public QueryExecutor(parser XMLConfigParser, util PhoenixUtil, workloadExecutor WorkloadExecutor) in class org.apache.phoenix.pherf.workload.QueryExecutor	From	To
Pull Up Attribute	6
Pull Up Attribute private resultFileDetails : ResultFileDetails from class org.apache.phoenix.pherf.result.impl.XMLResultHandler to protected resultFileDetails : ResultFileDetails from class org.apache.phoenix.pherf.result.impl.DefaultResultHandler	From	To
Pull Up Attribute private resultFileName : String from class org.apache.phoenix.pherf.result.impl.CSVResultHandler to protected resultFileName : String from class org.apache.phoenix.pherf.result.impl.DefaultResultHandler	From	To
Pull Up Attribute private resultFileName : String from class org.apache.phoenix.pherf.result.impl.XMLResultHandler to protected resultFileName : String from class org.apache.phoenix.pherf.result.impl.DefaultResultHandler	From	To
Pull Up Attribute private resultFileDetails : ResultFileDetails from class org.apache.phoenix.pherf.result.impl.CSVResultHandler to protected resultFileDetails : ResultFileDetails from class org.apache.phoenix.pherf.result.impl.DefaultResultHandler	From	To
Pull Up Attribute private resultFileName : String from class org.apache.phoenix.pherf.result.impl.ImageResultHandler to protected resultFileName : String from class org.apache.phoenix.pherf.result.impl.DefaultResultHandler	From	To
Pull Up Attribute private resultFileDetails : ResultFileDetails from class org.apache.phoenix.pherf.result.impl.ImageResultHandler to protected resultFileDetails : ResultFileDetails from class org.apache.phoenix.pherf.result.impl.DefaultResultHandler	From	To
Extract Superclass	1
Extract Superclass org.apache.phoenix.pherf.result.impl.DefaultResultHandler from classes [org.apache.phoenix.pherf.result.impl.CSVResultHandler, org.apache.phoenix.pherf.result.impl.ImageResultHandler, org.apache.phoenix.pherf.result.impl.XMLResultHandler]	From	To
Rename Attribute	2
Rename Attribute diff : boolean to isFunctional : boolean in class org.apache.phoenix.pherf.Pherf	From	To
Rename Attribute runMode : RunMode to workloadExecutor : WorkloadExecutor in class org.apache.phoenix.pherf.workload.QueryExecutor	From	To
Change Variable Type	1
Change Variable Type detailsCSVWriter : CSVResultHandler to detailsCSVWriter : CSVFileResultHandler in method public write(dataModelResults List<DataModelResult>) : void in class org.apache.phoenix.pherf.result.ResultManager	From	To
Extract Method	1
Extract Method private setUpDataModelResult() : DataModelResult extracted from public testResult() : void in class org.apache.phoenix.pherf.ResultTest	From	To
Change Attribute Type	1
Change Attribute Type runMode : RunMode to workloadExecutor : WorkloadExecutor in class org.apache.phoenix.pherf.workload.QueryExecutor	From	To
Rename Parameter	2
Rename Parameter runMode : RunMode to details : ResultFileDetails in method public getCsvDetailedRepresentation(util ResultUtil, details ResultFileDetails) : List<List<ResultValue>> in class org.apache.phoenix.pherf.result.QueryResult	From	To
Rename Parameter pool : ExecutorService to workloadExecutor : WorkloadExecutor in method public QueryExecutor(parser XMLConfigParser, util PhoenixUtil, workloadExecutor WorkloadExecutor) in class org.apache.phoenix.pherf.workload.QueryExecutor	From	To

ebebf58910ba03aaab9e515ddb0cd36ea469515d

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: