0a5b39b2fa5968d701f4df6e4b296525a419f40e
Files Diff
- Added: 53
- Removed: 2
- Renamed: 0
- Modified: 33
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 2 | ||
| Move And Rename Method public newMultiClassNameMatcher(classNameList String...) : Matcher from class com.navercorp.pinpoint.bootstrap.instrument.matcher.Matchers to public toInternalName(className String) : String from class com.navercorp.pinpoint.common.util.ClassUtils | From | To | |
| Move And Rename Method private transform0(classLoader ClassLoader, classInternalName String, classBeingRedefined Class<?>, protectionDomain ProtectionDomain, classFileBuffer byte[], transformer ClassFileTransformer) : byte[] from class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher to public transform(classLoader ClassLoader, classInternalName String, classBeingRedefined Class<?>, protectionDomain ProtectionDomain, classFileBuffer byte[], transformer ClassFileTransformer) : byte[] from class com.navercorp.pinpoint.profiler.BaseClassFileTransformer | From | To | |
| Change Parameter Type | 7 | ||
| Change Parameter Type classNameList : String... to className : String in method public toInternalName(className String) : String in class com.navercorp.pinpoint.common.util.ClassUtils | From | To | |
| Change Parameter Type transformTemplate : TransformTemplate to transformTemplate : MatchableTransformTemplate in method public setTransformTemplate(transformTemplate MatchableTransformTemplate) : void in class com.navercorp.pinpoint.plugin.vertx.VertxPlugin | From | To | |
| Change Parameter Type targetClassName : String to matcher : Matcher in method public addClassFileTransformer(matcher Matcher, transformCallback TransformCallback) : void in class com.navercorp.pinpoint.profiler.plugin.PluginInstrumentContext | From | To | |
| Change Parameter Type className : String to basePackageNames : List<String> in method private addHandlerInterceptor(basePackageNames List<String>) : void in class com.navercorp.pinpoint.plugin.vertx.VertxPlugin | From | To | |
| Change Parameter Type targetClassName : String to matcher : Matcher in method public addClassFileTransformer(matcher Matcher, transformCallback TransformCallback) : void in class com.navercorp.pinpoint.bootstrap.instrument.InstrumentContext | From | To | |
| Change Parameter Type targetClassName : String to matcher : Matcher in method public addClassFileTransformer(matcher Matcher, transformCallback TransformCallback) : void in class com.navercorp.pinpoint.profiler.instrument.GuardInstrumentContext | From | To | |
| Change Parameter Type targetClassName : String to matcher : Matcher in method public addClassFileTransformer(instrumentContext InstrumentContext, matcher Matcher, transformCallback TransformCallback) : void in class com.navercorp.pinpoint.profiler.plugin.ClassFileTransformerLoader | From | To | |
| Move Method | 2 | ||
| Move Method private getContextClassLoader(thread Thread) : ClassLoader from class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher to private getContextClassLoader(thread Thread) : ClassLoader from class com.navercorp.pinpoint.profiler.BaseClassFileTransformer | From | To | |
| Move Method public testDoFilter_ClassLoader() : void from class com.navercorp.pinpoint.profiler.PinpointClassFilterTest to public testDoFilter_ClassLoader() : void from class com.navercorp.pinpoint.profiler.PinpointClassLoaderFilterTest | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private annotationInternalNames : List<String> from class com.navercorp.pinpoint.profiler.instrument.classreading.AnnotationMetadataVisitor to private annotationInternalNames : List<String> from class com.navercorp.pinpoint.profiler.instrument.classreading.ClassReaderWrapper | From | To | |
| Move Attribute private agentLoader : ClassLoader from class com.navercorp.pinpoint.profiler.PinpointClassFilter to private agentLoader : ClassLoader from class com.navercorp.pinpoint.profiler.PinpointClassLoaderFilter | From | To | |
| Extract Class | 1 | ||
| Extract Class com.navercorp.pinpoint.profiler.BaseClassFileTransformer from class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class com.navercorp.pinpoint.profiler.instrument.classreading.AnnotationMetadataVisitorTest.HasAnnotation moved and renamed to com.navercorp.pinpoint.profiler.instrument.transformer.DefaultTransformerMatcherTest.HasMetaMetaAnnotation | From | To | |
| Move Class | 1 | ||
| Move Class com.navercorp.pinpoint.profiler.instrument.classreading.AnnotationMetadataVisitorTest.HasMetaAnnotation moved to com.navercorp.pinpoint.profiler.instrument.transformer.DefaultTransformerMatcherTest.HasMetaAnnotation | From | To | |
| Extract Variable | 1 | ||
| Extract Variable internalName : String in method public transform(classLoader ClassLoader, classInternalName String, classBeingRedefined Class<?>, protectionDomain ProtectionDomain, classFileBuffer byte[]) : byte[] from class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type classNameTrim : String to basePackageNames : List<String> in method public setup(context ProfilerPluginSetupContext) : void in class com.navercorp.pinpoint.plugin.vertx.VertxPlugin | From | To | |
| Rename Method | 1 | ||
| Rename Method public getHandlerClassNames() : List<String> renamed to public getHandlerBasePackageNames() : List<String> in class com.navercorp.pinpoint.plugin.vertx.VertxConfig | From | To | |
| Rename Variable | 2 | ||
| Rename Variable builder : StringBuilder to sb : StringBuilder in method public toString() : String in class com.navercorp.pinpoint.bootstrap.config.DefaultProfilerConfig | From | To | |
| Rename Variable classNameTrim : String to basePackageNames : List<String> in method public setup(context ProfilerPluginSetupContext) : void in class com.navercorp.pinpoint.plugin.vertx.VertxPlugin | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Matcher to String in method public toInternalName(className String) : String in class com.navercorp.pinpoint.common.util.ClassUtils | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute handlerClassNames : List<String> to handlerBasePackageNames : List<String> in class com.navercorp.pinpoint.plugin.vertx.VertxConfig | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type transformTemplate : TransformTemplate to transformTemplate : MatchableTransformTemplate in class com.navercorp.pinpoint.plugin.vertx.VertxPlugin | From | To | |
| Rename Parameter | 8 | ||
| Rename Parameter targetClassName : String to matcher : Matcher in method public addClassFileTransformer(matcher Matcher, transformCallback TransformCallback) : void in class com.navercorp.pinpoint.profiler.plugin.PluginInstrumentContext | From | To | |
| Rename Parameter className : String to basePackageNames : List<String> in method private addHandlerInterceptor(basePackageNames List<String>) : void in class com.navercorp.pinpoint.plugin.vertx.VertxPlugin | From | To | |
| Rename Parameter className : String to classInternalName : String in method public findTransformer(classLoader ClassLoader, classInternalName String, classFileBuffer byte[], classMetadata InternalClassMetadata) : ClassFileTransformer in class com.navercorp.pinpoint.profiler.instrument.transformer.TransformerRegistry | From | To | |
| Rename Parameter targetClassName : String to matcher : Matcher in method public addClassFileTransformer(matcher Matcher, transformCallback TransformCallback) : void in class com.navercorp.pinpoint.bootstrap.instrument.InstrumentContext | From | To | |
| Rename Parameter targetClassName : String to matcher : Matcher in method public addClassFileTransformer(matcher Matcher, transformCallback TransformCallback) : void in class com.navercorp.pinpoint.profiler.instrument.GuardInstrumentContext | From | To | |
| Rename Parameter targetClassName : String to matcher : Matcher in method public addClassFileTransformer(instrumentContext InstrumentContext, matcher Matcher, transformCallback TransformCallback) : void in class com.navercorp.pinpoint.profiler.plugin.ClassFileTransformerLoader | From | To | |
| Rename Parameter className : String to classInternalName : String in method public findTransformer(classLoader ClassLoader, classInternalName String, classFileBuffer byte[], classMetadata InternalClassMetadata) : ClassFileTransformer in class com.navercorp.pinpoint.profiler.instrument.transformer.DefaultTransformerRegistry | From | To | |
| Rename Parameter classNameList : String... to className : String in method public toInternalName(className String) : String in class com.navercorp.pinpoint.common.util.ClassUtils | From | To |