13f28b4a00858246f14880da10f424a0a1b583d6
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 10
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 7 | ||
Rename Method public changeClosed(before int) : boolean renamed to public changeToClosed(before int) : boolean in class com.navercorp.pinpoint.rpc.client.State | From | To | |
Rename Method public changeRunDuplexCommunication() : boolean renamed to public changeToRunDuplexCommunication() : boolean in class com.navercorp.pinpoint.rpc.client.State | From | To | |
Rename Method public changeRun() : boolean renamed to public changeToRun() : boolean in class com.navercorp.pinpoint.rpc.client.State | From | To | |
Rename Method private setSessionState(state PinpointServerSocketStateCode) : boolean renamed to private changeState0(nextState PinpointServerSocketStateCode, skipLogicStateList List<PinpointServerSocketStateCode>, throwException boolean) : PinpointServerSocketStateCode in class com.navercorp.pinpoint.rpc.server.PinpointServerSocketState | From | To | |
Rename Method private closeChannel(channel Channel) : void renamed to private handleClosePacket(channel Channel) : void in class com.navercorp.pinpoint.rpc.server.PinpointServerSocket | From | To | |
Rename Method public changeRunSimplexCommunication() : boolean renamed to public changeToRunSimplexCommunication() : boolean in class com.navercorp.pinpoint.rpc.client.State | From | To | |
Rename Method public changeClosed() : boolean renamed to public changeToClosed() : boolean in class com.navercorp.pinpoint.rpc.client.State | From | To | |
Rename Variable | 3 | ||
Rename Variable currentStateCode : PinpointServerSocketStateCode to currentState : PinpointServerSocketStateCode in method private isExpectedShutdown(channelContext ChannelContext) : boolean in class com.navercorp.pinpoint.rpc.server.PinpointServerSocket | From | To | |
Rename Variable check : boolean to isIgnore : boolean in method public channelConnected(ctx ChannelHandlerContext, e ChannelStateEvent) : void in class com.navercorp.pinpoint.rpc.server.PinpointServerSocket | From | To | |
Rename Variable check : boolean to isIgnore : boolean in method public channelDisconnected(ctx ChannelHandlerContext, e ChannelStateEvent) : void in class com.navercorp.pinpoint.rpc.server.PinpointServerSocket | From | To | |
Change Return Type | 1 | ||
Change Return Type boolean to PinpointServerSocketStateCode in method private changeState0(nextState PinpointServerSocketStateCode, skipLogicStateList List<PinpointServerSocketStateCode>, throwException boolean) : PinpointServerSocketStateCode in class com.navercorp.pinpoint.rpc.server.PinpointServerSocketState | From | To | |
Extract Method | 1 | ||
Extract Method private isExpectedShutdown(channelContext ChannelContext) : boolean extracted from public channelDisconnected(ctx ChannelHandlerContext, e ChannelStateEvent) : void in class com.navercorp.pinpoint.rpc.server.PinpointServerSocket | From | To | |
Rename Parameter | 1 | ||
Rename Parameter state : PinpointServerSocketStateCode to nextState : PinpointServerSocketStateCode in method private changeState0(nextState PinpointServerSocketStateCode, skipLogicStateList List<PinpointServerSocketStateCode>, throwException boolean) : PinpointServerSocketStateCode in class com.navercorp.pinpoint.rpc.server.PinpointServerSocketState | From | To |