21af2851b82266e94cd2e2e942a8792443939aa0
Files Diff
- Added: 6
- Removed: 3
- Renamed: 0
- Modified: 34
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 4 | ||
Rename Method private writeHeaderData(data Map<String,String>) : void renamed to private writeHeaderEntity() : void in class com.navercorp.pinpoint.io.header.ByteArrayHeaderWriter | From | To | |
Rename Method private replaceDataInsendAgentStatService() : void renamed to private replaceDataInSendAgentStatService() : void in class com.navercorp.pinpoint.collector.cluster.flink.TcpDataSenderRepository | From | To | |
Rename Method public replaceFlinkServerList(flinkServerList List<TcpDataSender>) : void renamed to public replaceFlinkTcpDataSenderList(flinkTcpDataSenderList List<FlinkTcpDataSender>) : void in class com.navercorp.pinpoint.collector.service.SendAgentStatService | From | To | |
Rename Method public getTcpDataSender() : TcpDataSender renamed to public getFlinkTcpDataSender() : FlinkTcpDataSender in class com.navercorp.pinpoint.collector.cluster.flink.SenderContext | From | To | |
Move And Inline Method | 1 | ||
Move And Inline Method private readHeader() : Header moved from class com.navercorp.pinpoint.thrift.io.HeaderTBaseDeserializer to class com.navercorp.pinpoint.thrift.io.ChunkHeaderTBaseDeserializer & inlined to private readInternal() : Message<TBase<?,?>> | From | To | |
Change Parameter Type | 6 | ||
Change Parameter Type sourceContext : SourceContext<ServerRequest> to sourceContext : SourceContext<RawData> in method public setStatHandlerTcpDispatchHandler(sourceContext SourceContext<RawData>) : void in class com.navercorp.pinpoint.flink.Bootstrap | From | To | |
Change Parameter Type ctx : SourceContext<ServerRequest> to ctx : SourceContext<RawData> in method public run(ctx SourceContext<RawData>) : void in class com.navercorp.pinpoint.flink.receiver.TcpSourceFunction | From | To | |
Change Parameter Type serverRequest : ServerRequest to rawData : RawData in method public flatMap(rawData RawData, out Collector<Tuple3<String,JoinStatBo,Long>>) : void in class com.navercorp.pinpoint.flink.process.TBaseFlatMapper | From | To | |
Change Parameter Type flinkHeaderTBaseSerializerFactory : FlinkHeaderTBaseSerializerFactory to flinkHeaderTBaseSerializerFactory : HeaderTBaseSerializerFactory in method public FlinkPacketHandlerFactory(flinkHeaderTBaseSerializerFactory HeaderTBaseSerializerFactory, flinkHeaderTBaseDeserializerFactory FlinkHeaderTBaseDeserializerFactory) in class com.navercorp.pinpoint.flink.receiver.FlinkPacketHandlerFactory | From | To | |
Change Parameter Type tcpDataSender : TcpDataSender to tcpDataSender : FlinkTcpDataSender in method public SenderContext(tcpDataSender FlinkTcpDataSender) in class com.navercorp.pinpoint.collector.cluster.flink.SenderContext | From | To | |
Change Parameter Type flinkServerList : List<TcpDataSender> to flinkTcpDataSenderList : List<FlinkTcpDataSender> in method public replaceFlinkTcpDataSenderList(flinkTcpDataSenderList List<FlinkTcpDataSender>) : void in class com.navercorp.pinpoint.collector.service.SendAgentStatService | From | To | |
Move Method | 3 | ||
Move Method private createHeader(type short) : Header from class com.navercorp.pinpoint.thrift.io.FlinkTBaseLocator to private createHeader(type short) : Header from class com.navercorp.pinpoint.thrift.io.FlinkTBaseLocator.FlinkHeaderFactory | From | To | |
Move Method private createHeaderV2(type short) : Header from class com.navercorp.pinpoint.thrift.io.FlinkTBaseLocator to private createHeaderV2(type short) : Header from class com.navercorp.pinpoint.thrift.io.FlinkTBaseLocator.FlinkHeaderFactory | From | To | |
Move Method private createHeaderV1(type short) : Header from class com.navercorp.pinpoint.thrift.io.FlinkTBaseLocator to private createHeaderV1(type short) : Header from class com.navercorp.pinpoint.thrift.io.FlinkTBaseLocator.FlinkHeaderFactory | From | To | |
Inline Method | 4 | ||
Inline Method private createHeaderV2(signature byte, version byte) : HeaderV2 inlined to public readHeader() : Header in class com.navercorp.pinpoint.io.header.ByteArrayHeaderReader | From | To | |
Inline Method private createHeaderV1(signature byte, version byte) : HeaderV1 inlined to public readHeader() : Header in class com.navercorp.pinpoint.io.header.ByteArrayHeaderReader | From | To | |
Inline Method private readHeader() : Header inlined to private readInternal() : Message<TBase<?,?>> in class com.navercorp.pinpoint.thrift.io.HeaderTBaseDeserializer | From | To | |
Rename Variable | 8 | ||
Rename Variable request : ServerRequest<TBase<?,?>> to rawData : RawData in method public flatMap4Test() : void in class com.navercorp.pinpoint.flink.process.TBaseFlatMapperTest | From | To | |
Rename Variable request : ServerRequest<TBase<?,?>> to rawData : RawData in method public flatMap3Test() : void in class com.navercorp.pinpoint.flink.process.TBaseFlatMapperTest | From | To | |
Rename Variable data : Map<String,String> to headerEntityData : Map<String,String> in method private writeHeaderEntity() : void in class com.navercorp.pinpoint.io.header.ByteArrayHeaderWriter | From | To | |
Rename Variable request : ServerRequest<TBase<?,?>> to rawdata : RawData in method public flatMap2Test() : void in class com.navercorp.pinpoint.flink.process.TBaseFlatMapperTest | From | To | |
Rename Variable data : Object to tBase : TBase<?,?> in method public handleSimple(serverRequest ServerRequest) : void in class com.navercorp.pinpoint.flink.receiver.AgentStatHandler | From | To | |
Rename Variable copiedServerRequest : ServerRequest<TBase<?,?>> to rawData : RawData in method public handleSimple(serverRequest ServerRequest) : void in class com.navercorp.pinpoint.flink.receiver.AgentStatHandler | From | To | |
Rename Variable request : ServerRequest<TBase<?,?>> to rawData : RawData in method public flatMapTest() : void in class com.navercorp.pinpoint.flink.process.TBaseFlatMapperTest | From | To | |
Rename Variable request : ServerRequest<TBase<?,?>> to rawData : RawData in method public flatMap5Test() : void in class com.navercorp.pinpoint.flink.process.TBaseFlatMapperTest | From | To | |
Change Return Type | 3 | ||
Change Return Type HeaderTBaseSerializer to FlinkHeaderTBaseSerializer in method public createSerializer() : FlinkHeaderTBaseSerializer in class com.navercorp.pinpoint.thrift.io.FlinkHeaderTBaseSerializerFactory | From | To | |
Change Return Type TcpDataSender to FlinkTcpDataSender in method public getFlinkTcpDataSender() : FlinkTcpDataSender in class com.navercorp.pinpoint.collector.cluster.flink.SenderContext | From | To | |
Change Return Type TcpDataSender to FlinkTcpDataSender in method private roundRobinTcpDataSender() : FlinkTcpDataSender in class com.navercorp.pinpoint.collector.service.SendAgentStatService | From | To | |
Rename Attribute | 4 | ||
Rename Attribute flinkServerList : List<TcpDataSender> to flinkTcpDataSenderList : List<FlinkTcpDataSender> in class com.navercorp.pinpoint.collector.service.SendAgentStatService | From | To | |
Rename Attribute HEADER_DATA_MAX_SIZE : int to HEADER_ENTITY_COUNT_MAX_SIZE : int in class com.navercorp.pinpoint.io.header.v2.HeaderV2 | From | To | |
Rename Attribute tcpDataSender : TcpDataSender to flinkTcpDataSender : FlinkTcpDataSender in class com.navercorp.pinpoint.collector.cluster.flink.SenderContext | From | To | |
Rename Attribute HEADER_DATA_STRING_MAX_LANGTH : int to HEADER_ENTITY_STRING_MAX_LANGTH : int in class com.navercorp.pinpoint.io.header.v2.HeaderV2 | From | To | |
Change Variable Type | 11 | ||
Change Variable Type request : ServerRequest<TBase<?,?>> to rawData : RawData in method public flatMapTest() : void in class com.navercorp.pinpoint.flink.process.TBaseFlatMapperTest | From | To | |
Change Variable Type copiedServerRequest : ServerRequest<TBase<?,?>> to rawData : RawData in method public handleSimple(serverRequest ServerRequest) : void in class com.navercorp.pinpoint.flink.receiver.AgentStatHandler | From | To | |
Change Variable Type request : ServerRequest<TBase<?,?>> to rawData : RawData in method public flatMap5Test() : void in class com.navercorp.pinpoint.flink.process.TBaseFlatMapperTest | From | To | |
Change Variable Type request : ServerRequest<TBase<?,?>> to rawData : RawData in method public flatMap4Test() : void in class com.navercorp.pinpoint.flink.process.TBaseFlatMapperTest | From | To | |
Change Variable Type rawData : DataStreamSource<ServerRequest> to rawData : DataStreamSource<RawData> in method public start() : void in class com.navercorp.pinpoint.flink.StatStreamingVer2Job | From | To | |
Change Variable Type request : ServerRequest<TBase<?,?>> to rawData : RawData in method public flatMap3Test() : void in class com.navercorp.pinpoint.flink.process.TBaseFlatMapperTest | From | To | |
Change Variable Type tcpDataSenderList : List<TcpDataSender> to tcpDataSenderList : List<FlinkTcpDataSender> in method private replaceDataInSendAgentStatService() : void in class com.navercorp.pinpoint.collector.cluster.flink.TcpDataSenderRepository | From | To | |
Change Variable Type serializer : HeaderTBaseSerializer to serializer : FlinkHeaderTBaseSerializer in method private createTcpDataSender(address Address) : SenderContext in class com.navercorp.pinpoint.collector.cluster.flink.FlinkClusterConnectionManager | From | To | |
Change Variable Type request : ServerRequest<TBase<?,?>> to rawdata : RawData in method public flatMap2Test() : void in class com.navercorp.pinpoint.flink.process.TBaseFlatMapperTest | From | To | |
Change Variable Type data : Object to tBase : TBase<?,?> in method public handleSimple(serverRequest ServerRequest) : void in class com.navercorp.pinpoint.flink.receiver.AgentStatHandler | From | To | |
Change Variable Type tcpDataSender : TcpDataSender to tcpDataSender : FlinkTcpDataSender in method public save(agentStatBo AgentStatBo) : void in class com.navercorp.pinpoint.collector.service.SendAgentStatService | From | To | |
Extract Method | 1 | ||
Extract Method public createResettableByteArrayOutputStream() : ResettableByteArrayOutputStream extracted from public createSerializer() : HeaderTBaseSerializer in class com.navercorp.pinpoint.thrift.io.HeaderTBaseSerializerFactory | From | To | |
Change Attribute Type | 3 | ||
Change Attribute Type flinkServerList : List<TcpDataSender> to flinkTcpDataSenderList : List<FlinkTcpDataSender> in class com.navercorp.pinpoint.collector.service.SendAgentStatService | From | To | |
Change Attribute Type flinkHeaderTBaseSerializerFactory : SerializerFactory<HeaderTBaseSerializer> to flinkHeaderTBaseSerializerFactory : FlinkHeaderTBaseSerializerFactory in class com.navercorp.pinpoint.collector.cluster.flink.FlinkClusterConnectionManager | From | To | |
Change Attribute Type tcpDataSender : TcpDataSender to flinkTcpDataSender : FlinkTcpDataSender in class com.navercorp.pinpoint.collector.cluster.flink.SenderContext | From | To | |
Rename Parameter | 2 | ||
Rename Parameter serverRequest : ServerRequest to rawData : RawData in method public flatMap(rawData RawData, out Collector<Tuple3<String,JoinStatBo,Long>>) : void in class com.navercorp.pinpoint.flink.process.TBaseFlatMapper | From | To | |
Rename Parameter flinkServerList : List<TcpDataSender> to flinkTcpDataSenderList : List<FlinkTcpDataSender> in method public replaceFlinkTcpDataSenderList(flinkTcpDataSenderList List<FlinkTcpDataSender>) : void in class com.navercorp.pinpoint.collector.service.SendAgentStatService | From | To |