pinpoint 2e7748c4ffdf3bf12394d873ae799a0e56f8e6a1

2e7748c4ffdf3bf12394d873ae799a0e56f8e6a1

Files Diff

Added: 16
Removed: 6
Renamed: 0
Modified: 11

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	1
Move And Rename Method private addNextNode(sourceApplication Application) : void from class com.navercorp.pinpoint.web.service.map.BFSLinkSelectorV2 to public addNextApplication(application Application) : void from class com.navercorp.pinpoint.web.service.map.LinkSelectContext	From	To
Change Parameter Type	3
Change Parameter Type application : Application to linkDataMap : LinkDataMap in method public replaceRpcCalls(linkDataMap LinkDataMap, range Range) : LinkDataMap in class com.navercorp.pinpoint.web.service.map.RpcCallReplacer	From	To
Change Parameter Type virtualLinkHandler : VirtualLinkHandler to virtualLinkProcessor : VirtualLinkProcessor in method package BFSLinkSelectorV2(applicationsMapCreator ApplicationsMapCreator, virtualLinkProcessor VirtualLinkProcessor, serverMapDataFilter ServerMapDataFilter) in class com.navercorp.pinpoint.web.service.map.BFSLinkSelectorV2	From	To
Change Parameter Type linkDataMapCreator : LinkDataMapCreator to applicationsMapCreator : ApplicationsMapCreator in method package BFSLinkSelectorV2(applicationsMapCreator ApplicationsMapCreator, virtualLinkProcessor VirtualLinkProcessor, serverMapDataFilter ServerMapDataFilter) in class com.navercorp.pinpoint.web.service.map.BFSLinkSelectorV2	From	To
Move Method	4
Move Method public createVirtualLinkData(linkData LinkData, toApplication Application, acceptApplicationList Set<AcceptApplication>) : List<LinkData> from class com.navercorp.pinpoint.web.service.map.VirtualLinkHandler to public createVirtualLinkData(linkData LinkData, toApplication Application, acceptApplicationList Set<AcceptApplication>) : List<LinkData> from class com.navercorp.pinpoint.web.service.map.VirtualLinkMarker	From	To
Move Method private markVirtualLinkData(virtualLinkData LinkData) : void from class com.navercorp.pinpoint.web.service.map.VirtualLinkHandler to private markVirtualLinkData(virtualLinkData LinkData) : void from class com.navercorp.pinpoint.web.service.map.VirtualLinkMarker	From	To
Move Method private checkNextCallee(targetApplication Application, depth SearchDepth) : boolean from class com.navercorp.pinpoint.web.service.map.BFSLinkSelectorV2 to public checkNextCallee(application Application) : boolean from class com.navercorp.pinpoint.web.service.map.LinkSelectContext	From	To
Move Method private checkNextCaller(targetApplication Application, depth SearchDepth) : boolean from class com.navercorp.pinpoint.web.service.map.BFSLinkSelectorV2 to public checkNextCaller(application Application) : boolean from class com.navercorp.pinpoint.web.service.map.LinkSelectContext	From	To
Pull Up Attribute	4
Pull Up Attribute private serverInfoAppender : ServerInfoAppender from class com.navercorp.pinpoint.web.applicationmap.appender.server.SerialServerInfoAppenderTest to private serverInfoAppender : ServerInfoAppender from class com.navercorp.pinpoint.web.applicationmap.appender.server.ServerInfoAppenderTestBase	From	To
Pull Up Attribute private nodeHistogramDataSource : NodeHistogramDataSource from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.SerialNodeHistogramAppenderTest to private nodeHistogramDataSource : NodeHistogramDataSource from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.NodeHistogramAppenderTestBase	From	To
Pull Up Attribute private nodeHistogramAppender : NodeHistogramAppender from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.SerialNodeHistogramAppenderTest to private nodeHistogramAppender : NodeHistogramAppender from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.NodeHistogramAppenderTestBase	From	To
Pull Up Attribute private serverInstanceListDataSource : ServerInstanceListDataSource from class com.navercorp.pinpoint.web.applicationmap.appender.server.SerialServerInfoAppenderTest to private serverInstanceListDataSource : ServerInstanceListDataSource from class com.navercorp.pinpoint.web.applicationmap.appender.server.ServerInfoAppenderTestBase	From	To
Move Attribute	1
Move Attribute private virtualLinkDataMarker : Set<LinkData> from class com.navercorp.pinpoint.web.service.map.VirtualLinkHandler to private virtualLinkDataMarker : Set<LinkData> from class com.navercorp.pinpoint.web.service.map.VirtualLinkMarker	From	To
Extract Class	1
Extract Class com.navercorp.pinpoint.web.service.map.VirtualLinkMarker from class com.navercorp.pinpoint.web.service.map.VirtualLinkHandler	From	To
Rename Class	3
Rename Class com.navercorp.pinpoint.web.service.map.VirtualLinkHandler renamed to com.navercorp.pinpoint.web.service.map.VirtualLinkProcessor	From	To
Rename Class com.navercorp.pinpoint.web.service.map.DefaultLinkDataMapCreator renamed to com.navercorp.pinpoint.web.service.map.RpcCallReplacer	From	To
Rename Class com.navercorp.pinpoint.web.service.map.LinkDataMapCreator renamed to com.navercorp.pinpoint.web.service.map.ApplicationsMapCreator	From	To
Rename Method	1
Rename Method public createCallerLinkDataMap(application Application, range Range) : LinkDataMap renamed to public replaceRpcCalls(linkDataMap LinkDataMap, range Range) : LinkDataMap in class com.navercorp.pinpoint.web.service.map.RpcCallReplacer	From	To
Pull Up Method	18
Pull Up Method public terminalNodes() : void from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.SerialNodeHistogramAppenderTest to public terminalNodes() : void from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.NodeHistogramAppenderTestBase	From	To
Pull Up Method public wasNode() : void from class com.navercorp.pinpoint.web.applicationmap.appender.server.SerialServerInfoAppenderTest to public wasNode() : void from class com.navercorp.pinpoint.web.applicationmap.appender.server.ServerInfoAppenderTestBase	From	To
Pull Up Method public wasNodes() : void from class com.navercorp.pinpoint.web.applicationmap.appender.server.SerialServerInfoAppenderTest to public wasNodes() : void from class com.navercorp.pinpoint.web.applicationmap.appender.server.ServerInfoAppenderTestBase	From	To
Pull Up Method public userNode() : void from class com.navercorp.pinpoint.web.applicationmap.appender.server.SerialServerInfoAppenderTest to public userNode() : void from class com.navercorp.pinpoint.web.applicationmap.appender.server.ServerInfoAppenderTestBase	From	To
Pull Up Method public emptyNodeList() : void from class com.navercorp.pinpoint.web.applicationmap.appender.server.SerialServerInfoAppenderTest to public emptyNodeList() : void from class com.navercorp.pinpoint.web.applicationmap.appender.server.ServerInfoAppenderTestBase	From	To
Pull Up Method public terminalNode_multiple() : void from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.SerialNodeHistogramAppenderTest to public terminalNode_multiple() : void from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.NodeHistogramAppenderTestBase	From	To
Pull Up Method public terminalNode_multipleInstances() : void from class com.navercorp.pinpoint.web.applicationmap.appender.server.SerialServerInfoAppenderTest to public terminalNode_multipleInstances() : void from class com.navercorp.pinpoint.web.applicationmap.appender.server.ServerInfoAppenderTestBase	From	To
Pull Up Method public wasNode() : void from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.SerialNodeHistogramAppenderTest to public wasNode() : void from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.NodeHistogramAppenderTestBase	From	To
Pull Up Method public setUp() : void from class com.navercorp.pinpoint.web.applicationmap.appender.server.SerialServerInfoAppenderTest to public setUp() : void from class com.navercorp.pinpoint.web.applicationmap.appender.server.ServerInfoAppenderTestBase	From	To
Pull Up Method private createLinkCallDataMap(fromAgentId String, fromAgentServiceType ServiceType, toAgentId String, toAgentServiceType ServiceType, slot HistogramSlot, callCount long) : LinkCallDataMap from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.SerialNodeHistogramAppenderTest to private createLinkCallDataMap(fromAgentId String, fromAgentServiceType ServiceType, toAgentId String, toAgentServiceType ServiceType, slot HistogramSlot, callCount long) : LinkCallDataMap from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.NodeHistogramAppenderTestBase	From	To
Pull Up Method public setUp() : void from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.SerialNodeHistogramAppenderTest to public setUp() : void from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.NodeHistogramAppenderTestBase	From	To
Pull Up Method public userNode() : void from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.SerialNodeHistogramAppenderTest to public userNode() : void from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.NodeHistogramAppenderTestBase	From	To
Pull Up Method public nullNodeList() : void from class com.navercorp.pinpoint.web.applicationmap.appender.server.SerialServerInfoAppenderTest to public nullNodeList() : void from class com.navercorp.pinpoint.web.applicationmap.appender.server.ServerInfoAppenderTestBase	From	To
Pull Up Method public emptyNodeList() : void from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.SerialNodeHistogramAppenderTest to public emptyNodeList() : void from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.NodeHistogramAppenderTestBase	From	To
Pull Up Method public terminalNode() : void from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.SerialNodeHistogramAppenderTest to public terminalNode() : void from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.NodeHistogramAppenderTestBase	From	To
Pull Up Method public terminalNode() : void from class com.navercorp.pinpoint.web.applicationmap.appender.server.SerialServerInfoAppenderTest to public terminalNode() : void from class com.navercorp.pinpoint.web.applicationmap.appender.server.ServerInfoAppenderTestBase	From	To
Pull Up Method public unknownNode() : void from class com.navercorp.pinpoint.web.applicationmap.appender.server.SerialServerInfoAppenderTest to public unknownNode() : void from class com.navercorp.pinpoint.web.applicationmap.appender.server.ServerInfoAppenderTestBase	From	To
Pull Up Method private createNode(applicationName String, serviceType ServiceType) : Node from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.SerialNodeHistogramAppenderTest to private createNode(applicationName String, serviceType ServiceType) : Node from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.NodeHistogramAppenderTestBase	From	To
Rename Variable	2
Rename Variable callerLinkData : LinkData to linkData : LinkData in method public replaceRpcCalls(linkDataMap LinkDataMap, range Range) : LinkDataMap in class com.navercorp.pinpoint.web.service.map.RpcCallReplacer	From	To
Rename Variable replacedDataMap : LinkDataMap to replacedLinkDataMap : LinkDataMap in method public replaceRpcCalls(linkDataMap LinkDataMap, range Range) : LinkDataMap in class com.navercorp.pinpoint.web.service.map.RpcCallReplacer	From	To
Parameterize Variable	1
Parameterize Variable caller : LinkDataMap to linkDataMap : LinkDataMap in method public replaceRpcCalls(linkDataMap LinkDataMap, range Range) : LinkDataMap in class com.navercorp.pinpoint.web.service.map.RpcCallReplacer	From	To
Extract Superclass	2
Extract Superclass com.navercorp.pinpoint.web.applicationmap.appender.histogram.NodeHistogramAppenderTestBase from classes [com.navercorp.pinpoint.web.applicationmap.appender.histogram.SerialNodeHistogramAppenderTest]	From	To
Extract Superclass com.navercorp.pinpoint.web.applicationmap.appender.server.ServerInfoAppenderTestBase from classes [com.navercorp.pinpoint.web.applicationmap.appender.server.SerialServerInfoAppenderTest]	From	To
Rename Attribute	3
Rename Attribute linkDataMapCreator : LinkDataMapCreator to applicationsMapCreator : ApplicationsMapCreator in class com.navercorp.pinpoint.web.service.map.BFSLinkSelectorV2	From	To
Rename Attribute virtualLinkHandler : VirtualLinkHandler to virtualLinkMarker : VirtualLinkMarker in class com.navercorp.pinpoint.web.service.map.RpcCallReplacer	From	To
Rename Attribute virtualLinkHandler : VirtualLinkHandler to virtualLinkProcessor : VirtualLinkProcessor in class com.navercorp.pinpoint.web.service.map.BFSLinkSelectorV2	From	To
Change Attribute Type	3
Change Attribute Type linkDataMapCreator : LinkDataMapCreator to applicationsMapCreator : ApplicationsMapCreator in class com.navercorp.pinpoint.web.service.map.BFSLinkSelectorV2	From	To
Change Attribute Type virtualLinkHandler : VirtualLinkHandler to virtualLinkMarker : VirtualLinkMarker in class com.navercorp.pinpoint.web.service.map.RpcCallReplacer	From	To
Change Attribute Type virtualLinkHandler : VirtualLinkHandler to virtualLinkProcessor : VirtualLinkProcessor in class com.navercorp.pinpoint.web.service.map.BFSLinkSelectorV2	From	To
Extract And Move Method	1
Extract And Move Method protected createLinkSelectorFactory(linkDataMapService LinkDataMapService, hostApplicationMapDao HostApplicationMapDao) : LinkSelectorFactory extracted from public setUp() : void in class com.navercorp.pinpoint.web.service.map.LinkSelectorTestBase & moved to class com.navercorp.pinpoint.web.service.map.BFSLinkSelectorTest	From	To
Rename Parameter	6
Rename Parameter targetApplication : Application to application : Application in method public checkNextCallee(application Application) : boolean in class com.navercorp.pinpoint.web.service.map.LinkSelectContext	From	To
Rename Parameter targetApplication : Application to application : Application in method public checkNextCaller(application Application) : boolean in class com.navercorp.pinpoint.web.service.map.LinkSelectContext	From	To
Rename Parameter application : Application to linkDataMap : LinkDataMap in method public replaceRpcCalls(linkDataMap LinkDataMap, range Range) : LinkDataMap in class com.navercorp.pinpoint.web.service.map.RpcCallReplacer	From	To
Rename Parameter virtualLinkHandler : VirtualLinkHandler to virtualLinkProcessor : VirtualLinkProcessor in method package BFSLinkSelectorV2(applicationsMapCreator ApplicationsMapCreator, virtualLinkProcessor VirtualLinkProcessor, serverMapDataFilter ServerMapDataFilter) in class com.navercorp.pinpoint.web.service.map.BFSLinkSelectorV2	From	To
Rename Parameter linkDataMapCreator : LinkDataMapCreator to applicationsMapCreator : ApplicationsMapCreator in method package BFSLinkSelectorV2(applicationsMapCreator ApplicationsMapCreator, virtualLinkProcessor VirtualLinkProcessor, serverMapDataFilter ServerMapDataFilter) in class com.navercorp.pinpoint.web.service.map.BFSLinkSelectorV2	From	To
Rename Parameter sourceApplication : Application to application : Application in method public addNextApplication(application Application) : void in class com.navercorp.pinpoint.web.service.map.LinkSelectContext	From	To

2e7748c4ffdf3bf12394d873ae799a0e56f8e6a1

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: