pinpoint 341caecbb19cacf98c46991a2be9a9f340c85657

341caecbb19cacf98c46991a2be9a9f340c85657

Files Diff

Added: 33
Removed: 6
Renamed: 0
Modified: 9

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Push Down Method	21
Push Down Method public appendAgentInfo(nodeList NodeList, linkDataDuplexMap LinkDataDuplexMap, agentInfoPopulator AgentInfoPopulator) : void from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to public appendAgentInfo(nodeList NodeList, linkDataDuplexMap LinkDataDuplexMap, agentInfoPopulator AgentInfoPopulator) : void from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Push Down Method public build(application Application, agentInfoService AgentInfoService) : ApplicationMap from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to public build(application Application, agentInfoService AgentInfoService) : ApplicationMap from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Push Down Method public build(linkDataDuplexMap LinkDataDuplexMap, agentInfoService AgentInfoService, mapHistogramSummary ResponseHistogramBuilder) : ApplicationMap from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to public build(linkDataDuplexMap LinkDataDuplexMap, agentInfoService AgentInfoService, mapHistogramSummary ResponseHistogramBuilder) : ApplicationMap from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Push Down Method private getServerInstanceList(node Node, agentInfoService AgentInfoService) : ServerInstanceList from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to private getServerInstanceList(node Node, agentInfoService AgentInfoService) : ServerInstanceList from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Push Down Method private createNode(nodeList NodeList, linkDataMap LinkDataMap) : void from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to private createNode(nodeList NodeList, linkDataMap LinkDataMap) : void from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Push Down Method private filterAgentInfoByResponseData(agentList Set<AgentInfo>, timestamp long, node Node, agentInfoService AgentInfoService) : Set<AgentInfo> from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to private filterAgentInfoByResponseData(agentList Set<AgentInfo>, timestamp long, node Node, agentInfoService AgentInfoService) : Set<AgentInfo> from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Push Down Method private isAgentRunning(agentInfo AgentInfo) : boolean from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to private isAgentRunning(agentInfo AgentInfo) : boolean from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Push Down Method private buildLink(nodeList NodeList, linkDataDuplexMap LinkDataDuplexMap) : LinkList from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to private buildLink(nodeList NodeList, linkDataDuplexMap LinkDataDuplexMap) : LinkList from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Push Down Method private addLink(linkList LinkList, fromNode Node, toNode Node, createType CreateType) : Link from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to private addLink(linkList LinkList, fromNode Node, toNode Node, createType CreateType) : Link from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Push Down Method private buildNode(linkDataDuplexMap LinkDataDuplexMap) : NodeList from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to private buildNode(linkDataDuplexMap LinkDataDuplexMap) : NodeList from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Push Down Method public appendNodeResponseTime(nodeList NodeList, linkList LinkList, nodeHistogramDataSource NodeHistogramDataSource) : void from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to public appendNodeResponseTime(nodeList NodeList, linkList LinkList, nodeHistogramDataSource NodeHistogramDataSource) : void from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Push Down Method private createTerminalNodeHistogram(node Node, linkList LinkList) : NodeHistogram from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to private createTerminalNodeHistogram(node Node, linkList LinkList) : NodeHistogram from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Push Down Method private createTargetLink(nodeList NodeList, linkList LinkList, linkDataMap LinkDataMap) : void from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to private createTargetLink(nodeList NodeList, linkList LinkList, linkDataMap LinkDataMap) : void from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Push Down Method public ApplicationMapBuilder(range Range) from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to package ApplicationMapBuilderV1(range Range) from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Push Down Method public build(nodeList NodeList, linkList LinkList) : ApplicationMap from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to public build(nodeList NodeList, linkList LinkList) : ApplicationMap from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Push Down Method public build(linkDataDuplexMap LinkDataDuplexMap, agentInfoService AgentInfoService, mapResponseDao MapResponseDao) : ApplicationMap from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to public build(linkDataDuplexMap LinkDataDuplexMap, agentInfoService AgentInfoService, mapResponseDao MapResponseDao) : ApplicationMap from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Push Down Method private appendServerInfo(node Node, linkDataDuplexMap LinkDataDuplexMap, agentInfoPopulator AgentInfoPopulator) : void from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to private appendServerInfo(node Node, linkDataDuplexMap LinkDataDuplexMap, agentInfoPopulator AgentInfoPopulator) : void from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Push Down Method private appendLinkHistogram(link Link, linkDataDuplexMap LinkDataDuplexMap) : void from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to private appendLinkHistogram(link Link, linkDataDuplexMap LinkDataDuplexMap) : void from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Push Down Method public build(linkDataDuplexMap LinkDataDuplexMap, agentInfoPopulator AgentInfoPopulator, nodeHistogramDataSource NodeHistogramDataSource) : ApplicationMap from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to public build(linkDataDuplexMap LinkDataDuplexMap, agentInfoPopulator AgentInfoPopulator, nodeHistogramDataSource NodeHistogramDataSource) : ApplicationMap from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Push Down Method private createSourceLink(nodeList NodeList, linkList LinkList, linkDataMap LinkDataMap) : void from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to private createSourceLink(nodeList NodeList, linkList LinkList, linkDataMap LinkDataMap) : void from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Push Down Method private addNode(nodeList NodeList, application Application) : boolean from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to private addNode(nodeList NodeList, application Application) : boolean from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Extract Subclass	1
Extract Subclass com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1 from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder	From	To
Push Down Attribute	2
Push Down Attribute private logger : Logger from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to private logger : Logger from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Push Down Attribute private range : Range from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder to private range : Range from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Move Attribute	3
Move Attribute private mapStatisticsCallerDao : MapStatisticsCallerDao from class com.navercorp.pinpoint.web.service.MapServiceImpl to private mapStatisticsCallerDao : MapStatisticsCallerDao from class com.navercorp.pinpoint.web.service.LinkDataMapServiceImpl	From	To
Move Attribute private hostApplicationMapDao : HostApplicationMapDao from class com.navercorp.pinpoint.web.service.MapServiceImpl to private hostApplicationMapDao : HostApplicationMapDao from class com.navercorp.pinpoint.web.service.map.LinkSelectorFactory	From	To
Move Attribute private mapStatisticsCalleeDao : MapStatisticsCalleeDao from class com.navercorp.pinpoint.web.service.MapServiceImpl to private mapStatisticsCalleeDao : MapStatisticsCalleeDao from class com.navercorp.pinpoint.web.service.LinkDataMapServiceImpl	From	To
Extract Class	1
Extract Class com.navercorp.pinpoint.web.service.LinkDataMapServiceImpl from class com.navercorp.pinpoint.web.service.MapServiceImpl	From	To
Move Class	7
Move Class com.navercorp.pinpoint.web.service.LinkSelector moved to com.navercorp.pinpoint.web.service.map.LinkSelector	From	To
Move Class com.navercorp.pinpoint.web.service.LinkVisitChecker moved to com.navercorp.pinpoint.web.service.map.LinkVisitChecker	From	To
Move Class com.navercorp.pinpoint.web.service.BFSLinkSelector moved to com.navercorp.pinpoint.web.service.map.BFSLinkSelector	From	To
Move Class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder.NodeHistogramDataSource moved to com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1.NodeHistogramDataSource	From	To
Move Class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder.AgentInfoPopulator moved to com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1.AgentInfoPopulator	From	To
Move Class com.navercorp.pinpoint.web.service.LinkVisitCheckerTest moved to com.navercorp.pinpoint.web.service.map.LinkVisitCheckerTest	From	To
Move Class com.navercorp.pinpoint.web.service.DFSLinkSelector moved to com.navercorp.pinpoint.web.service.map.DFSLinkSelector	From	To
Rename Attribute	2
Rename Attribute mapStatisticsCalleeDao : MapStatisticsCalleeDao to linkDataMapService : LinkDataMapService in class com.navercorp.pinpoint.web.service.map.BFSLinkSelector	From	To
Rename Attribute mapStatisticsCalleeDao : MapStatisticsCalleeDao to linkDataMapService : LinkDataMapService in class com.navercorp.pinpoint.web.service.map.DFSLinkSelector	From	To
Extract Method	1
Extract Method private replaceRpcCaller(caller LinkDataMap, range Range) : LinkDataMap extracted from private selectCaller(callerApplication Application, range Range, searchDepth SearchDepth) : LinkDataDuplexMap in class com.navercorp.pinpoint.web.service.map.DFSLinkSelector	From	To
Change Attribute Type	3
Change Attribute Type mapStatisticsCalleeDao : MapStatisticsCalleeDao to linkDataMapService : LinkDataMapService in class com.navercorp.pinpoint.web.service.map.BFSLinkSelector	From	To
Change Attribute Type mapStatisticsCalleeDao : MapStatisticsCalleeDao to linkDataMapService : LinkDataMapService in class com.navercorp.pinpoint.web.service.map.DFSLinkSelector	From	To
Change Attribute Type acceptApplicationLocalCache : Map<RpcApplication,Set<AcceptApplication>> to acceptApplicationLocalCache : ConcurrentMap<RpcApplication,Set<AcceptApplication>> in class com.navercorp.pinpoint.web.service.map.AcceptApplicationLocalCache	From	To
Rename Parameter	1
Rename Parameter mapHistogramSummary : ResponseHistogramBuilder to responseHistogramBuilder : ResponseHistogramBuilder in method public build(linkDataDuplexMap LinkDataDuplexMap, agentInfoService AgentInfoService, responseHistogramBuilder ResponseHistogramBuilder) : ApplicationMap in class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilder	From	To

341caecbb19cacf98c46991a2be9a9f340c85657

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: