pinpoint 34285e1cf1974f69328944f69dd07fd80bd3d4d3

34285e1cf1974f69328944f69dd07fd80bd3d4d3

Files Diff

Added: 9
Removed: 7
Renamed: 0
Modified: 14

Link to commit

Dependency Action
Added
	org.apache.curator:curator-framework:4.0.1
Updated
	From com.fasterxml.jackson.core:jackson-databind 2.6.6 To 2.9.7
	From com.fasterxml.jackson.core:jackson-core 2.6.6 To 2.9.7
	From com.fasterxml.jackson.core:jackson-annotations 2.9.7 To 2.6.6
	From com.fasterxml.jackson.core:jackson-annotations 2.6.6 To 2.9.7
	From com.fasterxml.jackson.core:jackson-databind 2.9.7 To 2.6.6
	From com.fasterxml.jackson.core:jackson-core 2.9.7 To 2.6.6
	From org.apache.httpcomponents:httpcore 4.5.6 To 4.4.10
	From org.apache.httpcomponents:httpcore 4.4.10 To 4.5.6
	From org.apache.curator:curator-test 2.6.0 To 2.12.0

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	2
Change Parameter Type keeperException : KeeperException to exception : Exception in method package resolve(exception Exception) : PinpointZookeeperException in class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperExceptionResolver	From	To
Change Parameter Type keeperException : KeeperException to exception : Exception in method public resolve(exception Exception, throwException boolean) : PinpointZookeeperException in class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperExceptionResolver	From	To
Move Attribute	8
Move Attribute private PINPOINT_WEB_CLUSTER_PATH : String from class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperClusterService to public PINPOINT_WEB_CLUSTER_PATH : String from class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperConstants	From	To
Move Attribute private PINPOINT_CLUSTER_PATH : String from class com.navercorp.pinpoint.web.cluster.zookeeper.ZookeeperClusterDataManager to public PINPOINT_CLUSTER_PATH : String from class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperConstants	From	To
Move Attribute private PINPOINT_CLUSTER_PATH : String from class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperClusterService to public PINPOINT_CLUSTER_PATH : String from class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperConstants	From	To
Move Attribute private PINPOINT_CLUSTER_PATH : String from class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperJobWorker to public PINPOINT_CLUSTER_PATH : String from class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperConstants	From	To
Move Attribute private PINPOINT_COLLECTOR_CLUSTER_PATH : String from class com.navercorp.pinpoint.web.cluster.zookeeper.ZookeeperClusterDataManager to public PINPOINT_COLLECTOR_CLUSTER_PATH : String from class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperConstants	From	To
Move Attribute private zookeeperEventWatcher : ZookeeperEventWatcher from class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperConnectionManager to private zookeeperEventWatcher : ZookeeperEventWatcher from class com.navercorp.pinpoint.common.server.cluster.zookeeper.PinpointZookeeperConnectionStateListener	From	To
Move Attribute private PINPOINT_WEB_CLUSTER_PATH : String from class com.navercorp.pinpoint.web.cluster.zookeeper.ZookeeperClusterDataManager to public PINPOINT_WEB_CLUSTER_PATH : String from class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperConstants	From	To
Move Attribute private PINPOINT_COLLECTOR_CLUSTER_PATH : String from class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperJobWorker to public PINPOINT_COLLECTOR_CLUSTER_PATH : String from class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperConstants	From	To
Extract Class	4
Extract Class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperConstants from class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperJobWorker	From	To
Extract Class com.navercorp.pinpoint.common.server.cluster.zookeeper.PinpointZookeeperConnectionStateListener from class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperConnectionManager	From	To
Extract Class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperConstants from class com.navercorp.pinpoint.web.cluster.zookeeper.ZookeeperClusterDataManager	From	To
Extract Class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperConstants from class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperClusterService	From	To
Rename Class	1
Rename Class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperConnectionManager renamed to com.navercorp.pinpoint.common.server.cluster.zookeeper.CuratorZookeeperConnectionManager	From	To
Move And Rename Class	1
Move And Rename Class com.navercorp.pinpoint.collector.cluster.zookeeper.DefaultZookeeperClient moved and renamed to com.navercorp.pinpoint.common.server.cluster.zookeeper.CuratorZookeeperClient	From	To
Move Class	1
Move Class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperClient moved to com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperClient	From	To
Change Variable Type	1
Change Variable Type exception : KeeperException to e : Exception in method public delete(path String) : void in class com.navercorp.pinpoint.common.server.cluster.zookeeper.CuratorZookeeperClient	From	To
Extract Method	2
Extract Method public getData(path String, watch boolean) : byte[] extracted from public getData(path String) : byte[] in class com.navercorp.pinpoint.common.server.cluster.zookeeper.CuratorZookeeperClient	From	To
Extract Method private getTargetAddressList(parentPath String) : List<Address> extracted from private handleAndRegisterWatcher0() : boolean in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperClusterManager.GetAndRegisterTask	From	To
Rename Method	6
Rename Method public exists(path String) : boolean renamed to public getData(path String, watch boolean) : byte[] in class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperClient	From	To
Rename Method public setData(path String, data byte[]) : void renamed to public createOrSetNode(path String, payload byte[]) : String in class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperClient	From	To
Rename Method public setData(path String, data byte[]) : void renamed to public createOrSetNode(path String, payload byte[]) : String in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperJobWorkerTest.MockZookeeperClient	From	To
Rename Method public exists(path String) : boolean renamed to public getData(path String, watch boolean) : byte[] in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperJobWorkerTest.MockZookeeperClient	From	To
Rename Method public getChildrenNode(path String, watch boolean) : List<String> renamed to public getChildNodeList(path String, watch boolean) : List<String> in class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperClient	From	To
Rename Method public getChildrenNode(path String, watch boolean) : List<String> renamed to public getChildNodeList(path String, watch boolean) : List<String> in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperJobWorkerTest.MockZookeeperClient	From	To
Inline Method	2
Inline Method public createNode(zNodePath String, data byte[], throwExceptionIfNodeExists boolean) : String inlined to public createNode(zNodePath String, data byte[]) : String in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperJobWorkerTest.MockZookeeperClient	From	To
Inline Method public createNode(zNodePath String, data byte[], throwExceptionIfNodeExists boolean) : String inlined to public createNode(path String, payload byte[]) : String in class com.navercorp.pinpoint.common.server.cluster.zookeeper.CuratorZookeeperClient	From	To
Rename Variable	13
Rename Variable currentClusterData : String to currentData : String in method private handleUpdate(zookeeperJobList List<ZookeeperJob>) : boolean in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperJobWorker	From	To
Rename Variable clusterAddressList : List<Address> to targetAddressList : List<Address> in method private handleAndRegisterWatcher0() : boolean in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperClusterManager.GetAndRegisterTask	From	To
Rename Variable address : Address to connectedAddress : Address in method private handleAndRegisterWatcher0() : boolean in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperClusterManager.GetAndRegisterTask	From	To
Rename Variable exception : KeeperException to e : Exception in method public delete(path String) : void in class com.navercorp.pinpoint.common.server.cluster.zookeeper.CuratorZookeeperClient	From	To
Rename Variable currentClusterData : String to currentData : String in method private handleDelete(zookeeperJobList List<ZookeeperJob>) : boolean in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperJobWorker	From	To
Rename Variable addressList : List<Address> to connectedAddressList : List<Address> in method private handleAndRegisterWatcher0() : boolean in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperClusterManager.GetAndRegisterTask	From	To
Rename Variable remainCluster : String to newData : String in method private handleDelete(zookeeperJobList List<ZookeeperJob>) : boolean in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperJobWorker	From	To
Rename Variable path : String to eventPath : String in method public process(event WatchedEvent) : void in class com.navercorp.pinpoint.collector.cluster.flink.FlinkClusterService.ClusterManagerWatcher	From	To
Rename Variable updateCluster : String to newData : String in method private handleUpdate(zookeeperJobList List<ZookeeperJob>) : boolean in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperJobWorker	From	To
Rename Variable clusterBytes : byte[] to result : byte[] in method private getClusterData() : String in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperJobWorker	From	To
Rename Variable clusterAddress : Address to targetAddress : Address in method private handleAndRegisterWatcher0() : boolean in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperClusterManager.GetAndRegisterTask	From	To
Rename Variable clusterBytes : byte[] to payload : byte[] in method private setClusterData(value String) : void in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperJobWorker	From	To
Rename Variable node : String to fullPath : String in method package getCollectorData(client ZookeeperClient, parentPath String) : Map<String,byte[]> in class com.navercorp.pinpoint.web.cluster.zookeeper.ZookeeperClusterDataManagerHelper	From	To
Change Return Type	5
Change Return Type ZooKeeper to CuratorFramework in method package getZookeeperClient() : CuratorFramework in class com.navercorp.pinpoint.common.server.cluster.zookeeper.CuratorZookeeperConnectionManager	From	To
Change Return Type void to String in method public createOrSetNode(path String, payload byte[]) : String in class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperClient	From	To
Change Return Type boolean to byte[] in method public getData(path String, watch boolean) : byte[] in class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperClient	From	To
Change Return Type void to String in method public createOrSetNode(path String, payload byte[]) : String in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperJobWorkerTest.MockZookeeperClient	From	To
Change Return Type boolean to byte[] in method public getData(path String, watch boolean) : byte[] in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperJobWorkerTest.MockZookeeperClient	From	To
Rename Attribute	1
Rename Attribute zNodePath : String to parentPath : String in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperClusterManager	From	To
Rename Parameter	11
Rename Parameter path : String to value : String in method public createPath(value String) : void in class com.navercorp.pinpoint.common.server.cluster.zookeeper.CuratorZookeeperClient	From	To
Rename Parameter path : String to parentPath : String in method package getCollectorData(client ZookeeperClient, parentPath String) : Map<String,byte[]> in class com.navercorp.pinpoint.web.cluster.zookeeper.ZookeeperClusterDataManagerHelper	From	To
Rename Parameter keeperException : KeeperException to exception : Exception in method public resolve(exception Exception, throwException boolean) : PinpointZookeeperException in class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperExceptionResolver	From	To
Rename Parameter watcher : ZookeeperEventWatcher to zookeeperEventWatcher : ZookeeperEventWatcher in method public CuratorZookeeperClient(hostPort String, sessionTimeout int, zookeeperEventWatcher ZookeeperEventWatcher) in class com.navercorp.pinpoint.common.server.cluster.zookeeper.CuratorZookeeperClient	From	To
Rename Parameter zNodePath : String to path : String in method public createNode(path String, payload byte[]) : String in class com.navercorp.pinpoint.common.server.cluster.zookeeper.CuratorZookeeperClient	From	To
Rename Parameter data : byte[] to payload : byte[] in method public createNode(path String, payload byte[]) : String in class com.navercorp.pinpoint.common.server.cluster.zookeeper.CuratorZookeeperClient	From	To
Rename Parameter data : byte[] to payload : byte[] in method public createOrSetNode(path String, payload byte[]) : String in class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperClient	From	To
Rename Parameter clusterString : String to value : String in method private setClusterData(value String) : void in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperJobWorker	From	To
Rename Parameter path : String to value : String in method public createPath(value String) : void in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperJobWorkerTest.MockZookeeperClient	From	To
Rename Parameter keeperException : KeeperException to exception : Exception in method package resolve(exception Exception) : PinpointZookeeperException in class com.navercorp.pinpoint.common.server.cluster.zookeeper.ZookeeperExceptionResolver	From	To
Rename Parameter data : byte[] to payload : byte[] in method public createOrSetNode(path String, payload byte[]) : String in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperJobWorkerTest.MockZookeeperClient	From	To

34285e1cf1974f69328944f69dd07fd80bd3d4d3

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: