pinpoint 400bc293ae1ce412e79bcae5d03d677bfdcea63b

400bc293ae1ce412e79bcae5d03d677bfdcea63b

Files Diff

Added: 44
Removed: 5
Renamed: 0
Modified: 54

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	9
Move And Rename Method private createInstrumentEngine(profilerConfig ProfilerConfig, agentOption AgentOption, interceptorRegistryBinder InterceptorRegistryBinder) : InstrumentClassPool from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext to public get() : InstrumentClassPool from class com.navercorp.pinpoint.profiler.context.provider.InstrumentEngineProvider	From	To
Move And Rename Method private createUdpStatDataSender() : DataSender from class com.navercorp.pinpoint.test.PluginTestAgent to private newUdpStatDataSender() : DataSender from class com.navercorp.pinpoint.test.PluginApplicationContextModule	From	To
Move And Rename Method private createCommandService(profilerConfig ProfilerConfig, activeTraceRepository ActiveTraceRepository) : CommandDispatcher from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext to public get() : CommandDispatcher from class com.navercorp.pinpoint.profiler.context.provider.CommandDispatcherProvider	From	To
Move And Rename Method private createActiveTraceRepository(profilerConfig ProfilerConfig) : ActiveTraceRepository from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext to public get() : ActiveTraceRepository from class com.navercorp.pinpoint.profiler.context.provider.ActiveTraceRepositoryProvider	From	To
Move And Rename Method private createSampler(profilerConfig ProfilerConfig) : Sampler from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext to public get() : Sampler from class com.navercorp.pinpoint.profiler.context.provider.SamplerProvider	From	To
Move And Rename Method private wrapClassFileTransformer(profilerConfig ProfilerConfig, classFileTransformerDispatcher ClassFileTransformer) : ClassFileTransformer from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext to public get() : ClassFileTransformer from class com.navercorp.pinpoint.profiler.context.provider.ClassFileTransformerWrapProvider	From	To
Move And Rename Method protected createTcpDataSender() : EnhancedDataSender from class com.navercorp.pinpoint.test.PluginTestAgent to protected newTcpDataSender() : EnhancedDataSender from class com.navercorp.pinpoint.test.PluginApplicationContextModule	From	To
Move And Rename Method private createUdpSpanDataSender() : DataSender from class com.navercorp.pinpoint.test.PluginTestAgent to private newUdpSpanDataSender() : DataSender from class com.navercorp.pinpoint.test.PluginApplicationContextModule	From	To
Move And Rename Method private createServerMetaDataHolder() : ServerMetaDataHolder from class com.navercorp.pinpoint.test.PluginTestAgent to private newServerMetaDataHolder() : ServerMetaDataHolder from class com.navercorp.pinpoint.test.PluginApplicationContextModule	From	To
Extract Subclass	5
Extract Subclass com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher from class com.navercorp.pinpoint.profiler.ClassFileTransformerDispatcher	From	To
Extract Subclass com.navercorp.pinpoint.profiler.DefaultAgentInformation from class com.navercorp.pinpoint.profiler.AgentInformation	From	To
Extract Subclass com.navercorp.pinpoint.profiler.monitor.DefaultAgentStatMonitor from class com.navercorp.pinpoint.profiler.monitor.AgentStatMonitor	From	To
Extract Subclass com.navercorp.pinpoint.profiler.context.AtomicIdGenerator from class com.navercorp.pinpoint.profiler.context.IdGenerator	From	To
Extract Subclass com.navercorp.pinpoint.profiler.monitor.codahale.DefaultAgentStatCollectorFactory from class com.navercorp.pinpoint.profiler.monitor.codahale.AgentStatCollectorFactory	From	To
Change Parameter Type	8
Change Parameter Type plugins : List<DefaultProfilerPluginContext> to plugins : PluginContextLoadResult in method public ApplicationServerTypeResolver(plugins PluginContextLoadResult, defaultType ServiceType, orderedDetectors List<String>) in class com.navercorp.pinpoint.profiler.util.ApplicationServerTypeResolver	From	To
Change Parameter Type pluginContexts : List<DefaultProfilerPluginContext> to pluginContexts : PluginContextLoadResult in method public DefaultClassFileTransformerDispatcher(applicationContext ApplicationContext, pluginContexts PluginContextLoadResult) in class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher	From	To
Change Parameter Type applicationContext : ApplicationContext to applicationContext : MockApplicationContext in method public createTestClassLoader(applicationContext MockApplicationContext) : TestClassLoader in class com.navercorp.pinpoint.test.classloader.TestClassLoaderFactory	From	To
Change Parameter Type idGenerator : IdGenerator to idGenerator : AtomicIdGenerator in method public DefaultTraceFactoryBuilder(storageFactory StorageFactory, sampler Sampler, idGenerator AtomicIdGenerator, activeTraceRepository ActiveTraceRepository) in class com.navercorp.pinpoint.profiler.context.DefaultTraceFactoryBuilder	From	To
Change Parameter Type pluginContexts : List<DefaultProfilerPluginContext> to pluginContexts : PluginContextLoadResult in method private createTransformerRegistry(pluginContexts PluginContextLoadResult) : TransformerRegistry in class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher	From	To
Change Parameter Type applicationContext : ApplicationContext to applicationContext : MockApplicationContext in method public TestClassLoader(applicationContext MockApplicationContext) in class com.navercorp.pinpoint.test.classloader.TestClassLoader	From	To
Change Parameter Type idGenerator : IdGenerator to idGenerator : AtomicIdGenerator in method public DefaultBaseTraceFactory(traceContext TraceContext, storageFactory StorageFactory, sampler Sampler, idGenerator AtomicIdGenerator) in class com.navercorp.pinpoint.profiler.context.DefaultBaseTraceFactory	From	To
Change Parameter Type plugins : List<DefaultProfilerPluginContext> to plugins : PluginContextLoadResult in method private getRegisteredServerTypeDetectors(plugins PluginContextLoadResult) : Map<String,ApplicationTypeDetector> in class com.navercorp.pinpoint.profiler.util.ApplicationServerTypeResolver	From	To
Move Method	2
Move Method private preparePlugin(plugin ProfilerPlugin, context InstrumentContext) : GuardInstrumentContext from class com.navercorp.pinpoint.profiler.plugin.ProfilerPluginLoader to private preparePlugin(plugin ProfilerPlugin, context InstrumentContext) : GuardInstrumentContext from class com.navercorp.pinpoint.profiler.plugin.DefaultPluginSetup	From	To
Move Method private preparePlugin(plugin ProfilerPlugin, context InstrumentContext) : void from class com.navercorp.pinpoint.test.MockApplicationContext to private preparePlugin(plugin ProfilerPlugin, context InstrumentContext) : void from class com.navercorp.pinpoint.test.MockPluginSetup	From	To
Push Down Attribute	48
Push Down Attribute private agentId : String from class com.navercorp.pinpoint.profiler.AgentInformation to private agentId : String from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Push Down Attribute private numCollectionsPerBatch : int from class com.navercorp.pinpoint.profiler.monitor.AgentStatMonitor to private numCollectionsPerBatch : int from class com.navercorp.pinpoint.profiler.monitor.DefaultAgentStatMonitor	From	To
Push Down Attribute private transactionMetricCollector : TransactionMetricCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.AgentStatCollectorFactory to private transactionMetricCollector : TransactionMetricCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.DefaultAgentStatCollectorFactory	From	To
Push Down Attribute private logger : Logger from class com.navercorp.pinpoint.profiler.ClassFileTransformerDispatcher to private logger : Logger from class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher	From	To
Push Down Attribute private agentStatCollectorFactory : AgentStatCollectorFactory from class com.navercorp.pinpoint.profiler.monitor.AgentStatMonitor to private agentStatCollectorFactory : AgentStatCollectorFactory from class com.navercorp.pinpoint.profiler.monitor.DefaultAgentStatMonitor	From	To
Push Down Attribute private isTrace : boolean from class com.navercorp.pinpoint.profiler.monitor.AgentStatMonitor to private isTrace : boolean from class com.navercorp.pinpoint.profiler.monitor.DefaultAgentStatMonitor	From	To
Push Down Attribute private disabledId : AtomicLong from class com.navercorp.pinpoint.profiler.context.IdGenerator to private disabledId : AtomicLong from class com.navercorp.pinpoint.profiler.context.AtomicIdGenerator	From	To
Push Down Attribute private collectionIntervalMs : long from class com.navercorp.pinpoint.profiler.monitor.AgentStatMonitor to private collectionIntervalMs : long from class com.navercorp.pinpoint.profiler.monitor.DefaultAgentStatMonitor	From	To
Push Down Attribute private logger : Logger from class com.navercorp.pinpoint.profiler.monitor.AgentStatMonitor to private logger : Logger from class com.navercorp.pinpoint.profiler.monitor.DefaultAgentStatMonitor	From	To
Push Down Attribute private isDebug : boolean from class com.navercorp.pinpoint.profiler.ClassFileTransformerDispatcher to private isDebug : boolean from class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher	From	To
Push Down Attribute public INITIAL_TRANSACTION_ID : long from class com.navercorp.pinpoint.profiler.context.IdGenerator to public INITIAL_TRANSACTION_ID : long from class com.navercorp.pinpoint.profiler.context.AtomicIdGenerator	From	To
Push Down Attribute private logger : Logger from class com.navercorp.pinpoint.profiler.monitor.codahale.AgentStatCollectorFactory to private logger : Logger from class com.navercorp.pinpoint.profiler.monitor.codahale.DefaultAgentStatCollectorFactory	From	To
Push Down Attribute private debugTransformer : DebugTransformer from class com.navercorp.pinpoint.profiler.ClassFileTransformerDispatcher to private debugTransformer : DebugTransformer from class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher	From	To
Push Down Attribute public RESERVED_MAX : long from class com.navercorp.pinpoint.profiler.context.IdGenerator to public RESERVED_MAX : long from class com.navercorp.pinpoint.profiler.context.AtomicIdGenerator	From	To
Push Down Attribute private DEFAULT_NUM_COLLECTIONS_PER_SEND : int from class com.navercorp.pinpoint.profiler.monitor.AgentStatMonitor to private DEFAULT_NUM_COLLECTIONS_PER_SEND : int from class com.navercorp.pinpoint.profiler.monitor.DefaultAgentStatMonitor	From	To
Push Down Attribute public INITIAL_DISABLED_ID : long from class com.navercorp.pinpoint.profiler.context.IdGenerator to public INITIAL_DISABLED_ID : long from class com.navercorp.pinpoint.profiler.context.AtomicIdGenerator	From	To
Push Down Attribute private dataSender : DataSender from class com.navercorp.pinpoint.profiler.monitor.AgentStatMonitor to private dataSender : DataSender from class com.navercorp.pinpoint.profiler.monitor.DefaultAgentStatMonitor	From	To
Push Down Attribute private debugTargetFilter : Filter<String> from class com.navercorp.pinpoint.profiler.ClassFileTransformerDispatcher to private debugTargetFilter : Filter<String> from class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher	From	To
Push Down Attribute public UNTRACKED_ID : long from class com.navercorp.pinpoint.profiler.context.IdGenerator to public UNTRACKED_ID : long from class com.navercorp.pinpoint.profiler.context.AtomicIdGenerator	From	To
Push Down Attribute private executor : ScheduledExecutorService from class com.navercorp.pinpoint.profiler.monitor.AgentStatMonitor to private executor : ScheduledExecutorService from class com.navercorp.pinpoint.profiler.monitor.DefaultAgentStatMonitor	From	To
Push Down Attribute private dataSourceCollector : DataSourceCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.AgentStatCollectorFactory to private dataSourceCollector : DataSourceCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.DefaultAgentStatCollectorFactory	From	To
Push Down Attribute private hostIp : String from class com.navercorp.pinpoint.profiler.AgentInformation to private hostIp : String from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Push Down Attribute private applicationName : String from class com.navercorp.pinpoint.profiler.AgentInformation to private applicationName : String from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Push Down Attribute private garbageCollector : GarbageCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.AgentStatCollectorFactory to private garbageCollector : GarbageCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.DefaultAgentStatCollectorFactory	From	To
Push Down Attribute private agentClassLoader : ClassLoader from class com.navercorp.pinpoint.profiler.ClassFileTransformerDispatcher to private agentClassLoader : ClassLoader from class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher	From	To
Push Down Attribute private transactionId : AtomicLong from class com.navercorp.pinpoint.profiler.context.IdGenerator to private transactionId : AtomicLong from class com.navercorp.pinpoint.profiler.context.AtomicIdGenerator	From	To
Push Down Attribute private serverType : ServiceType from class com.navercorp.pinpoint.profiler.AgentInformation to private serverType : ServiceType from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Push Down Attribute private monitorRegistry : MetricMonitorRegistry from class com.navercorp.pinpoint.profiler.monitor.codahale.AgentStatCollectorFactory to private monitorRegistry : MetricMonitorRegistry from class com.navercorp.pinpoint.profiler.monitor.codahale.DefaultAgentStatCollectorFactory	From	To
Push Down Attribute private pid : int from class com.navercorp.pinpoint.profiler.AgentInformation to private pid : int from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Push Down Attribute public INITIAL_CONTINUED_TRANSACTION_ID : long from class com.navercorp.pinpoint.profiler.context.IdGenerator to public INITIAL_CONTINUED_TRANSACTION_ID : long from class com.navercorp.pinpoint.profiler.context.AtomicIdGenerator	From	To
Push Down Attribute private startTime : long from class com.navercorp.pinpoint.profiler.AgentInformation to private startTime : long from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Push Down Attribute private jvmVersion : String from class com.navercorp.pinpoint.profiler.AgentInformation to private jvmVersion : String from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Push Down Attribute private globalContext : DefaultProfilerPluginContext from class com.navercorp.pinpoint.profiler.ClassFileTransformerDispatcher to private globalContext : DefaultProfilerPluginContext from class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher	From	To
Push Down Attribute public NEGATIVE_DECREMENT_CYCLE : int from class com.navercorp.pinpoint.profiler.context.IdGenerator to public NEGATIVE_DECREMENT_CYCLE : int from class com.navercorp.pinpoint.profiler.context.AtomicIdGenerator	From	To
Push Down Attribute private agentVersion : String from class com.navercorp.pinpoint.profiler.AgentInformation to private agentVersion : String from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Push Down Attribute public INITIAL_CONTINUED_DISABLED_ID : long from class com.navercorp.pinpoint.profiler.context.IdGenerator to public INITIAL_CONTINUED_DISABLED_ID : long from class com.navercorp.pinpoint.profiler.context.AtomicIdGenerator	From	To
Push Down Attribute private activeTraceMetricCollector : ActiveTraceMetricCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.AgentStatCollectorFactory to private activeTraceMetricCollector : ActiveTraceMetricCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.DefaultAgentStatCollectorFactory	From	To
Push Down Attribute private pinpointClassFilter : ClassFileFilter from class com.navercorp.pinpoint.profiler.ClassFileTransformerDispatcher to private pinpointClassFilter : ClassFileFilter from class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher	From	To
Push Down Attribute public DECREMENT_CYCLE : int from class com.navercorp.pinpoint.profiler.context.IdGenerator to public DECREMENT_CYCLE : int from class com.navercorp.pinpoint.profiler.context.AtomicIdGenerator	From	To
Push Down Attribute private continuedDisabledId : AtomicLong from class com.navercorp.pinpoint.profiler.context.IdGenerator to private continuedDisabledId : AtomicLong from class com.navercorp.pinpoint.profiler.context.AtomicIdGenerator	From	To
Push Down Attribute private continuedTransactionId : AtomicLong from class com.navercorp.pinpoint.profiler.context.IdGenerator to private continuedTransactionId : AtomicLong from class com.navercorp.pinpoint.profiler.context.AtomicIdGenerator	From	To
Push Down Attribute private machineName : String from class com.navercorp.pinpoint.profiler.AgentInformation to private machineName : String from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Push Down Attribute private dynamicTransformerRegistry : DynamicTransformerRegistry from class com.navercorp.pinpoint.profiler.ClassFileTransformerDispatcher to private dynamicTransformerRegistry : DynamicTransformerRegistry from class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher	From	To
Push Down Attribute private unmodifiableFilter : ClassFileFilter from class com.navercorp.pinpoint.profiler.ClassFileTransformerDispatcher to private unmodifiableFilter : ClassFileFilter from class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher	From	To
Push Down Attribute private transformerRegistry : TransformerRegistry from class com.navercorp.pinpoint.profiler.ClassFileTransformerDispatcher to private transformerRegistry : TransformerRegistry from class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher	From	To
Push Down Attribute private DEFAULT_COLLECTION_INTERVAL_MS : long from class com.navercorp.pinpoint.profiler.monitor.AgentStatMonitor to private DEFAULT_COLLECTION_INTERVAL_MS : long from class com.navercorp.pinpoint.profiler.monitor.DefaultAgentStatMonitor	From	To
Push Down Attribute public RESERVED_MIN : long from class com.navercorp.pinpoint.profiler.context.IdGenerator to public RESERVED_MIN : long from class com.navercorp.pinpoint.profiler.context.AtomicIdGenerator	From	To
Push Down Attribute private cpuLoadCollector : CpuLoadCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.AgentStatCollectorFactory to private cpuLoadCollector : CpuLoadCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.DefaultAgentStatCollectorFactory	From	To
Move Attribute	8
Move Attribute private agentStartTime : long from class com.navercorp.pinpoint.profiler.monitor.AgentStatMonitor to private agentStartTime : long from class com.navercorp.pinpoint.profiler.DefaultAgentInformationFactory	From	To
Move Attribute private applicationName : String from class com.navercorp.pinpoint.profiler.AgentInformationFactory to private applicationName : String from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Move Attribute private serverMetaDataHolder : ServerMetaDataHolder from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext to private serverMetaDataHolder : ServerMetaDataHolder from class com.navercorp.pinpoint.test.PluginApplicationContextModule	From	To
Move Attribute private tcpDataSender : TestTcpDataSender from class com.navercorp.pinpoint.test.PluginTestAgent to private tcpDataSender : TestTcpDataSender from class com.navercorp.pinpoint.test.PluginApplicationContextModule	From	To
Move Attribute private serverMetaDataListener : TestableServerMetaDataListener from class com.navercorp.pinpoint.test.PluginTestAgent to private serverMetaDataListener : TestableServerMetaDataListener from class com.navercorp.pinpoint.test.PluginApplicationContextModule	From	To
Move Attribute private agentId : String from class com.navercorp.pinpoint.profiler.AgentInformationFactory to private agentId : String from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Move Attribute private agentId : String from class com.navercorp.pinpoint.profiler.monitor.AgentStatMonitor to private agentId : String from class com.navercorp.pinpoint.profiler.DefaultAgentInformationFactory	From	To
Move Attribute private orderedSpanRecorder : OrderedSpanRecorder from class com.navercorp.pinpoint.test.PluginTestAgent to private orderedSpanRecorder : OrderedSpanRecorder from class com.navercorp.pinpoint.test.PluginApplicationContextModule	From	To
Extract Class	7
Extract Class com.navercorp.pinpoint.test.PluginApplicationContextModule from class com.navercorp.pinpoint.test.MockApplicationContext	From	To
Extract Class com.navercorp.pinpoint.test.PluginApplicationContextModule from class com.navercorp.pinpoint.test.PluginTestAgent	From	To
Extract Class com.navercorp.pinpoint.test.MockApplicationContextModule from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Extract Class com.navercorp.pinpoint.test.PluginApplicationContextModule from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Extract Class com.navercorp.pinpoint.test.MockApplicationContextModule from class com.navercorp.pinpoint.test.MockApplicationContext	From	To
Extract Class com.navercorp.pinpoint.profiler.DefaultAgentInformationFactory from class com.navercorp.pinpoint.profiler.monitor.AgentStatMonitor	From	To
Extract Class com.navercorp.pinpoint.profiler.DefaultAgentInformation from class com.navercorp.pinpoint.profiler.AgentInformationFactory	From	To
Move Class	1
Move Class com.navercorp.pinpoint.profiler.monitor.AgentStatMonitor.CollectJob moved to com.navercorp.pinpoint.profiler.monitor.DefaultAgentStatMonitor.CollectJob	From	To
Change Variable Type	7
Change Variable Type dynamicTransformService : DynamicTransformService to dynamicTransformService : DynamicTransformTrigger in method public addClassFileTransformer(classLoader ClassLoader, targetClassName String, transformCallback TransformCallback) : void in class com.navercorp.pinpoint.profiler.plugin.DefaultProfilerPluginContext	From	To
Change Variable Type applicationContext : ApplicationContext to applicationContext : MockApplicationContext in method private getTestClassLoader() : TestClassLoader in class com.navercorp.pinpoint.test.javasssit.JavassistClassTest	From	To
Change Variable Type dynamicTransformService : DynamicTransformService to dynamicTransformService : DynamicTransformTrigger in method public retransform(target Class<?>, transformCallback TransformCallback) : void in class com.navercorp.pinpoint.profiler.plugin.DefaultProfilerPluginContext	From	To
Change Variable Type pluginMonitorContextBuilder : PluginMonitorContextBuilder to pluginMonitorContextBuilder : PluginMonitorContextProvider in method public MockTraceContextFactory(profilerConfig ProfilerConfig) in class com.navercorp.pinpoint.profiler.context.MockTraceContextFactory	From	To
Change Variable Type idGenerator : IdGenerator to idGenerator : AtomicIdGenerator in method private newAgentStatCollectorFactory() : AgentStatCollectorFactory in class com.navercorp.pinpoint.test.monitor.AgentStatMonitorTest	From	To
Change Variable Type applicationContext : ApplicationContext to applicationContext : MockApplicationContext in method private getTestClassLoader() : TestClassLoader in class com.navercorp.pinpoint.test.javasssit.accessor.AccessorInjectionTest	From	To
Change Variable Type idGenerator : IdGenerator to idGenerator : AtomicIdGenerator in method private newAgentStatCollectorFactory(detailedMetrics boolean) : AgentStatCollectorFactory in class com.navercorp.pinpoint.profiler.monitor.codahale.gc.GarbageCollectorFactoryTest	From	To
Rename Method	2
Rename Method public getDynamicTransformService() : DynamicTransformService renamed to public getDynamicTransformTrigger() : DynamicTransformTrigger in class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Rename Method public getDynamicTransformService() : DynamicTransformService renamed to public getDynamicTransformTrigger() : DynamicTransformTrigger in class com.navercorp.pinpoint.profiler.context.ApplicationContext	From	To
Push Down Method	45
Push Down Method private createDataSourceCollector(pluginMonitorContext PluginMonitorContext) : DataSourceCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.AgentStatCollectorFactory to private createDataSourceCollector(pluginMonitorContext PluginMonitorContext) : DataSourceCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.DefaultAgentStatCollectorFactory	From	To
Push Down Method private checkId(id String) : String from class com.navercorp.pinpoint.profiler.AgentInformationFactory to private checkId(id String) : String from class com.navercorp.pinpoint.profiler.DefaultAgentInformationFactory	From	To
Push Down Method public getHostIp() : String from class com.navercorp.pinpoint.profiler.AgentInformation to public getHostIp() : String from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Push Down Method private getContextClassLoader(thread Thread) : ClassLoader from class com.navercorp.pinpoint.profiler.ClassFileTransformerDispatcher to private getContextClassLoader(thread Thread) : ClassLoader from class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher	From	To
Push Down Method public AgentInformationFactory(agentId String, applicationName String) from class com.navercorp.pinpoint.profiler.AgentInformationFactory to public DefaultAgentInformationFactory(agentId String, applicationName String, agentStartTime long, serverType ServiceType) from class com.navercorp.pinpoint.profiler.DefaultAgentInformationFactory	From	To
Push Down Method private createGarbageCollector(collectDetailedMetrics boolean) : GarbageCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.AgentStatCollectorFactory to private createGarbageCollector(collectDetailedMetrics boolean) : GarbageCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.DefaultAgentStatCollectorFactory	From	To
Push Down Method private createActiveTraceCollector(activeTraceRepository ActiveTraceRepository, isTraceAgentActiveThread boolean) : ActiveTraceMetricCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.AgentStatCollectorFactory to private createActiveTraceCollector(activeTraceRepository ActiveTraceRepository, isTraceAgentActiveThread boolean) : ActiveTraceMetricCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.DefaultAgentStatCollectorFactory	From	To
Push Down Method public nextContinuedDisabledId() : long from class com.navercorp.pinpoint.profiler.context.IdGenerator to public nextContinuedDisabledId() : long from class com.navercorp.pinpoint.profiler.context.AtomicIdGenerator	From	To
Push Down Method public nextDisabledId() : long from class com.navercorp.pinpoint.profiler.context.IdGenerator to public nextDisabledId() : long from class com.navercorp.pinpoint.profiler.context.AtomicIdGenerator	From	To
Push Down Method public getGarbageCollector() : GarbageCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.AgentStatCollectorFactory to public getGarbageCollector() : GarbageCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.DefaultAgentStatCollectorFactory	From	To
Push Down Method public nextContinuedTransactionId() : long from class com.navercorp.pinpoint.profiler.context.IdGenerator to public nextContinuedTransactionId() : long from class com.navercorp.pinpoint.profiler.context.AtomicIdGenerator	From	To
Push Down Method public getPid() : int from class com.navercorp.pinpoint.profiler.AgentInformation to public getPid() : int from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Push Down Method public getAgentVersion() : String from class com.navercorp.pinpoint.profiler.AgentInformation to public getAgentVersion() : String from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Push Down Method public transform(classLoader ClassLoader, classInternalName String, classBeingRedefined Class<?>, protectionDomain ProtectionDomain, classFileBuffer byte[]) : byte[] from class com.navercorp.pinpoint.profiler.ClassFileTransformerDispatcher to public transform(classLoader ClassLoader, classInternalName String, classBeingRedefined Class<?>, protectionDomain ProtectionDomain, classFileBuffer byte[]) : byte[] from class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher	From	To
Push Down Method public AgentStatMonitor(dataSender DataSender, agentId String, startTime long, agentStatCollectorFactory AgentStatCollectorFactory, collectionInterval long, numCollectionsPerBatch int) from class com.navercorp.pinpoint.profiler.monitor.AgentStatMonitor to public DefaultAgentStatMonitor(dataSender DataSender, agentId String, startTime long, agentStatCollectorFactory AgentStatCollectorFactory, collectionInterval long, numCollectionsPerBatch int) from class com.navercorp.pinpoint.profiler.monitor.DefaultAgentStatMonitor	From	To
Push Down Method public stop() : void from class com.navercorp.pinpoint.profiler.monitor.AgentStatMonitor to public stop() : void from class com.navercorp.pinpoint.profiler.monitor.DefaultAgentStatMonitor	From	To
Push Down Method public currentContinuedTransactionId() : long from class com.navercorp.pinpoint.profiler.context.IdGenerator to public currentContinuedTransactionId() : long from class com.navercorp.pinpoint.profiler.context.AtomicIdGenerator	From	To
Push Down Method public start() : void from class com.navercorp.pinpoint.profiler.monitor.AgentStatMonitor to public start() : void from class com.navercorp.pinpoint.profiler.monitor.DefaultAgentStatMonitor	From	To
Push Down Method public getCpuLoadCollector() : CpuLoadCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.AgentStatCollectorFactory to public getCpuLoadCollector() : CpuLoadCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.DefaultAgentStatCollectorFactory	From	To
Push Down Method public AgentInformation(agentId String, applicationName String, startTime long, pid int, machineName String, hostIp String, serverType ServiceType, jvmVersion String, agentVersion String) from class com.navercorp.pinpoint.profiler.AgentInformation to public DefaultAgentInformation(agentId String, applicationName String, startTime long, pid int, machineName String, hostIp String, serverType ServiceType, jvmVersion String, agentVersion String) from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Push Down Method public getServerType() : ServiceType from class com.navercorp.pinpoint.profiler.AgentInformation to public getServerType() : ServiceType from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Push Down Method private createRegistry() : MetricMonitorRegistry from class com.navercorp.pinpoint.profiler.monitor.codahale.AgentStatCollectorFactory to private createRegistry() : MetricMonitorRegistry from class com.navercorp.pinpoint.profiler.monitor.codahale.DefaultAgentStatCollectorFactory	From	To
Push Down Method public createAgentInformation(serverType ServiceType) : AgentInformation from class com.navercorp.pinpoint.profiler.AgentInformationFactory to public createAgentInformation() : AgentInformation from class com.navercorp.pinpoint.profiler.DefaultAgentInformationFactory	From	To
Push Down Method public AgentStatCollectorFactory(profilerConfig ProfilerConfig, activeTraceRepository ActiveTraceRepository, transactionCounter TransactionCounter, pluginMonitorContext PluginMonitorContext) from class com.navercorp.pinpoint.profiler.monitor.codahale.AgentStatCollectorFactory to public DefaultAgentStatCollectorFactory(profilerConfig ProfilerConfig, activeTraceRepository ActiveTraceRepository, transactionCounter TransactionCounter, pluginMonitorContext PluginMonitorContext) from class com.navercorp.pinpoint.profiler.monitor.codahale.DefaultAgentStatCollectorFactory	From	To
Push Down Method public toString() : String from class com.navercorp.pinpoint.profiler.AgentInformation to public toString() : String from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Push Down Method public getStartTime() : long from class com.navercorp.pinpoint.profiler.AgentInformation to public getStartTime() : long from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Push Down Method public onRetransformRequest(target Class<?>, transformer ClassFileTransformer) : RequestHandle from class com.navercorp.pinpoint.profiler.ClassFileTransformerDispatcher to public onRetransformRequest(target Class<?>, transformer ClassFileTransformer) : RequestHandle from class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher	From	To
Push Down Method public ClassFileTransformerDispatcher(applicationContext ApplicationContext, pluginContexts List<DefaultProfilerPluginContext>) from class com.navercorp.pinpoint.profiler.ClassFileTransformerDispatcher to public DefaultClassFileTransformerDispatcher(applicationContext ApplicationContext, pluginContexts PluginContextLoadResult) from class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher	From	To
Push Down Method public getTransactionMetricCollector() : TransactionMetricCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.AgentStatCollectorFactory to public getTransactionMetricCollector() : TransactionMetricCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.DefaultAgentStatCollectorFactory	From	To
Push Down Method public onTransformRequest(classLoader ClassLoader, targetClassName String, transformer ClassFileTransformer) : void from class com.navercorp.pinpoint.profiler.ClassFileTransformerDispatcher to public onTransformRequest(classLoader ClassLoader, targetClassName String, transformer ClassFileTransformer) : void from class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher	From	To
Push Down Method public getJvmVersion() : String from class com.navercorp.pinpoint.profiler.AgentInformation to public getJvmVersion() : String from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Push Down Method public getActiveTraceMetricCollector() : ActiveTraceMetricCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.AgentStatCollectorFactory to public getActiveTraceMetricCollector() : ActiveTraceMetricCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.DefaultAgentStatCollectorFactory	From	To
Push Down Method public nextTransactionId() : long from class com.navercorp.pinpoint.profiler.context.IdGenerator to public nextTransactionId() : long from class com.navercorp.pinpoint.profiler.context.AtomicIdGenerator	From	To
Push Down Method public getDataSourceCollector() : DataSourceCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.AgentStatCollectorFactory to public getDataSourceCollector() : DataSourceCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.DefaultAgentStatCollectorFactory	From	To
Push Down Method public getMachineName() : String from class com.navercorp.pinpoint.profiler.AgentInformation to public getMachineName() : String from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Push Down Method private transform0(classLoader ClassLoader, classInternalName String, classBeingRedefined Class<?>, protectionDomain ProtectionDomain, classFileBuffer byte[], transformer ClassFileTransformer) : byte[] from class com.navercorp.pinpoint.profiler.ClassFileTransformerDispatcher to private transform0(classLoader ClassLoader, classInternalName String, classBeingRedefined Class<?>, protectionDomain ProtectionDomain, classFileBuffer byte[], transformer ClassFileTransformer) : byte[] from class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher	From	To
Push Down Method private createCpuLoadCollector(vendorName String) : CpuLoadCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.AgentStatCollectorFactory to private createCpuLoadCollector(vendorName String) : CpuLoadCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.DefaultAgentStatCollectorFactory	From	To
Push Down Method public currentContinuedDisabledId() : long from class com.navercorp.pinpoint.profiler.context.IdGenerator to public currentContinuedDisabledId() : long from class com.navercorp.pinpoint.profiler.context.AtomicIdGenerator	From	To
Push Down Method private createTransactionMetricCollector(transactionCounter TransactionCounter) : TransactionMetricCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.AgentStatCollectorFactory to private createTransactionMetricCollector(transactionCounter TransactionCounter) : TransactionMetricCollector from class com.navercorp.pinpoint.profiler.monitor.codahale.DefaultAgentStatCollectorFactory	From	To
Push Down Method public getApplicationName() : String from class com.navercorp.pinpoint.profiler.AgentInformation to public getApplicationName() : String from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Push Down Method public AgentStatMonitor(dataSender DataSender, agentId String, startTime long, agentStatCollectorFactory AgentStatCollectorFactory) from class com.navercorp.pinpoint.profiler.monitor.AgentStatMonitor to public DefaultAgentStatMonitor(dataSender DataSender, agentId String, startTime long, agentStatCollectorFactory AgentStatCollectorFactory) from class com.navercorp.pinpoint.profiler.monitor.DefaultAgentStatMonitor	From	To
Push Down Method public currentDisabledId() : long from class com.navercorp.pinpoint.profiler.context.IdGenerator to public currentDisabledId() : long from class com.navercorp.pinpoint.profiler.context.AtomicIdGenerator	From	To
Push Down Method public currentTransactionId() : long from class com.navercorp.pinpoint.profiler.context.IdGenerator to public currentTransactionId() : long from class com.navercorp.pinpoint.profiler.context.AtomicIdGenerator	From	To
Push Down Method public getAgentId() : String from class com.navercorp.pinpoint.profiler.AgentInformation to public getAgentId() : String from class com.navercorp.pinpoint.profiler.DefaultAgentInformation	From	To
Push Down Method private createTransformerRegistry(pluginContexts List<DefaultProfilerPluginContext>) : TransformerRegistry from class com.navercorp.pinpoint.profiler.ClassFileTransformerDispatcher to private createTransformerRegistry(pluginContexts PluginContextLoadResult) : TransformerRegistry from class com.navercorp.pinpoint.profiler.DefaultClassFileTransformerDispatcher	From	To
Rename Variable	1
Rename Variable wrappedTransformer : ClassFileTransformer to classFileTransformer : ClassFileTransformer in method public DefaultApplicationContext(agentOption AgentOption, interceptorRegistryBinder InterceptorRegistryBinder) in class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Change Return Type	2
Change Return Type DynamicTransformService to DynamicTransformTrigger in method public getDynamicTransformTrigger() : DynamicTransformTrigger in class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Change Return Type DynamicTransformService to DynamicTransformTrigger in method public getDynamicTransformTrigger() : DynamicTransformTrigger in class com.navercorp.pinpoint.profiler.context.ApplicationContext	From	To
Extract Superclass	1
Extract Superclass com.navercorp.pinpoint.profiler.DefaultAgentInformation from classes [com.navercorp.pinpoint.test.TestAgentInformation, com.navercorp.pinpoint.profiler.context.TestAgentInformation]	From	To
Change Attribute Type	6
Change Attribute Type idGenerator : IdGenerator to idGenerator : AtomicIdGenerator in class com.navercorp.pinpoint.profiler.context.DefaultTraceFactoryBuilder	From	To
Change Attribute Type idGenerator : IdGenerator to idGenerator : AtomicIdGenerator in class com.navercorp.pinpoint.profiler.context.DefaultTransactionCounterTest	From	To
Change Attribute Type applicationContext : ApplicationContext to applicationContext : MockApplicationContext in class com.navercorp.pinpoint.test.classloader.TestClassLoader	From	To
Change Attribute Type idGenerator : IdGenerator to idGenerator : AtomicIdGenerator in class com.navercorp.pinpoint.test.MockTraceContextFactory	From	To
Change Attribute Type idGenerator : IdGenerator to idGenerator : AtomicIdGenerator in class com.navercorp.pinpoint.profiler.context.MockTraceContextFactory	From	To
Change Attribute Type idGenerator : IdGenerator to idGenerator : AtomicIdGenerator in class com.navercorp.pinpoint.profiler.context.DefaultBaseTraceFactory	From	To

400bc293ae1ce412e79bcae5d03d677bfdcea63b

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: