pinpoint 40e77e58fdb0d23a863a794eca7c6a21f340814e

40e77e58fdb0d23a863a794eca7c6a21f340814e

Files Diff

Added: 15
Removed: 0
Renamed: 0
Modified: 48

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	3
Rename Method public getCookieDumpType() : DumpType renamed to public getHttpDumpConfig() : HttpDumpConfig in class com.navercorp.pinpoint.plugin.okhttp.OkHttpPluginConfig	From	To
Rename Method public getCookieDumpType() : DumpType renamed to public getHttpDumpConfig() : HttpDumpConfig in class com.navercorp.pinpoint.plugin.ning.asynchttpclient.NingAsyncHttpClientPluginConfig	From	To
Rename Method public isProfileParam() : boolean renamed to public isParam() : boolean in class com.navercorp.pinpoint.plugin.ning.asynchttpclient.NingAsyncHttpClientPluginConfig	From	To
Move And Rename Method	3
Move And Rename Method private putHeader(httpRequestHeaders FluentCaseInsensitiveStringsMap, key String, value String) : void from class com.navercorp.pinpoint.plugin.ning.asynchttpclient.interceptor.ExecuteRequestInterceptor to public setHeader(name String, value String) : void from class com.navercorp.pinpoint.plugin.ning.asynchttpclient.NingAsyncHttpClientRequestTraceV1	From	To
Move And Rename Method private recordRequest(trace Trace, httpMethod HttpMethod, throwable Throwable) : void from class com.navercorp.pinpoint.plugin.httpclient3.interceptor.HttpMethodBaseExecuteMethodInterceptor to public record(recorder SpanEventRecorder, clientRequestTrace ClientRequestTrace, throwable Throwable) : void from class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder	From	To
Move And Rename Method private recordHttpRequest(trace Trace, httpRequest HttpRequest, throwable Throwable) : void from class com.navercorp.pinpoint.plugin.httpclient4.interceptor.HttpRequestExecutorExecuteMethodInterceptor to public record(recorder SpanEventRecorder, clientRequestTrace ClientRequestTrace, throwable Throwable) : void from class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder	From	To
Move Method	15
Move Method private getDestinationId(httpUrl HttpUrl) : String from class com.navercorp.pinpoint.plugin.okhttp.v3.interceptor.HttpEngineSendRequestMethodInterceptor to public getDestinationId() : String from class com.navercorp.pinpoint.plugin.okhttp.v2.OkHttpClientRequestTrace	From	To
Move Method private getEndpoint(host String, port int) : String from class com.navercorp.pinpoint.plugin.jdk.http.interceptor.HttpURLConnectionInterceptor to private getEndpoint(host String, port int) : String from class com.navercorp.pinpoint.plugin.jdk.http.JdkHttpClientRequestTrace	From	To
Move Method private getHost(httpMethod HttpMethod, args Object[]) : String from class com.navercorp.pinpoint.plugin.httpclient3.interceptor.HttpMethodBaseExecuteMethodInterceptor to public getHost() : String from class com.navercorp.pinpoint.plugin.httpclient3.HttpClient3RequestTrace	From	To
Move Method public getContentCharSet(entity HttpEntity) : String from class com.navercorp.pinpoint.plugin.httpclient4.interceptor.DefaultClientExchangeHandlerImplStartMethodInterceptor to public getContentCharSet(entity HttpEntity) : String from class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4RequestTrace	From	To
Move Method public entityUtilsToString(entity HttpEntity, defaultCharset String, maxLength int) : String from class com.navercorp.pinpoint.plugin.httpclient4.interceptor.DefaultClientExchangeHandlerImplStartMethodInterceptor to private entityUtilsToString(entity HttpEntity, defaultCharset String, maxLength int) : String from class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4RequestTrace	From	To
Move Method private getEndpoint(host String, port int) : String from class com.navercorp.pinpoint.plugin.httpclient4.interceptor.HttpRequestExecutorExecuteMethodInterceptor to private getEndpoint(host String, port int) : String from class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4RequestTrace	From	To
Move Method private entityUtilsToString(entity RequestEntity, charSet String) : String from class com.navercorp.pinpoint.plugin.httpclient3.interceptor.HttpMethodBaseExecuteMethodInterceptor to private entityUtilsToString(entity RequestEntity, charSet String) : String from class com.navercorp.pinpoint.plugin.httpclient3.HttpClient3RequestTrace	From	To
Move Method private getHttpUrl(host String, port int, uri URI, httpConnection HttpConnection) : String from class com.navercorp.pinpoint.plugin.httpclient3.interceptor.HttpMethodBaseExecuteMethodInterceptor to private getHttpUrl(host String, port int, uri URI, httpConnection HttpConnection) : String from class com.navercorp.pinpoint.plugin.httpclient3.HttpClient3RequestTrace	From	To
Move Method public entityUtilsToString(entity HttpEntity, defaultCharset String, maxLength int) : String from class com.navercorp.pinpoint.plugin.httpclient4.interceptor.HttpRequestExecutorExecuteMethodInterceptor to private entityUtilsToString(entity HttpEntity, defaultCharset String, maxLength int) : String from class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4RequestTrace	From	To
Move Method private getEndpoint(host String, port int) : String from class com.navercorp.pinpoint.plugin.httpclient3.interceptor.HttpMethodBaseExecuteMethodInterceptor to private getEndpoint(host String, port int) : String from class com.navercorp.pinpoint.plugin.httpclient3.HttpClient3RequestTrace	From	To
Move Method private getEndpoint(host String, port int) : String from class com.navercorp.pinpoint.plugin.httpclient4.interceptor.DefaultClientExchangeHandlerImplStartMethodInterceptor to private getEndpoint(host String, port int) : String from class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4RequestTrace	From	To
Move Method private getDestinationId(httpUrl URL) : String from class com.navercorp.pinpoint.plugin.okhttp.v3.interceptor.BridgeInterceptorInterceptMethodInterceptor to public getDestinationId() : String from class com.navercorp.pinpoint.plugin.okhttp.v2.OkHttpClientRequestTrace	From	To
Move Method public getContentCharSet(entity HttpEntity) : String from class com.navercorp.pinpoint.plugin.httpclient4.interceptor.HttpRequestExecutorExecuteMethodInterceptor to public getContentCharSet(entity HttpEntity) : String from class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4RequestTrace	From	To
Move Method private getDestinationId(httpUrl URL) : String from class com.navercorp.pinpoint.plugin.okhttp.v2.interceptor.HttpEngineSendRequestMethodInterceptor to public getDestinationId() : String from class com.navercorp.pinpoint.plugin.okhttp.v2.OkHttpClientRequestTrace	From	To
Move Method private getPort(httpConnection HttpConnection) : int from class com.navercorp.pinpoint.plugin.httpclient3.interceptor.HttpMethodBaseExecuteMethodInterceptor to private getPort(httpConnection HttpConnection) : int from class com.navercorp.pinpoint.plugin.httpclient3.HttpClient3RequestTrace	From	To
Inline Method	3
Inline Method private recordRootSpan(recorder SpanRecorder, request ServletRequestImpl) : void inlined to private createTrace(target Object, args Object[]) : Trace in class com.navercorp.pinpoint.plugin.weblogic.interceptor.AbstractServerHandleInterceptor	From	To
Inline Method private setHttpTraceHeader(target Object, args Object[], nextId TraceId) : void inlined to public before(target Object, args Object[]) : void in class com.navercorp.pinpoint.plugin.httpclient3.interceptor.HttpMethodBaseExecuteMethodInterceptor	From	To
Inline Method private setHttpSampledHeader(target Object) : void inlined to public before(target Object, args Object[]) : void in class com.navercorp.pinpoint.plugin.httpclient3.interceptor.HttpMethodBaseExecuteMethodInterceptor	From	To
Change Return Type	2
Change Return Type DumpType to HttpDumpConfig in method public getHttpDumpConfig() : HttpDumpConfig in class com.navercorp.pinpoint.plugin.okhttp.OkHttpPluginConfig	From	To
Change Return Type DumpType to HttpDumpConfig in method public getHttpDumpConfig() : HttpDumpConfig in class com.navercorp.pinpoint.plugin.ning.asynchttpclient.NingAsyncHttpClientPluginConfig	From	To
Move Attribute	10
Move Attribute private param : boolean from class com.navercorp.pinpoint.plugin.okhttp.v3.interceptor.HttpEngineSendRequestMethodInterceptor to private param : boolean from class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder	From	To
Move Attribute private SKIP_DEFAULT_PORT : int from class com.navercorp.pinpoint.plugin.httpclient3.interceptor.HttpMethodBaseExecuteMethodInterceptor to private SKIP_DEFAULT_PORT : int from class com.navercorp.pinpoint.plugin.httpclient3.HttpClient3RequestTrace	From	To
Move Attribute private param : boolean from class com.navercorp.pinpoint.plugin.jdk.http.interceptor.HttpURLConnectionInterceptor to private param : boolean from class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder	From	To
Move Attribute private param : boolean from class com.navercorp.pinpoint.plugin.okhttp.v2.interceptor.HttpEngineSendRequestMethodInterceptor to private param : boolean from class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder	From	To
Move Attribute private param : boolean from class com.navercorp.pinpoint.plugin.httpclient4.interceptor.HttpRequestExecutorExecuteMethodInterceptor to private param : boolean from class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder	From	To
Move Attribute private param : boolean from class com.navercorp.pinpoint.plugin.okhttp.v3.interceptor.BridgeInterceptorInterceptMethodInterceptor to private param : boolean from class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder	From	To
Move Attribute private param : boolean from class com.navercorp.pinpoint.plugin.vertx.interceptor.HttpClientStreamInterceptor to private param : boolean from class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder	From	To
Move Attribute private param : boolean from class com.navercorp.pinpoint.plugin.httpclient4.interceptor.DefaultClientExchangeHandlerImplStartMethodInterceptor to private param : boolean from class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder	From	To
Move Attribute private MAX_READ_SIZE : int from class com.navercorp.pinpoint.plugin.httpclient3.interceptor.HttpMethodBaseExecuteMethodInterceptor to private MAX_READ_SIZE : int from class com.navercorp.pinpoint.plugin.httpclient3.HttpClient3RequestTrace	From	To
Move Attribute private param : boolean from class com.navercorp.pinpoint.plugin.httpclient3.interceptor.HttpMethodBaseExecuteMethodInterceptor to private param : boolean from class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder	From	To
Extract Class	10
Extract Class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder from class com.navercorp.pinpoint.plugin.okhttp.v3.interceptor.HttpEngineSendRequestMethodInterceptor	From	To
Extract Class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder from class com.navercorp.pinpoint.plugin.jdk.http.interceptor.HttpURLConnectionInterceptor	From	To
Extract Class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder from class com.navercorp.pinpoint.plugin.okhttp.v2.interceptor.HttpEngineSendRequestMethodInterceptor	From	To
Extract Class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4RequestTrace from class com.navercorp.pinpoint.plugin.httpclient4.interceptor.HttpRequestExecutorExecuteMethodInterceptor	From	To
Extract Class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder from class com.navercorp.pinpoint.plugin.httpclient4.interceptor.HttpRequestExecutorExecuteMethodInterceptor	From	To
Extract Class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder from class com.navercorp.pinpoint.plugin.okhttp.v3.interceptor.BridgeInterceptorInterceptMethodInterceptor	From	To
Extract Class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder from class com.navercorp.pinpoint.plugin.httpclient4.interceptor.DefaultClientExchangeHandlerImplStartMethodInterceptor	From	To
Extract Class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder from class com.navercorp.pinpoint.plugin.httpclient3.interceptor.HttpMethodBaseExecuteMethodInterceptor	From	To
Extract Class com.navercorp.pinpoint.plugin.httpclient3.HttpClient3RequestTrace from class com.navercorp.pinpoint.plugin.httpclient3.interceptor.HttpMethodBaseExecuteMethodInterceptor	From	To
Extract Class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4RequestTrace from class com.navercorp.pinpoint.plugin.httpclient4.interceptor.DefaultClientExchangeHandlerImplStartMethodInterceptor	From	To
Rename Attribute	4
Rename Attribute entityDumpType : DumpType to httpDumpConfig : HttpDumpConfig in class com.navercorp.pinpoint.plugin.httpclient3.HttpClient3PluginConfig	From	To
Rename Attribute cookieDumpType : DumpType to httpDumpConfig : HttpDumpConfig in class com.navercorp.pinpoint.plugin.okhttp.OkHttpPluginConfig	From	To
Rename Attribute entityDumpType : DumpType to httpDumpConfig : HttpDumpConfig in class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4PluginConfig	From	To
Rename Attribute profileParam : boolean to param : boolean in class com.navercorp.pinpoint.plugin.ning.asynchttpclient.NingAsyncHttpClientPluginConfig	From	To
Extract Variable	4
Extract Variable remoteAddress : String in method public record(recorder SpanRecorder, serverRequestTrace ServerRequestTrace) : void from class com.navercorp.pinpoint.bootstrap.plugin.request.ServerRequestRecorder	From	To
Extract Variable rpcName : String in method public record(recorder SpanRecorder, serverRequestTrace ServerRequestTrace) : void from class com.navercorp.pinpoint.bootstrap.plugin.request.ServerRequestRecorder	From	To
Extract Variable endPoint : String in method public record(recorder SpanRecorder, serverRequestTrace ServerRequestTrace) : void from class com.navercorp.pinpoint.bootstrap.plugin.request.ServerRequestRecorder	From	To
Extract Variable resultToRequest : HttpClientRequest in method public after(target Object, args Object[], result Object, throwable Throwable) : void from class com.navercorp.pinpoint.plugin.vertx.interceptor.HttpClientImplDoRequestInterceptor	From	To
Extract Method	1
Extract Method private getHost(target Object) : String extracted from public before(target Object, args Object[]) : void in class com.navercorp.pinpoint.plugin.okhttp.v3.interceptor.RequestBuilderBuildMethodInterceptor	From	To
Change Attribute Type	3
Change Attribute Type entityDumpType : DumpType to httpDumpConfig : HttpDumpConfig in class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4PluginConfig	From	To
Change Attribute Type entityDumpType : DumpType to httpDumpConfig : HttpDumpConfig in class com.navercorp.pinpoint.plugin.httpclient3.HttpClient3PluginConfig	From	To
Change Attribute Type cookieDumpType : DumpType to httpDumpConfig : HttpDumpConfig in class com.navercorp.pinpoint.plugin.okhttp.OkHttpPluginConfig	From	To
Rename Parameter	1
Rename Parameter key : String to name : String in method public setHeader(name String, value String) : void in class com.navercorp.pinpoint.plugin.ning.asynchttpclient.NingAsyncHttpClientRequestTraceV1	From	To

40e77e58fdb0d23a863a794eca7c6a21f340814e

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: