469218807b1642291b5d7049e437b37289c28404
Files Diff
- Added: 9
- Removed: 7
- Renamed: 0
- Modified: 3
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 6 | ||
| Change Parameter Type classPathResolver : ClassPathResolver to agentDirectory : AgentDirectory in method private saveLogFilePath(agentDirectory AgentDirectory) : void in class com.navercorp.pinpoint.bootstrap.PinpointStarter | From | To | |
| Change Parameter Type classPathResolver : ClassPathResolver to agentDirectory : AgentDirectory in method private getConfigPath(agentDirectory AgentDirectory) : String in class com.navercorp.pinpoint.bootstrap.PinpointStarter | From | To | |
| Change Parameter Type bootstrapJarFile : BootstrapJarFile to jarFiles : List<JarFile> in method private closeJarFile(jarFiles List<JarFile>) : void in class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirBaseClassPathResolverTest | From | To | |
| Change Parameter Type classPathResolver : ClassPathResolver to agentDirectory : AgentDirectory in method public PinpointStarter(parentClassLoader ClassLoader, agentArgs Map<String,String>, agentDirectory AgentDirectory, instrumentation Instrumentation, moduleBootLoader ModuleBootLoader) in class com.navercorp.pinpoint.bootstrap.PinpointStarter | From | To | |
| Change Parameter Type agentJarFile : BootstrapJarFile to bootDir : BootDir in method private appendToBootstrapClassLoader(instrumentation Instrumentation, bootDir BootDir) : void in class com.navercorp.pinpoint.bootstrap.PinpointBootStrap | From | To | |
| Change Parameter Type classPathResolver : ClassPathResolver to classPathResolver : AgentDirectory in method private resolveLib(classPathResolver AgentDirectory) : URL[] in class com.navercorp.pinpoint.bootstrap.PinpointStarter | From | To | |
| Move Method | 5 | ||
| Move Method public getAgentJarName() : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver to public getAgentJarName() : String from class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirectory | From | To | |
| Move Method public getAgentJarFullPath() : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver to public getAgentJarFullPath() : String from class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirectory | From | To | |
| Move Method public getAgentDirPath() : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver to public getAgentDirPath() : String from class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirectory | From | To | |
| Move Method public getAgentConfigPath() : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver to public getAgentConfigPath() : String from class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirectory | From | To | |
| Move Method public getAgentLogFilePath() : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver to public getAgentLogFilePath() : String from class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirectory | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private agentDirPath : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver to private agentDirPath : String from class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirectory | From | To | |
| Move Attribute private agentJarName : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver to private agentJarName : String from class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirectory | From | To | |
| Move Attribute private agentJarFullPath : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver to private agentJarFullPath : String from class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirectory | From | To | |
| Extract Class | 2 | ||
| Extract Class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirectory from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver | From | To | |
| Extract Class com.navercorp.pinpoint.bootstrap.agentdir.BootDir from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class com.navercorp.pinpoint.bootstrap.ClassPathResolver moved and renamed to com.navercorp.pinpoint.bootstrap.agentdir.AgentDirectory | From | To | |
| Move Class | 5 | ||
| Move Class com.navercorp.pinpoint.bootstrap.JavaAgentPathResolver moved to com.navercorp.pinpoint.bootstrap.agentdir.JavaAgentPathResolver | From | To | |
| Move Class com.navercorp.pinpoint.bootstrap.JavaAgentPathResolverTest moved to com.navercorp.pinpoint.bootstrap.agentdir.JavaAgentPathResolverTest | From | To | |
| Move Class com.navercorp.pinpoint.bootstrap.AgentVersionTest moved to com.navercorp.pinpoint.bootstrap.agentdir.AgentVersionTest | From | To | |
| Move Class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver moved to com.navercorp.pinpoint.bootstrap.agentdir.AgentDirBaseClassPathResolver | From | To | |
| Move Class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolverTest moved to com.navercorp.pinpoint.bootstrap.agentdir.AgentDirBaseClassPathResolverTest | From | To | |
| Extract Method | 4 | ||
| Extract Method private find(bootDirPath String, name String, pattern Pattern) : String extracted from private findFromBootDir(name String, pattern Pattern) : String in class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirBaseClassPathResolver | From | To | |
| Extract Method private checkDirectory(file File) : boolean extracted from public resolvePlugins() : List<String> in class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirBaseClassPathResolver | From | To | |
| Extract Method private checkDirectory(file File) : boolean extracted from public resolveLib() : List<URL> in class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirBaseClassPathResolver | From | To | |
| Extract Method private resolveLib(agentLibPath String, bootDir BootDir) : List<URL> extracted from public resolveLib() : List<URL> in class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirBaseClassPathResolver | From | To | |
| Rename Method | 1 | ||
| Rename Method private findFromBootDir(name String, pattern Pattern) : String renamed to private resolveBootDir(agentDirPath String) : BootDir in class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirBaseClassPathResolver | From | To | |
| Rename Variable | 2 | ||
| Rename Variable file : File to directory : File in method private resolvePlugins(agentPluginPath String) : List<String> in class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirBaseClassPathResolver | From | To | |
| Rename Variable jarFileList : List<JarFile> to jarFiles : List<JarFile> in method private appendToBootstrapClassLoader(instrumentation Instrumentation, bootDir BootDir) : void in class com.navercorp.pinpoint.bootstrap.PinpointBootStrap | From | To | |
| Change Return Type | 2 | ||
| Change Return Type List<URL> to AgentDirectory in method public resolve() : AgentDirectory in class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirBaseClassPathResolver | From | To | |
| Change Return Type String to BootDir in method private resolveBootDir(agentDirPath String) : BootDir in class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirBaseClassPathResolver | From | To | |
| Parameterize Variable | 2 | ||
| Parameterize Variable jarFileList : List<JarFile> to jarFiles : List<JarFile> in method private closeJarFile(jarFiles List<JarFile>) : void in class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirBaseClassPathResolverTest | From | To | |
| Parameterize Variable libDir : File to file : File in method private checkDirectory(file File) : boolean in class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirBaseClassPathResolver | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute agentPattern : Pattern to agentBootstrapPattern : Pattern in class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirBaseClassPathResolver | From | To | |
| Rename Attribute DEFAULT_AGENT_PATTERN : Pattern to DEFAULT_AGENT_BOOTSTRAP_PATTERN : Pattern in class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirBaseClassPathResolver | From | To | |
| Rename Attribute classPathResolver : ClassPathResolver to agentDirectory : AgentDirectory in class com.navercorp.pinpoint.bootstrap.PinpointStarter | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type classPathResolver : ClassPathResolver to agentDirectory : AgentDirectory in class com.navercorp.pinpoint.bootstrap.PinpointStarter | From | To | |
| Rename Parameter | 6 | ||
| Rename Parameter name : String to agentDirPath : String in method private resolveBootDir(agentDirPath String) : BootDir in class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirBaseClassPathResolver | From | To | |
| Rename Parameter classPathResolver : ClassPathResolver to agentDirectory : AgentDirectory in method private saveLogFilePath(agentDirectory AgentDirectory) : void in class com.navercorp.pinpoint.bootstrap.PinpointStarter | From | To | |
| Rename Parameter classPathResolver : ClassPathResolver to agentDirectory : AgentDirectory in method private getConfigPath(agentDirectory AgentDirectory) : String in class com.navercorp.pinpoint.bootstrap.PinpointStarter | From | To | |
| Rename Parameter bootstrapJarFile : BootstrapJarFile to jarFiles : List<JarFile> in method private closeJarFile(jarFiles List<JarFile>) : void in class com.navercorp.pinpoint.bootstrap.agentdir.AgentDirBaseClassPathResolverTest | From | To | |
| Rename Parameter classPathResolver : ClassPathResolver to agentDirectory : AgentDirectory in method public PinpointStarter(parentClassLoader ClassLoader, agentArgs Map<String,String>, agentDirectory AgentDirectory, instrumentation Instrumentation, moduleBootLoader ModuleBootLoader) in class com.navercorp.pinpoint.bootstrap.PinpointStarter | From | To | |
| Rename Parameter agentJarFile : BootstrapJarFile to bootDir : BootDir in method private appendToBootstrapClassLoader(instrumentation Instrumentation, bootDir BootDir) : void in class com.navercorp.pinpoint.bootstrap.PinpointBootStrap | From | To |