4c02c0d2ab69d5fbcdc59aab2cc01cee0e27e3a0
Files Diff
- Added: 7
- Removed: 2
- Renamed: 0
- Modified: 27
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public setUrl(url String) : void renamed to public setUrlPattern(urlPattern String) : void in class com.navercorp.pinpoint.web.filter.FilterDescriptor | From | To | |
| Change Parameter Type | 7 | ||
| Change Parameter Type filter : Filter to filter : Filter<SpanBo> in method public selectApplicationMapWithScatterData(traceIdList List<TransactionId>, originalRange Range, scanRange Range, xGroupUnit int, yGroupUnit int, filter Filter<SpanBo>, version int) : ApplicationMap in class com.navercorp.pinpoint.web.service.FilteredMapService | From | To | |
| Change Parameter Type filter : Filter to filter : Filter<SpanBo> in method private selectFilteredSpan(transactionIdList List<TransactionId>, filter Filter<SpanBo>) : List<List<SpanBo>> in class com.navercorp.pinpoint.web.service.FilteredMapServiceImpl | From | To | |
| Change Parameter Type filter : Filter to filter : Filter<SpanBo> in method public linkStatistics(range Range, traceIdSet List<TransactionId>, sourceApplication Application, destinationApplication Application, filter Filter<SpanBo>) : LoadFactor in class com.navercorp.pinpoint.web.service.FilteredMapService | From | To | |
| Change Parameter Type filter : Filter to filter : Filter<SpanBo> in method public selectApplicationMapWithScatterData(transactionIdList List<TransactionId>, originalRange Range, scanRange Range, xGroupUnit int, yGroupUnit int, filter Filter<SpanBo>, version int) : ApplicationMap in class com.navercorp.pinpoint.web.service.FilteredMapServiceImpl | From | To | |
| Change Parameter Type filter : Filter to filter : Filter<SpanBo> in method private filterList2(transactionList List<List<SpanBo>>, filter Filter<SpanBo>) : List<List<SpanBo>> in class com.navercorp.pinpoint.web.service.FilteredMapServiceImpl | From | To | |
| Change Parameter Type filter : Filter to filter : Filter<SpanBo> in method public linkStatistics(range Range, traceIdSet List<TransactionId>, sourceApplication Application, destinationApplication Application, filter Filter<SpanBo>) : LoadFactor in class com.navercorp.pinpoint.web.service.FilteredMapServiceImpl | From | To | |
| Change Parameter Type filter : Filter to filter : Filter<SpanBo> in method private filterList(transactionList List<List<SpanBo>>, filter Filter<SpanBo>) : List<SpanBo> in class com.navercorp.pinpoint.web.service.FilteredMapServiceImpl | From | To | |
| Inline Method | 2 | ||
| Inline Method private flushLog(success boolean, message Object) : void inlined to public store(span Span) : void in class com.navercorp.pinpoint.profiler.context.storage.BufferedStorage | From | To | |
| Inline Method private flushLog(success boolean, message Object) : void inlined to private sendSpanChunk(spanEventList List<SpanEvent>) : void in class com.navercorp.pinpoint.profiler.context.storage.BufferedStorage | From | To | |
| Rename Variable | 4 | ||
| Rename Variable asyncSpanEventBoList : List<SpanEventBo> to spanChunkEventBoList : List<SpanEventBo> in method public include(spanBoList List<SpanBo>) : boolean in class com.navercorp.pinpoint.web.filter.SpanEventVisitor | From | To | |
| Rename Variable pLocalAsyncId : PLocalAsyncId.Builder to pAsyncIdBuilder : PLocalAsyncId.Builder in method package buildPSpanChunk(spanChunk SpanChunk) : PSpanChunk in class com.navercorp.pinpoint.profiler.context.proto.SpanProtoMessageConverter | From | To | |
| Rename Variable asyncSpanChunkBo : SpanChunkBo to spanChunkBo : SpanChunkBo in method public include(spanBoList List<SpanBo>) : boolean in class com.navercorp.pinpoint.web.filter.SpanEventVisitor | From | To | |
| Rename Variable asyncSpanChunkBoList : List<SpanChunkBo> to spanChunkBoList : List<SpanChunkBo> in method public include(spanBoList List<SpanBo>) : boolean in class com.navercorp.pinpoint.web.filter.SpanEventVisitor | From | To | |
| Rename Class | 1 | ||
| Rename Class com.navercorp.pinpoint.profiler.context.provider.SpanPostProcessorProvider renamed to com.navercorp.pinpoint.profiler.context.provider.SpanProcessorProvider | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable emptyHint : FilterHint to hint : FilterHint in method private newLinkFilter(descriptor FilterDescriptor, hint FilterHint) : LinkFilter in class com.navercorp.pinpoint.web.filter.LinkFilterTest | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute url : String to urlPattern : String in class com.navercorp.pinpoint.web.filter.FilterDescriptor | From | To | |
| Extract Variable | 8 | ||
| Extract Variable pLocalAsyncId : PLocalAsyncId in method package buildPSpanChunk(spanChunk SpanChunk) : PSpanChunk from class com.navercorp.pinpoint.profiler.context.proto.SpanProtoMessageConverter | From | To | |
| Extract Variable endPoint : String in method private buildNextEvent(spanEvent SpanEvent, pSpanEvent PSpanEvent.Builder) : PNextEvent from class com.navercorp.pinpoint.profiler.context.proto.SpanProtoMessageConverter | From | To | |
| Extract Variable destinationId : String in method private buildNextEvent(spanEvent SpanEvent, pSpanEvent PSpanEvent.Builder) : PNextEvent from class com.navercorp.pinpoint.profiler.context.proto.SpanProtoMessageConverter | From | To | |
| Extract Variable endPoint : String in method package buildPSpanChunk(spanChunk SpanChunk) : PSpanChunk from class com.navercorp.pinpoint.profiler.context.proto.SpanProtoMessageConverter | From | To | |
| Extract Variable urlPattern : String in method private createRpcUrlFilter(filterDescriptor FilterDescriptor) : URLPatternFilter from class com.navercorp.pinpoint.web.filter.LinkFilter | From | To | |
| Extract Variable startElapsed : int in method private bind(spanEvent SpanEventBo, pSpanEvent PSpanEvent, prevSpanEvent SpanEventBo) : void from class com.navercorp.pinpoint.common.server.bo.grpc.GrpcSpanFactory | From | To | |
| Extract Variable urlPattern : String in method private createAcceptUrlFilter(filterDescriptor FilterDescriptor) : URLPatternFilter from class com.navercorp.pinpoint.web.filter.LinkFilter | From | To | |
| Extract Method | 15 | ||
| Extract Method private newLinkFilter(descriptor FilterDescriptor, hint FilterHint) : LinkFilter extracted from public wasToWasFilter_noMatch_missingReceivingSpan() : void in class com.navercorp.pinpoint.web.filter.LinkFilterTest | From | To | |
| Extract Method private newPMessageEvent(builder PMessageEvent.Builder) : PMessageEvent.Builder extracted from private buildNextEvent(spanEvent SpanEvent, pSpanEvent PSpanEvent.Builder) : PNextEvent in class com.navercorp.pinpoint.profiler.context.proto.SpanProtoMessageConverter | From | To | |
| Extract Method private newLinkFilter(descriptor FilterDescriptor, hint FilterHint) : LinkFilter extracted from public wasToWasFilter_perfectMatch() : void in class com.navercorp.pinpoint.web.filter.LinkFilterTest | From | To | |
| Extract Method private newLinkFilter(descriptor FilterDescriptor, hint FilterHint) : LinkFilter extracted from public wasToUnknownFilter() : void in class com.navercorp.pinpoint.web.filter.LinkFilterTest | From | To | |
| Extract Method private newLinkFilter(descriptor FilterDescriptor, hint FilterHint) : LinkFilter extracted from public wasToBackendFilter() : void in class com.navercorp.pinpoint.web.filter.LinkFilterTest | From | To | |
| Extract Method private newLinkFilter(descriptor FilterDescriptor, hint FilterHint) : LinkFilter extracted from public wasToWasFilter_noMatch() : void in class com.navercorp.pinpoint.web.filter.LinkFilterTest | From | To | |
| Extract Method private newLinkFilter(descriptor FilterDescriptor, hint FilterHint) : LinkFilter extracted from public wasToQueueFilter() : void in class com.navercorp.pinpoint.web.filter.LinkFilterTest | From | To | |
| Extract Method private newLinkFilter(descriptor FilterDescriptor, hint FilterHint) : LinkFilter extracted from public userToWasFilter() : void in class com.navercorp.pinpoint.web.filter.LinkFilterTest | From | To | |
| Extract Method private newLinkFilter(descriptor FilterDescriptor, hint FilterHint) : LinkFilter extracted from public fromToFilterAgentTest() : void in class com.navercorp.pinpoint.web.filter.LinkFilterTest | From | To | |
| Extract Method private newLinkFilter(descriptor FilterDescriptor, hint FilterHint) : LinkFilter extracted from public queueToWasFilter() : void in class com.navercorp.pinpoint.web.filter.LinkFilterTest | From | To | |
| Extract Method private newLinkFilter(descriptor FilterDescriptor, hint FilterHint) : LinkFilter extracted from public fromToFilterTest() : void in class com.navercorp.pinpoint.web.filter.LinkFilterTest | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type spanDataHandler : ThriftSpanHandler to spanDataHandler : SimpleHandler in class com.navercorp.pinpoint.collector.receiver.SpanDispatchHandler | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter url : String to urlPattern : String in method public setUrlPattern(urlPattern String) : void in class com.navercorp.pinpoint.web.filter.FilterDescriptor | From | To |