4d6f718c6bf45ca375fe6f57dcaf2570a8b8b475
Files Diff
- Added: 4
- Removed: 13
- Renamed: 0
- Modified: 40
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 2 | ||
| Move And Rename Method private initializeServiceTypeStatisticsLookupTable(serviceTypes List<ServiceType>) : Map<String,List<ServiceType>> from class com.navercorp.pinpoint.common.ServiceType to private buildDescLookupTable(serviceTypes Collection<ServiceType>) : Map<String,List<ServiceType>> from class com.navercorp.pinpoint.common.util.ServiceTypeRegistry | From | To | |
| Move And Rename Method public DynamicAcceptHistogram() from class com.navercorp.pinpoint.profiler.monitor.metric.DynamicAcceptHistogram to public DefaultAcceptHistogram() from class com.navercorp.pinpoint.profiler.monitor.metric.DefaultAcceptHistogram | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type applicationServerType : ServiceType to applicationServerType : String in method public setApplicationServerType(applicationServerType String) : void in class com.navercorp.pinpoint.bootstrap.config.ProfilerConfig | From | To | |
| Change Parameter Type filterDescriptor : FilterDescriptor to fromServiceList : List<ServiceType> in method public FromToResponseFilter(fromServiceList List<ServiceType>, fromApplicationName String, fromAgentName String, toServiceList List<ServiceType>, toApplicationName String, toAgentName String, fromResponseTime Long, toResponseTime Long, includeFailed Boolean, hint FilterHint) in class com.navercorp.pinpoint.web.filter.FromToResponseFilter | From | To | |
| Change Parameter Type serviceTypes : List<ServiceType> to serviceTypes : Collection<ServiceType> in method private buildDescLookupTable(serviceTypes Collection<ServiceType>) : Map<String,List<ServiceType>> in class com.navercorp.pinpoint.common.util.ServiceTypeRegistry | From | To | |
| Move Method | 2 | ||
| Move Method public findDesc(desc String) : List<ServiceType> from class com.navercorp.pinpoint.common.ServiceType to public findDesc(desc String) : List<ServiceType> from class com.navercorp.pinpoint.common.util.ServiceTypeRegistry | From | To | |
| Move Method private getHistogram(responseKey ResponseKey) : Histogram from class com.navercorp.pinpoint.profiler.monitor.metric.DynamicAcceptHistogram to private getHistogram(responseKey ResponseKey) : Histogram from class com.navercorp.pinpoint.profiler.monitor.metric.DefaultAcceptHistogram | From | To | |
| Change Return Type | 2 | ||
| Change Return Type void to ServiceTypeRegistryService in method private loadServiceTypeProviders(pluginJars URL[]) : ServiceTypeRegistryService in class com.navercorp.pinpoint.bootstrap.PinpointBootStrap | From | To | |
| Change Return Type ServiceType to String in method public getApplicationServerType() : String in class com.navercorp.pinpoint.bootstrap.config.ProfilerConfig | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private map : ConcurrentMap<ResponseKey,Histogram> from class com.navercorp.pinpoint.profiler.monitor.metric.DynamicAcceptHistogram to private map : ConcurrentMap<ResponseKey,Histogram> from class com.navercorp.pinpoint.profiler.monitor.metric.DefaultAcceptHistogram | From | To | |
| Move Class | 3 | ||
| Move Class com.navercorp.pinpoint.web.service.ServiceTypeRegistryService moved to com.navercorp.pinpoint.common.service.ServiceTypeRegistryService | From | To | |
| Move Class com.navercorp.pinpoint.profiler.monitor.metric.DynamicAcceptHistogram.ResponseKey moved to com.navercorp.pinpoint.profiler.monitor.metric.DefaultAcceptHistogram.ResponseKey | From | To | |
| Move Class com.navercorp.pinpoint.collector.util.DefaultServiceTypeRegistryService moved to com.navercorp.pinpoint.common.service.DefaultServiceTypeRegistryService | From | To | |
| Replace Variable With Attribute | 2 | ||
| Replace Variable With Attribute typeProviderLoader : TypeProviderLoader to typeLoaderService : TypeLoaderService in method private loadType() : List<Type> in class com.navercorp.pinpoint.common.service.DefaultServiceTypeRegistryService | From | To | |
| Replace Variable With Attribute typeProviderLoader : TypeProviderLoader to typeLoaderService : TypeLoaderService in method private loadType() : List<Type> in class com.navercorp.pinpoint.web.service.DefaultAnnotationKeyMatcherService | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type typeProviderLoader : TypeProviderLoader to typeLoaderService : TypeLoaderService in method private loadType() : List<Type> in class com.navercorp.pinpoint.web.service.DefaultAnnotationKeyMatcherService | From | To | |
| Change Variable Type typeProviderLoader : TypeProviderLoader to typeLoaderService : TypeLoaderService in method private loadType() : List<Type> in class com.navercorp.pinpoint.common.service.DefaultServiceTypeRegistryService | From | To | |
| Split Parameter | 1 | ||
| Split Parameter filterDescriptor : FilterDescriptor to [fromApplicationName : String, fromAgentName : String, toApplicationName : String, toAgentName : String, fromResponseTime : Long, toResponseTime : Long, includeFailed : Boolean] in method public FromToResponseFilter(fromServiceList List<ServiceType>, fromApplicationName String, fromAgentName String, toServiceList List<ServiceType>, toApplicationName String, toAgentName String, fromResponseTime Long, toResponseTime Long, includeFailed Boolean, hint FilterHint) in class com.navercorp.pinpoint.web.filter.FromToResponseFilter | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type applicationServerType : ServiceType to applicationServerType : String in class com.navercorp.pinpoint.bootstrap.config.ProfilerConfig | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter serviceType : short to serviceTypeCode : short in method public addResponseTime(parentApplicationName String, serviceTypeCode short, millis int) : boolean in class com.navercorp.pinpoint.profiler.monitor.metric.DefaultAcceptHistogram | From | To | |
| Rename Parameter filterDescriptor : FilterDescriptor to fromServiceList : List<ServiceType> in method public FromToResponseFilter(fromServiceList List<ServiceType>, fromApplicationName String, fromAgentName String, toServiceList List<ServiceType>, toApplicationName String, toAgentName String, fromResponseTime Long, toResponseTime Long, includeFailed Boolean, hint FilterHint) in class com.navercorp.pinpoint.web.filter.FromToResponseFilter | From | To |