pinpoint 51c72032647640cc49a7a71e7a3d3164ccee65f9

51c72032647640cc49a7a71e7a3d3164ccee65f9

Files Diff

Added: 11
Removed: 3
Renamed: 0
Modified: 17

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	1
Move And Rename Method private appendServerInfo(node Node, linkDataDuplexMap LinkDataDuplexMap, agentInfoPopulator AgentInfoPopulator) : void from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1 to public createTerminalNodeInstanceList(terminalNode Node, linkDataDuplexMap LinkDataDuplexMap) : ServerInstanceList from class com.navercorp.pinpoint.web.applicationmap.appender.server.DefaultServerInstanceListFactory	From	To
Change Parameter Type	9
Change Parameter Type serverInstanceListDataSource : ServerInstanceListDataSource to serverInstanceListFactory : ServerInstanceListFactory in method public SerialServerInfoAppender(serverInstanceListFactory ServerInstanceListFactory) in class com.navercorp.pinpoint.web.applicationmap.appender.server.SerialServerInfoAppender	From	To
Change Parameter Type nodeHistogramDataSource : NodeHistogramDataSource to nodeHistogramFactory : NodeHistogramFactory in method public SerialNodeHistogramAppender(nodeHistogramFactory NodeHistogramFactory) in class com.navercorp.pinpoint.web.applicationmap.appender.histogram.SerialNodeHistogramAppender	From	To
Change Parameter Type nodeHistogramDataSource : NodeHistogramDataSource to nodeHistogramFactory : NodeHistogramFactory in method public ParallelNodeHistogramAppender(nodeHistogramFactory NodeHistogramFactory, executorService ExecutorService) in class com.navercorp.pinpoint.web.applicationmap.appender.histogram.ParallelNodeHistogramAppender	From	To
Change Parameter Type nodeHistogramDataSource : NodeHistogramDataSource to nodeHistogramFactory : NodeHistogramFactory in method public create(nodeHistogramFactory NodeHistogramFactory) : NodeHistogramAppender in class com.navercorp.pinpoint.web.applicationmap.appender.histogram.NodeHistogramAppenderFactory	From	To
Change Parameter Type agentInfoService : AgentInfoService to serverInstanceListFactory : ServerInstanceListFactory in method public create(serverInstanceListFactory ServerInstanceListFactory) : ServerInfoAppender in class com.navercorp.pinpoint.web.applicationmap.appender.server.ServerInfoAppenderFactory	From	To
Change Parameter Type agentInfoPopulator : AgentInfoPopulator to serverInstanceListFactory : ServerInstanceListFactory in method private appendAgentInfo(nodeList NodeList, linkDataDuplexMap LinkDataDuplexMap, serverInstanceListFactory ServerInstanceListFactory) : void in class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Change Parameter Type serverInstanceListDataSource : ServerInstanceListDataSource to serverInstanceListFactory : ServerInstanceListFactory in method public ParallelServerInfoAppender(serverInstanceListFactory ServerInstanceListFactory, executorService ExecutorService) in class com.navercorp.pinpoint.web.applicationmap.appender.server.ParallelServerInfoAppender	From	To
Change Parameter Type nodeToFind : Node to nodeNameToFind : String in method private findNode(nodes Collection<Node>, nodeNameToFind String) : Node in class com.navercorp.pinpoint.web.applicationmap.ApplicationMapVerifier	From	To
Change Parameter Type serverInstanceListDataSource : ServerInstanceListDataSource to serverInstanceListFactory : ServerInstanceListFactory in method public create(serverInstanceListFactory ServerInstanceListFactory) : ServerInfoAppender in class com.navercorp.pinpoint.web.applicationmap.appender.server.ServerInfoAppenderFactory	From	To
Move Method	6
Move Method private createUserNodeHistogram(range Range, node Node, linkList LinkList) : NodeHistogram from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.ParallelNodeHistogramAppender to public createUserNodeHistogram(userApplication Application, range Range, linkList LinkList) : NodeHistogram from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.DefaultNodeHistogramFactory	From	To
Move Method private createTerminalNodeHistogram(node Node, linkList LinkList) : NodeHistogram from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1 to public createTerminalNodeHistogram(terminalApplication Application, range Range, linkList LinkList) : NodeHistogram from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.DefaultNodeHistogramFactory	From	To
Move Method private createTerminalNodeInstanceList(node Node, linkDataDuplexMap LinkDataDuplexMap) : ServerInstanceList from class com.navercorp.pinpoint.web.applicationmap.appender.server.ParallelServerInfoAppender to public createTerminalNodeInstanceList(terminalNode Node, linkDataDuplexMap LinkDataDuplexMap) : ServerInstanceList from class com.navercorp.pinpoint.web.applicationmap.appender.server.DefaultServerInstanceListFactory	From	To
Move Method private createUserNodeHistogram(range Range, node Node, linkList LinkList) : NodeHistogram from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.SerialNodeHistogramAppender to public createUserNodeHistogram(userApplication Application, range Range, linkList LinkList) : NodeHistogram from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.DefaultNodeHistogramFactory	From	To
Move Method private createTerminalNodeHistogram(range Range, node Node, linkList LinkList) : NodeHistogram from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.SerialNodeHistogramAppender to public createTerminalNodeHistogram(terminalApplication Application, range Range, linkList LinkList) : NodeHistogram from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.DefaultNodeHistogramFactory	From	To
Move Method private createTerminalNodeHistogram(range Range, node Node, linkList LinkList) : NodeHistogram from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.ParallelNodeHistogramAppender to public createTerminalNodeHistogram(terminalApplication Application, range Range, linkList LinkList) : NodeHistogram from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.DefaultNodeHistogramFactory	From	To
Move Attribute	5
Move Attribute private serverInstanceListDataSource : ServerInstanceListDataSource from class com.navercorp.pinpoint.web.applicationmap.appender.server.SerialServerInfoAppender to private serverInstanceListDataSource : ServerInstanceListDataSource from class com.navercorp.pinpoint.web.applicationmap.appender.server.DefaultServerInstanceListFactory	From	To
Move Attribute private responseHistogramBuilder : ResponseHistogramBuilder from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderCompatibilityTest to private responseHistogramBuilder : ResponseHistogramBuilder from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.datasource.ResponseHistogramBuilderNodeHistogramDataSource	From	To
Move Attribute private mapResponseDao : MapResponseDao from class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderCompatibilityTest to private mapResponseDao : MapResponseDao from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.datasource.MapResponseNodeHistogramDataSource	From	To
Move Attribute private logger : Logger from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.SerialNodeHistogramAppender to private logger : Logger from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.DefaultNodeHistogramFactory	From	To
Move Attribute private serverInstanceListDataSource : ServerInstanceListDataSource from class com.navercorp.pinpoint.web.applicationmap.appender.server.ParallelServerInfoAppender to private serverInstanceListDataSource : ServerInstanceListDataSource from class com.navercorp.pinpoint.web.applicationmap.appender.server.DefaultServerInstanceListFactory	From	To
Move And Rename Class	3
Move And Rename Class com.navercorp.pinpoint.web.applicationmap.appender.server.ServerInstanceListAgentInfoServiceDataSource moved and renamed to com.navercorp.pinpoint.web.applicationmap.appender.server.datasource.AgentInfoServerInstanceListDataSource	From	To
Move And Rename Class com.navercorp.pinpoint.web.applicationmap.appender.histogram.NodeHistogramDataSource moved and renamed to com.navercorp.pinpoint.web.applicationmap.appender.histogram.datasource.WasNodeHistogramDataSource	From	To
Move And Rename Class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1.NodeHistogramDataSource moved and renamed to com.navercorp.pinpoint.web.applicationmap.appender.histogram.NodeHistogramFactory	From	To
Move Class	1
Move Class com.navercorp.pinpoint.web.applicationmap.appender.server.ServerInstanceListDataSource moved to com.navercorp.pinpoint.web.applicationmap.appender.server.datasource.ServerInstanceListDataSource	From	To
Extract Variable	1
Extract Variable application : Application in method private getNodeHistogramFuture(range Range, node Node, linkList LinkList) : CompletableFuture<Void> from class com.navercorp.pinpoint.web.applicationmap.appender.histogram.ParallelNodeHistogramAppender	From	To
Rename Method	2
Rename Method public createAppender(agentInfoService AgentInfoService) : ServerInfoAppender renamed to public create(serverInstanceListFactory ServerInstanceListFactory) : ServerInfoAppender in class com.navercorp.pinpoint.web.applicationmap.appender.server.ServerInfoAppenderFactory	From	To
Rename Method public from(nodeHistogramDataSource NodeHistogramDataSource) : NodeHistogramAppender renamed to public create(nodeHistogramFactory NodeHistogramFactory) : NodeHistogramAppender in class com.navercorp.pinpoint.web.applicationmap.appender.histogram.NodeHistogramAppenderFactory	From	To
Rename Variable	1
Rename Variable nodeType : ServiceType to serviceType : ServiceType in method private getNodeHistogramFuture(range Range, node Node, linkList LinkList) : CompletableFuture<Void> in class com.navercorp.pinpoint.web.applicationmap.appender.histogram.ParallelNodeHistogramAppender	From	To
Inline Method	2
Inline Method private build(nodeList NodeList, linkList LinkList, linkDataDuplexMap LinkDataDuplexMap, nodeHistogramAppender NodeHistogramAppender, serverInfoAppender ServerInfoAppender) : ApplicationMap inlined to public build(linkDataDuplexMap LinkDataDuplexMap) : ApplicationMap in class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV2	From	To
Inline Method public from(serverInstanceListDataSource ServerInstanceListDataSource) : ServerInfoAppender inlined to public create(serverInstanceListFactory ServerInstanceListFactory) : ServerInfoAppender in class com.navercorp.pinpoint.web.applicationmap.appender.server.ServerInfoAppenderFactory	From	To
Change Return Type	1
Change Return Type void to ServerInstanceList in method public createTerminalNodeInstanceList(terminalNode Node, linkDataDuplexMap LinkDataDuplexMap) : ServerInstanceList in class com.navercorp.pinpoint.web.applicationmap.appender.server.DefaultServerInstanceListFactory	From	To
Rename Attribute	5
Rename Attribute serverInstanceListDataSource : ServerInstanceListDataSource to serverInstanceListFactory : ServerInstanceListFactory in class com.navercorp.pinpoint.web.applicationmap.appender.server.SerialServerInfoAppender	From	To
Rename Attribute serverInstanceListDataSource : ServerInstanceListDataSource to serverInstanceListFactory : ServerInstanceListFactory in class com.navercorp.pinpoint.web.applicationmap.appender.server.ParallelServerInfoAppender	From	To
Rename Attribute nodeHistogramDataSource : NodeHistogramDataSource to nodeHistogramFactory : NodeHistogramFactory in class com.navercorp.pinpoint.web.applicationmap.appender.histogram.ParallelNodeHistogramAppender	From	To
Rename Attribute nodeHistogramDataSource : NodeHistogramDataSource to wasNodeHistogramDataSource : WasNodeHistogramDataSource in class com.navercorp.pinpoint.web.applicationmap.appender.histogram.NodeHistogramAppenderTestBase	From	To
Rename Attribute nodeHistogramDataSource : NodeHistogramDataSource to nodeHistogramFactory : NodeHistogramFactory in class com.navercorp.pinpoint.web.applicationmap.appender.histogram.SerialNodeHistogramAppender	From	To
Change Attribute Type	5
Change Attribute Type serverInstanceListDataSource : ServerInstanceListDataSource to serverInstanceListFactory : ServerInstanceListFactory in class com.navercorp.pinpoint.web.applicationmap.appender.server.SerialServerInfoAppender	From	To
Change Attribute Type serverInstanceListDataSource : ServerInstanceListDataSource to serverInstanceListFactory : ServerInstanceListFactory in class com.navercorp.pinpoint.web.applicationmap.appender.server.ParallelServerInfoAppender	From	To
Change Attribute Type nodeHistogramDataSource : NodeHistogramDataSource to nodeHistogramFactory : NodeHistogramFactory in class com.navercorp.pinpoint.web.applicationmap.appender.histogram.ParallelNodeHistogramAppender	From	To
Change Attribute Type nodeHistogramDataSource : NodeHistogramDataSource to wasNodeHistogramDataSource : WasNodeHistogramDataSource in class com.navercorp.pinpoint.web.applicationmap.appender.histogram.NodeHistogramAppenderTestBase	From	To
Change Attribute Type nodeHistogramDataSource : NodeHistogramDataSource to nodeHistogramFactory : NodeHistogramFactory in class com.navercorp.pinpoint.web.applicationmap.appender.histogram.SerialNodeHistogramAppender	From	To
Rename Parameter	11
Rename Parameter agentInfoService : AgentInfoService to serverInstanceListFactory : ServerInstanceListFactory in method public create(serverInstanceListFactory ServerInstanceListFactory) : ServerInfoAppender in class com.navercorp.pinpoint.web.applicationmap.appender.server.ServerInfoAppenderFactory	From	To
Rename Parameter node : Node to terminalNode : Node in method public createTerminalNodeInstanceList(terminalNode Node, linkDataDuplexMap LinkDataDuplexMap) : ServerInstanceList in class com.navercorp.pinpoint.web.applicationmap.appender.server.DefaultServerInstanceListFactory	From	To
Rename Parameter agentInfoPopulator : AgentInfoPopulator to serverInstanceListFactory : ServerInstanceListFactory in method private appendAgentInfo(nodeList NodeList, linkDataDuplexMap LinkDataDuplexMap, serverInstanceListFactory ServerInstanceListFactory) : void in class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderV1	From	To
Rename Parameter serverInstanceListDataSource : ServerInstanceListDataSource to serverInstanceListFactory : ServerInstanceListFactory in method public ParallelServerInfoAppender(serverInstanceListFactory ServerInstanceListFactory, executorService ExecutorService) in class com.navercorp.pinpoint.web.applicationmap.appender.server.ParallelServerInfoAppender	From	To
Rename Parameter nodeToFind : Node to nodeNameToFind : String in method private findNode(nodes Collection<Node>, nodeNameToFind String) : Node in class com.navercorp.pinpoint.web.applicationmap.ApplicationMapVerifier	From	To
Rename Parameter serverInstanceListDataSource : ServerInstanceListDataSource to serverInstanceListFactory : ServerInstanceListFactory in method public create(serverInstanceListFactory ServerInstanceListFactory) : ServerInfoAppender in class com.navercorp.pinpoint.web.applicationmap.appender.server.ServerInfoAppenderFactory	From	To
Rename Parameter serverInstanceListDataSource : ServerInstanceListDataSource to serverInstanceListFactory : ServerInstanceListFactory in method public SerialServerInfoAppender(serverInstanceListFactory ServerInstanceListFactory) in class com.navercorp.pinpoint.web.applicationmap.appender.server.SerialServerInfoAppender	From	To
Rename Parameter nodeHistogramDataSource : NodeHistogramDataSource to nodeHistogramFactory : NodeHistogramFactory in method public SerialNodeHistogramAppender(nodeHistogramFactory NodeHistogramFactory) in class com.navercorp.pinpoint.web.applicationmap.appender.histogram.SerialNodeHistogramAppender	From	To
Rename Parameter nodeHistogramDataSource : NodeHistogramDataSource to nodeHistogramFactory : NodeHistogramFactory in method public ParallelNodeHistogramAppender(nodeHistogramFactory NodeHistogramFactory, executorService ExecutorService) in class com.navercorp.pinpoint.web.applicationmap.appender.histogram.ParallelNodeHistogramAppender	From	To
Rename Parameter nodeHistogramDataSource : NodeHistogramDataSource to nodeHistogramFactory : NodeHistogramFactory in method public create(nodeHistogramFactory NodeHistogramFactory) : NodeHistogramAppender in class com.navercorp.pinpoint.web.applicationmap.appender.histogram.NodeHistogramAppenderFactory	From	To

51c72032647640cc49a7a71e7a3d3164ccee65f9

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: