5a3f709eafe7ca1c7b44d931aaa753a74dd6ef6f
Files Diff
- Added: 8
- Removed: 8
- Renamed: 0
- Modified: 33
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 2 | ||
| Move And Rename Method private getTestTcpDataSender() : TestTcpDataSender from class com.navercorp.pinpoint.test.PluginVerifierExternalAdaptor to private findTestTcpDataSender(injector Injector) : TestTcpDataSender from class com.navercorp.pinpoint.test.ApplicationContextHandler | From | To | |
| Move And Rename Method private getRecorder() : OrderedSpanRecorder from class com.navercorp.pinpoint.test.PluginVerifierExternalAdaptor to private findRecorder(injector Injector) : OrderedSpanRecorder from class com.navercorp.pinpoint.test.ApplicationContextHandler | From | To | |
| Extract Subclass | 1 | ||
| Extract Subclass com.navercorp.pinpoint.profiler.context.DefaultSpanChunk from class com.navercorp.pinpoint.profiler.context.SpanChunk | From | To | |
| Change Parameter Type | 8 | ||
| Change Parameter Type traceRoot : TraceRoot to spanChunkFactory : SpanChunkFactory in method public BufferedStorage(spanChunkFactory SpanChunkFactory, dataSender DataSender<Object>, bufferSize int) in class com.navercorp.pinpoint.profiler.context.storage.BufferedStorage | From | To | |
| Change Parameter Type sequence : short to sequence : int in method public DefaultLocalAsyncId(asyncId int, sequence int) in class com.navercorp.pinpoint.profiler.context.DefaultLocalAsyncId | From | To | |
| Change Parameter Type traceRoot : TraceRoot to spanChunkFactory : SpanChunkFactory in method public createStorage(spanChunkFactory SpanChunkFactory) : Storage in class com.navercorp.pinpoint.profiler.context.storage.LogStorageFactory | From | To | |
| Change Parameter Type localAsyncId : LocalAsyncId to localAsyncId : TLocalAsyncId in method public setLocalAsyncId(localAsyncId TLocalAsyncId) : void in class com.navercorp.pinpoint.thrift.dto.TSpanChunk | From | To | |
| Change Parameter Type traceRoot : TraceRoot to spanChunkFactory : SpanChunkFactory in method public createStorage(spanChunkFactory SpanChunkFactory) : Storage in class com.navercorp.pinpoint.profiler.context.storage.TraceLogDelegateStorageFactory | From | To | |
| Change Parameter Type traceRoot : TraceRoot to spanChunkFactory : SpanChunkFactory in method public createStorage(spanChunkFactory SpanChunkFactory) : Storage in class com.navercorp.pinpoint.profiler.context.storage.StorageFactory | From | To | |
| Change Parameter Type traceRoot : TraceRoot to spanChunkFactory : SpanChunkFactory in method public createStorage(spanChunkFactory SpanChunkFactory) : Storage in class com.navercorp.pinpoint.test.TestSpanStorageFactory | From | To | |
| Change Parameter Type traceRoot : TraceRoot to spanChunkFactory : SpanChunkFactory in method public createStorage(spanChunkFactory SpanChunkFactory) : Storage in class com.navercorp.pinpoint.profiler.context.storage.BufferedStorageFactory | From | To | |
| Move Method | 4 | ||
| Move Method private getServiceTypeRegistry() : ServiceTypeRegistryService from class com.navercorp.pinpoint.test.PluginVerifierExternalAdaptor to public getServiceTypeRegistry() : ServiceTypeRegistryService from class com.navercorp.pinpoint.test.ApplicationContextHandler | From | To | |
| Move Method public setLocalAsyncId(localAsyncId LocalAsyncId) : void from class com.navercorp.pinpoint.profiler.context.SpanEvent to public setLocalAsyncId(localAsyncId TLocalAsyncId) : void from class com.navercorp.pinpoint.thrift.dto.TSpanChunk | From | To | |
| Move Method private getAnnotationKeyRegistryService() : AnnotationKeyRegistryService from class com.navercorp.pinpoint.test.PluginVerifierExternalAdaptor to public getAnnotationKeyRegistryService() : AnnotationKeyRegistryService from class com.navercorp.pinpoint.test.ApplicationContextHandler | From | To | |
| Move Method public validate() : void from class com.navercorp.pinpoint.thrift.dto.TSpanChunk to public validate() : void from class com.navercorp.pinpoint.thrift.dto.TLocalAsyncId | From | To | |
| Push Down Attribute | 2 | ||
| Push Down Attribute private traceRoot : TraceRoot from class com.navercorp.pinpoint.profiler.context.SpanChunk to private traceRoot : TraceRoot from class com.navercorp.pinpoint.profiler.context.DefaultSpanChunk | From | To | |
| Push Down Attribute private spanEventList : List<SpanEvent> from class com.navercorp.pinpoint.profiler.context.SpanChunk to private spanEventList : List<SpanEvent> from class com.navercorp.pinpoint.profiler.context.DefaultSpanChunk | From | To | |
| Move Attribute | 8 | ||
| Move Attribute private traceRoot : TraceRoot from class com.navercorp.pinpoint.profiler.context.id.DefaultAsyncTraceId to private traceRoot : TraceRoot from class com.navercorp.pinpoint.profiler.context.SpanAsyncStateListenerTest | From | To | |
| Move Attribute private localAsyncId : LocalAsyncId from class com.navercorp.pinpoint.profiler.context.SpanEvent to private localAsyncId : LocalAsyncId from class com.navercorp.pinpoint.profiler.context.AsyncSpanChunkFactory | From | To | |
| Move Attribute private traceRoot : TraceRoot from class com.navercorp.pinpoint.profiler.context.storage.SpanStorage to private traceRoot : TraceRoot from class com.navercorp.pinpoint.profiler.context.SpanAsyncStateListenerTest | From | To | |
| Move Attribute private traceRoot : TraceRoot from class com.navercorp.pinpoint.profiler.context.storage.BufferedStorage to private traceRoot : TraceRoot from class com.navercorp.pinpoint.profiler.context.DefaultSpanChunkFactory | From | To | |
| Move Attribute private traceRoot : TraceRoot from class com.navercorp.pinpoint.profiler.context.storage.BufferedStorage to private traceRoot : TraceRoot from class com.navercorp.pinpoint.profiler.context.SpanAsyncStateListenerTest | From | To | |
| Move Attribute private localAsyncId : LocalAsyncId from class com.navercorp.pinpoint.profiler.context.SpanEvent to private localAsyncId : LocalAsyncId from class com.navercorp.pinpoint.profiler.context.DefaultAsyncSpanChunk | From | To | |
| Move Attribute private traceRoot : TraceRoot from class com.navercorp.pinpoint.profiler.context.storage.BufferedStorage to private traceRoot : TraceRoot from class com.navercorp.pinpoint.profiler.context.DefaultSpanChunk | From | To | |
| Move Attribute private traceRoot : TraceRoot from class com.navercorp.pinpoint.profiler.context.storage.BufferedStorage to private traceRoot : TraceRoot from class com.navercorp.pinpoint.profiler.context.AsyncSpanChunkFactory | From | To | |
| Extract Class | 2 | ||
| Extract Class com.navercorp.pinpoint.test.ApplicationContextHandler from class com.navercorp.pinpoint.test.PluginVerifierExternalAdaptor | From | To | |
| Extract Class com.navercorp.pinpoint.thrift.dto.TLocalAsyncId from class com.navercorp.pinpoint.thrift.dto.TSpanChunk | From | To | |
| Extract Variable | 2 | ||
| Extract Variable spanChunkFactory : SpanChunkFactory in method public onComplete_check_atomicity() : void from class com.navercorp.pinpoint.profiler.context.SpanAsyncStateListenerTest | From | To | |
| Extract Variable spanChunkFactory : SpanChunkFactory in method public onComplete() : void from class com.navercorp.pinpoint.profiler.context.SpanAsyncStateListenerTest | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type sequence : short to sequence : int in method public nextLocalAsyncId() : LocalAsyncId in class com.navercorp.pinpoint.profiler.context.DefaultAsyncId | From | To | |
| Change Variable Type spanEvent : SpanEvent to spanChunk : SpanChunk in method private wrap(obj Object) : ActualTrace in class com.navercorp.pinpoint.test.PluginVerifierExternalAdaptor | From | To | |
| Extract Method | 3 | ||
| Extract Method private getServiceTypeCode(obj Object) : short extracted from private isIgnored(obj Object) : boolean in class com.navercorp.pinpoint.test.PluginVerifierExternalAdaptor | From | To | |
| Extract Method private sendSpanChunk(spanEventList List<SpanEvent>) : void extracted from public store(spanEvent SpanEvent) : void in class com.navercorp.pinpoint.profiler.context.storage.BufferedStorage | From | To | |
| Extract Method private sendSpanChunk(spanEventList List<SpanEvent>) : void extracted from public flush() : void in class com.navercorp.pinpoint.profiler.context.storage.BufferedStorage | From | To | |
| Push Down Method | 3 | ||
| Push Down Method public getSpanEventList() : List<SpanEvent> from class com.navercorp.pinpoint.profiler.context.SpanChunk to public getSpanEventList() : List<SpanEvent> from class com.navercorp.pinpoint.profiler.context.DefaultSpanChunk | From | To | |
| Push Down Method public getTraceRoot() : TraceRoot from class com.navercorp.pinpoint.profiler.context.SpanChunk to public getTraceRoot() : TraceRoot from class com.navercorp.pinpoint.profiler.context.DefaultSpanChunk | From | To | |
| Push Down Method public SpanChunk(traceRoot TraceRoot, spanEventList List<SpanEvent>) from class com.navercorp.pinpoint.profiler.context.SpanChunk to public DefaultSpanChunk(traceRoot TraceRoot, spanEventList List<SpanEvent>) from class com.navercorp.pinpoint.profiler.context.DefaultSpanChunk | From | To | |
| Rename Variable | 1 | ||
| Rename Variable spanEvent : SpanEvent to spanChunk : SpanChunk in method private wrap(obj Object) : ActualTrace in class com.navercorp.pinpoint.test.PluginVerifierExternalAdaptor | From | To | |
| Change Return Type | 4 | ||
| Change Return Type short to int in method public getSequence() : int in class com.navercorp.pinpoint.profiler.context.LocalAsyncId | From | To | |
| Change Return Type short to int in method public nextAsyncSequence() : int in class com.navercorp.pinpoint.profiler.context.DefaultAsyncId | From | To | |
| Change Return Type short to int in method public getSequence() : int in class com.navercorp.pinpoint.profiler.context.DefaultLocalAsyncId | From | To | |
| Change Return Type short to int in method public nextAsyncSequence() : int in class com.navercorp.pinpoint.profiler.context.AsyncId | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute asyncId : int to localAsyncId : LocalAsyncId in class com.navercorp.pinpoint.test.Item | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type asyncId : int to localAsyncId : LocalAsyncId in class com.navercorp.pinpoint.test.Item | From | To | |
| Change Attribute Type sequence : short to sequence : int in class com.navercorp.pinpoint.profiler.context.DefaultLocalAsyncId | From | To | |
| Rename Parameter | 6 | ||
| Rename Parameter traceRoot : TraceRoot to spanChunkFactory : SpanChunkFactory in method public createStorage(spanChunkFactory SpanChunkFactory) : Storage in class com.navercorp.pinpoint.profiler.context.storage.BufferedStorageFactory | From | To | |
| Rename Parameter traceRoot : TraceRoot to spanChunkFactory : SpanChunkFactory in method public BufferedStorage(spanChunkFactory SpanChunkFactory, dataSender DataSender<Object>, bufferSize int) in class com.navercorp.pinpoint.profiler.context.storage.BufferedStorage | From | To | |
| Rename Parameter traceRoot : TraceRoot to spanChunkFactory : SpanChunkFactory in method public createStorage(spanChunkFactory SpanChunkFactory) : Storage in class com.navercorp.pinpoint.profiler.context.storage.LogStorageFactory | From | To | |
| Rename Parameter traceRoot : TraceRoot to spanChunkFactory : SpanChunkFactory in method public createStorage(spanChunkFactory SpanChunkFactory) : Storage in class com.navercorp.pinpoint.profiler.context.storage.TraceLogDelegateStorageFactory | From | To | |
| Rename Parameter traceRoot : TraceRoot to spanChunkFactory : SpanChunkFactory in method public createStorage(spanChunkFactory SpanChunkFactory) : Storage in class com.navercorp.pinpoint.profiler.context.storage.StorageFactory | From | To | |
| Rename Parameter traceRoot : TraceRoot to spanChunkFactory : SpanChunkFactory in method public createStorage(spanChunkFactory SpanChunkFactory) : Storage in class com.navercorp.pinpoint.test.TestSpanStorageFactory | From | To |