5c74ac38dea74ef1b16786ea4c51cc5d9aa4d6d1
Files Diff
- Added: 9
- Removed: 1
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Merge Attribute | 1 | ||
| Merge Attribute [pingDelay : long, timeoutMillis : long] to clientOption : ClientOption in class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandler | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method package getSocketHandler(channelConnectFuture ChannelFuture, address SocketAddress) : PinpointClientHandler from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientFactory to private awaitHandshake0() : PinpointClientHandler from class com.navercorp.pinpoint.rpc.client.Connection | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type retryInterval : int to retryInterval : long in method public PinpointClientHandshaker(handshakerTimer Timer, retryInterval long, maxHandshakeCount int) in class com.navercorp.pinpoint.rpc.client.PinpointClientHandshaker | From | To | |
| Move Method | 1 | ||
| Move Method private createChannelFactory(bossCount int, workerCount int, timer Timer) : ChannelFactory from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientFactory to public createChannelFactory(bossCount int, workerCount int, timer Timer) : ChannelFactory from class com.navercorp.pinpoint.rpc.client.ClientChannelFactory | From | To | |
| Move Attribute | 14 | ||
| Move Attribute private enableWorkerPacketDelay : long from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientFactory to private enableWorkerPacketDelay : long from class com.navercorp.pinpoint.rpc.client.ClientOption | From | To | |
| Move Attribute private DEFAULT_TIMEOUT_MILLIS : long from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientFactory to package DEFAULT_TIMEOUT_MILLIS : long from class com.navercorp.pinpoint.rpc.client.ClientOption | From | To | |
| Move Attribute private DEFAULT_TIMEOUT_MILLIS : long from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandler to package DEFAULT_TIMEOUT_MILLIS : long from class com.navercorp.pinpoint.rpc.client.ClientOption | From | To | |
| Move Attribute private pingDelay : long from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandler to private pingDelay : long from class com.navercorp.pinpoint.rpc.client.ClientOption | From | To | |
| Move Attribute private pingDelay : long from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientFactory to private pingDelay : long from class com.navercorp.pinpoint.rpc.client.ClientOption | From | To | |
| Move Attribute public CONNECT_TIMEOUT_MILLIS : String from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientFactory to private CONNECT_TIMEOUT_MILLIS : String from class com.navercorp.pinpoint.rpc.client.SocketOption | From | To | |
| Move Attribute private reconnectDelay : long from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientFactory to private reconnectDelay : long from class com.navercorp.pinpoint.rpc.client.ClientOption | From | To | |
| Move Attribute private DEFAULT_ENABLE_WORKER_PACKET_DELAY : long from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientFactory to package DEFAULT_ENABLE_WORKER_PACKET_DELAY : long from class com.navercorp.pinpoint.rpc.client.ClientOption | From | To | |
| Move Attribute private DEFAULT_ENABLE_WORKER_PACKET_DELAY : long from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandler to package DEFAULT_ENABLE_WORKER_PACKET_DELAY : long from class com.navercorp.pinpoint.rpc.client.ClientOption | From | To | |
| Move Attribute private DEFAULT_PING_DELAY : long from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientFactory to package DEFAULT_PING_DELAY : long from class com.navercorp.pinpoint.rpc.client.ClientOption | From | To | |
| Move Attribute private DEFAULT_PING_DELAY : long from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandler to package DEFAULT_PING_DELAY : long from class com.navercorp.pinpoint.rpc.client.ClientOption | From | To | |
| Move Attribute private timeoutMillis : long from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandler to private timeoutMillis : long from class com.navercorp.pinpoint.rpc.client.ClientOption | From | To | |
| Move Attribute private DEFAULT_CONNECT_TIMEOUT : int from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientFactory to package DEFAULT_CONNECT_TIMEOUT : int from class com.navercorp.pinpoint.rpc.client.SocketOption | From | To | |
| Move Attribute private timeoutMillis : long from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientFactory to private timeoutMillis : long from class com.navercorp.pinpoint.rpc.client.ClientOption | From | To | |
| Extract Class | 3 | ||
| Extract Class com.navercorp.pinpoint.rpc.client.SocketOption from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientFactory | From | To | |
| Extract Class com.navercorp.pinpoint.rpc.client.ClientOption from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientFactory | From | To | |
| Extract Class com.navercorp.pinpoint.rpc.client.ClientOption from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandler | From | To | |
| Move Class | 1 | ||
| Move Class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientFactory.ConnectEvent moved to com.navercorp.pinpoint.rpc.client.ConnectionFactory.ConnectEvent | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type timer : HashedWheelTimer to channelTimer : Timer in method public DefaultPinpointClientHandler(connectionFactory ConnectionFactory, handshakeData Map<String,Object>, localClusterOption ClusterOption, messageListener MessageListener, serverStreamChannelMessageListener ServerStreamChannelMessageListener, stateChangeEventListeners List<StateChangeEventListener>, channelTimer Timer, clientOption ClientOption) in class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandler | From | To | |
| Extract Method | 2 | ||
| Extract Method private getHandshakeResponseCode(responseCode HandshakeResponseCode, isFirst boolean) : HandshakeResponseCode extracted from private createHandshakeResponse(responseCode HandshakeResponseCode, isFirst boolean) : Map<String,Object> in class com.navercorp.pinpoint.rpc.server.DefaultPinpointServer | From | To | |
| Extract Method private reconnect() : void extracted from public channelClosed(ctx ChannelHandlerContext, e ChannelStateEvent) : void in class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandler | From | To | |
| Rename Method | 3 | ||
| Rename Method package issueNewSocketId() : int renamed to private nextSocketId() : int in class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientFactory | From | To | |
| Rename Method public getProperties() : Map<String,Object> renamed to public toMap() : Map<String,Object> in class com.navercorp.pinpoint.rpc.cluster.ClusterOption | From | To | |
| Rename Method protected getPinpointClient() : PinpointClient renamed to protected getPinpointSocket() : PinpointSocket in class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandler | From | To | |
| Inline Method | 1 | ||
| Inline Method private createBootStrap(bossCount int, workerCount int, timer Timer) : ClientBootstrap inlined to public DefaultPinpointClientFactory(bossCount int, workerCount int) in class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientFactory | From | To | |
| Change Return Type | 1 | ||
| Change Return Type PinpointClient to PinpointSocket in method protected getPinpointSocket() : PinpointSocket in class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandler | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable timer : HashedWheelTimer to channelTimer : Timer in method public DefaultPinpointClientHandler(connectionFactory ConnectionFactory, handshakeData Map<String,Object>, localClusterOption ClusterOption, messageListener MessageListener, serverStreamChannelMessageListener ServerStreamChannelMessageListener, stateChangeEventListeners List<StateChangeEventListener>, channelTimer Timer, clientOption ClientOption) in class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandler | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute clientFactory : DefaultPinpointClientFactory to connectionFactory : ConnectionFactory in class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandler | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type clientFactory : DefaultPinpointClientFactory to connectionFactory : ConnectionFactory in class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandler | From | To | |
| Change Attribute Type retryInterval : int to retryInterval : long in class com.navercorp.pinpoint.rpc.client.PinpointClientHandshaker | From | To | |
| Change Attribute Type clientFactory : PinpointClientFactory to clientFactory : DefaultPinpointClientFactory in class com.navercorp.pinpoint.rpc.client.PinpointClientFactoryTest | From | To |