6660a4a2f8a6c4c0ff2264c0444861fa1bd17f50
Files Diff
- Added: 11
- Removed: 2
- Renamed: 0
- Modified: 10
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 2 | ||
| Move And Rename Method public toString(span SpanEvent) : String from class com.navercorp.pinpoint.test.PluginTestAgent to private getClassPathAsString() : String from class com.navercorp.pinpoint.test.plugin.PinpointPluginTestStatement | From | To | |
| Move And Rename Method public toString(span Span) : String from class com.navercorp.pinpoint.test.PluginTestAgent to private getClassPathAsString() : String from class com.navercorp.pinpoint.test.plugin.PinpointPluginTestStatement | From | To | |
| Move Method | 1 | ||
| Move Method public toString(serviceCode short, annotations ExpectedAnnotation...) : String from class com.navercorp.pinpoint.test.PluginTestAgent to public toString() : String from class com.navercorp.pinpoint.test.PluginTestAgent.Expected | From | To | |
| Pull Up Attribute | 6 | ||
| Pull Up Attribute private agentJar : String from class com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite to private agentJar : String from class com.navercorp.pinpoint.test.plugin.AbstractPinpointPluginTestSuite | From | To | |
| Pull Up Attribute private configFile : String from class com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite to private configFile : String from class com.navercorp.pinpoint.test.plugin.AbstractPinpointPluginTestSuite | From | To | |
| Pull Up Attribute private REQUIRED_CLASS_PATHS : String[] from class com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite to private REQUIRED_CLASS_PATHS : String[] from class com.navercorp.pinpoint.test.plugin.AbstractPinpointPluginTestSuite | From | To | |
| Pull Up Attribute package JUNIT_OUTPUT_DELIMETER : String from class com.navercorp.pinpoint.test.plugin.ForkedPinpointPluginTest to public JUNIT_OUTPUT_DELIMETER : String from class com.navercorp.pinpoint.test.plugin.PinpointPluginTestConstants | From | To | |
| Pull Up Attribute package CHILD_CLASS_PATH_PREFIX : String from class com.navercorp.pinpoint.test.plugin.ForkedPinpointPluginTest to public CHILD_CLASS_PATH_PREFIX : String from class com.navercorp.pinpoint.test.plugin.PinpointPluginTestConstants | From | To | |
| Pull Up Attribute private jvmArguments : String[] from class com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite to private jvmArguments : String[] from class com.navercorp.pinpoint.test.plugin.AbstractPinpointPluginTestSuite | From | To | |
| Move Attribute | 1 | ||
| Move Attribute package JUNIT_OUTPUT_DELIMETER_REGEXP : String from class com.navercorp.pinpoint.test.plugin.ForkedPinpointPluginTest to private JUNIT_OUTPUT_DELIMETER_REGEXP : String from class com.navercorp.pinpoint.test.plugin.PinpointPluginTestStatement | From | To | |
| Move Class | 1 | ||
| Move Class com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite.ChildProcessException moved to com.navercorp.pinpoint.test.plugin.ChildProcessException | From | To | |
| Extract Variable | 2 | ||
| Extract Variable api : String in method private addData(data TBase<?,?>) : void from class com.navercorp.pinpoint.test.TestTcpDataSender | From | To | |
| Extract Variable subKey : String in method private combination(groups List<List<List<Artifact>>>) : Map<String,List<Artifact>> from class com.navercorp.pinpoint.test.plugin.DependencyResolver | From | To | |
| Inline Variable | 2 | ||
| Inline Variable fileList : File[] in method private addRunnersWithLibraryPath(testClass Class<?>, testClassLocation String) : void from class com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite | From | To | |
| Inline Variable libList : File[] in method private addJars(libDir File, libraries List<String>) : void from class com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite | From | To | |
| Extract Method | 1 | ||
| Extract Method private findApiId(method Method) : int extracted from public verifyApi(serviceType ServiceType, method Method, params Object...) : void in class com.navercorp.pinpoint.test.PluginTestAgent | From | To | |
| Rename Method | 2 | ||
| Rename Method private addRunnersWithDependencies(testClass Class<?>, testClassLocation String) : void renamed to private createCasesWithDependencies(context PinpointPluginTestContext) : List<PinpointPluginTestInstance> in class com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite | From | To | |
| Rename Method private addRunnersWithLibraryPath(testClass Class<?>, testClassLocation String) : void renamed to private createCasesWithLibraryPath(context PinpointPluginTestContext) : List<PinpointPluginTestInstance> in class com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite | From | To | |
| Pull Up Method | 6 | ||
| Pull Up Method protected withBeforeClasses(statement Statement) : Statement from class com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite to protected withBeforeClasses(statement Statement) : Statement from class com.navercorp.pinpoint.test.plugin.AbstractPinpointPluginTestSuite | From | To | |
| Pull Up Method protected getChildren() : List<Runner> from class com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite to protected getChildren() : List<Runner> from class com.navercorp.pinpoint.test.plugin.AbstractPinpointPluginTestSuite | From | To | |
| Pull Up Method private resolveAgentPath(agent PinpointAgent) : String from class com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite to private resolveAgentPath(agent PinpointAgent) : String from class com.navercorp.pinpoint.test.plugin.AbstractPinpointPluginTestSuite | From | To | |
| Pull Up Method private toPathString(url URL) : String from class com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite to private toPathString(url URL) : String from class com.navercorp.pinpoint.test.plugin.AbstractPinpointPluginTestSuite | From | To | |
| Pull Up Method private resolveTestClassLocation(testClass Class<?>) : String from class com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite to private resolveTestClassLocation(testClass Class<?>) : String from class com.navercorp.pinpoint.test.plugin.AbstractPinpointPluginTestSuite | From | To | |
| Pull Up Method protected withAfterClasses(statement Statement) : Statement from class com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite to protected withAfterClasses(statement Statement) : Statement from class com.navercorp.pinpoint.test.plugin.AbstractPinpointPluginTestSuite | From | To | |
| Change Return Type | 2 | ||
| Change Return Type void to List<PinpointPluginTestInstance> in method private createCasesWithLibraryPath(context PinpointPluginTestContext) : List<PinpointPluginTestInstance> in class com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite | From | To | |
| Change Return Type void to List<PinpointPluginTestInstance> in method private createCasesWithDependencies(context PinpointPluginTestContext) : List<PinpointPluginTestInstance> in class com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass com.navercorp.pinpoint.test.plugin.AbstractPinpointPluginTestSuite from classes [com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite] | From | To | |
| Extract Interface | 1 | ||
| Extract Interface com.navercorp.pinpoint.test.plugin.PinpointPluginTestConstants from classes [com.navercorp.pinpoint.test.plugin.ForkedPinpointPluginTest, com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite] | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter serviceType : ServiceType to expected : ServiceType in method public verifyServerType(expected ServiceType) : void in class com.navercorp.pinpoint.bootstrap.plugin.test.PluginTestVerifier | From | To | |
| Rename Parameter count : int to expected : int in method public verifySpanCount(expected int) : void in class com.navercorp.pinpoint.bootstrap.plugin.test.PluginTestVerifier | From | To | |
| Rename Parameter params : Object... to args : Object... in method public verifyApi(serviceType ServiceType, method Method, args Object...) : void in class com.navercorp.pinpoint.test.PluginTestAgent | From | To |