6ea54a2fbefc3364c5b4a1d2a43c308aa34986f7
Files Diff
- Added: 28
- Removed: 3
- Renamed: 0
- Modified: 22
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 1 | ||
Rename Method public encodeValues() : void renamed to public encodeAndDecodeTest() : void in class com.navercorp.pinpoint.common.server.bo.codec.stat.join.CpuLoadCodecTest | From | To | |
Change Parameter Type | 3 | ||
Change Parameter Type codecs : List<ApplicationStatCodec> to codecs : List<T> in method public ApplicationStatDecoder(codecs List<T>) in class com.navercorp.pinpoint.common.server.bo.codec.stat.ApplicationStatDecoder | From | To | |
Change Parameter Type cpuLoadCodecs : List<ApplicationStatCodec> to cpuLoadCodecs : List<CpuLoadCodec> in method public CpuLoadDecoder(cpuLoadCodecs List<CpuLoadCodec>) in class com.navercorp.pinpoint.common.server.bo.codec.stat.join.CpuLoadDecoder | From | To | |
Change Parameter Type joinCpuLoadBoList : List<JoinCpuLoadBo> to joinCpuLoadBoList : List in method private castJoinStatBoList(joinCpuLoadBoList List) : List<JoinStatBo> in class com.navercorp.pinpoint.flink.dao.hbase.StatisticsDao | From | To | |
Rename Variable | 5 | ||
Rename Variable joinCpuLoadBoList : List<JoinCpuLoadBo> to joinMemoryBoList : List<JoinMemoryBo> in method private joinMemoryBoByTimeSlice(joinApplicaitonStatBoList List<JoinApplicationStatBo>) : List<JoinMemoryBo> in class com.navercorp.pinpoint.common.server.bo.stat.join.JoinApplicationStatBo | From | To | |
Rename Variable joinCpuLoadBoMap : Map<Long,List<JoinCpuLoadBo>> to joinMemoryBoMap : Map<Long,List<JoinMemoryBo>> in method private joinMemoryBoByTimeSlice(joinApplicaitonStatBoList List<JoinApplicationStatBo>) : List<JoinMemoryBo> in class com.navercorp.pinpoint.common.server.bo.stat.join.JoinApplicationStatBo | From | To | |
Rename Variable joinCpuLoadBo : JoinCpuLoadBo to joinMemoryBo : JoinMemoryBo in method private joinMemoryBoByTimeSlice(joinApplicaitonStatBoList List<JoinApplicationStatBo>) : List<JoinMemoryBo> in class com.navercorp.pinpoint.common.server.bo.stat.join.JoinApplicationStatBo | From | To | |
Rename Variable newJoinCpuLoadBoList : ArrayList<JoinCpuLoadBo> to newJoinMemoryBoList : List<JoinMemoryBo> in method private joinMemoryBoByTimeSlice(joinApplicaitonStatBoList List<JoinApplicationStatBo>) : List<JoinMemoryBo> in class com.navercorp.pinpoint.common.server.bo.stat.join.JoinApplicationStatBo | From | To | |
Rename Variable cpuLoadBoList : List<CpuLoadBo> to agentId : String in method public map(agentStatBo AgentStatBo) : List<TFAgentStat> in class com.navercorp.pinpoint.collector.mapper.thrift.stat.TFAgentStatMappter | From | To | |
Pull Up Attribute | 2 | ||
Pull Up Attribute public UNKNOWN_AGENT : String from class com.navercorp.pinpoint.common.server.bo.stat.join.JoinCpuLoadBo to public UNKNOWN_AGENT : String from class com.navercorp.pinpoint.common.server.bo.stat.join.JoinStatBo | From | To | |
Pull Up Attribute public UNKNOWN_ID : String from class com.navercorp.pinpoint.common.server.bo.stat.join.JoinCpuLoadBo to public UNKNOWN_ID : String from class com.navercorp.pinpoint.common.server.bo.stat.join.JoinStatBo | From | To | |
Move Attribute | 3 | ||
Move Attribute private applicationStatHbaseOperationFactory : ApplicationStatHbaseOperationFactory from class com.navercorp.pinpoint.flink.dao.hbase.StatisticsDao to private applicationStatHbaseOperationFactory : ApplicationStatHbaseOperationFactory from class com.navercorp.pinpoint.flink.dao.hbase.CpuLoadDao | From | To | |
Move Attribute private cpuLoadSerializer : CpuLoadSerializer from class com.navercorp.pinpoint.flink.dao.hbase.StatisticsDao to private cpuLoadSerializer : CpuLoadSerializer from class com.navercorp.pinpoint.flink.dao.hbase.CpuLoadDao | From | To | |
Move Attribute private hbaseTemplate2 : HbaseTemplate2 from class com.navercorp.pinpoint.flink.dao.hbase.StatisticsDao to private hbaseTemplate2 : HbaseTemplate2 from class com.navercorp.pinpoint.flink.dao.hbase.CpuLoadDao | From | To | |
Extract Class | 1 | ||
Extract Class com.navercorp.pinpoint.flink.dao.hbase.CpuLoadDao from class com.navercorp.pinpoint.flink.dao.hbase.StatisticsDao | From | To | |
Rename Class | 1 | ||
Rename Class com.navercorp.pinpoint.web.service.ApplicationStatChartServiceImpl renamed to com.navercorp.pinpoint.web.service.ApplicationCpuLoadService | From | To | |
Move Class | 2 | ||
Move Class flink.mapper.thrift.stat.JoinAgentStatBoMapperTest moved to com.navercorp.pinpoint.flink.mapper.thrift.stat.JoinAgentStatBoMapperTest | From | To | |
Move Class flink.mapper.thrift.stat.JoinCpuLoadBoMapperTest moved to com.navercorp.pinpoint.flink.mapper.thrift.stat.JoinCpuLoadBoMapperTest | From | To | |
Rename Attribute | 2 | ||
Rename Attribute hbaseTemplate2 : HbaseTemplate2 to memoryDao : MemoryDao in class com.navercorp.pinpoint.flink.dao.hbase.StatisticsDao | From | To | |
Rename Attribute cpuLoadSerializer : CpuLoadSerializer to cpuLoadDao : CpuLoadDao in class com.navercorp.pinpoint.flink.dao.hbase.StatisticsDao | From | To | |
Change Variable Type | 5 | ||
Change Variable Type joinCpuLoadBo : JoinCpuLoadBo to joinMemoryBo : JoinMemoryBo in method private joinMemoryBoByTimeSlice(joinApplicaitonStatBoList List<JoinApplicationStatBo>) : List<JoinMemoryBo> in class com.navercorp.pinpoint.common.server.bo.stat.join.JoinApplicationStatBo | From | To | |
Change Variable Type joinCpuLoadBoMap : Map<Long,List<JoinCpuLoadBo>> to joinMemoryBoMap : Map<Long,List<JoinMemoryBo>> in method private joinMemoryBoByTimeSlice(joinApplicaitonStatBoList List<JoinApplicationStatBo>) : List<JoinMemoryBo> in class com.navercorp.pinpoint.common.server.bo.stat.join.JoinApplicationStatBo | From | To | |
Change Variable Type joinCpuLoadBoList : List<JoinCpuLoadBo> to joinMemoryBoList : List<JoinMemoryBo> in method private joinMemoryBoByTimeSlice(joinApplicaitonStatBoList List<JoinApplicationStatBo>) : List<JoinMemoryBo> in class com.navercorp.pinpoint.common.server.bo.stat.join.JoinApplicationStatBo | From | To | |
Change Variable Type newJoinCpuLoadBoList : ArrayList<JoinCpuLoadBo> to newJoinMemoryBoList : List<JoinMemoryBo> in method private joinMemoryBoByTimeSlice(joinApplicaitonStatBoList List<JoinApplicationStatBo>) : List<JoinMemoryBo> in class com.navercorp.pinpoint.common.server.bo.stat.join.JoinApplicationStatBo | From | To | |
Change Variable Type cpuLoadBoList : List<CpuLoadBo> to agentId : String in method public map(agentStatBo AgentStatBo) : List<TFAgentStat> in class com.navercorp.pinpoint.collector.mapper.thrift.stat.TFAgentStatMappter | From | To | |
Extract Method | 3 | ||
Extract Method private joinMemoryBoByTimeSlice(joinApplicaitonStatBoList List<JoinApplicationStatBo>) : List<JoinMemoryBo> extracted from public joinApplicationStatBoByTimeSlice(joinApplicaitonStatBoList List<JoinApplicationStatBo>) : JoinApplicationStatBo in class com.navercorp.pinpoint.common.server.bo.stat.join.JoinApplicationStatBo | From | To | |
Extract Method private extractMinTimestamp(joinApplicationStatBo JoinApplicationStatBo) : long extracted from public joinApplicationStatBoByTimeSlice(joinApplicaitonStatBoList List<JoinApplicationStatBo>) : JoinApplicationStatBo in class com.navercorp.pinpoint.common.server.bo.stat.join.JoinApplicationStatBo | From | To | |
Extract Method public getJoinMemoryBoList() : List<JoinMemoryBo> extracted from public joinApplicationStatBoByTimeSlice(joinApplicaitonStatBoList List<JoinApplicationStatBo>) : JoinApplicationStatBo in class com.navercorp.pinpoint.common.server.bo.stat.join.JoinApplicationStatBo | From | To | |
Change Attribute Type | 3 | ||
Change Attribute Type cpuLoadSerializer : CpuLoadSerializer to cpuLoadDao : CpuLoadDao in class com.navercorp.pinpoint.flink.dao.hbase.StatisticsDao | From | To | |
Change Attribute Type codecs : List<ApplicationStatCodec> to codecs : List<T> in class com.navercorp.pinpoint.common.server.bo.codec.stat.ApplicationStatDecoder | From | To | |
Change Attribute Type hbaseTemplate2 : HbaseTemplate2 to memoryDao : MemoryDao in class com.navercorp.pinpoint.flink.dao.hbase.StatisticsDao | From | To | |
Extract And Move Method | 1 | ||
Extract And Move Method public getStartTimestamp() : long extracted from public map(agentStatBo AgentStatBo) : List<TFAgentStat> in class com.navercorp.pinpoint.collector.mapper.thrift.stat.TFAgentStatMappter & moved to class com.navercorp.pinpoint.common.server.bo.stat.AgentStatBo | From | To |