72e939ab0856e811c4c15105b45b61c74a0800f3
Files Diff
- Added: 10
- Removed: 4
- Renamed: 0
- Modified: 16
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Extract Subclass | 1 | ||
| Extract Subclass com.navercorp.pinpoint.common.util.DefaultSqlParser from class com.navercorp.pinpoint.common.util.SqlParser | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private sqlParser : SqlParser from class com.navercorp.pinpoint.profiler.context.DefaultTraceContext to private sqlParser : SqlParser from class com.navercorp.pinpoint.profiler.context.DefaultCachingSqlNormalizer | From | To | |
| Move Attribute private sqlCache : SimpleCache<String> from class com.navercorp.pinpoint.profiler.context.DefaultTraceContext to private sqlCache : SimpleCache<String> from class com.navercorp.pinpoint.profiler.context.DefaultCachingSqlNormalizer | From | To | |
| Push Down Attribute | 3 | ||
| Push Down Attribute public SYMBOL_REPLACE : char from class com.navercorp.pinpoint.common.util.SqlParser to public SYMBOL_REPLACE : char from class com.navercorp.pinpoint.common.util.DefaultSqlParser | From | To | |
| Push Down Attribute private NEXT_TOKEN_NOT_EXIST : int from class com.navercorp.pinpoint.common.util.SqlParser to private NEXT_TOKEN_NOT_EXIST : int from class com.navercorp.pinpoint.common.util.DefaultSqlParser | From | To | |
| Push Down Attribute public NUMBER_REPLACE : char from class com.navercorp.pinpoint.common.util.SqlParser to public NUMBER_REPLACE : char from class com.navercorp.pinpoint.common.util.DefaultSqlParser | From | To | |
| Extract Class | 1 | ||
| Extract Class com.navercorp.pinpoint.profiler.context.DefaultCachingSqlNormalizer from class com.navercorp.pinpoint.profiler.context.DefaultTraceContext | From | To | |
| Rename Class | 1 | ||
| Rename Class com.navercorp.pinpoint.common.util.SqlParserTest renamed to com.navercorp.pinpoint.common.util.DefaultSqlParserTest | From | To | |
| Move Class | 3 | ||
| Move Class com.navercorp.pinpoint.common.util.DefaultParsingResultTest moved to com.navercorp.pinpoint.profiler.context.DefaultParsingResultTest | From | To | |
| Move Class com.navercorp.pinpoint.common.util.DefaultParsingResult moved to com.navercorp.pinpoint.profiler.context.DefaultParsingResult | From | To | |
| Move Class com.navercorp.pinpoint.common.util.ParsingResult moved to com.navercorp.pinpoint.bootstrap.context.ParsingResult | From | To | |
| Change Variable Type | 9 | ||
| Change Variable Type parsingResult : ParsingResult to parsingResult : NormalizedSql in method private assertEqual(expected String) : void in class com.navercorp.pinpoint.common.util.DefaultSqlParserTest | From | To | |
| Change Variable Type parsingResult : ParsingResult to parsingResult : NormalizedSql in method private assertCombine(result String, sql String, outputParams String) : void in class com.navercorp.pinpoint.common.util.DefaultSqlParserTest | From | To | |
| Change Variable Type parsingResult : ParsingResult to parsingResult : NormalizedSql in method private assertEqual(expected String, actual String, outputExpected String) : void in class com.navercorp.pinpoint.common.util.DefaultSqlParserTest | From | To | |
| Change Variable Type parsingResult : ParsingResult to parsingResult : NormalizedSql in method private assertEqualObject(expected String) : void in class com.navercorp.pinpoint.common.util.DefaultSqlParserTest | From | To | |
| Change Variable Type parsingResult : ParsingResult to parsingResult : NormalizedSql in method private assertEqual(expected String, actual String) : void in class com.navercorp.pinpoint.common.util.DefaultSqlParserTest | From | To | |
| Change Variable Type parsingResult : ParsingResult to parsingResult : NormalizedSql in method public normalizedSql() : void in class com.navercorp.pinpoint.common.util.DefaultSqlParserTest | From | To | |
| Change Variable Type parsingResult2 : ParsingResult to parsingResult2 : NormalizedSql in method public normalizedSql() : void in class com.navercorp.pinpoint.common.util.DefaultSqlParserTest | From | To | |
| Change Variable Type parsingResult3 : ParsingResult to parsingResult3 : NormalizedSql in method public normalizedSql() : void in class com.navercorp.pinpoint.common.util.DefaultSqlParserTest | From | To | |
| Change Variable Type parsingResult2 : ParsingResult to parsingResult2 : NormalizedSql in method public separatorTest() : void in class com.navercorp.pinpoint.common.util.DefaultSqlParserTest | From | To | |
| Inline Variable | 1 | ||
| Inline Variable normalizedSql : String in method public cacheSql(parsingResult ParsingResult) : boolean from class com.navercorp.pinpoint.profiler.context.DefaultTraceContext | From | To | |
| Push Down Method | 4 | ||
| Push Down Method private lookAhead1(sql String, index int) : int from class com.navercorp.pinpoint.common.util.SqlParser to private lookAhead1(sql String, index int) : int from class com.navercorp.pinpoint.common.util.DefaultSqlParser | From | To | |
| Push Down Method public combineOutputParams(sql String, outputParams List<String>) : String from class com.navercorp.pinpoint.common.util.SqlParser to public combineOutputParams(sql String, outputParams List<String>) : String from class com.navercorp.pinpoint.common.util.DefaultSqlParser | From | To | |
| Push Down Method private readLine(sql String, normalized StringBuilder, index int) : int from class com.navercorp.pinpoint.common.util.SqlParser to private readLine(sql String, normalized StringBuilder, index int) : int from class com.navercorp.pinpoint.common.util.DefaultSqlParser | From | To | |
| Push Down Method public normalizedSql(sql String) : DefaultParsingResult from class com.navercorp.pinpoint.common.util.SqlParser to public normalizedSql(sql String) : NormalizedSql from class com.navercorp.pinpoint.common.util.DefaultSqlParser | From | To | |
| Change Return Type | 1 | ||
| Change Return Type DefaultParsingResult to NormalizedSql in method public normalizedSql(sql String) : NormalizedSql in class com.navercorp.pinpoint.common.util.DefaultSqlParser | From | To | |
| Extract Interface | 1 | ||
| Extract Interface com.navercorp.pinpoint.profiler.context.ParsingResultInternal from classes [com.navercorp.pinpoint.profiler.context.DefaultParsingResult] | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type output : StringBuilder to output : String in class com.navercorp.pinpoint.profiler.context.DefaultParsingResult | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter sql : String to originalSql : String in method public DefaultParsingResult(originalSql String) in class com.navercorp.pinpoint.profiler.context.DefaultParsingResult | From | To |