7a0aa62856356e10cdb55a2443cfa2930661ed90
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 3
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method protected doInBeforeTrace(recorder SpanRecorder, target Object, args Object[]) : void renamed to private recordRequest(recorder SpanRecorder, target Object, args Object[]) : void in class com.navercorp.pinpoint.plugin.dubbo.interceptor.DubboProviderInterceptor | From | To | |
| Pull Up Method | 3 | ||
| Pull Up Method public before(target Object, args Object[]) : void from class com.navercorp.pinpoint.plugin.dubbo.interceptor.DubboProviderInterceptor to public before(target Object, args Object[]) : void from class com.navercorp.pinpoint.bootstrap.interceptor.SpanRecursiveAroundInterceptor | From | To | |
| Pull Up Method private deleteTrace(trace Trace) : void from class com.navercorp.pinpoint.plugin.dubbo.interceptor.DubboProviderInterceptor to private deleteTrace(trace Trace) : void from class com.navercorp.pinpoint.bootstrap.interceptor.SpanRecursiveAroundInterceptor | From | To | |
| Pull Up Method public after(target Object, args Object[], result Object, throwable Throwable) : void from class com.navercorp.pinpoint.plugin.dubbo.interceptor.DubboProviderInterceptor to public after(target Object, args Object[], result Object, throwable Throwable) : void from class com.navercorp.pinpoint.bootstrap.interceptor.SpanRecursiveAroundInterceptor | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type arg0 : Object to args : Object[] in method public before(target Object, args Object[]) : void in class com.navercorp.pinpoint.plugin.dubbo.interceptor.DubboConsumerInterceptor | From | To | |
| Change Parameter Type arg0 : Object to args : Object[] in method public after(target Object, args Object[], result Object, throwable Throwable) : void in class com.navercorp.pinpoint.plugin.dubbo.interceptor.DubboConsumerInterceptor | From | To | |
| Change Parameter Type recorder : SpanRecorder to recorder : SpanEventRecorder in method protected doInAfterTrace(recorder SpanEventRecorder, target Object, args Object[], result Object, throwable Throwable) : void in class com.navercorp.pinpoint.plugin.dubbo.interceptor.DubboProviderInterceptor | From | To | |
| Pull Up Attribute | 4 | ||
| Pull Up Attribute protected logger : PLogger from class com.navercorp.pinpoint.plugin.dubbo.interceptor.DubboProviderInterceptor to protected logger : PLogger from class com.navercorp.pinpoint.bootstrap.interceptor.SpanRecursiveAroundInterceptor | From | To | |
| Pull Up Attribute protected methodDescriptor : MethodDescriptor from class com.navercorp.pinpoint.plugin.dubbo.interceptor.DubboProviderInterceptor to protected methodDescriptor : MethodDescriptor from class com.navercorp.pinpoint.bootstrap.interceptor.SpanRecursiveAroundInterceptor | From | To | |
| Pull Up Attribute protected traceContext : TraceContext from class com.navercorp.pinpoint.plugin.dubbo.interceptor.DubboProviderInterceptor to protected traceContext : TraceContext from class com.navercorp.pinpoint.bootstrap.interceptor.SpanRecursiveAroundInterceptor | From | To | |
| Pull Up Attribute protected isDebug : boolean from class com.navercorp.pinpoint.plugin.dubbo.interceptor.DubboProviderInterceptor to protected isDebug : boolean from class com.navercorp.pinpoint.bootstrap.interceptor.SpanRecursiveAroundInterceptor | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass com.navercorp.pinpoint.bootstrap.interceptor.SpanRecursiveAroundInterceptor from classes [com.navercorp.pinpoint.plugin.dubbo.interceptor.DubboProviderInterceptor] | From | To | |
| Extract Variable | 2 | ||
| Extract Variable invokeMethod : InstrumentMethod in method public doInTransform(instrumentor Instrumentor, loader ClassLoader, className String, classBeingRedefined Class<?>, protectionDomain ProtectionDomain, classfileBuffer byte[]) : byte[] from class com.navercorp.pinpoint.plugin.dubbo.DubboPlugin.addTransformers.transform | From | To | |
| Extract Method | 9 | ||
| Extract Method private deleteTrace(trace Trace) : void extracted from public before(target Object, args Object[]) : void in class com.navercorp.pinpoint.bootstrap.interceptor.SpanRecursiveAroundInterceptor | From | To | |
| Extract Method private readRequestTrace(target Object, args Object[]) : Trace extracted from protected createTrace(target Object, args Object[]) : Trace in class com.navercorp.pinpoint.plugin.dubbo.interceptor.DubboProviderInterceptor | From | To | |
| Extract Method private setAttachment(invocation RpcInvocation, name String, value String) : void extracted from public before(target Object, arg0 Object) : void in class com.navercorp.pinpoint.plugin.dubbo.interceptor.DubboConsumerInterceptor | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter arg0 : Object to args : Object[] in method public before(target Object, args Object[]) : void in class com.navercorp.pinpoint.plugin.dubbo.interceptor.DubboConsumerInterceptor | From | To | |
| Rename Parameter arg0 : Object to args : Object[] in method public after(target Object, args Object[], result Object, throwable Throwable) : void in class com.navercorp.pinpoint.plugin.dubbo.interceptor.DubboConsumerInterceptor | From | To |