7b106349310fc91eb1af6d446ea9e357b4d43d25
Files Diff
- Added: 10
- Removed: 0
- Renamed: 0
- Modified: 13
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method private createWaitingJobList(createActiveTraceRepositorySize int) : List<WaitingJob> from class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadLightDumpServiceTest to public createList(size int, timeout long) : List<WaitingJob> from class com.navercorp.pinpoint.profiler.receiver.service.WaitingJobListFactory | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type activeTraceRepository : ActiveTraceRepository to activeThreadDump : ActiveThreadDumpCoreService in method public ActiveThreadLightDumpService(activeThreadDump ActiveThreadDumpCoreService) in class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadLightDumpService | From | To | |
| Change Parameter Type threadDump : TThreadDump to threadDump : ThreadDump in method private createTActiveThreadDump(threadDump ThreadDump) : TActiveThreadDump in class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadDumpService | From | To | |
| Change Parameter Type threadDump : TThreadLightDump to threadDump : ThreadDump in method private createActiveThreadDump(threadDump ThreadDump) : TActiveThreadLightDump in class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadLightDumpService | From | To | |
| Change Parameter Type activeTraceRepository : ActiveTraceRepository to activeThreadDumpCoreService : ActiveThreadDumpCoreService in method public ActiveThreadDumpService(activeThreadDumpCoreService ActiveThreadDumpCoreService) in class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadDumpService | From | To | |
| Move Method | 1 | ||
| Move Method package getLimit(limit int) : int from class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadDumpService to package getLimit(limit int) : int from class com.navercorp.pinpoint.profiler.receiver.service.ThreadDumpRequest | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private activeTraceRepository : ActiveTraceRepository from class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadDumpService to private activeTraceRepository : ActiveTraceRepository from class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadDumpCoreService | From | To | |
| Move Attribute private activeTraceRepository : ActiveTraceRepository from class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadLightDumpService to private activeTraceRepository : ActiveTraceRepository from class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadDumpCoreService | From | To | |
| Move Attribute package MAX_THREAD_DUMP_LIMIT : int from class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadDumpService to package MAX_THREAD_DUMP_LIMIT : int from class com.navercorp.pinpoint.profiler.receiver.service.ThreadDumpRequest | From | To | |
| Extract Class | 2 | ||
| Extract Class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadDumpCoreService from class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadDumpService | From | To | |
| Extract Class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadDumpCoreService from class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadLightDumpService | From | To | |
| Move Class | 1 | ||
| Move Class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadLightDumpServiceTest.WaitingJob moved to com.navercorp.pinpoint.profiler.receiver.service.WaitingJob | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type collectData : List<ActiveTraceSnapshot> to collectData : List<Long> in method public getThreadIdList() : List<Long> in class com.navercorp.pinpoint.profiler.context.active.DefaultActiveTraceRepository | From | To | |
| Extract Method | 2 | ||
| Extract Method public snapshot() : List<ActiveTraceSnapshot> extracted from public collect() : List<ActiveTraceSnapshot> in class com.navercorp.pinpoint.profiler.context.active.DefaultActiveTraceRepository | From | To | |
| Extract Method public getThreadInfo(id long, stackTraceMaxDepth int) : ThreadInfo extracted from public findThread(id long, stackTraceMaxDepth int) : ThreadInfo in class com.navercorp.pinpoint.common.util.ThreadMXBeanUtils | From | To | |
| Rename Method | 4 | ||
| Rename Method public collect() : List<ActiveTraceSnapshot> renamed to public snapshot() : List<ActiveTraceSnapshot> in class com.navercorp.pinpoint.profiler.context.active.EmptyActiveTraceRepository | From | To | |
| Rename Method public collect() : List<ActiveTraceSnapshot> renamed to public snapshot() : List<ActiveTraceSnapshot> in class com.navercorp.pinpoint.profiler.context.active.ActiveTraceRepository | From | To | |
| Rename Method public collect() : List<ActiveTraceSnapshot> renamed to public getThreadIdList() : List<Long> in class com.navercorp.pinpoint.profiler.context.active.ActiveTraceRepository | From | To | |
| Rename Method public collect() : List<ActiveTraceSnapshot> renamed to public getThreadIdList() : List<Long> in class com.navercorp.pinpoint.profiler.context.active.DefaultActiveTraceRepository | From | To | |
| Change Return Type | 2 | ||
| Change Return Type List<ActiveTraceSnapshot> to List<Long> in method public getThreadIdList() : List<Long> in class com.navercorp.pinpoint.profiler.context.active.DefaultActiveTraceRepository | From | To | |
| Change Return Type List<ActiveTraceSnapshot> to List<Long> in method public getThreadIdList() : List<Long> in class com.navercorp.pinpoint.profiler.context.active.ActiveTraceRepository | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute activeTraceRepository : ActiveTraceRepository to activeThreadDumpCoreService : ActiveThreadDumpCoreService in class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadDumpService | From | To | |
| Rename Attribute activeTraceRepository : ActiveTraceRepository to activeThreadDump : ActiveThreadDumpCoreService in class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadLightDumpService | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type activeTraceRepository : ActiveTraceRepository to activeThreadDump : ActiveThreadDumpCoreService in class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadLightDumpService | From | To | |
| Change Attribute Type activeTraceRepository : ActiveTraceRepository to activeThreadDumpCoreService : ActiveThreadDumpCoreService in class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadDumpService | From | To | |
| Rename Parameter | 5 | ||
| Rename Parameter request : TCmdActiveThreadDump to tRequest : TCmdActiveThreadDump in method private getActiveThreadDumpList(tRequest TCmdActiveThreadDump) : List<TActiveThreadDump> in class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadDumpService | From | To | |
| Rename Parameter activeTraceRepository : ActiveTraceRepository to activeThreadDump : ActiveThreadDumpCoreService in method public ActiveThreadLightDumpService(activeThreadDump ActiveThreadDumpCoreService) in class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadLightDumpService | From | To | |
| Rename Parameter request : TCmdActiveThreadLightDump to tRequest : TCmdActiveThreadLightDump in method private getActiveThreadDumpList(tRequest TCmdActiveThreadLightDump) : List<TActiveThreadLightDump> in class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadLightDumpService | From | To | |
| Rename Parameter activeTraceRepository : ActiveTraceRepository to activeThreadDumpCoreService : ActiveThreadDumpCoreService in method public ActiveThreadDumpService(activeThreadDumpCoreService ActiveThreadDumpCoreService) in class com.navercorp.pinpoint.profiler.receiver.service.ActiveThreadDumpService | From | To | |
| Rename Parameter createActiveTraceRepositorySize : int to size : int in method public createList(size int, timeout long) : List<WaitingJob> in class com.navercorp.pinpoint.profiler.receiver.service.WaitingJobListFactory | From | To |